All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Palmer <daniel@0x0f.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: DTML <devicetree@vger.kernel.org>,
	linux-clk@vger.kernel.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH 2/6] dt-bindings: clk: mstar msc313 mpll binding description
Date: Thu, 11 Feb 2021 11:28:40 +0900	[thread overview]
Message-ID: <CAFr9PXkGeFUyGCKZgYF+0uJT1ywad42RvPg39ggO8WRngY8uWw@mail.gmail.com> (raw)
In-Reply-To: <161292417080.418021.13416197091150418216@swboyd.mtv.corp.google.com>

Hi Stephen,

On Wed, 10 Feb 2021 at 11:29, Stephen Boyd <sboyd@kernel.org> wrote:
> The child clks should be using clk_parent_data to point to the parent
> clks through DT. That way the name of the clk doesn't matter except for
> debug purposes.

I think I get it now. I was using of_clk_parent_fill() to get the
parent clocks sourced
from the mpll but I seems like I should be filling out an array of
struct clk_parent_data
with the indices of the parents and using
clk_register_composite_pdata() etc instead.

Thanks!

Daniel

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Palmer <daniel@0x0f.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: DTML <devicetree@vger.kernel.org>, Willy Tarreau <w@1wt.eu>,
	linux-clk@vger.kernel.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6] dt-bindings: clk: mstar msc313 mpll binding description
Date: Thu, 11 Feb 2021 11:28:40 +0900	[thread overview]
Message-ID: <CAFr9PXkGeFUyGCKZgYF+0uJT1ywad42RvPg39ggO8WRngY8uWw@mail.gmail.com> (raw)
In-Reply-To: <161292417080.418021.13416197091150418216@swboyd.mtv.corp.google.com>

Hi Stephen,

On Wed, 10 Feb 2021 at 11:29, Stephen Boyd <sboyd@kernel.org> wrote:
> The child clks should be using clk_parent_data to point to the parent
> clks through DT. That way the name of the clk doesn't matter except for
> debug purposes.

I think I get it now. I was using of_clk_parent_fill() to get the
parent clocks sourced
from the mpll but I seems like I should be filling out an array of
struct clk_parent_data
with the indices of the parents and using
clk_register_composite_pdata() etc instead.

Thanks!

Daniel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-11  2:29 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-14 13:50 [PATCH 0/6] ARM: mstar: Basic MPLL support Daniel Palmer
2020-11-14 13:50 ` Daniel Palmer
2020-11-14 13:50 ` [PATCH 1/6] dt-bindings: clk: mstar msc313 mpll binding header Daniel Palmer
2020-11-14 13:50   ` Daniel Palmer
2020-12-07 19:02   ` Rob Herring
2020-12-07 19:02     ` Rob Herring
2020-11-14 13:50 ` [PATCH 2/6] dt-bindings: clk: mstar msc313 mpll binding description Daniel Palmer
2020-11-14 13:50   ` Daniel Palmer
2020-12-07 19:03   ` Rob Herring
2020-12-07 19:03     ` Rob Herring
2020-12-20  3:39   ` Stephen Boyd
2020-12-20  3:39     ` Stephen Boyd
2020-12-20  6:35     ` Daniel Palmer
2020-12-20  6:35       ` Daniel Palmer
2020-12-20 18:44       ` Stephen Boyd
2020-12-20 18:44         ` Stephen Boyd
2020-12-21  8:51         ` Daniel Palmer
2020-12-21  8:51           ` Daniel Palmer
2021-02-10  2:29           ` Stephen Boyd
2021-02-10  2:29             ` Stephen Boyd
2021-02-11  2:28             ` Daniel Palmer [this message]
2021-02-11  2:28               ` Daniel Palmer
2021-02-11  2:55               ` Stephen Boyd
2021-02-11  2:55                 ` Stephen Boyd
2020-11-14 13:50 ` [PATCH 3/6] clk: mstar: MStar/SigmaStar MPLL driver Daniel Palmer
2020-11-14 13:50   ` Daniel Palmer
2020-12-20  4:36   ` Stephen Boyd
2020-12-20  4:36     ` Stephen Boyd
2020-12-20  6:42     ` Daniel Palmer
2020-12-20  6:42       ` Daniel Palmer
2020-12-20 18:43       ` Stephen Boyd
2020-12-20 18:43         ` Stephen Boyd
2020-12-21  8:40         ` Daniel Palmer
2020-12-21  8:40           ` Daniel Palmer
2020-11-14 13:50 ` [PATCH 4/6] ARM: mstar: Select MSTAR_MSC313_MPLL Daniel Palmer
2020-11-14 13:50   ` Daniel Palmer
2020-11-14 13:50 ` [PATCH 5/6] ARM: mstar: Add the external clocks to the base dsti Daniel Palmer
2020-11-14 13:50   ` Daniel Palmer
2020-11-14 13:50 ` [PATCH 6/6] ARM: mstar: Add mpll to base dtsi Daniel Palmer
2020-11-14 13:50   ` Daniel Palmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFr9PXkGeFUyGCKZgYF+0uJT1ywad42RvPg39ggO8WRngY8uWw@mail.gmail.com \
    --to=daniel@0x0f.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.