From: Sameer Pujar <spujar@nvidia.com> To: <broonie@kernel.org>, <robh@kernel.org>, <thierry.reding@gmail.com> Cc: <jonathanh@nvidia.com>, <kuninori.morimoto.gx@renesas.com>, <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <sharadg@nvidia.com>, Sameer Pujar <spujar@nvidia.com> Subject: [PATCH 0/3] Use clocks property in a device node Date: Wed, 10 Feb 2021 12:13:38 +0530 [thread overview] Message-ID: <1612939421-19900-1-git-send-email-spujar@nvidia.com> (raw) It is recommended to not specifiy clocks property in an endpoint subnode. This series moves clocks to device node. However after moving the clocks to device node, the audio playback or capture fails. The specified clock is not actually getting enabled and hence the failure is seen. There seems to be a bug in simple-card-utils.c where clock handle is not assigned when parsing clocks from device node. Fix the same and revert original change which actually added clocks property in endpoint subnode. Also update Jetson AGX Xavier DT where the usage is found. Sameer Pujar (3): ASoC: simple-card-utils: Fix device module clock Revert "ASoC: audio-graph-card: Add clocks property to endpoint node" arm64: tegra: Move clocks from RT5658 endpoint to device node .../devicetree/bindings/sound/audio-graph-port.yaml | 3 --- arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 2 +- sound/soc/generic/simple-card-utils.c | 13 ++++++------- 3 files changed, 7 insertions(+), 11 deletions(-) -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Sameer Pujar <spujar@nvidia.com> To: <broonie@kernel.org>, <robh@kernel.org>, <thierry.reding@gmail.com> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, Sameer Pujar <spujar@nvidia.com>, linux-kernel@vger.kernel.org, jonathanh@nvidia.com, sharadg@nvidia.com, linux-tegra@vger.kernel.org Subject: [PATCH 0/3] Use clocks property in a device node Date: Wed, 10 Feb 2021 12:13:38 +0530 [thread overview] Message-ID: <1612939421-19900-1-git-send-email-spujar@nvidia.com> (raw) It is recommended to not specifiy clocks property in an endpoint subnode. This series moves clocks to device node. However after moving the clocks to device node, the audio playback or capture fails. The specified clock is not actually getting enabled and hence the failure is seen. There seems to be a bug in simple-card-utils.c where clock handle is not assigned when parsing clocks from device node. Fix the same and revert original change which actually added clocks property in endpoint subnode. Also update Jetson AGX Xavier DT where the usage is found. Sameer Pujar (3): ASoC: simple-card-utils: Fix device module clock Revert "ASoC: audio-graph-card: Add clocks property to endpoint node" arm64: tegra: Move clocks from RT5658 endpoint to device node .../devicetree/bindings/sound/audio-graph-port.yaml | 3 --- arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 2 +- sound/soc/generic/simple-card-utils.c | 13 ++++++------- 3 files changed, 7 insertions(+), 11 deletions(-) -- 2.7.4
next reply other threads:[~2021-02-10 6:44 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-10 6:43 Sameer Pujar [this message] 2021-02-10 6:43 ` [PATCH 0/3] Use clocks property in a device node Sameer Pujar 2021-02-10 6:43 ` [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock Sameer Pujar 2021-02-10 6:43 ` Sameer Pujar 2021-02-11 23:44 ` Kuninori Morimoto 2021-02-11 23:44 ` Kuninori Morimoto 2021-02-14 17:56 ` Sameer Pujar 2021-02-14 17:56 ` Sameer Pujar 2021-02-14 23:25 ` Kuninori Morimoto 2021-02-14 23:25 ` Kuninori Morimoto 2021-03-09 14:41 ` Michael Walle 2021-03-09 14:41 ` Michael Walle 2021-03-09 16:27 ` Sameer Pujar 2021-03-09 16:27 ` Sameer Pujar 2021-03-09 22:30 ` Michael Walle 2021-03-09 22:30 ` Michael Walle 2021-03-10 14:50 ` Sameer Pujar 2021-03-10 14:50 ` Sameer Pujar 2021-03-10 18:14 ` Michael Walle 2021-03-10 18:14 ` Michael Walle 2021-03-10 19:19 ` Sameer Pujar 2021-03-10 19:19 ` Sameer Pujar 2021-03-11 10:27 ` Michael Walle 2021-03-11 10:27 ` Michael Walle 2021-03-11 11:05 ` Sameer Pujar 2021-03-11 11:05 ` Sameer Pujar 2021-03-11 11:16 ` Michael Walle 2021-03-11 11:16 ` Michael Walle 2021-03-11 14:29 ` Sameer Pujar 2021-03-11 14:29 ` Sameer Pujar 2021-03-11 15:43 ` Michael Walle 2021-03-11 15:43 ` Michael Walle 2021-03-11 16:41 ` Mark Brown 2021-03-11 16:41 ` Mark Brown 2021-03-11 16:15 ` Mark Brown 2021-03-11 16:15 ` Mark Brown 2021-03-11 22:11 ` Michael Walle 2021-03-11 22:11 ` Michael Walle 2021-03-12 11:35 ` Mark Brown 2021-03-12 11:35 ` Mark Brown 2021-03-12 12:01 ` Michael Walle 2021-03-12 12:01 ` Michael Walle 2021-03-12 12:04 ` Mark Brown 2021-03-12 12:04 ` Mark Brown 2021-03-12 12:30 ` Michael Walle 2021-03-12 12:30 ` Michael Walle 2021-03-12 13:46 ` Mark Brown 2021-03-12 13:46 ` Mark Brown 2021-03-15 12:05 ` Michael Walle 2021-03-15 12:05 ` Michael Walle 2021-03-15 15:19 ` Sameer Pujar 2021-03-15 15:19 ` Sameer Pujar 2021-03-15 15:33 ` Michael Walle 2021-03-15 15:33 ` Michael Walle 2021-03-15 15:57 ` Sameer Pujar 2021-03-15 15:57 ` Sameer Pujar 2021-03-15 15:39 ` Mark Brown 2021-03-15 15:39 ` Mark Brown 2021-03-15 17:10 ` Sameer Pujar 2021-03-15 17:10 ` Sameer Pujar 2021-03-15 17:13 ` Michael Walle 2021-03-15 17:13 ` Michael Walle 2021-03-11 16:00 ` Mark Brown 2021-03-11 16:00 ` Mark Brown 2021-03-11 21:34 ` Michael Walle 2021-03-11 21:34 ` Michael Walle 2021-02-10 6:43 ` [PATCH 2/3] Revert "ASoC: audio-graph-card: Add clocks property to endpoint node" Sameer Pujar 2021-02-10 6:43 ` Sameer Pujar 2021-02-11 13:00 ` Mark Brown 2021-02-11 13:00 ` Mark Brown 2021-02-10 6:43 ` [PATCH 3/3] arm64: tegra: Move clocks from RT5658 endpoint to device node Sameer Pujar 2021-02-10 6:43 ` Sameer Pujar 2021-02-11 15:38 ` [PATCH 0/3] Use clocks property in a " Mark Brown 2021-02-11 15:38 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1612939421-19900-1-git-send-email-spujar@nvidia.com \ --to=spujar@nvidia.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=jonathanh@nvidia.com \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=robh@kernel.org \ --cc=sharadg@nvidia.com \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.