From: Mark Brown <broonie@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Sameer Pujar <spujar@nvidia.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
jonathanh@nvidia.com, kuninori.morimoto.gx@renesas.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
robh@kernel.org, sharadg@nvidia.com, thierry.reding@gmail.com
Subject: Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock
Date: Fri, 12 Mar 2021 11:35:44 +0000 [thread overview]
Message-ID: <20210312113544.GB5348@sirena.org.uk> (raw)
In-Reply-To: <f21b87f1afb3eda54b5f00f2d1c146d3@walle.cc>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
On Thu, Mar 11, 2021 at 11:11:15PM +0100, Michael Walle wrote:
> Am 2021-03-11 17:15, schrieb Mark Brown:
> > The trick is figuring out if it's best to vary the input clock
> > or to use the FLL to adapt a fixed input clock,
> For simple-audio-card you can set the "clock" property if you want
> that clock to be changed/enabled/disabled. But that doesn't seem to
> be the way to go, at least it was NAKed by Rob for the audio-graph-card.
> I don't see a way to figure out if MCLK should be controlled by
> simple-*-card without adding further properties to the device tree.
If the card has a clock API clock as sysclk then set_sysclk(() should
be configuring that clock.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
kuninori.morimoto.gx@renesas.com, robh@kernel.org,
Sameer Pujar <spujar@nvidia.com>,
linux-kernel@vger.kernel.org, jonathanh@nvidia.com,
sharadg@nvidia.com, thierry.reding@gmail.com,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock
Date: Fri, 12 Mar 2021 11:35:44 +0000 [thread overview]
Message-ID: <20210312113544.GB5348@sirena.org.uk> (raw)
In-Reply-To: <f21b87f1afb3eda54b5f00f2d1c146d3@walle.cc>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
On Thu, Mar 11, 2021 at 11:11:15PM +0100, Michael Walle wrote:
> Am 2021-03-11 17:15, schrieb Mark Brown:
> > The trick is figuring out if it's best to vary the input clock
> > or to use the FLL to adapt a fixed input clock,
> For simple-audio-card you can set the "clock" property if you want
> that clock to be changed/enabled/disabled. But that doesn't seem to
> be the way to go, at least it was NAKed by Rob for the audio-graph-card.
> I don't see a way to figure out if MCLK should be controlled by
> simple-*-card without adding further properties to the device tree.
If the card has a clock API clock as sysclk then set_sysclk(() should
be configuring that clock.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-12 11:37 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 6:43 [PATCH 0/3] Use clocks property in a device node Sameer Pujar
2021-02-10 6:43 ` Sameer Pujar
2021-02-10 6:43 ` [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock Sameer Pujar
2021-02-10 6:43 ` Sameer Pujar
2021-02-11 23:44 ` Kuninori Morimoto
2021-02-11 23:44 ` Kuninori Morimoto
2021-02-14 17:56 ` Sameer Pujar
2021-02-14 17:56 ` Sameer Pujar
2021-02-14 23:25 ` Kuninori Morimoto
2021-02-14 23:25 ` Kuninori Morimoto
2021-03-09 14:41 ` Michael Walle
2021-03-09 14:41 ` Michael Walle
2021-03-09 16:27 ` Sameer Pujar
2021-03-09 16:27 ` Sameer Pujar
2021-03-09 22:30 ` Michael Walle
2021-03-09 22:30 ` Michael Walle
2021-03-10 14:50 ` Sameer Pujar
2021-03-10 14:50 ` Sameer Pujar
2021-03-10 18:14 ` Michael Walle
2021-03-10 18:14 ` Michael Walle
2021-03-10 19:19 ` Sameer Pujar
2021-03-10 19:19 ` Sameer Pujar
2021-03-11 10:27 ` Michael Walle
2021-03-11 10:27 ` Michael Walle
2021-03-11 11:05 ` Sameer Pujar
2021-03-11 11:05 ` Sameer Pujar
2021-03-11 11:16 ` Michael Walle
2021-03-11 11:16 ` Michael Walle
2021-03-11 14:29 ` Sameer Pujar
2021-03-11 14:29 ` Sameer Pujar
2021-03-11 15:43 ` Michael Walle
2021-03-11 15:43 ` Michael Walle
2021-03-11 16:41 ` Mark Brown
2021-03-11 16:41 ` Mark Brown
2021-03-11 16:15 ` Mark Brown
2021-03-11 16:15 ` Mark Brown
2021-03-11 22:11 ` Michael Walle
2021-03-11 22:11 ` Michael Walle
2021-03-12 11:35 ` Mark Brown [this message]
2021-03-12 11:35 ` Mark Brown
2021-03-12 12:01 ` Michael Walle
2021-03-12 12:01 ` Michael Walle
2021-03-12 12:04 ` Mark Brown
2021-03-12 12:04 ` Mark Brown
2021-03-12 12:30 ` Michael Walle
2021-03-12 12:30 ` Michael Walle
2021-03-12 13:46 ` Mark Brown
2021-03-12 13:46 ` Mark Brown
2021-03-15 12:05 ` Michael Walle
2021-03-15 12:05 ` Michael Walle
2021-03-15 15:19 ` Sameer Pujar
2021-03-15 15:19 ` Sameer Pujar
2021-03-15 15:33 ` Michael Walle
2021-03-15 15:33 ` Michael Walle
2021-03-15 15:57 ` Sameer Pujar
2021-03-15 15:57 ` Sameer Pujar
2021-03-15 15:39 ` Mark Brown
2021-03-15 15:39 ` Mark Brown
2021-03-15 17:10 ` Sameer Pujar
2021-03-15 17:10 ` Sameer Pujar
2021-03-15 17:13 ` Michael Walle
2021-03-15 17:13 ` Michael Walle
2021-03-11 16:00 ` Mark Brown
2021-03-11 16:00 ` Mark Brown
2021-03-11 21:34 ` Michael Walle
2021-03-11 21:34 ` Michael Walle
2021-02-10 6:43 ` [PATCH 2/3] Revert "ASoC: audio-graph-card: Add clocks property to endpoint node" Sameer Pujar
2021-02-10 6:43 ` Sameer Pujar
2021-02-11 13:00 ` Mark Brown
2021-02-11 13:00 ` Mark Brown
2021-02-10 6:43 ` [PATCH 3/3] arm64: tegra: Move clocks from RT5658 endpoint to device node Sameer Pujar
2021-02-10 6:43 ` Sameer Pujar
2021-02-11 15:38 ` [PATCH 0/3] Use clocks property in a " Mark Brown
2021-02-11 15:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210312113544.GB5348@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=michael@walle.cc \
--cc=robh@kernel.org \
--cc=sharadg@nvidia.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.