From: Catalin Marinas <catalin.marinas@arm.com>
To: linux-arm-kernel@lists.infradead.org, Pingfan Liu <kernelfans@gmail.com>
Cc: Will Deacon <will@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
Yuichi Ito <ito-yuichi@fujitsu.com>,
Julien Thierry <julien.thierry@arm.com>,
Marc Zyngier <maz@kernel.org>, Joey Gouly <joey.gouly@arm.com>,
Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [PATCHv4 0/3] arm64/irqentry: remove duplicate housekeeping of rcu
Date: Tue, 5 Oct 2021 18:17:25 +0100 [thread overview]
Message-ID: <163345423700.2001694.5653085141940230637.b4-ty@arm.com> (raw)
In-Reply-To: <20211001144406.7719-1-kernelfans@gmail.com>
On Fri, 1 Oct 2021 22:44:03 +0800, Pingfan Liu wrote:
> When an IRQ is taken, some accounting needs to be performed to enter and
> exit IRQ context around the IRQ handler. Historically arch code would
> leave this to the irqchip or core IRQ code, but these days we want this
> to happen in exception entry code, and architectures such as arm64 do
> this.
>
> Currently handle_domain_irq() performs this entry/exit accounting, and
> if used on an architecture where the entry code also does this, the
> entry/exit accounting will be performed twice per IRQ. This is
> problematic as core RCU code such as rcu_is_cpu_rrupt_from_idle()
> depends on this happening once per IRQ, and will not detect quescent
> periods correctly, leading to stall warnings.
>
> [...]
Applied to arm64 (for-next/fixes), thanks!
[1/3] kernel/irq: make irq_{enter,exit}() in handle_domain_irq() arch optional
https://git.kernel.org/arm64/c/db795cf55b21
[2/3] arm64: entry: refactor EL1 interrupt entry logic
https://git.kernel.org/arm64/c/ad0d5cfb9535
[3/3] arm64: entry: avoid double-accounting IRQ RCU entry
https://git.kernel.org/arm64/c/12074b059fdc
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: linux-arm-kernel@lists.infradead.org, Pingfan Liu <kernelfans@gmail.com>
Cc: Will Deacon <will@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
Yuichi Ito <ito-yuichi@fujitsu.com>,
Julien Thierry <julien.thierry@arm.com>,
Marc Zyngier <maz@kernel.org>, Joey Gouly <joey.gouly@arm.com>,
Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [PATCHv4 0/3] arm64/irqentry: remove duplicate housekeeping of rcu
Date: Tue, 5 Oct 2021 18:17:25 +0100 [thread overview]
Message-ID: <163345423700.2001694.5653085141940230637.b4-ty@arm.com> (raw)
In-Reply-To: <20211001144406.7719-1-kernelfans@gmail.com>
On Fri, 1 Oct 2021 22:44:03 +0800, Pingfan Liu wrote:
> When an IRQ is taken, some accounting needs to be performed to enter and
> exit IRQ context around the IRQ handler. Historically arch code would
> leave this to the irqchip or core IRQ code, but these days we want this
> to happen in exception entry code, and architectures such as arm64 do
> this.
>
> Currently handle_domain_irq() performs this entry/exit accounting, and
> if used on an architecture where the entry code also does this, the
> entry/exit accounting will be performed twice per IRQ. This is
> problematic as core RCU code such as rcu_is_cpu_rrupt_from_idle()
> depends on this happening once per IRQ, and will not detect quescent
> periods correctly, leading to stall warnings.
>
> [...]
Applied to arm64 (for-next/fixes), thanks!
[1/3] kernel/irq: make irq_{enter,exit}() in handle_domain_irq() arch optional
https://git.kernel.org/arm64/c/db795cf55b21
[2/3] arm64: entry: refactor EL1 interrupt entry logic
https://git.kernel.org/arm64/c/ad0d5cfb9535
[3/3] arm64: entry: avoid double-accounting IRQ RCU entry
https://git.kernel.org/arm64/c/12074b059fdc
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-05 17:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 14:44 [PATCHv4 0/3] arm64/irqentry: remove duplicate housekeeping of rcu Pingfan Liu
2021-10-01 14:44 ` Pingfan Liu
2021-10-01 14:44 ` [PATCHv4 1/3] kernel/irq: make irq_{enter,exit}() in handle_domain_irq() arch optional Pingfan Liu
2021-10-01 14:44 ` [PATCHv4 1/3] kernel/irq: make irq_{enter, exit}() " Pingfan Liu
2021-10-04 16:30 ` [PATCHv4 1/3] kernel/irq: make irq_{enter,exit}() " Marc Zyngier
2021-10-04 16:30 ` [PATCHv4 1/3] kernel/irq: make irq_{enter, exit}() " Marc Zyngier
2021-10-01 14:44 ` [PATCHv4 2/3] arm64: entry: refactor EL1 interrupt entry logic Pingfan Liu
2021-10-01 14:44 ` Pingfan Liu
2021-10-01 14:44 ` [PATCHv4 3/3] arm64: entry: avoid double-accounting IRQ RCU entry Pingfan Liu
2021-10-01 14:44 ` Pingfan Liu
2021-10-04 16:31 ` [PATCHv4 0/3] arm64/irqentry: remove duplicate housekeeping of rcu Marc Zyngier
2021-10-04 16:31 ` Marc Zyngier
2021-10-05 17:17 ` Catalin Marinas [this message]
2021-10-05 17:17 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163345423700.2001694.5653085141940230637.b4-ty@arm.com \
--to=catalin.marinas@arm.com \
--cc=ito-yuichi@fujitsu.com \
--cc=joey.gouly@arm.com \
--cc=julien.thierry@arm.com \
--cc=kernelfans@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=paulmck@kernel.org \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.