* [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects
@ 2022-09-06 17:46 Ville Syrjala
2022-09-06 18:40 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (5 more replies)
0 siblings, 6 replies; 15+ messages in thread
From: Ville Syrjala @ 2022-09-06 17:46 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
On gen3 the selftests are pretty much always tripping this:
<4> [383.822424] pci 0000:00:02.0: drm_WARN_ON(dev_priv->mm.shrink_count)
<4> [383.822546] WARNING: CPU: 2 PID: 3560 at drivers/gpu/drm/i915/i915_gem.c:1223 i915_gem_cleanup_early+0x96/0xb0 [i915]
Looks to be due to the status page object lingering on the
purge_list. Call synchronize_rcu() ahead of it to make more
sure all objects have been freed.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 0f49ec9d494a..5b61f7ad6473 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1098,6 +1098,7 @@ void i915_gem_drain_freed_objects(struct drm_i915_private *i915)
flush_delayed_work(&i915->bdev.wq);
rcu_barrier();
}
+ synchronize_rcu();
}
/*
--
2.35.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Kick rcu harder to free objects
2022-09-06 17:46 [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects Ville Syrjala
@ 2022-09-06 18:40 ` Patchwork
2022-09-06 18:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (4 subsequent siblings)
5 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-09-06 18:40 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Kick rcu harder to free objects
URL : https://patchwork.freedesktop.org/series/108196/
State : warning
== Summary ==
Error: dim checkpatch failed
9c3f8d76c799 drm/i915: Kick rcu harder to free objects
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11:
<4> [383.822546] WARNING: CPU: 2 PID: 3560 at drivers/gpu/drm/i915/i915_gem.c:1223 i915_gem_cleanup_early+0x96/0xb0 [i915]
total: 0 errors, 1 warnings, 0 checks, 7 lines checked
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Kick rcu harder to free objects
2022-09-06 17:46 [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects Ville Syrjala
2022-09-06 18:40 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2022-09-06 18:54 ` Patchwork
2022-09-06 22:10 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
` (3 subsequent siblings)
5 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-09-06 18:54 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6869 bytes --]
== Series Details ==
Series: drm/i915: Kick rcu harder to free objects
URL : https://patchwork.freedesktop.org/series/108196/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12080 -> Patchwork_108196v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/index.html
Participating hosts (40 -> 41)
------------------------------
Additional (1): fi-icl-u2
Known issues
------------
Here are the changes found in Patchwork_108196v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][1] ([i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/fi-icl-u2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][2] ([i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/fi-icl-u2/igt@gem_lmem_swapping@random-engines.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-bdw-5557u: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#111827])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/fi-bdw-5557u/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-blb-e6850: NOTRUN -> [SKIP][4] ([fdo#109271])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/fi-blb-e6850/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-pnv-d510: NOTRUN -> [SKIP][5] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/fi-pnv-d510/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][6] ([fdo#111827]) +8 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-icl-u2: NOTRUN -> [SKIP][7] ([i915#4103])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [PASS][8] -> [FAIL][9] ([i915#6298])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
* igt@kms_force_connector_basic@force-connector-state:
- fi-icl-u2: NOTRUN -> [WARN][10] ([i915#6008])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/fi-icl-u2/igt@kms_force_connector_basic@force-connector-state.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][11] ([fdo#109285])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/fi-icl-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-icl-u2: NOTRUN -> [SKIP][12] ([i915#3555])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/fi-icl-u2/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][13] ([fdo#109295] / [i915#3301])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/fi-icl-u2/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@smem:
- fi-bdw-5557u: [INCOMPLETE][14] ([i915#146] / [i915#6598]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@gem:
- fi-blb-e6850: [DMESG-FAIL][16] ([i915#4528]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/fi-blb-e6850/igt@i915_selftest@live@gem.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/fi-blb-e6850/igt@i915_selftest@live@gem.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][18] ([i915#4528]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/fi-pnv-d510/igt@i915_selftest@live@requests.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/fi-pnv-d510/igt@i915_selftest@live@requests.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6008]: https://gitlab.freedesktop.org/drm/intel/issues/6008
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6598]: https://gitlab.freedesktop.org/drm/intel/issues/6598
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
Build changes
-------------
* Linux: CI_DRM_12080 -> Patchwork_108196v1
CI-20190529: 20190529
CI_DRM_12080: 487cf03929452418ab3678492676822beeb6c86c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6646: c1f420ae84b76079cd32ac014cfdf95b5f2922f7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_108196v1: 487cf03929452418ab3678492676822beeb6c86c @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
cb02109083f9 drm/i915: Kick rcu harder to free objects
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/index.html
[-- Attachment #2: Type: text/html, Size: 7624 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Kick rcu harder to free objects
2022-09-06 17:46 [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects Ville Syrjala
2022-09-06 18:40 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-09-06 18:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-09-06 22:10 ` Patchwork
2022-09-08 12:23 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
` (2 subsequent siblings)
5 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-09-06 22:10 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 26484 bytes --]
== Series Details ==
Series: drm/i915: Kick rcu harder to free objects
URL : https://patchwork.freedesktop.org/series/108196/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12080_full -> Patchwork_108196v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (12 -> 11)
------------------------------
Missing (1): shard-dg1
Known issues
------------
Here are the changes found in Patchwork_108196v1_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-apl: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [FAIL][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50]) ([i915#4386])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl8/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl8/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl8/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl7/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl7/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl7/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl6/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl6/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl6/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl4/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl4/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl4/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl4/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl3/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl3/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl3/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl3/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl2/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl2/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl2/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl1/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl1/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl1/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl1/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl1/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl2/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl4/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl4/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl4/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl4/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl3/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl3/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl3/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl3/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl2/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl1/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl1/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl1/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl1/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl8/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl8/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl8/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl2/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl7/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl7/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl7/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl6/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl6/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl6/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl6/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@smoketest:
- shard-tglb: [PASS][51] -> [FAIL][52] ([i915#5099])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-tglb7/igt@gem_ctx_persistence@smoketest.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-tglb5/igt@gem_ctx_persistence@smoketest.html
* igt@gem_eio@reset-stress:
- shard-tglb: [PASS][53] -> [FAIL][54] ([i915#5784])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-tglb6/igt@gem_eio@reset-stress.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-tglb5/igt@gem_eio@reset-stress.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][55] -> [TIMEOUT][56] ([i915#3070])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb8/igt@gem_eio@unwedge-stress.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb4/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [PASS][57] -> [SKIP][58] ([i915#4525]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb2/igt@gem_exec_balancer@parallel-out-fence.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb8/igt@gem_exec_balancer@parallel-out-fence.html
* igt@gem_exec_fair@basic-deadline:
- shard-apl: NOTRUN -> [FAIL][59] ([i915#2846])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl4/igt@gem_exec_fair@basic-deadline.html
- shard-glk: [PASS][60] -> [FAIL][61] ([i915#2846])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-glk6/igt@gem_exec_fair@basic-deadline.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-glk8/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][62] -> [FAIL][63] ([i915#2842])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][64] ([i915#2842])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb1/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-iclb: [PASS][65] -> [FAIL][66] ([i915#2842])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb6/igt@gem_exec_fair@basic-pace@vecs0.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb1/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][67] -> [SKIP][68] ([i915#2190])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-tglb3/igt@gem_huc_copy@huc-copy.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-tglb7/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@smem-oom:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#4613]) +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl4/igt@gem_lmem_swapping@smem-oom.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][70] -> [FAIL][71] ([i915#454])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb4/igt@i915_pm_dc@dc6-dpms.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-0:
- shard-iclb: [PASS][72] -> [FAIL][73] ([i915#1888])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb1/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb3/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
- shard-glk: [PASS][74] -> [FAIL][75] ([i915#1888]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-glk7/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-glk7/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#3886]) +4 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl1/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-hpd-storm-disable:
- shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271] / [fdo#111827]) +3 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl7/igt@kms_chamelium@dp-hpd-storm-disable.html
* igt@kms_color@ctm-red-to-blue:
- shard-snb: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#3546])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-snb7/igt@kms_color@ctm-red-to-blue.html
* igt@kms_content_protection@legacy:
- shard-apl: NOTRUN -> [TIMEOUT][79] ([i915#1319])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl7/igt@kms_content_protection@legacy.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][80] -> [FAIL][81] ([i915#79])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][82] ([i915#3555]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][83] ([i915#2672]) +8 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][84] ([i915#2672] / [i915#3555])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb5/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-plflip-blt:
- shard-apl: NOTRUN -> [SKIP][85] ([fdo#109271]) +111 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl7/igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-plflip-blt.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][86] ([fdo#108145] / [i915#265])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl4/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1:
- shard-iclb: [PASS][87] -> [SKIP][88] ([i915#5176]) +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb1/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb2/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-apl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#658]) +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl4/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [PASS][90] -> [SKIP][91] ([fdo#109441]) +3 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb2/igt@kms_psr@psr2_primary_blt.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb7/igt@kms_psr@psr2_primary_blt.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-apl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#2437])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl1/igt@kms_writeback@writeback-pixel-formats.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [FAIL][93] ([i915#6268]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-tglb3/igt@gem_ctx_exec@basic-nohangcheck.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-tglb2/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_eio@unwedge-stress:
- {shard-tglu}: [TIMEOUT][95] ([i915#3063]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-tglu-2/igt@gem_eio@unwedge-stress.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-tglu-4/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [SKIP][97] ([i915#4525]) -> [PASS][98] +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb7/igt@gem_exec_balancer@parallel-keep-in-fence.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb4/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- {shard-tglu}: [FAIL][99] ([i915#2842]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-tglu-1/igt@gem_exec_fair@basic-none-share@rcs0.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-tglu-2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [DMESG-WARN][101] ([i915#5566] / [i915#716]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl1/igt@gen9_exec_parse@allowed-single.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl7/igt@gen9_exec_parse@allowed-single.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][103] ([i915#180]) -> [PASS][104] +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@i915_suspend@forcewake:
- shard-iclb: [TIMEOUT][105] -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb8/igt@i915_suspend@forcewake.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb5/igt@i915_suspend@forcewake.html
* igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2:
- shard-glk: [FAIL][107] ([i915#79]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-glk8/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-glk5/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-b-hdmi-a-2:
- shard-glk: [FAIL][109] -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-glk7/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-b-hdmi-a-2.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-glk7/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1:
- shard-iclb: [SKIP][111] ([i915#5176]) -> [PASS][112] +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb1/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1:
- shard-iclb: [SKIP][113] ([i915#5235]) -> [PASS][114] +2 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb8/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][115] ([fdo#109441]) -> [PASS][116] +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@testdisplay:
- {shard-tglu}: [DMESG-WARN][117] ([i915#4941]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-tglu-3/igt@testdisplay.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-tglu-1/igt@testdisplay.html
#### Warnings ####
* igt@gem_eio@kms:
- shard-tglb: [TIMEOUT][119] ([i915#3063]) -> [FAIL][120] ([i915#5784])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-tglb2/igt@gem_eio@kms.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-tglb1/igt@gem_eio@kms.html
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [SKIP][121] ([i915#4525]) -> [FAIL][122] ([i915#6117])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb6/igt@gem_exec_balancer@parallel-ordering.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb1/igt@gem_exec_balancer@parallel-ordering.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][123] ([i915#2920]) -> [SKIP][124] ([i915#658]) +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb8/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-iclb: [SKIP][125] ([fdo#111068] / [i915#658]) -> [SKIP][126] ([i915#2920]) +1 similar issue
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb1/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-iclb: [SKIP][127] ([i915#2920]) -> [SKIP][128] ([fdo#111068] / [i915#658])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-iclb7/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@runner@aborted:
- shard-apl: ([FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][134], [FAIL][135]) ([i915#3002] / [i915#4312] / [i915#5257] / [i915#6599])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl6/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl1/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl2/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl1/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12080/shard-apl1/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl6/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/shard-apl2/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3070]: https://gitlab.freedesktop.org/drm/intel/issues/3070
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4386]: https://gitlab.freedesktop.org/drm/intel/issues/4386
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4941]: https://gitlab.freedesktop.org/drm/intel/issues/4941
[i915#5099]: https://gitlab.freedesktop.org/drm/intel/issues/5099
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12080 -> Patchwork_108196v1
CI-20190529: 20190529
CI_DRM_12080: 487cf03929452418ab3678492676822beeb6c86c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6646: c1f420ae84b76079cd32ac014cfdf95b5f2922f7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_108196v1: 487cf03929452418ab3678492676822beeb6c86c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108196v1/index.html
[-- Attachment #2: Type: text/html, Size: 29919 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects
2022-09-06 17:46 [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects Ville Syrjala
` (2 preceding siblings ...)
2022-09-06 22:10 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2022-09-08 12:23 ` Tvrtko Ursulin
2022-09-08 13:30 ` Ville Syrjälä
2022-09-08 14:32 ` Das, Nirmoy
2022-09-08 15:15 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Kick rcu harder to free objects (rev2) Patchwork
5 siblings, 1 reply; 15+ messages in thread
From: Tvrtko Ursulin @ 2022-09-08 12:23 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On 06/09/2022 18:46, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> On gen3 the selftests are pretty much always tripping this:
> <4> [383.822424] pci 0000:00:02.0: drm_WARN_ON(dev_priv->mm.shrink_count)
> <4> [383.822546] WARNING: CPU: 2 PID: 3560 at drivers/gpu/drm/i915/i915_gem.c:1223 i915_gem_cleanup_early+0x96/0xb0 [i915]
>
> Looks to be due to the status page object lingering on the
> purge_list. Call synchronize_rcu() ahead of it to make more
> sure all objects have been freed.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 0f49ec9d494a..5b61f7ad6473 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -1098,6 +1098,7 @@ void i915_gem_drain_freed_objects(struct drm_i915_private *i915)
> flush_delayed_work(&i915->bdev.wq);
> rcu_barrier();
> }
> + synchronize_rcu();
Looks a bit suspicious that a loop would not free all but one last rcu
grace would. Definitely fixes the issue in your testing?
Perhaps the fact there is a cond_resched in __i915_gem_free_objects, but
then again free count should reflect the state and keep it looping in here..
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects
2022-09-08 12:23 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
@ 2022-09-08 13:30 ` Ville Syrjälä
0 siblings, 0 replies; 15+ messages in thread
From: Ville Syrjälä @ 2022-09-08 13:30 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: intel-gfx
On Thu, Sep 08, 2022 at 01:23:50PM +0100, Tvrtko Ursulin wrote:
>
> On 06/09/2022 18:46, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > On gen3 the selftests are pretty much always tripping this:
> > <4> [383.822424] pci 0000:00:02.0: drm_WARN_ON(dev_priv->mm.shrink_count)
> > <4> [383.822546] WARNING: CPU: 2 PID: 3560 at drivers/gpu/drm/i915/i915_gem.c:1223 i915_gem_cleanup_early+0x96/0xb0 [i915]
> >
> > Looks to be due to the status page object lingering on the
> > purge_list. Call synchronize_rcu() ahead of it to make more
> > sure all objects have been freed.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_gem.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> > index 0f49ec9d494a..5b61f7ad6473 100644
> > --- a/drivers/gpu/drm/i915/i915_gem.c
> > +++ b/drivers/gpu/drm/i915/i915_gem.c
> > @@ -1098,6 +1098,7 @@ void i915_gem_drain_freed_objects(struct drm_i915_private *i915)
> > flush_delayed_work(&i915->bdev.wq);
> > rcu_barrier();
> > }
> > + synchronize_rcu();
>
> Looks a bit suspicious that a loop would not free all but one last rcu
> grace would. Definitely fixes the issue in your testing?
Definite is a bit hard to say with fuzzy stuff like this. But yes,
so far didn't see the warn triggering anymore. CI results show the same.
>
> Perhaps the fact there is a cond_resched in __i915_gem_free_objects, but
> then again free count should reflect the state and keep it looping in here..
>
> Regards,
>
> Tvrtko
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects
2022-09-06 17:46 [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects Ville Syrjala
` (3 preceding siblings ...)
2022-09-08 12:23 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
@ 2022-09-08 14:32 ` Das, Nirmoy
2022-09-08 14:55 ` Tvrtko Ursulin
2022-09-08 15:11 ` Ville Syrjälä
2022-09-08 15:15 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Kick rcu harder to free objects (rev2) Patchwork
5 siblings, 2 replies; 15+ messages in thread
From: Das, Nirmoy @ 2022-09-08 14:32 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
Hi Ville,
I fixed a similar issue in DII but I couldn't reproduce it in drm
http://intel-gfx-pw.fi.intel.com/patch/228850/?series=15910&rev=2.
I wonder if that fixes the problem you are facing then I can send that
to drm.
diff --git a/drivers/gpu/drm/i915/i915_gem.c
b/drivers/gpu/drm/i915/i915_gem.c
index 7809be3a6840..5438e9277924 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1213,7 +1213,7 @@ void i915_gem_init_early(struct drm_i915_private
*dev_priv)
void i915_gem_cleanup_early(struct drm_i915_private *dev_priv)
{
- i915_gem_drain_freed_objects(dev_priv);
+ i915_gem_drain_workqueue(dev_priv);
GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list));
GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count));
drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count);
Regards,
Nirmoy
On 9/6/2022 7:46 PM, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> On gen3 the selftests are pretty much always tripping this:
> <4> [383.822424] pci 0000:00:02.0: drm_WARN_ON(dev_priv->mm.shrink_count)
> <4> [383.822546] WARNING: CPU: 2 PID: 3560 at drivers/gpu/drm/i915/i915_gem.c:1223 i915_gem_cleanup_early+0x96/0xb0 [i915]
>
> Looks to be due to the status page object lingering on the
> purge_list. Call synchronize_rcu() ahead of it to make more
> sure all objects have been freed.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 0f49ec9d494a..5b61f7ad6473 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -1098,6 +1098,7 @@ void i915_gem_drain_freed_objects(struct drm_i915_private *i915)
> flush_delayed_work(&i915->bdev.wq);
> rcu_barrier();
> }
> + synchronize_rcu();
> }
>
> /*
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects
2022-09-08 14:32 ` Das, Nirmoy
@ 2022-09-08 14:55 ` Tvrtko Ursulin
2022-09-08 19:22 ` Das, Nirmoy
2022-09-08 15:11 ` Ville Syrjälä
1 sibling, 1 reply; 15+ messages in thread
From: Tvrtko Ursulin @ 2022-09-08 14:55 UTC (permalink / raw)
To: Das, Nirmoy, Ville Syrjala, intel-gfx
On 08/09/2022 15:32, Das, Nirmoy wrote:
> Hi Ville,
>
>
> I fixed a similar issue in DII but I couldn't reproduce it in drm
>
> http://intel-gfx-pw.fi.intel.com/patch/228850/?series=15910&rev=2.
>
> I wonder if that fixes the problem you are facing then I can send that
> to drm.
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c
> b/drivers/gpu/drm/i915/i915_gem.c
> index 7809be3a6840..5438e9277924 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -1213,7 +1213,7 @@ void i915_gem_init_early(struct drm_i915_private
> *dev_priv)
>
> void i915_gem_cleanup_early(struct drm_i915_private *dev_priv)
> {
> - i915_gem_drain_freed_objects(dev_priv);
> + i915_gem_drain_workqueue(dev_priv);
> GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list));
> GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count));
> drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count);
Yes why not, more black magic (count to three) but if it works... :) I
also spy the general area has been a bit neglected. Like:
i915_gem_driver_remove:
...
i915_gem_drain_workqueue
i915_gem_drain_freed_objects
While i915_gem_drain_workqueue:
...
i915_gem_drain_freed_objects
So i915_gem_drain_freed_objects in i915_gem_driver_remove is redundant
already.
Should i915_gem_drain_freed_objects be unexported and all callers made
just call i915_gem_drain_workqueue after your patch? Or if "drain free
objects" is considered more self descriptive it could be made as an
alias to i915_gem_drain_workqueue.
Regards,
Tvrtko
>
>
> Regards,
>
> Nirmoy
>
> On 9/6/2022 7:46 PM, Ville Syrjala wrote:
>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
>> On gen3 the selftests are pretty much always tripping this:
>> <4> [383.822424] pci 0000:00:02.0: drm_WARN_ON(dev_priv->mm.shrink_count)
>> <4> [383.822546] WARNING: CPU: 2 PID: 3560 at
>> drivers/gpu/drm/i915/i915_gem.c:1223 i915_gem_cleanup_early+0x96/0xb0
>> [i915]
>>
>> Looks to be due to the status page object lingering on the
>> purge_list. Call synchronize_rcu() ahead of it to make more
>> sure all objects have been freed.
>>
>> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_gem.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gem.c
>> b/drivers/gpu/drm/i915/i915_gem.c
>> index 0f49ec9d494a..5b61f7ad6473 100644
>> --- a/drivers/gpu/drm/i915/i915_gem.c
>> +++ b/drivers/gpu/drm/i915/i915_gem.c
>> @@ -1098,6 +1098,7 @@ void i915_gem_drain_freed_objects(struct
>> drm_i915_private *i915)
>> flush_delayed_work(&i915->bdev.wq);
>> rcu_barrier();
>> }
>> + synchronize_rcu();
>> }
>> /*
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects
2022-09-08 14:32 ` Das, Nirmoy
2022-09-08 14:55 ` Tvrtko Ursulin
@ 2022-09-08 15:11 ` Ville Syrjälä
2022-09-08 19:34 ` Das, Nirmoy
1 sibling, 1 reply; 15+ messages in thread
From: Ville Syrjälä @ 2022-09-08 15:11 UTC (permalink / raw)
To: Das, Nirmoy; +Cc: intel-gfx
On Thu, Sep 08, 2022 at 04:32:56PM +0200, Das, Nirmoy wrote:
> Hi Ville,
>
>
> I fixed a similar issue in DII but I couldn't reproduce it in drm
>
> http://intel-gfx-pw.fi.intel.com/patch/228850/?series=15910&rev=2.
>
> I wonder if that fixes the problem you are facing then I can send that
> to drm.
CI can tell you. It has been complaining about this for ages without
anyone doing anything about it.
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c
> b/drivers/gpu/drm/i915/i915_gem.c
> index 7809be3a6840..5438e9277924 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -1213,7 +1213,7 @@ void i915_gem_init_early(struct drm_i915_private
> *dev_priv)
>
> void i915_gem_cleanup_early(struct drm_i915_private *dev_priv)
> {
> - i915_gem_drain_freed_objects(dev_priv);
> + i915_gem_drain_workqueue(dev_priv);
> GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list));
> GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count));
> drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count);
>
>
> Regards,
>
> Nirmoy
>
> On 9/6/2022 7:46 PM, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > On gen3 the selftests are pretty much always tripping this:
> > <4> [383.822424] pci 0000:00:02.0: drm_WARN_ON(dev_priv->mm.shrink_count)
> > <4> [383.822546] WARNING: CPU: 2 PID: 3560 at drivers/gpu/drm/i915/i915_gem.c:1223 i915_gem_cleanup_early+0x96/0xb0 [i915]
> >
> > Looks to be due to the status page object lingering on the
> > purge_list. Call synchronize_rcu() ahead of it to make more
> > sure all objects have been freed.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_gem.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> > index 0f49ec9d494a..5b61f7ad6473 100644
> > --- a/drivers/gpu/drm/i915/i915_gem.c
> > +++ b/drivers/gpu/drm/i915/i915_gem.c
> > @@ -1098,6 +1098,7 @@ void i915_gem_drain_freed_objects(struct drm_i915_private *i915)
> > flush_delayed_work(&i915->bdev.wq);
> > rcu_barrier();
> > }
> > + synchronize_rcu();
> > }
> >
> > /*
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Kick rcu harder to free objects (rev2)
2022-09-06 17:46 [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects Ville Syrjala
` (4 preceding siblings ...)
2022-09-08 14:32 ` Das, Nirmoy
@ 2022-09-08 15:15 ` Patchwork
5 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-09-08 15:15 UTC (permalink / raw)
To: Das, Nirmoy; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Kick rcu harder to free objects (rev2)
URL : https://patchwork.freedesktop.org/series/108196/
State : failure
== Summary ==
Error: patch https://patchwork.freedesktop.org/api/1.0/series/108196/revisions/2/mbox/ not applied
Applying: drm/i915: Kick rcu harder to free objects
error: git diff header lacks filename information when removing 1 leading pathname component (line 2)
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 drm/i915: Kick rcu harder to free objects
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects
2022-09-08 14:55 ` Tvrtko Ursulin
@ 2022-09-08 19:22 ` Das, Nirmoy
0 siblings, 0 replies; 15+ messages in thread
From: Das, Nirmoy @ 2022-09-08 19:22 UTC (permalink / raw)
To: Tvrtko Ursulin, Ville Syrjala, intel-gfx
On 9/8/2022 4:55 PM, Tvrtko Ursulin wrote:
>
> On 08/09/2022 15:32, Das, Nirmoy wrote:
>> Hi Ville,
>>
>>
>> I fixed a similar issue in DII but I couldn't reproduce it in drm
>>
>> http://intel-gfx-pw.fi.intel.com/patch/228850/?series=15910&rev=2.
>>
>> I wonder if that fixes the problem you are facing then I can send
>> that to drm.
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gem.c
>> b/drivers/gpu/drm/i915/i915_gem.c
>> index 7809be3a6840..5438e9277924 100644
>> --- a/drivers/gpu/drm/i915/i915_gem.c
>> +++ b/drivers/gpu/drm/i915/i915_gem.c
>> @@ -1213,7 +1213,7 @@ void i915_gem_init_early(struct
>> drm_i915_private *dev_priv)
>>
>> void i915_gem_cleanup_early(struct drm_i915_private *dev_priv)
>> {
>> - i915_gem_drain_freed_objects(dev_priv);
>> + i915_gem_drain_workqueue(dev_priv);
>> GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list));
>> GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count));
>> drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count);
>
> Yes why not, more black magic (count to three) but if it works... :) I
> also spy the general area has been a bit neglected. Like:
Not sure what should be the correct solution here. I wonder if we might
have to change this because of
https://lwn.net/Articles/906975/ ?
>
> i915_gem_driver_remove:
> ...
> i915_gem_drain_workqueue
> i915_gem_drain_freed_objects
>
> While i915_gem_drain_workqueue:
> ...
> i915_gem_drain_freed_objects
>
> So i915_gem_drain_freed_objects in i915_gem_driver_remove is redundant
> already.
>
> Should i915_gem_drain_freed_objects be unexported and all callers made
> just call i915_gem_drain_workqueue after your patch? Or if "drain free
> objects" is considered more self descriptive it could be made as an
> alias to i915_gem_drain_workqueue.
We are using i915_gem_drain_freed_objects() in many places and replacing
that with i915_gem_drain_workqueue() might have performance implication.
Nirmoy
>
> Regards,
>
> Tvrtko
>
>>
>>
>> Regards,
>>
>> Nirmoy
>>
>> On 9/6/2022 7:46 PM, Ville Syrjala wrote:
>>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>>
>>> On gen3 the selftests are pretty much always tripping this:
>>> <4> [383.822424] pci 0000:00:02.0:
>>> drm_WARN_ON(dev_priv->mm.shrink_count)
>>> <4> [383.822546] WARNING: CPU: 2 PID: 3560 at
>>> drivers/gpu/drm/i915/i915_gem.c:1223
>>> i915_gem_cleanup_early+0x96/0xb0 [i915]
>>>
>>> Looks to be due to the status page object lingering on the
>>> purge_list. Call synchronize_rcu() ahead of it to make more
>>> sure all objects have been freed.
>>>
>>> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>> ---
>>> drivers/gpu/drm/i915/i915_gem.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_gem.c
>>> b/drivers/gpu/drm/i915/i915_gem.c
>>> index 0f49ec9d494a..5b61f7ad6473 100644
>>> --- a/drivers/gpu/drm/i915/i915_gem.c
>>> +++ b/drivers/gpu/drm/i915/i915_gem.c
>>> @@ -1098,6 +1098,7 @@ void i915_gem_drain_freed_objects(struct
>>> drm_i915_private *i915)
>>> flush_delayed_work(&i915->bdev.wq);
>>> rcu_barrier();
>>> }
>>> + synchronize_rcu();
>>> }
>>> /*
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects
2022-09-08 15:11 ` Ville Syrjälä
@ 2022-09-08 19:34 ` Das, Nirmoy
2022-09-09 7:29 ` Ville Syrjälä
0 siblings, 1 reply; 15+ messages in thread
From: Das, Nirmoy @ 2022-09-08 19:34 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On 9/8/2022 5:11 PM, Ville Syrjälä wrote:
> On Thu, Sep 08, 2022 at 04:32:56PM +0200, Das, Nirmoy wrote:
>> Hi Ville,
>>
>>
>> I fixed a similar issue in DII but I couldn't reproduce it in drm
>>
>> http://intel-gfx-pw.fi.intel.com/patch/228850/?series=15910&rev=2.
>>
>> I wonder if that fixes the problem you are facing then I can send that
>> to drm.
> CI can tell you. It has been complaining about this for ages
Could you please share a url/failed test name. I must be searching the
wrong hw/test(https://intel-gfx-ci.01.org/tree/drm-tip/fi-ivb-3770.html).
Thanks,
Nirmoy
> without
> anyone doing anything about it.
>
>> diff --git a/drivers/gpu/drm/i915/i915_gem.c
>> b/drivers/gpu/drm/i915/i915_gem.c
>> index 7809be3a6840..5438e9277924 100644
>> --- a/drivers/gpu/drm/i915/i915_gem.c
>> +++ b/drivers/gpu/drm/i915/i915_gem.c
>> @@ -1213,7 +1213,7 @@ void i915_gem_init_early(struct drm_i915_private
>> *dev_priv)
>>
>> void i915_gem_cleanup_early(struct drm_i915_private *dev_priv)
>> {
>> - i915_gem_drain_freed_objects(dev_priv);
>> + i915_gem_drain_workqueue(dev_priv);
>> GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list));
>> GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count));
>> drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count);
>>
>>
>> Regards,
>>
>> Nirmoy
>>
>> On 9/6/2022 7:46 PM, Ville Syrjala wrote:
>>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>>
>>> On gen3 the selftests are pretty much always tripping this:
>>> <4> [383.822424] pci 0000:00:02.0: drm_WARN_ON(dev_priv->mm.shrink_count)
>>> <4> [383.822546] WARNING: CPU: 2 PID: 3560 at drivers/gpu/drm/i915/i915_gem.c:1223 i915_gem_cleanup_early+0x96/0xb0 [i915]
>>>
>>> Looks to be due to the status page object lingering on the
>>> purge_list. Call synchronize_rcu() ahead of it to make more
>>> sure all objects have been freed.
>>>
>>> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>> ---
>>> drivers/gpu/drm/i915/i915_gem.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
>>> index 0f49ec9d494a..5b61f7ad6473 100644
>>> --- a/drivers/gpu/drm/i915/i915_gem.c
>>> +++ b/drivers/gpu/drm/i915/i915_gem.c
>>> @@ -1098,6 +1098,7 @@ void i915_gem_drain_freed_objects(struct drm_i915_private *i915)
>>> flush_delayed_work(&i915->bdev.wq);
>>> rcu_barrier();
>>> }
>>> + synchronize_rcu();
>>> }
>>>
>>> /*
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects
2022-09-08 19:34 ` Das, Nirmoy
@ 2022-09-09 7:29 ` Ville Syrjälä
2022-09-21 7:56 ` Ville Syrjälä
0 siblings, 1 reply; 15+ messages in thread
From: Ville Syrjälä @ 2022-09-09 7:29 UTC (permalink / raw)
To: Das, Nirmoy; +Cc: intel-gfx
On Thu, Sep 08, 2022 at 09:34:04PM +0200, Das, Nirmoy wrote:
>
> On 9/8/2022 5:11 PM, Ville Syrjälä wrote:
> > On Thu, Sep 08, 2022 at 04:32:56PM +0200, Das, Nirmoy wrote:
> >> Hi Ville,
> >>
> >>
> >> I fixed a similar issue in DII but I couldn't reproduce it in drm
> >>
> >> http://intel-gfx-pw.fi.intel.com/patch/228850/?series=15910&rev=2.
> >>
> >> I wonder if that fixes the problem you are facing then I can send that
> >> to drm.
> > CI can tell you. It has been complaining about this for ages
>
>
> Could you please share a url/failed test name. I must be searching the
> wrong hw/test(https://intel-gfx-ci.01.org/tree/drm-tip/fi-ivb-3770.html).
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12102/fi-pnv-d510/igt@i915_selftest@live@requests.html
gen3 hits it nearly 100% of the time in the live selftests.
IIRC it also looked like shard-snb has also hit it more
sporadically in some tests.
There's also at least one bug about it
https://gitlab.freedesktop.org/drm/intel/-/issues/4528
which I guess is why ci is able to ignore this, and that
then has enabled all the humans to ignore it as well.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects
2022-09-09 7:29 ` Ville Syrjälä
@ 2022-09-21 7:56 ` Ville Syrjälä
2022-09-22 8:39 ` Das, Nirmoy
0 siblings, 1 reply; 15+ messages in thread
From: Ville Syrjälä @ 2022-09-21 7:56 UTC (permalink / raw)
To: Das, Nirmoy; +Cc: intel-gfx
On Fri, Sep 09, 2022 at 10:29:55AM +0300, Ville Syrjälä wrote:
> On Thu, Sep 08, 2022 at 09:34:04PM +0200, Das, Nirmoy wrote:
> >
> > On 9/8/2022 5:11 PM, Ville Syrjälä wrote:
> > > On Thu, Sep 08, 2022 at 04:32:56PM +0200, Das, Nirmoy wrote:
> > >> Hi Ville,
> > >>
> > >>
> > >> I fixed a similar issue in DII but I couldn't reproduce it in drm
> > >>
> > >> http://intel-gfx-pw.fi.intel.com/patch/228850/?series=15910&rev=2.
> > >>
> > >> I wonder if that fixes the problem you are facing then I can send that
> > >> to drm.
> > > CI can tell you. It has been complaining about this for ages
> >
> >
> > Could you please share a url/failed test name. I must be searching the
> > wrong hw/test(https://intel-gfx-ci.01.org/tree/drm-tip/fi-ivb-3770.html).
>
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12102/fi-pnv-d510/igt@i915_selftest@live@requests.html
>
> gen3 hits it nearly 100% of the time in the live selftests.
> IIRC it also looked like shard-snb has also hit it more
> sporadically in some tests.
>
> There's also at least one bug about it
> https://gitlab.freedesktop.org/drm/intel/-/issues/4528
> which I guess is why ci is able to ignore this, and that
> then has enabled all the humans to ignore it as well.
Did we get anywhere with this? I'm getting tired of
seeing the red in CI.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects
2022-09-21 7:56 ` Ville Syrjälä
@ 2022-09-22 8:39 ` Das, Nirmoy
0 siblings, 0 replies; 15+ messages in thread
From: Das, Nirmoy @ 2022-09-22 8:39 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On 9/21/2022 9:56 AM, Ville Syrjälä wrote:
> On Fri, Sep 09, 2022 at 10:29:55AM +0300, Ville Syrjälä wrote:
>> On Thu, Sep 08, 2022 at 09:34:04PM +0200, Das, Nirmoy wrote:
>>> On 9/8/2022 5:11 PM, Ville Syrjälä wrote:
>>>> On Thu, Sep 08, 2022 at 04:32:56PM +0200, Das, Nirmoy wrote:
>>>>> Hi Ville,
>>>>>
>>>>>
>>>>> I fixed a similar issue in DII but I couldn't reproduce it in drm
>>>>>
>>>>> http://intel-gfx-pw.fi.intel.com/patch/228850/?series=15910&rev=2.
>>>>>
>>>>> I wonder if that fixes the problem you are facing then I can send that
>>>>> to drm.
>>>> CI can tell you. It has been complaining about this for ages
>>>
>>> Could you please share a url/failed test name. I must be searching the
>>> wrong hw/test(https://intel-gfx-ci.01.org/tree/drm-tip/fi-ivb-3770.html).
>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12102/fi-pnv-d510/igt@i915_selftest@live@requests.html
>>
>> gen3 hits it nearly 100% of the time in the live selftests.
>> IIRC it also looked like shard-snb has also hit it more
>> sporadically in some tests.
>>
>> There's also at least one bug about it
>> https://gitlab.freedesktop.org/drm/intel/-/issues/4528
>> which I guess is why ci is able to ignore this, and that
>> then has enabled all the humans to ignore it as well.
> Did we get anywhere with this? I'm getting tired of
> seeing the red in CI.
Please review
https://patchwork.freedesktop.org/patch/501991/?series=108314&rev=1
Sorry, I should've Cced you.
It seems to fix the issue:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108314v1/fi-pnv-d510/igt@i915_selftest@live@requests.html
Regards,
Nirmoy
>
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-09-22 8:39 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-06 17:46 [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects Ville Syrjala
2022-09-06 18:40 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-09-06 18:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-06 22:10 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-09-08 12:23 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
2022-09-08 13:30 ` Ville Syrjälä
2022-09-08 14:32 ` Das, Nirmoy
2022-09-08 14:55 ` Tvrtko Ursulin
2022-09-08 19:22 ` Das, Nirmoy
2022-09-08 15:11 ` Ville Syrjälä
2022-09-08 19:34 ` Das, Nirmoy
2022-09-09 7:29 ` Ville Syrjälä
2022-09-21 7:56 ` Ville Syrjälä
2022-09-22 8:39 ` Das, Nirmoy
2022-09-08 15:15 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Kick rcu harder to free objects (rev2) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.