All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects
@ 2022-09-06 17:46 Ville Syrjala
  2022-09-06 18:40 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 15+ messages in thread
From: Ville Syrjala @ 2022-09-06 17:46 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

On gen3 the selftests are pretty much always tripping this:
<4> [383.822424] pci 0000:00:02.0: drm_WARN_ON(dev_priv->mm.shrink_count)
<4> [383.822546] WARNING: CPU: 2 PID: 3560 at drivers/gpu/drm/i915/i915_gem.c:1223 i915_gem_cleanup_early+0x96/0xb0 [i915]

Looks to be due to the status page object lingering on the
purge_list. Call synchronize_rcu() ahead of it to make more
sure all objects have been freed.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_gem.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 0f49ec9d494a..5b61f7ad6473 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1098,6 +1098,7 @@ void i915_gem_drain_freed_objects(struct drm_i915_private *i915)
 		flush_delayed_work(&i915->bdev.wq);
 		rcu_barrier();
 	}
+	synchronize_rcu();
 }
 
 /*
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2022-09-22  8:39 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-06 17:46 [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects Ville Syrjala
2022-09-06 18:40 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-09-06 18:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-06 22:10 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-09-08 12:23 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
2022-09-08 13:30   ` Ville Syrjälä
2022-09-08 14:32 ` Das, Nirmoy
2022-09-08 14:55   ` Tvrtko Ursulin
2022-09-08 19:22     ` Das, Nirmoy
2022-09-08 15:11   ` Ville Syrjälä
2022-09-08 19:34     ` Das, Nirmoy
2022-09-09  7:29       ` Ville Syrjälä
2022-09-21  7:56         ` Ville Syrjälä
2022-09-22  8:39           ` Das, Nirmoy
2022-09-08 15:15 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Kick rcu harder to free objects (rev2) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.