From: Jesper Dangaard Brouer <brouer@redhat.com>
To: bpf@vger.kernel.org, "Stanislav Fomichev" <sdf@google.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: ast@kernel.org, edumazet@google.com, anthony.l.nguyen@intel.com,
boon.leong.ong@intel.com, hawk@kernel.org,
xdp-hints@xdp-project.net, daniel@iogearbox.net,
linux-rdma@vger.kernel.org, john.fastabend@gmail.com,
jesse.brandeburg@intel.com, intel-wired-lan@lists.osuosl.org,
Jesper Dangaard Brouer <brouer@redhat.com>,
kuba@kernel.org, pabeni@redhat.com, martin.lau@kernel.org,
larysa.zaremba@intel.com, leon@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
tariqt@nvidia.com, yoong.siang.song@intel.com, saeedm@nvidia.com,
davem@davemloft.net
Subject: [Intel-wired-lan] [PATCH bpf V8 0/7] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash
Date: Wed, 12 Apr 2023 14:42:37 +0200 [thread overview]
Message-ID: <168130333143.150247.11159481574477358816.stgit@firesoul> (raw)
Current API for bpf_xdp_metadata_rx_hash() returns the raw RSS hash value,
but doesn't provide information on the RSS hash type (part of 6.3-rc).
This patchset proposal is to change the function call signature via adding
a pointer value argument for providing the RSS hash type.
Patchset also disables all bpf_printk's from xdp_hw_metadata program
that we expect driver developers to use. Instead counters are introduced
for relaying e.g. skip and fail info to end-user, this can be further
debugged by re-enabling bpf_printk (when driver devel troubleshoot).
---
Jesper Dangaard Brouer (7):
selftests/bpf: xdp_hw_metadata default disable bpf_printk
selftests/bpf: Add counters to xdp_hw_metadata
xdp: rss hash types representation
mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type
veth: bpf_xdp_metadata_rx_hash add xdp rss hash type
mlx4: bpf_xdp_metadata_rx_hash add xdp rss hash type
selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg
drivers/net/ethernet/mellanox/mlx4/en_rx.c | 22 ++++++-
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 3 +-
.../net/ethernet/mellanox/mlx5/core/en/xdp.c | 63 ++++++++++++++++++-
drivers/net/veth.c | 10 ++-
include/linux/mlx5/device.h | 14 ++++-
include/linux/netdevice.h | 3 +-
include/net/xdp.h | 47 ++++++++++++++
net/core/xdp.c | 10 ++-
.../selftests/bpf/prog_tests/xdp_metadata.c | 2 +
.../selftests/bpf/progs/xdp_hw_metadata.c | 42 ++++++++++---
.../selftests/bpf/progs/xdp_metadata.c | 6 +-
.../selftests/bpf/progs/xdp_metadata2.c | 7 ++-
tools/testing/selftests/bpf/xdp_hw_metadata.c | 10 ++-
tools/testing/selftests/bpf/xdp_metadata.h | 4 ++
14 files changed, 213 insertions(+), 30 deletions(-)
--
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jesper Dangaard Brouer <brouer@redhat.com>
To: bpf@vger.kernel.org, "Stanislav Fomichev" <sdf@google.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
martin.lau@kernel.org, ast@kernel.org, daniel@iogearbox.net,
alexandr.lobakin@intel.com, larysa.zaremba@intel.com,
xdp-hints@xdp-project.net, anthony.l.nguyen@intel.com,
yoong.siang.song@intel.com, boon.leong.ong@intel.com,
intel-wired-lan@lists.osuosl.org, pabeni@redhat.com,
jesse.brandeburg@intel.com, kuba@kernel.org, edumazet@google.com,
john.fastabend@gmail.com, hawk@kernel.org, davem@davemloft.net,
tariqt@nvidia.com, saeedm@nvidia.com, leon@kernel.org,
linux-rdma@vger.kernel.org
Subject: [PATCH bpf V8 0/7] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash
Date: Wed, 12 Apr 2023 14:42:37 +0200 [thread overview]
Message-ID: <168130333143.150247.11159481574477358816.stgit@firesoul> (raw)
Current API for bpf_xdp_metadata_rx_hash() returns the raw RSS hash value,
but doesn't provide information on the RSS hash type (part of 6.3-rc).
This patchset proposal is to change the function call signature via adding
a pointer value argument for providing the RSS hash type.
Patchset also disables all bpf_printk's from xdp_hw_metadata program
that we expect driver developers to use. Instead counters are introduced
for relaying e.g. skip and fail info to end-user, this can be further
debugged by re-enabling bpf_printk (when driver devel troubleshoot).
---
Jesper Dangaard Brouer (7):
selftests/bpf: xdp_hw_metadata default disable bpf_printk
selftests/bpf: Add counters to xdp_hw_metadata
xdp: rss hash types representation
mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type
veth: bpf_xdp_metadata_rx_hash add xdp rss hash type
mlx4: bpf_xdp_metadata_rx_hash add xdp rss hash type
selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg
drivers/net/ethernet/mellanox/mlx4/en_rx.c | 22 ++++++-
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 3 +-
.../net/ethernet/mellanox/mlx5/core/en/xdp.c | 63 ++++++++++++++++++-
drivers/net/veth.c | 10 ++-
include/linux/mlx5/device.h | 14 ++++-
include/linux/netdevice.h | 3 +-
include/net/xdp.h | 47 ++++++++++++++
net/core/xdp.c | 10 ++-
.../selftests/bpf/prog_tests/xdp_metadata.c | 2 +
.../selftests/bpf/progs/xdp_hw_metadata.c | 42 ++++++++++---
.../selftests/bpf/progs/xdp_metadata.c | 6 +-
.../selftests/bpf/progs/xdp_metadata2.c | 7 ++-
tools/testing/selftests/bpf/xdp_hw_metadata.c | 10 ++-
tools/testing/selftests/bpf/xdp_metadata.h | 4 ++
14 files changed, 213 insertions(+), 30 deletions(-)
--
next reply other threads:[~2023-04-12 12:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 12:42 Jesper Dangaard Brouer [this message]
2023-04-12 12:42 ` [PATCH bpf V8 0/7] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash Jesper Dangaard Brouer
2023-04-12 12:42 ` [Intel-wired-lan] [PATCH bpf V8 1/7] selftests/bpf: xdp_hw_metadata default disable bpf_printk Jesper Dangaard Brouer
2023-04-12 12:42 ` Jesper Dangaard Brouer
2023-04-12 12:42 ` [Intel-wired-lan] [PATCH bpf V8 2/7] selftests/bpf: Add counters to xdp_hw_metadata Jesper Dangaard Brouer
2023-04-12 12:42 ` Jesper Dangaard Brouer
2023-04-12 16:56 ` [Intel-wired-lan] " Stanislav Fomichev
2023-04-12 16:56 ` Stanislav Fomichev
2023-04-12 17:52 ` [Intel-wired-lan] " Jesper Dangaard Brouer
2023-04-12 17:52 ` Jesper Dangaard Brouer
2023-04-12 17:56 ` Stanislav Fomichev
2023-04-12 17:56 ` [Intel-wired-lan] " Stanislav Fomichev
2023-04-12 12:42 ` [Intel-wired-lan] [PATCH bpf V8 3/7] xdp: rss hash types representation Jesper Dangaard Brouer
2023-04-12 12:42 ` Jesper Dangaard Brouer
2023-04-12 12:42 ` [Intel-wired-lan] [PATCH bpf V8 4/7] mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type Jesper Dangaard Brouer
2023-04-12 12:42 ` Jesper Dangaard Brouer
2023-04-12 12:43 ` [Intel-wired-lan] [PATCH bpf V8 5/7] veth: " Jesper Dangaard Brouer
2023-04-12 12:43 ` Jesper Dangaard Brouer
2023-04-12 12:43 ` [Intel-wired-lan] [PATCH bpf V8 6/7] mlx4: " Jesper Dangaard Brouer
2023-04-12 12:43 ` Jesper Dangaard Brouer
2023-04-12 12:43 ` [Intel-wired-lan] [PATCH bpf V8 7/7] selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg Jesper Dangaard Brouer
2023-04-12 12:43 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168130333143.150247.11159481574477358816.stgit@firesoul \
--to=brouer@redhat.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=boon.leong.ong@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=sdf@google.com \
--cc=tariqt@nvidia.com \
--cc=toke@redhat.com \
--cc=xdp-hints@xdp-project.net \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.