From: Jesper Dangaard Brouer <brouer@redhat.com> To: bpf@vger.kernel.org, "Stanislav Fomichev" <sdf@google.com>, "Toke Høiland-Jørgensen" <toke@redhat.com> Cc: ast@kernel.org, edumazet@google.com, anthony.l.nguyen@intel.com, boon.leong.ong@intel.com, hawk@kernel.org, xdp-hints@xdp-project.net, daniel@iogearbox.net, linux-rdma@vger.kernel.org, john.fastabend@gmail.com, jesse.brandeburg@intel.com, intel-wired-lan@lists.osuosl.org, Jesper Dangaard Brouer <brouer@redhat.com>, kuba@kernel.org, pabeni@redhat.com, martin.lau@kernel.org, larysa.zaremba@intel.com, leon@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, tariqt@nvidia.com, yoong.siang.song@intel.com, saeedm@nvidia.com, davem@davemloft.net Subject: [Intel-wired-lan] [PATCH bpf V8 1/7] selftests/bpf: xdp_hw_metadata default disable bpf_printk Date: Wed, 12 Apr 2023 14:42:42 +0200 [thread overview] Message-ID: <168130336215.150247.1088133245386431977.stgit@firesoul> (raw) In-Reply-To: <168130333143.150247.11159481574477358816.stgit@firesoul> The tool xdp_hw_metadata can be used by driver developers implementing XDP-hints kfuncs. The tool transfers the XDP-hints via metadata information to an AF_XDP userspace process. When everything works the bpf_printk calls are unncesssary. Thus, disable bpf_printk by default, but make it easy to reenable for driver developers to use when debugging their driver implementation. Next patch will add counters to track some of these cases. That will provide a hint to re-enable bpf_printk. This also converts bpf_printk "forwarding UDP:9091 to AF_XDP" into a code comment. The bpf_printk's that are important to the driver developers is when bpf_xdp_adjust_meta fails. The likely mistake from driver developers is expected to be that they didn't implement XDP metadata adjust support. Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com> --- .../testing/selftests/bpf/progs/xdp_hw_metadata.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c b/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c index 4c55b4d79d3d..b0104763405a 100644 --- a/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c +++ b/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c @@ -5,6 +5,19 @@ #include <bpf/bpf_helpers.h> #include <bpf/bpf_endian.h> +/* Per default below bpf_printk() calls are disabled. Can be + * reenabled manually for convenience by XDP-hints driver developer, + * when troubleshooting the drivers kfuncs implementation details. + * + * Remember BPF-prog bpf_printk info output can be access via: + * /sys/kernel/debug/tracing/trace_pipe + */ +//#define DEBUG 1 +#ifndef DEBUG +#undef bpf_printk +#define bpf_printk(fmt, ...) ({}) +#endif + struct { __uint(type, BPF_MAP_TYPE_XSKMAP); __uint(max_entries, 256); @@ -49,11 +62,10 @@ int rx(struct xdp_md *ctx) if (!udp) return XDP_PASS; + /* Forwarding UDP:9091 to AF_XDP */ if (udp->dest != bpf_htons(9091)) return XDP_PASS; - bpf_printk("forwarding UDP:9091 to AF_XDP"); - ret = bpf_xdp_adjust_meta(ctx, -(int)sizeof(struct xdp_meta)); if (ret != 0) { bpf_printk("bpf_xdp_adjust_meta returned %d", ret); _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jesper Dangaard Brouer <brouer@redhat.com> To: bpf@vger.kernel.org, "Stanislav Fomichev" <sdf@google.com>, "Toke Høiland-Jørgensen" <toke@redhat.com> Cc: Jesper Dangaard Brouer <brouer@redhat.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, martin.lau@kernel.org, ast@kernel.org, daniel@iogearbox.net, alexandr.lobakin@intel.com, larysa.zaremba@intel.com, xdp-hints@xdp-project.net, anthony.l.nguyen@intel.com, yoong.siang.song@intel.com, boon.leong.ong@intel.com, intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, jesse.brandeburg@intel.com, kuba@kernel.org, edumazet@google.com, john.fastabend@gmail.com, hawk@kernel.org, davem@davemloft.net, tariqt@nvidia.com, saeedm@nvidia.com, leon@kernel.org, linux-rdma@vger.kernel.org Subject: [PATCH bpf V8 1/7] selftests/bpf: xdp_hw_metadata default disable bpf_printk Date: Wed, 12 Apr 2023 14:42:42 +0200 [thread overview] Message-ID: <168130336215.150247.1088133245386431977.stgit@firesoul> (raw) In-Reply-To: <168130333143.150247.11159481574477358816.stgit@firesoul> The tool xdp_hw_metadata can be used by driver developers implementing XDP-hints kfuncs. The tool transfers the XDP-hints via metadata information to an AF_XDP userspace process. When everything works the bpf_printk calls are unncesssary. Thus, disable bpf_printk by default, but make it easy to reenable for driver developers to use when debugging their driver implementation. Next patch will add counters to track some of these cases. That will provide a hint to re-enable bpf_printk. This also converts bpf_printk "forwarding UDP:9091 to AF_XDP" into a code comment. The bpf_printk's that are important to the driver developers is when bpf_xdp_adjust_meta fails. The likely mistake from driver developers is expected to be that they didn't implement XDP metadata adjust support. Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com> --- .../testing/selftests/bpf/progs/xdp_hw_metadata.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c b/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c index 4c55b4d79d3d..b0104763405a 100644 --- a/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c +++ b/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c @@ -5,6 +5,19 @@ #include <bpf/bpf_helpers.h> #include <bpf/bpf_endian.h> +/* Per default below bpf_printk() calls are disabled. Can be + * reenabled manually for convenience by XDP-hints driver developer, + * when troubleshooting the drivers kfuncs implementation details. + * + * Remember BPF-prog bpf_printk info output can be access via: + * /sys/kernel/debug/tracing/trace_pipe + */ +//#define DEBUG 1 +#ifndef DEBUG +#undef bpf_printk +#define bpf_printk(fmt, ...) ({}) +#endif + struct { __uint(type, BPF_MAP_TYPE_XSKMAP); __uint(max_entries, 256); @@ -49,11 +62,10 @@ int rx(struct xdp_md *ctx) if (!udp) return XDP_PASS; + /* Forwarding UDP:9091 to AF_XDP */ if (udp->dest != bpf_htons(9091)) return XDP_PASS; - bpf_printk("forwarding UDP:9091 to AF_XDP"); - ret = bpf_xdp_adjust_meta(ctx, -(int)sizeof(struct xdp_meta)); if (ret != 0) { bpf_printk("bpf_xdp_adjust_meta returned %d", ret);
next prev parent reply other threads:[~2023-04-12 12:43 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-12 12:42 [Intel-wired-lan] [PATCH bpf V8 0/7] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash Jesper Dangaard Brouer 2023-04-12 12:42 ` Jesper Dangaard Brouer 2023-04-12 12:42 ` Jesper Dangaard Brouer [this message] 2023-04-12 12:42 ` [PATCH bpf V8 1/7] selftests/bpf: xdp_hw_metadata default disable bpf_printk Jesper Dangaard Brouer 2023-04-12 12:42 ` [Intel-wired-lan] [PATCH bpf V8 2/7] selftests/bpf: Add counters to xdp_hw_metadata Jesper Dangaard Brouer 2023-04-12 12:42 ` Jesper Dangaard Brouer 2023-04-12 16:56 ` [Intel-wired-lan] " Stanislav Fomichev 2023-04-12 16:56 ` Stanislav Fomichev 2023-04-12 17:52 ` [Intel-wired-lan] " Jesper Dangaard Brouer 2023-04-12 17:52 ` Jesper Dangaard Brouer 2023-04-12 17:56 ` Stanislav Fomichev 2023-04-12 17:56 ` [Intel-wired-lan] " Stanislav Fomichev 2023-04-12 12:42 ` [Intel-wired-lan] [PATCH bpf V8 3/7] xdp: rss hash types representation Jesper Dangaard Brouer 2023-04-12 12:42 ` Jesper Dangaard Brouer 2023-04-12 12:42 ` [Intel-wired-lan] [PATCH bpf V8 4/7] mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type Jesper Dangaard Brouer 2023-04-12 12:42 ` Jesper Dangaard Brouer 2023-04-12 12:43 ` [Intel-wired-lan] [PATCH bpf V8 5/7] veth: " Jesper Dangaard Brouer 2023-04-12 12:43 ` Jesper Dangaard Brouer 2023-04-12 12:43 ` [Intel-wired-lan] [PATCH bpf V8 6/7] mlx4: " Jesper Dangaard Brouer 2023-04-12 12:43 ` Jesper Dangaard Brouer 2023-04-12 12:43 ` [Intel-wired-lan] [PATCH bpf V8 7/7] selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg Jesper Dangaard Brouer 2023-04-12 12:43 ` Jesper Dangaard Brouer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=168130336215.150247.1088133245386431977.stgit@firesoul \ --to=brouer@redhat.com \ --cc=anthony.l.nguyen@intel.com \ --cc=ast@kernel.org \ --cc=boon.leong.ong@intel.com \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=hawk@kernel.org \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jesse.brandeburg@intel.com \ --cc=john.fastabend@gmail.com \ --cc=kuba@kernel.org \ --cc=larysa.zaremba@intel.com \ --cc=leon@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=martin.lau@kernel.org \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=saeedm@nvidia.com \ --cc=sdf@google.com \ --cc=tariqt@nvidia.com \ --cc=toke@redhat.com \ --cc=xdp-hints@xdp-project.net \ --cc=yoong.siang.song@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.