From: Marek Vasut <marex@denx.de>
To: Jagan Teki <jagan@amarulasolutions.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Inki Dae <inki.dae@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Maxime Ripard <mripard@kernel.org>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Tim Harvey <tharvey@gateworks.com>,
Adam Ford <aford173@gmail.com>,
Matteo Lisi <matteo.lisi@engicam.com>,
dri-devel@lists.freedesktop.org,
linux-samsung-soc@vger.kernel.org,
linux-amarula <linux-amarula@amarulasolutions.com>
Subject: Re: [PATCH v15 02/16] drm: exynos: dsi: Lookup OF-graph or Child node devices
Date: Fri, 3 Mar 2023 17:41:02 +0100 [thread overview]
Message-ID: <1686f1fd-a2db-dc82-a2a7-740a68c09938@denx.de> (raw)
In-Reply-To: <20230303145138.29233-3-jagan@amarulasolutions.com>
On 3/3/23 15:51, Jagan Teki wrote:
[...]
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1470,18 +1470,52 @@ static int exynos_dsi_host_attach(struct mipi_dsi_host *host,
> struct device *dev = dsi->dev;
> struct drm_encoder *encoder = &dsi->encoder;
> struct drm_device *drm = encoder->dev;
> + struct device_node *np = dev->of_node;
> + struct device_node *remote;
> struct drm_panel *panel;
> int ret;
>
> - panel = of_drm_find_panel(device->dev.of_node);
> + /**
This shouldn't be kerneldoc style comment, drop that extra asterisk (*).
> + * Devices can also be child nodes when we also control that device
> + * through the upstream device (ie, MIPI-DCS for a MIPI-DSI device).
[...]
With that fixed:
Reviewed-by: Marek Vasut <marex@denx.de>
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: Jagan Teki <jagan@amarulasolutions.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Inki Dae <inki.dae@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Maxime Ripard <mripard@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org,
Matteo Lisi <matteo.lisi@engicam.com>,
linux-amarula <linux-amarula@amarulasolutions.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Kyungmin Park <kyungmin.park@samsung.com>,
dri-devel@lists.freedesktop.org, Adam Ford <aford173@gmail.com>
Subject: Re: [PATCH v15 02/16] drm: exynos: dsi: Lookup OF-graph or Child node devices
Date: Fri, 3 Mar 2023 17:41:02 +0100 [thread overview]
Message-ID: <1686f1fd-a2db-dc82-a2a7-740a68c09938@denx.de> (raw)
In-Reply-To: <20230303145138.29233-3-jagan@amarulasolutions.com>
On 3/3/23 15:51, Jagan Teki wrote:
[...]
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1470,18 +1470,52 @@ static int exynos_dsi_host_attach(struct mipi_dsi_host *host,
> struct device *dev = dsi->dev;
> struct drm_encoder *encoder = &dsi->encoder;
> struct drm_device *drm = encoder->dev;
> + struct device_node *np = dev->of_node;
> + struct device_node *remote;
> struct drm_panel *panel;
> int ret;
>
> - panel = of_drm_find_panel(device->dev.of_node);
> + /**
This shouldn't be kerneldoc style comment, drop that extra asterisk (*).
> + * Devices can also be child nodes when we also control that device
> + * through the upstream device (ie, MIPI-DCS for a MIPI-DSI device).
[...]
With that fixed:
Reviewed-by: Marek Vasut <marex@denx.de>
next prev parent reply other threads:[~2023-03-03 16:41 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230303145219eucas1p218c2e302e41464432627c8ac074302f8@eucas1p2.samsung.com>
2023-03-03 14:51 ` [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 14:51 ` [PATCH v15 01/16] drm: exynos: dsi: Drop explicit call to bridge detach Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 16:39 ` Marek Vasut
2023-03-03 16:39 ` Marek Vasut
2023-03-03 14:51 ` [PATCH v15 02/16] drm: exynos: dsi: Lookup OF-graph or Child node devices Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 16:41 ` Marek Vasut [this message]
2023-03-03 16:41 ` Marek Vasut
2023-03-03 14:51 ` [PATCH v15 03/16] drm: exynos: dsi: Mark PHY as optional Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 14:51 ` [PATCH v15 04/16] drm: exynos: dsi: Add platform PLL_P (PMS_P) offset Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 14:51 ` [PATCH v15 05/16] drm: exynos: dsi: Introduce hw_type platform data Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 14:51 ` [PATCH v15 06/16] drm: exynos: dsi: Handle proper host initialization Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 14:51 ` [PATCH v15 07/16] drm: exynos: dsi: Add atomic check Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 14:51 ` [PATCH v15 08/16] drm: exynos: dsi: Add input_bus_flags Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 15:00 ` Maxime Ripard
2023-03-03 15:00 ` Maxime Ripard
2023-03-03 15:02 ` Maxime Ripard
2023-03-03 15:02 ` Maxime Ripard
2023-03-03 14:51 ` [PATCH v15 09/16] drm: exynos: dsi: Add atomic_get_input_bus_fmts Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 14:51 ` [PATCH v15 10/16] drm: exynos: dsi: Consolidate component and bridge Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 14:51 ` [PATCH v15 11/16] drm: exynos: dsi: Add host helper for te_irq_handler Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 14:51 ` [PATCH v15 12/16] drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge Jagan Teki
2023-03-03 15:08 ` Maxime Ripard
2023-03-03 15:08 ` Maxime Ripard
2023-03-03 15:11 ` Jagan Teki
2023-03-03 15:11 ` Jagan Teki
2023-03-03 14:51 ` [PATCH v15 13/16] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 14:51 ` [PATCH v15 14/16] drm: bridge: samsung-dsim: Add " Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 14:51 ` [PATCH v15 15/16] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 14:51 ` [PATCH v15 16/16] drm: bridge: samsung-dsim: Add " Jagan Teki
2023-03-03 14:51 ` Jagan Teki
2023-03-03 22:26 ` [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge Marek Szyprowski
2023-03-03 22:26 ` Marek Szyprowski
2023-03-04 18:59 ` Jagan Teki
2023-03-04 18:59 ` Jagan Teki
2023-03-06 11:02 ` Marek Szyprowski
2023-03-06 11:02 ` Marek Szyprowski
2023-03-06 17:24 ` Jagan Teki
2023-03-06 17:24 ` Jagan Teki
2023-03-06 22:41 ` Marek Szyprowski
2023-03-06 22:41 ` Marek Szyprowski
2023-03-07 7:55 ` Jagan Teki
2023-03-07 7:55 ` Jagan Teki
2023-03-07 9:22 ` Jagan Teki
2023-03-07 9:22 ` Jagan Teki
2023-03-07 10:44 ` Marek Szyprowski
2023-03-07 10:44 ` Marek Szyprowski
2023-03-06 5:24 ` 대인기/Tizen Platform Lab(SR)/삼성전자
2023-03-06 5:24 ` 대인기/Tizen Platform Lab(SR)/삼성전자
2023-03-06 8:48 ` Jagan Teki
2023-03-06 8:48 ` Jagan Teki
2023-03-14 0:31 ` Fabio Estevam
2023-03-14 0:31 ` Fabio Estevam
2023-03-14 0:51 ` Inki Dae
2023-03-23 15:34 ` Fabio Estevam
2023-03-23 15:34 ` Fabio Estevam
2023-03-27 14:08 ` Neil Armstrong
2023-03-27 14:08 ` Neil Armstrong
2023-03-28 0:03 ` Inki Dae
2023-03-28 7:53 ` Neil Armstrong
2023-03-28 7:53 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1686f1fd-a2db-dc82-a2a7-740a68c09938@denx.de \
--to=marex@denx.de \
--cc=aford173@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=frieder.schrempf@kontron.de \
--cc=inki.dae@samsung.com \
--cc=jagan@amarulasolutions.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=matteo.lisi@engicam.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=sw0312.kim@samsung.com \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.