* [PATCH] dmaengine: owl: fix register access functions
@ 2024-03-22 13:21 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2024-03-22 13:21 UTC (permalink / raw)
To: Vinod Koul, Andreas Färber, Manivannan Sadhasivam,
Nathan Chancellor
Cc: Arnd Bergmann, Nick Desaulniers, Bill Wendling, Justin Stitt,
Uwe Kleine-König, Randy Dunlap, Rob Herring, Zhang Jianhua,
dmaengine, linux-arm-kernel, linux-actions, linux-kernel, llvm
From: Arnd Bergmann <arnd@arndb.de>
When building with 'make W=1', clang notices that the computed register
values are never actually written back but instead the wrong variable
is set:
drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
244 | u32 regval;
| ^
drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
268 | u32 regval;
| ^
Change these to what was most likely intended.
Fixes: 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/dma/owl-dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c
index 4e76c4ec2d39..e001f4f7aa64 100644
--- a/drivers/dma/owl-dma.c
+++ b/drivers/dma/owl-dma.c
@@ -250,7 +250,7 @@ static void pchan_update(struct owl_dma_pchan *pchan, u32 reg,
else
regval &= ~val;
- writel(val, pchan->base + reg);
+ writel(regval, pchan->base + reg);
}
static void pchan_writel(struct owl_dma_pchan *pchan, u32 reg, u32 data)
@@ -274,7 +274,7 @@ static void dma_update(struct owl_dma *od, u32 reg, u32 val, bool state)
else
regval &= ~val;
- writel(val, od->base + reg);
+ writel(regval, od->base + reg);
}
static void dma_writel(struct owl_dma *od, u32 reg, u32 data)
--
2.39.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] dmaengine: owl: fix register access functions
@ 2024-03-22 13:21 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2024-03-22 13:21 UTC (permalink / raw)
To: Vinod Koul, Andreas Färber, Manivannan Sadhasivam,
Nathan Chancellor
Cc: Arnd Bergmann, Nick Desaulniers, Bill Wendling, Justin Stitt,
Uwe Kleine-König, Randy Dunlap, Rob Herring, Zhang Jianhua,
dmaengine, linux-arm-kernel, linux-actions, linux-kernel, llvm
From: Arnd Bergmann <arnd@arndb.de>
When building with 'make W=1', clang notices that the computed register
values are never actually written back but instead the wrong variable
is set:
drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
244 | u32 regval;
| ^
drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
268 | u32 regval;
| ^
Change these to what was most likely intended.
Fixes: 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/dma/owl-dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c
index 4e76c4ec2d39..e001f4f7aa64 100644
--- a/drivers/dma/owl-dma.c
+++ b/drivers/dma/owl-dma.c
@@ -250,7 +250,7 @@ static void pchan_update(struct owl_dma_pchan *pchan, u32 reg,
else
regval &= ~val;
- writel(val, pchan->base + reg);
+ writel(regval, pchan->base + reg);
}
static void pchan_writel(struct owl_dma_pchan *pchan, u32 reg, u32 data)
@@ -274,7 +274,7 @@ static void dma_update(struct owl_dma *od, u32 reg, u32 val, bool state)
else
regval &= ~val;
- writel(val, od->base + reg);
+ writel(regval, od->base + reg);
}
static void dma_writel(struct owl_dma *od, u32 reg, u32 data)
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] dmaengine: owl: fix register access functions
2024-03-22 13:21 ` Arnd Bergmann
@ 2024-03-22 13:36 ` Peter Korsgaard
-1 siblings, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2024-03-22 13:36 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Vinod Koul, Andreas Färber, Manivannan Sadhasivam,
Nathan Chancellor, Arnd Bergmann, Nick Desaulniers,
Bill Wendling, Justin Stitt, Uwe Kleine-König, Randy Dunlap,
Rob Herring, Zhang Jianhua, dmaengine, linux-arm-kernel,
linux-actions, linux-kernel, llvm
>>>>> "Arnd" == Arnd Bergmann <arnd@kernel.org> writes:
> From: Arnd Bergmann <arnd@arndb.de>
> When building with 'make W=1', clang notices that the computed register
> values are never actually written back but instead the wrong variable
> is set:
> drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
> 244 | u32 regval;
> | ^
> drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
> 268 | u32 regval;
> | ^
> Change these to what was most likely intended.
> Fixes: 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Good catch!
Reviewed-by: Peter Korsgaard <peter@korsgaard.com>
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dmaengine: owl: fix register access functions
@ 2024-03-22 13:36 ` Peter Korsgaard
0 siblings, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2024-03-22 13:36 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Vinod Koul, Andreas Färber, Manivannan Sadhasivam,
Nathan Chancellor, Arnd Bergmann, Nick Desaulniers,
Bill Wendling, Justin Stitt, Uwe Kleine-König, Randy Dunlap,
Rob Herring, Zhang Jianhua, dmaengine, linux-arm-kernel,
linux-actions, linux-kernel, llvm
>>>>> "Arnd" == Arnd Bergmann <arnd@kernel.org> writes:
> From: Arnd Bergmann <arnd@arndb.de>
> When building with 'make W=1', clang notices that the computed register
> values are never actually written back but instead the wrong variable
> is set:
> drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
> 244 | u32 regval;
> | ^
> drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
> 268 | u32 regval;
> | ^
> Change these to what was most likely intended.
> Fixes: 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Good catch!
Reviewed-by: Peter Korsgaard <peter@korsgaard.com>
--
Bye, Peter Korsgaard
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dmaengine: owl: fix register access functions
2024-03-22 13:21 ` Arnd Bergmann
@ 2024-03-22 14:32 ` Manivannan Sadhasivam
-1 siblings, 0 replies; 8+ messages in thread
From: Manivannan Sadhasivam @ 2024-03-22 14:32 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Vinod Koul, Andreas Färber, Nathan Chancellor,
Arnd Bergmann, Nick Desaulniers, Bill Wendling, Justin Stitt,
Uwe Kleine-König, Randy Dunlap, Rob Herring, Zhang Jianhua,
dmaengine, linux-arm-kernel, linux-actions, linux-kernel, llvm
On Fri, Mar 22, 2024 at 02:21:07PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When building with 'make W=1', clang notices that the computed register
> values are never actually written back but instead the wrong variable
> is set:
>
> drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
> 244 | u32 regval;
> | ^
> drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
> 268 | u32 regval;
> | ^
>
> Change these to what was most likely intended.
>
Wow... Thanks for spotting. Well thanks to Clang also ;)
> Fixes: 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: stable@vger.kernel.org # 4.19
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/dma/owl-dma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c
> index 4e76c4ec2d39..e001f4f7aa64 100644
> --- a/drivers/dma/owl-dma.c
> +++ b/drivers/dma/owl-dma.c
> @@ -250,7 +250,7 @@ static void pchan_update(struct owl_dma_pchan *pchan, u32 reg,
> else
> regval &= ~val;
>
> - writel(val, pchan->base + reg);
> + writel(regval, pchan->base + reg);
> }
>
> static void pchan_writel(struct owl_dma_pchan *pchan, u32 reg, u32 data)
> @@ -274,7 +274,7 @@ static void dma_update(struct owl_dma *od, u32 reg, u32 val, bool state)
> else
> regval &= ~val;
>
> - writel(val, od->base + reg);
> + writel(regval, od->base + reg);
> }
>
> static void dma_writel(struct owl_dma *od, u32 reg, u32 data)
> --
> 2.39.2
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dmaengine: owl: fix register access functions
@ 2024-03-22 14:32 ` Manivannan Sadhasivam
0 siblings, 0 replies; 8+ messages in thread
From: Manivannan Sadhasivam @ 2024-03-22 14:32 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Vinod Koul, Andreas Färber, Nathan Chancellor,
Arnd Bergmann, Nick Desaulniers, Bill Wendling, Justin Stitt,
Uwe Kleine-König, Randy Dunlap, Rob Herring, Zhang Jianhua,
dmaengine, linux-arm-kernel, linux-actions, linux-kernel, llvm
On Fri, Mar 22, 2024 at 02:21:07PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When building with 'make W=1', clang notices that the computed register
> values are never actually written back but instead the wrong variable
> is set:
>
> drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
> 244 | u32 regval;
> | ^
> drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
> 268 | u32 regval;
> | ^
>
> Change these to what was most likely intended.
>
Wow... Thanks for spotting. Well thanks to Clang also ;)
> Fixes: 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: stable@vger.kernel.org # 4.19
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/dma/owl-dma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c
> index 4e76c4ec2d39..e001f4f7aa64 100644
> --- a/drivers/dma/owl-dma.c
> +++ b/drivers/dma/owl-dma.c
> @@ -250,7 +250,7 @@ static void pchan_update(struct owl_dma_pchan *pchan, u32 reg,
> else
> regval &= ~val;
>
> - writel(val, pchan->base + reg);
> + writel(regval, pchan->base + reg);
> }
>
> static void pchan_writel(struct owl_dma_pchan *pchan, u32 reg, u32 data)
> @@ -274,7 +274,7 @@ static void dma_update(struct owl_dma *od, u32 reg, u32 val, bool state)
> else
> regval &= ~val;
>
> - writel(val, od->base + reg);
> + writel(regval, od->base + reg);
> }
>
> static void dma_writel(struct owl_dma *od, u32 reg, u32 data)
> --
> 2.39.2
>
--
மணிவண்ணன் சதாசிவம்
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dmaengine: owl: fix register access functions
2024-03-22 13:21 ` Arnd Bergmann
@ 2024-03-28 7:39 ` Vinod Koul
-1 siblings, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2024-03-28 7:39 UTC (permalink / raw)
To: Andreas Färber, Manivannan Sadhasivam, Nathan Chancellor,
Arnd Bergmann
Cc: Arnd Bergmann, Nick Desaulniers, Bill Wendling, Justin Stitt,
Uwe Kleine-König, Randy Dunlap, Rob Herring, Zhang Jianhua,
dmaengine, linux-arm-kernel, linux-actions, linux-kernel, llvm
On Fri, 22 Mar 2024 14:21:07 +0100, Arnd Bergmann wrote:
> When building with 'make W=1', clang notices that the computed register
> values are never actually written back but instead the wrong variable
> is set:
>
> drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
> 244 | u32 regval;
> | ^
> drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
> 268 | u32 regval;
> | ^
>
> [...]
Applied, thanks!
[1/1] dmaengine: owl: fix register access functions
commit: 43c633ef93a5d293c96ebcedb40130df13128428
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dmaengine: owl: fix register access functions
@ 2024-03-28 7:39 ` Vinod Koul
0 siblings, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2024-03-28 7:39 UTC (permalink / raw)
To: Andreas Färber, Manivannan Sadhasivam, Nathan Chancellor,
Arnd Bergmann
Cc: Arnd Bergmann, Nick Desaulniers, Bill Wendling, Justin Stitt,
Uwe Kleine-König, Randy Dunlap, Rob Herring, Zhang Jianhua,
dmaengine, linux-arm-kernel, linux-actions, linux-kernel, llvm
On Fri, 22 Mar 2024 14:21:07 +0100, Arnd Bergmann wrote:
> When building with 'make W=1', clang notices that the computed register
> values are never actually written back but instead the wrong variable
> is set:
>
> drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
> 244 | u32 regval;
> | ^
> drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
> 268 | u32 regval;
> | ^
>
> [...]
Applied, thanks!
[1/1] dmaengine: owl: fix register access functions
commit: 43c633ef93a5d293c96ebcedb40130df13128428
Best regards,
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-03-28 7:40 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-22 13:21 [PATCH] dmaengine: owl: fix register access functions Arnd Bergmann
2024-03-22 13:21 ` Arnd Bergmann
2024-03-22 13:36 ` Peter Korsgaard
2024-03-22 13:36 ` Peter Korsgaard
2024-03-22 14:32 ` Manivannan Sadhasivam
2024-03-22 14:32 ` Manivannan Sadhasivam
2024-03-28 7:39 ` Vinod Koul
2024-03-28 7:39 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.