From: Sricharan R <sricharan@codeaurora.org> To: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: robh+dt@kernel.org, Stephen Boyd <sboyd@kernel.org>, linus.walleij@linaro.org, agross@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/6] pinctrl: qcom: Add ipq6018 pinctrl driver Date: Mon, 10 Jun 2019 16:30:59 +0530 [thread overview] Message-ID: <1766bee3-e4da-7c7c-9881-4a58885640dc@codeaurora.org> (raw) In-Reply-To: <20190608032613.GC24059@builder> Hi Bjorn, On 6/8/2019 8:56 AM, Bjorn Andersson wrote: > On Wed 05 Jun 10:15 PDT 2019, Sricharan R wrote: > >> Add initial pinctrl driver to support pin configuration with >> pinctrl framework for ipq6018. >> >> Signed-off-by: Sricharan R <sricharan@codeaurora.org> >> Signed-off-by: Rajkumar Ayyasamy <arajkuma@codeaurora.org> >> Signed-off-by: speriaka <speriaka@codeaurora.org> > Thanks for the review !! > These should start with the author, then followed by each person that > handled the patch on its way to the list - so your name should probably > be last. If you have more than one author add Co-developed-by, in > addition to the Signed-off-by. > > And please spell our speriaka's first and last name. > ok, will fix it. > [..] >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt > [..] >> +- #gpio-cells: >> + Usage: required >> + Value type: <u32> >> + Definition: must be 2. Specifying the pin number and flags, as defined >> + in <dt-bindings/gpio/gpio.h> > > You're missing the required "gpio-ranges" property. > ok, will add. >> + > [..] >> +- function: >> + Usage: required >> + Value type: <string> >> + Definition: Specify the alternative function to be configured for the >> + specified pins. Functions are only valid for gpio pins. >> + Valid values are: >> + adsp_ext, alsp_int, atest_bbrx0, atest_bbrx1, atest_char, atest_char0, > > Please indent these. > ok. > [..] > > The rest should be in a separate patch from the binding. > >> diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig > [..] >> +enum ipq6018_functions { > [..] >> + msm_mux_NA, > > I like when these are sorted, and if you make the last entry msm_mux__ > the msm_pingroup array becomes easier to read. > ok. >> +}; > [..] >> +static const struct msm_function ipq6018_functions[] = { > [..] >> + FUNCTION(gcc_tlmm), > > As above, please sort these. > ok. >> +}; >> + >> +static const struct msm_pingroup ipq6018_groups[] = { >> + PINGROUP(0, qpic_pad, wci20, qdss_traceclk_b, NA, burn0, NA, NA, NA, >> + NA), > > Please ignore the 80-char and skip the line breaks. > ok. >> + PINGROUP(1, qpic_pad, mac12, qdss_tracectl_b, NA, burn1, NA, NA, NA, >> + NA), >> + PINGROUP(2, qpic_pad, wci20, qdss_tracedata_b, NA, NA, NA, NA, NA, NA), >> + PINGROUP(3, qpic_pad, mac01, qdss_tracedata_b, NA, NA, NA, NA, NA, NA), >> + PINGROUP(4, qpic_pad, mac01, qdss_tracedata_b, NA, NA, NA, NA, NA, NA), >> + PINGROUP(5, qpic_pad4, mac21, qdss_tracedata_b, NA, NA, NA, NA, NA, NA), > > Is there a reason to keep qpic_padN as separate functions from qpic_pad? > Hmm, the auto-gen scripts needs to be fixed. Will correct it. > [..] >> +static struct platform_driver ipq6018_pinctrl_driver = { >> + .driver = { >> + .name = "ipq6018-pinctrl", >> + .owner = THIS_MODULE, > > .owner is populated automagically by platform_driver_register, so please > omit this. > ok, missed it. will fix. Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: Sricharan R <sricharan@codeaurora.org> To: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: devicetree@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>, linux-arm-msm@vger.kernel.org, linus.walleij@linaro.org, agross@kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, robh+dt@kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/6] pinctrl: qcom: Add ipq6018 pinctrl driver Date: Mon, 10 Jun 2019 16:30:59 +0530 [thread overview] Message-ID: <1766bee3-e4da-7c7c-9881-4a58885640dc@codeaurora.org> (raw) In-Reply-To: <20190608032613.GC24059@builder> Hi Bjorn, On 6/8/2019 8:56 AM, Bjorn Andersson wrote: > On Wed 05 Jun 10:15 PDT 2019, Sricharan R wrote: > >> Add initial pinctrl driver to support pin configuration with >> pinctrl framework for ipq6018. >> >> Signed-off-by: Sricharan R <sricharan@codeaurora.org> >> Signed-off-by: Rajkumar Ayyasamy <arajkuma@codeaurora.org> >> Signed-off-by: speriaka <speriaka@codeaurora.org> > Thanks for the review !! > These should start with the author, then followed by each person that > handled the patch on its way to the list - so your name should probably > be last. If you have more than one author add Co-developed-by, in > addition to the Signed-off-by. > > And please spell our speriaka's first and last name. > ok, will fix it. > [..] >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt > [..] >> +- #gpio-cells: >> + Usage: required >> + Value type: <u32> >> + Definition: must be 2. Specifying the pin number and flags, as defined >> + in <dt-bindings/gpio/gpio.h> > > You're missing the required "gpio-ranges" property. > ok, will add. >> + > [..] >> +- function: >> + Usage: required >> + Value type: <string> >> + Definition: Specify the alternative function to be configured for the >> + specified pins. Functions are only valid for gpio pins. >> + Valid values are: >> + adsp_ext, alsp_int, atest_bbrx0, atest_bbrx1, atest_char, atest_char0, > > Please indent these. > ok. > [..] > > The rest should be in a separate patch from the binding. > >> diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig > [..] >> +enum ipq6018_functions { > [..] >> + msm_mux_NA, > > I like when these are sorted, and if you make the last entry msm_mux__ > the msm_pingroup array becomes easier to read. > ok. >> +}; > [..] >> +static const struct msm_function ipq6018_functions[] = { > [..] >> + FUNCTION(gcc_tlmm), > > As above, please sort these. > ok. >> +}; >> + >> +static const struct msm_pingroup ipq6018_groups[] = { >> + PINGROUP(0, qpic_pad, wci20, qdss_traceclk_b, NA, burn0, NA, NA, NA, >> + NA), > > Please ignore the 80-char and skip the line breaks. > ok. >> + PINGROUP(1, qpic_pad, mac12, qdss_tracectl_b, NA, burn1, NA, NA, NA, >> + NA), >> + PINGROUP(2, qpic_pad, wci20, qdss_tracedata_b, NA, NA, NA, NA, NA, NA), >> + PINGROUP(3, qpic_pad, mac01, qdss_tracedata_b, NA, NA, NA, NA, NA, NA), >> + PINGROUP(4, qpic_pad, mac01, qdss_tracedata_b, NA, NA, NA, NA, NA, NA), >> + PINGROUP(5, qpic_pad4, mac21, qdss_tracedata_b, NA, NA, NA, NA, NA, NA), > > Is there a reason to keep qpic_padN as separate functions from qpic_pad? > Hmm, the auto-gen scripts needs to be fixed. Will correct it. > [..] >> +static struct platform_driver ipq6018_pinctrl_driver = { >> + .driver = { >> + .name = "ipq6018-pinctrl", >> + .owner = THIS_MODULE, > > .owner is populated automagically by platform_driver_register, so please > omit this. > ok, missed it. will fix. Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-10 11:01 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-05 17:15 [PATCH 0/6] Add minimal boot support for IPQ6018 Sricharan R 2019-06-05 17:15 ` Sricharan R 2019-06-05 17:15 ` [PATCH 1/6] pinctrl: qcom: Add ipq6018 pinctrl driver Sricharan R 2019-06-05 17:15 ` Sricharan R 2019-06-08 3:26 ` Bjorn Andersson 2019-06-08 3:26 ` Bjorn Andersson 2019-06-08 3:26 ` Bjorn Andersson 2019-06-10 11:00 ` Sricharan R [this message] 2019-06-10 11:00 ` Sricharan R 2019-06-05 17:15 ` [PATCH 2/6] dt-bindings: qcom: Add ipq6018 bindings Sricharan R 2019-06-05 17:15 ` Sricharan R 2019-06-08 3:27 ` Bjorn Andersson 2019-06-08 3:27 ` Bjorn Andersson 2019-06-10 11:01 ` Sricharan R 2019-06-10 11:01 ` Sricharan R 2019-06-19 14:54 ` Rob Herring 2019-06-19 14:54 ` Rob Herring 2019-06-19 14:54 ` Rob Herring 2019-06-05 17:15 ` [PATCH 3/6] clk: qcom: Add DT bindings for ipq6018 gcc clock controller Sricharan R 2019-06-05 17:15 ` Sricharan R 2019-06-08 3:33 ` Bjorn Andersson 2019-06-08 3:33 ` Bjorn Andersson 2019-06-05 17:15 ` [PATCH 4/6] clk: qcom: Add ipq6018 Global Clock Controller support Sricharan R 2019-06-08 3:32 ` Bjorn Andersson 2019-06-08 3:32 ` Bjorn Andersson 2019-06-08 3:32 ` Bjorn Andersson 2019-06-10 11:47 ` Sricharan R 2019-06-10 11:47 ` Sricharan R 2019-06-10 16:58 ` Bjorn Andersson 2019-06-10 16:58 ` Bjorn Andersson 2019-06-05 17:16 ` [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support Sricharan R 2019-06-05 17:16 ` Sricharan R 2019-06-05 17:26 ` Marc Zyngier 2019-06-05 17:26 ` Marc Zyngier 2019-06-08 2:44 ` Sricharan R 2019-06-08 2:44 ` Sricharan R 2019-06-05 20:41 ` Christian Lamparter 2019-06-05 20:41 ` Christian Lamparter 2019-06-05 20:41 ` Christian Lamparter 2019-06-10 10:09 ` Sricharan R 2019-06-10 10:09 ` Sricharan R 2019-06-10 12:15 ` Christian Lamparter 2019-06-10 12:15 ` Christian Lamparter 2019-06-12 9:48 ` Sricharan R 2019-06-12 9:48 ` Sricharan R 2019-06-14 20:41 ` Christian Lamparter 2019-06-14 20:41 ` Christian Lamparter 2019-06-19 14:42 ` Sricharan R 2019-06-19 14:42 ` Sricharan R 2019-06-20 15:32 ` Christian Lamparter 2019-06-20 15:32 ` Christian Lamparter 2019-06-20 15:32 ` Christian Lamparter 2019-06-24 12:08 ` Sricharan R 2019-06-24 12:08 ` Sricharan R 2019-06-08 3:48 ` Bjorn Andersson 2019-06-08 3:48 ` Bjorn Andersson 2019-06-10 15:45 ` Sricharan R 2019-06-10 15:45 ` Sricharan R 2019-06-10 16:48 ` Stephen Boyd 2019-06-10 16:48 ` Stephen Boyd 2019-06-05 17:16 ` [PATCH 6/6] arm64: defconfig: Enable qcom ipq6018 clock and pinctrl Sricharan R 2019-06-05 17:16 ` Sricharan R 2019-06-08 3:32 ` Bjorn Andersson 2019-06-08 3:32 ` Bjorn Andersson 2019-06-05 17:26 ` [PATCH 0/6] Add minimal boot support for IPQ6018 Sricharan R 2019-06-05 17:26 ` Sricharan R 2019-06-07 23:08 ` Linus Walleij 2019-06-07 23:08 ` Linus Walleij 2019-06-05 17:28 Sricharan R 2019-06-05 17:28 ` [PATCH 1/6] pinctrl: qcom: Add ipq6018 pinctrl driver Sricharan R 2019-06-05 17:28 ` Sricharan R 2019-07-09 1:44 ` Rob Herring 2019-07-09 1:44 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1766bee3-e4da-7c7c-9881-4a58885640dc@codeaurora.org \ --to=sricharan@codeaurora.org \ --cc=agross@kernel.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-soc@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.