From: Stephen Boyd <sboyd@kernel.org> To: Bjorn Andersson <bjorn.andersson@linaro.org>, Sricharan R <sricharan@codeaurora.org> Cc: robh+dt@kernel.org, sboyd@codeaurora.org, linus.walleij@linaro.org, agross@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support Date: Mon, 10 Jun 2019 09:48:04 -0700 [thread overview] Message-ID: <20190610164805.18D15206C3@mail.kernel.org> (raw) In-Reply-To: <048a25c0-3a2c-3906-84d4-5eb67f3ce2ef@codeaurora.org> Quoting Sricharan R (2019-06-10 08:45:22) > On 6/8/2019 9:18 AM, Bjorn Andersson wrote: > > On Wed 05 Jun 10:16 PDT 2019, Sricharan R wrote: > >> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > >> new file mode 100644 > >> index 0000000..79cccdd > >> --- /dev/null > >> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > >> + compatible = "fixed-clock"; > >> + clock-frequency = <32000>; > >> + #clock-cells = <0>; > >> + }; > >> + > >> + xo: xo { > >> + compatible = "fixed-clock"; > >> + clock-frequency = <24000000>; > >> + #clock-cells = <0>; > >> + }; > >> + > >> + bias_pll_cc_clk { > > > > Please give this a label and reference it from the node that uses it > > (regardless of the implementation matching by clock name). > > > ok, in that case, so might have to remove these for now, till we add > the corresponding users. Yes, please remove them. They don't look like board clks, instead they're SoC level details that need to be created by some clk driver like GCC. > > >> + compatible = "fixed-clock"; > >> + clock-frequency = <300000000>; > >> + #clock-cells = <0>; > >> + }; > >> + > >> + bias_pll_nss_noc_clk { > >> + compatible = "fixed-clock"; > >> + clock-frequency = <416500000>; > >> + #clock-cells = <0>; > >> + }; > >> +
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org> To: Bjorn Andersson <bjorn.andersson@linaro.org>, Sricharan R <sricharan@codeaurora.org> Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linus.walleij@linaro.org, sboyd@codeaurora.org, agross@kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, robh+dt@kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support Date: Mon, 10 Jun 2019 09:48:04 -0700 [thread overview] Message-ID: <20190610164805.18D15206C3@mail.kernel.org> (raw) In-Reply-To: <048a25c0-3a2c-3906-84d4-5eb67f3ce2ef@codeaurora.org> Quoting Sricharan R (2019-06-10 08:45:22) > On 6/8/2019 9:18 AM, Bjorn Andersson wrote: > > On Wed 05 Jun 10:16 PDT 2019, Sricharan R wrote: > >> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > >> new file mode 100644 > >> index 0000000..79cccdd > >> --- /dev/null > >> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > >> + compatible = "fixed-clock"; > >> + clock-frequency = <32000>; > >> + #clock-cells = <0>; > >> + }; > >> + > >> + xo: xo { > >> + compatible = "fixed-clock"; > >> + clock-frequency = <24000000>; > >> + #clock-cells = <0>; > >> + }; > >> + > >> + bias_pll_cc_clk { > > > > Please give this a label and reference it from the node that uses it > > (regardless of the implementation matching by clock name). > > > ok, in that case, so might have to remove these for now, till we add > the corresponding users. Yes, please remove them. They don't look like board clks, instead they're SoC level details that need to be created by some clk driver like GCC. > > >> + compatible = "fixed-clock"; > >> + clock-frequency = <300000000>; > >> + #clock-cells = <0>; > >> + }; > >> + > >> + bias_pll_nss_noc_clk { > >> + compatible = "fixed-clock"; > >> + clock-frequency = <416500000>; > >> + #clock-cells = <0>; > >> + }; > >> + _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-10 16:48 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-05 17:15 [PATCH 0/6] Add minimal boot support for IPQ6018 Sricharan R 2019-06-05 17:15 ` Sricharan R 2019-06-05 17:15 ` [PATCH 1/6] pinctrl: qcom: Add ipq6018 pinctrl driver Sricharan R 2019-06-05 17:15 ` Sricharan R 2019-06-08 3:26 ` Bjorn Andersson 2019-06-08 3:26 ` Bjorn Andersson 2019-06-08 3:26 ` Bjorn Andersson 2019-06-10 11:00 ` Sricharan R 2019-06-10 11:00 ` Sricharan R 2019-06-05 17:15 ` [PATCH 2/6] dt-bindings: qcom: Add ipq6018 bindings Sricharan R 2019-06-05 17:15 ` Sricharan R 2019-06-08 3:27 ` Bjorn Andersson 2019-06-08 3:27 ` Bjorn Andersson 2019-06-10 11:01 ` Sricharan R 2019-06-10 11:01 ` Sricharan R 2019-06-19 14:54 ` Rob Herring 2019-06-19 14:54 ` Rob Herring 2019-06-19 14:54 ` Rob Herring 2019-06-05 17:15 ` [PATCH 3/6] clk: qcom: Add DT bindings for ipq6018 gcc clock controller Sricharan R 2019-06-05 17:15 ` Sricharan R 2019-06-08 3:33 ` Bjorn Andersson 2019-06-08 3:33 ` Bjorn Andersson 2019-06-05 17:15 ` [PATCH 4/6] clk: qcom: Add ipq6018 Global Clock Controller support Sricharan R 2019-06-08 3:32 ` Bjorn Andersson 2019-06-08 3:32 ` Bjorn Andersson 2019-06-08 3:32 ` Bjorn Andersson 2019-06-10 11:47 ` Sricharan R 2019-06-10 11:47 ` Sricharan R 2019-06-10 16:58 ` Bjorn Andersson 2019-06-10 16:58 ` Bjorn Andersson 2019-06-05 17:16 ` [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support Sricharan R 2019-06-05 17:16 ` Sricharan R 2019-06-05 17:26 ` Marc Zyngier 2019-06-05 17:26 ` Marc Zyngier 2019-06-08 2:44 ` Sricharan R 2019-06-08 2:44 ` Sricharan R 2019-06-05 20:41 ` Christian Lamparter 2019-06-05 20:41 ` Christian Lamparter 2019-06-05 20:41 ` Christian Lamparter 2019-06-10 10:09 ` Sricharan R 2019-06-10 10:09 ` Sricharan R 2019-06-10 12:15 ` Christian Lamparter 2019-06-10 12:15 ` Christian Lamparter 2019-06-12 9:48 ` Sricharan R 2019-06-12 9:48 ` Sricharan R 2019-06-14 20:41 ` Christian Lamparter 2019-06-14 20:41 ` Christian Lamparter 2019-06-19 14:42 ` Sricharan R 2019-06-19 14:42 ` Sricharan R 2019-06-20 15:32 ` Christian Lamparter 2019-06-20 15:32 ` Christian Lamparter 2019-06-20 15:32 ` Christian Lamparter 2019-06-24 12:08 ` Sricharan R 2019-06-24 12:08 ` Sricharan R 2019-06-08 3:48 ` Bjorn Andersson 2019-06-08 3:48 ` Bjorn Andersson 2019-06-10 15:45 ` Sricharan R 2019-06-10 15:45 ` Sricharan R 2019-06-10 16:48 ` Stephen Boyd [this message] 2019-06-10 16:48 ` Stephen Boyd 2019-06-05 17:16 ` [PATCH 6/6] arm64: defconfig: Enable qcom ipq6018 clock and pinctrl Sricharan R 2019-06-05 17:16 ` Sricharan R 2019-06-08 3:32 ` Bjorn Andersson 2019-06-08 3:32 ` Bjorn Andersson 2019-06-05 17:26 ` [PATCH 0/6] Add minimal boot support for IPQ6018 Sricharan R 2019-06-05 17:26 ` Sricharan R 2019-06-07 23:08 ` Linus Walleij 2019-06-07 23:08 ` Linus Walleij 2019-06-05 17:28 Sricharan R 2019-06-05 17:28 ` [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support Sricharan R 2019-06-05 17:28 ` Sricharan R 2019-06-05 17:34 ` Sudeep Holla 2019-06-05 17:34 ` Sudeep Holla 2019-06-05 17:34 ` Sudeep Holla 2019-06-08 2:44 ` Sricharan R 2019-06-08 2:44 ` Sricharan R
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190610164805.18D15206C3@mail.kernel.org \ --to=sboyd@kernel.org \ --cc=agross@kernel.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-soc@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=sboyd@codeaurora.org \ --cc=sricharan@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.