All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org,
	Magnus Damm <magnus.damm@gmail.com>,
	Simon Horman <horms@verge.net.au>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
	Yoshihiro Kaneko <ykaneko0929@gmail.com>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH 5/9] i2c: rcar: init new messages in irq
Date: Thu, 22 Oct 2015 11:12:03 +0000	[thread overview]
Message-ID: <1917001.aD8sIkvx7f@avalon> (raw)
In-Reply-To: <20151022110505.GB1572@katana>

Hi Wolfram,

On Thursday 22 October 2015 13:05:05 Wolfram Sang wrote:
> On Thu, Oct 22, 2015 at 02:10:52AM +0300, Laurent Pinchart wrote:
> > On Thursday 03 September 2015 22:20:09 Wolfram Sang wrote:
> > > From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > 
> > > Setting up new messages was done in process context while handling a
> > > message was in interrupt context. Because of the HW design, this IP core
> > > is sensitive to timing, so the context switches were too expensive. Move
> > > this setup to interrupt context as well.
> > > 
> > > In my test setup, this fixed the occasional 'data byte sent twice' issue
> > > which a number of people have seen. It also fixes to send REP_START
> > > after a read message which was wrongly send as a STOP + START sequence
> > > before.
> > 
> > I'm afraid this patch has been found by git bisect to break HDMI on
> > Koelsch
> > 
> > :-(
> > 
> > The regmap_read(adv7511->regmap, ADV7511_REG_CHIP_REVISION, &val) call in
> > drivers/gpu/drm/i2c/adv7511.c returns -ENXIO.
> > 
> > Reverting the patch on top of Geert's current drivers master branch fixes
> > the problem.
> 
> But HDMI worked on Koelsch in Dublin??

I know :-)

Do you have a Koelsch board now ? Could you try 
b9653e9c000dc2ebd9c8712442c659ccd1586e22 from Geert's drivers tree ? On my 
board the adv7511 fails to probe completely due to the regmap_read() failure.

-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org,
	Magnus Damm <magnus.damm@gmail.com>,
	Simon Horman <horms@verge.net.au>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
	Yoshihiro Kaneko <ykaneko0929@gmail.com>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH 5/9] i2c: rcar: init new messages in irq
Date: Thu, 22 Oct 2015 14:12:03 +0300	[thread overview]
Message-ID: <1917001.aD8sIkvx7f@avalon> (raw)
In-Reply-To: <20151022110505.GB1572@katana>

Hi Wolfram,

On Thursday 22 October 2015 13:05:05 Wolfram Sang wrote:
> On Thu, Oct 22, 2015 at 02:10:52AM +0300, Laurent Pinchart wrote:
> > On Thursday 03 September 2015 22:20:09 Wolfram Sang wrote:
> > > From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > 
> > > Setting up new messages was done in process context while handling a
> > > message was in interrupt context. Because of the HW design, this IP core
> > > is sensitive to timing, so the context switches were too expensive. Move
> > > this setup to interrupt context as well.
> > > 
> > > In my test setup, this fixed the occasional 'data byte sent twice' issue
> > > which a number of people have seen. It also fixes to send REP_START
> > > after a read message which was wrongly send as a STOP + START sequence
> > > before.
> > 
> > I'm afraid this patch has been found by git bisect to break HDMI on
> > Koelsch
> > 
> > :-(
> > 
> > The regmap_read(adv7511->regmap, ADV7511_REG_CHIP_REVISION, &val) call in
> > drivers/gpu/drm/i2c/adv7511.c returns -ENXIO.
> > 
> > Reverting the patch on top of Geert's current drivers master branch fixes
> > the problem.
> 
> But HDMI worked on Koelsch in Dublin??

I know :-)

Do you have a Koelsch board now ? Could you try 
b9653e9c000dc2ebd9c8712442c659ccd1586e22 from Geert's drivers tree ? On my 
board the adv7511 fails to probe completely due to the regmap_read() failure.

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2015-10-22 11:12 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-03 20:20 [PATCH 0/9] i2c: rcar: tackle race conditions in the driver Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 1/9] i2c: rcar: rework hw init Wolfram Sang
2015-09-03 20:20   ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 2/9] i2c: rcar: remove unused IOERROR state Wolfram Sang
2015-09-03 20:20   ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 6/9] i2c: rcar: don't issue stop when HW does it automatically Wolfram Sang
2015-09-03 20:20   ` Wolfram Sang
     [not found] ` <1441311613-2681-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-09-03 20:20   ` [PATCH 3/9] i2c: rcar: remove spinlock Wolfram Sang
2015-09-03 20:20     ` Wolfram Sang
2015-09-03 20:20   ` [PATCH 4/9] i2c: rcar: refactor setup of a msg Wolfram Sang
2015-09-03 20:20     ` Wolfram Sang
2015-09-03 20:20   ` [PATCH 5/9] i2c: rcar: init new messages in irq Wolfram Sang
2015-09-03 20:20     ` Wolfram Sang
2015-10-21 23:10     ` Laurent Pinchart
2015-10-21 23:10       ` Laurent Pinchart
2015-10-22 11:05       ` Wolfram Sang
2015-10-22 11:05         ` Wolfram Sang
2015-10-22 11:12         ` Laurent Pinchart [this message]
2015-10-22 11:12           ` Laurent Pinchart
2015-10-23  8:06           ` Wolfram Sang
2015-10-23  8:06             ` Wolfram Sang
2015-10-23  8:57             ` Laurent Pinchart
2015-10-23  9:45               ` Wolfram Sang
2015-10-23  9:45                 ` Wolfram Sang
2015-10-23 10:28                 ` Laurent Pinchart
2015-10-23 10:28                   ` Laurent Pinchart
2015-10-23 12:14                   ` Wolfram Sang
2015-10-23 12:14                     ` Wolfram Sang
2015-10-23 13:14                     ` Laurent Pinchart
2015-10-23 13:14                       ` Laurent Pinchart
2015-10-25 15:53                       ` Wolfram Sang
2015-10-25 15:53                         ` Wolfram Sang
2015-10-29 19:23                       ` Wolfram Sang
2015-10-29 19:23                         ` Wolfram Sang
2015-10-23 10:04             ` Geert Uytterhoeven
2015-10-23 10:04               ` Geert Uytterhoeven
2015-10-23 10:07               ` Wolfram Sang
2015-10-23 10:07                 ` Wolfram Sang
2015-09-03 20:20   ` [PATCH 7/9] i2c: rcar: check master irqs before slave irqs Wolfram Sang
2015-09-03 20:20     ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 8/9] i2c: rcar: revoke START request early Wolfram Sang
2015-09-03 20:20   ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 9/9] i2c: rcar: clean up after refactoring Wolfram Sang
2015-09-03 20:20   ` Wolfram Sang
2015-09-03 20:35 ` [PATCH 0/9] i2c: rcar: tackle race conditions in the driver Laurent Pinchart
2015-09-03 20:35   ` Laurent Pinchart
2015-09-03 20:40   ` Wolfram Sang
2015-09-03 20:40     ` Wolfram Sang
2015-09-03 20:47     ` Laurent Pinchart
2015-09-03 20:47       ` Laurent Pinchart
2015-09-03 20:55       ` Wolfram Sang
2015-09-03 20:55         ` Wolfram Sang
2015-09-04  4:33     ` Magnus Damm
2015-09-04  4:33       ` Magnus Damm
2015-09-05  7:31       ` Wolfram Sang
2015-09-05  7:31         ` Wolfram Sang
2015-09-07 16:04         ` Magnus Damm
2015-09-07 16:04           ` Magnus Damm
     [not found]           ` <CANqRtoRs=f=07B=HSLCVg5G4rnhxj6Heod+spYwxHiKFLZqFWg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-08 10:53             ` Wolfram Sang
2015-09-08 10:53               ` Wolfram Sang
2015-09-09  5:08               ` Magnus Damm
2015-09-09  5:08                 ` Magnus Damm
2015-09-09  8:54                 ` Wolfram Sang
2015-09-09  8:54                   ` Wolfram Sang
2015-10-09 21:34 ` Wolfram Sang
2015-10-09 21:34   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1917001.aD8sIkvx7f@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=kuninori.morimoto.gx@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=wsa@the-dreams.de \
    --cc=ykaneko0929@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.