From: Magnus Damm <magnus.damm@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Linux-I2C <linux-i2c@vger.kernel.org>,
SH-Linux <linux-sh@vger.kernel.org>,
Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
Yoshihiro Kaneko <ykaneko0929@gmail.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH 0/9] i2c: rcar: tackle race conditions in the driver
Date: Fri, 04 Sep 2015 04:33:39 +0000 [thread overview]
Message-ID: <CANqRtoRo7jemt52=mcmu=mf5dGsqwWKWA5aBYd7L=vFas6d+NQ@mail.gmail.com> (raw)
In-Reply-To: <20150903204000.GB1574@katana>
Hi Wolfram,
On Fri, Sep 4, 2015 at 5:40 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
>
>> > So I refactored the driver to setup new messages in interrupt context, too.
>> > This avoids the race for b) because we are now setting up the new message
>> > before we release the i2c bus clock (before we released the clock and set up
>> > the message in process context).
>>
>> Could this fix the HDMI EDID read issue on Koelsch ?
>
> I surely hope so. I can't test because I don't have Koelsch.
FYI, I have enabled Koelsch remote access on port 8001 if you want to
give it a shot!
Cheers,
/ magnus
WARNING: multiple messages have this Message-ID (diff)
From: Magnus Damm <magnus.damm@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Linux-I2C <linux-i2c@vger.kernel.org>,
SH-Linux <linux-sh@vger.kernel.org>,
Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
Yoshihiro Kaneko <ykaneko0929@gmail.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH 0/9] i2c: rcar: tackle race conditions in the driver
Date: Fri, 4 Sep 2015 13:33:39 +0900 [thread overview]
Message-ID: <CANqRtoRo7jemt52=mcmu=mf5dGsqwWKWA5aBYd7L=vFas6d+NQ@mail.gmail.com> (raw)
In-Reply-To: <20150903204000.GB1574@katana>
Hi Wolfram,
On Fri, Sep 4, 2015 at 5:40 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
>
>> > So I refactored the driver to setup new messages in interrupt context, too.
>> > This avoids the race for b) because we are now setting up the new message
>> > before we release the i2c bus clock (before we released the clock and set up
>> > the message in process context).
>>
>> Could this fix the HDMI EDID read issue on Koelsch ?
>
> I surely hope so. I can't test because I don't have Koelsch.
FYI, I have enabled Koelsch remote access on port 8001 if you want to
give it a shot!
Cheers,
/ magnus
next prev parent reply other threads:[~2015-09-04 4:33 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 20:20 [PATCH 0/9] i2c: rcar: tackle race conditions in the driver Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 1/9] i2c: rcar: rework hw init Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 2/9] i2c: rcar: remove unused IOERROR state Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 6/9] i2c: rcar: don't issue stop when HW does it automatically Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
[not found] ` <1441311613-2681-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-09-03 20:20 ` [PATCH 3/9] i2c: rcar: remove spinlock Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 4/9] i2c: rcar: refactor setup of a msg Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 5/9] i2c: rcar: init new messages in irq Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-10-21 23:10 ` Laurent Pinchart
2015-10-21 23:10 ` Laurent Pinchart
2015-10-22 11:05 ` Wolfram Sang
2015-10-22 11:05 ` Wolfram Sang
2015-10-22 11:12 ` Laurent Pinchart
2015-10-22 11:12 ` Laurent Pinchart
2015-10-23 8:06 ` Wolfram Sang
2015-10-23 8:06 ` Wolfram Sang
2015-10-23 8:57 ` Laurent Pinchart
2015-10-23 9:45 ` Wolfram Sang
2015-10-23 9:45 ` Wolfram Sang
2015-10-23 10:28 ` Laurent Pinchart
2015-10-23 10:28 ` Laurent Pinchart
2015-10-23 12:14 ` Wolfram Sang
2015-10-23 12:14 ` Wolfram Sang
2015-10-23 13:14 ` Laurent Pinchart
2015-10-23 13:14 ` Laurent Pinchart
2015-10-25 15:53 ` Wolfram Sang
2015-10-25 15:53 ` Wolfram Sang
2015-10-29 19:23 ` Wolfram Sang
2015-10-29 19:23 ` Wolfram Sang
2015-10-23 10:04 ` Geert Uytterhoeven
2015-10-23 10:04 ` Geert Uytterhoeven
2015-10-23 10:07 ` Wolfram Sang
2015-10-23 10:07 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 7/9] i2c: rcar: check master irqs before slave irqs Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 8/9] i2c: rcar: revoke START request early Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 9/9] i2c: rcar: clean up after refactoring Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:35 ` [PATCH 0/9] i2c: rcar: tackle race conditions in the driver Laurent Pinchart
2015-09-03 20:35 ` Laurent Pinchart
2015-09-03 20:40 ` Wolfram Sang
2015-09-03 20:40 ` Wolfram Sang
2015-09-03 20:47 ` Laurent Pinchart
2015-09-03 20:47 ` Laurent Pinchart
2015-09-03 20:55 ` Wolfram Sang
2015-09-03 20:55 ` Wolfram Sang
2015-09-04 4:33 ` Magnus Damm [this message]
2015-09-04 4:33 ` Magnus Damm
2015-09-05 7:31 ` Wolfram Sang
2015-09-05 7:31 ` Wolfram Sang
2015-09-07 16:04 ` Magnus Damm
2015-09-07 16:04 ` Magnus Damm
[not found] ` <CANqRtoRs=f=07B=HSLCVg5G4rnhxj6Heod+spYwxHiKFLZqFWg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-08 10:53 ` Wolfram Sang
2015-09-08 10:53 ` Wolfram Sang
2015-09-09 5:08 ` Magnus Damm
2015-09-09 5:08 ` Magnus Damm
2015-09-09 8:54 ` Wolfram Sang
2015-09-09 8:54 ` Wolfram Sang
2015-10-09 21:34 ` Wolfram Sang
2015-10-09 21:34 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANqRtoRo7jemt52=mcmu=mf5dGsqwWKWA5aBYd7L=vFas6d+NQ@mail.gmail.com' \
--to=magnus.damm@gmail.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wsa@the-dreams.de \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.