From: Wolfram Sang <wsa@the-dreams.de> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>, Simon Horman <horms@verge.net.au>, Geert Uytterhoeven <geert@linux-m68k.org>, Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>, Yoshihiro Kaneko <ykaneko0929@gmail.com>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Subject: Re: [PATCH 5/9] i2c: rcar: init new messages in irq Date: Fri, 23 Oct 2015 09:45:00 +0000 [thread overview] Message-ID: <20151023094500.GD13380@katana> (raw) In-Reply-To: <2048622.tkxROUAu7P@avalon> [-- Attachment #1: Type: text/plain, Size: 1544 bytes --] > I had CONFIG_DRM_FBDEV_EMULATION disabled. I've then enabled it but also > merged git://people.freedesktop.org/~airlied/linux next in my branch, which > probably fixes the problem. So, your tree is not strictly renesas-drivers-2015-10-13-v4.3-rc5? > > I fixed it locally and will see if I see ADV7511 problems. I cannot > > fully test HDMI probably, because it seems that this HDMI->DVI chain I > > have does not work. > > It's supposed to be supported, so that might be something we need to fix. More > work for me \o/ :-) :/ Let me know if I can send you debug output. > > Okay, so before any 'modetest' activity. Which kernelconfig? > > shmobile_defconfig? > > .config attached. That one also probes for me... I only disabled DHCP and added my initramfs. I patched the fbdev build error out and changed Lager dts to use i2c-rcar (instead of i2c-sh_mobile). Can you enable CONFIG_I2C_DEBUG_CORE in the config, apply this patch, and send me the trace output and bootlog? Thanks, Wolfram diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index 1921294afc87ce..cd56f77550cac1 100644 --- a/drivers/i2c/busses/i2c-rcar.c +++ b/drivers/i2c/busses/i2c-rcar.c @@ -418,6 +418,7 @@ static irqreturn_t rcar_i2c_irq(int irq, void *ptr) rcar_i2c_write(priv, ICMCR, val & RCAR_BUS_MASK_DATA); msr = rcar_i2c_read(priv, ICMSR); +trace_printk("msr %08x\n", msr); /* Only handle interrupts that are currently enabled */ msr &= rcar_i2c_read(priv, ICMIER); [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>, Simon Horman <horms@verge.net.au>, Geert Uytterhoeven <geert@linux-m68k.org>, Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>, Yoshihiro Kaneko <ykaneko0929@gmail.com>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Subject: Re: [PATCH 5/9] i2c: rcar: init new messages in irq Date: Fri, 23 Oct 2015 11:45:00 +0200 [thread overview] Message-ID: <20151023094500.GD13380@katana> (raw) In-Reply-To: <2048622.tkxROUAu7P@avalon> [-- Attachment #1: Type: text/plain, Size: 1544 bytes --] > I had CONFIG_DRM_FBDEV_EMULATION disabled. I've then enabled it but also > merged git://people.freedesktop.org/~airlied/linux next in my branch, which > probably fixes the problem. So, your tree is not strictly renesas-drivers-2015-10-13-v4.3-rc5? > > I fixed it locally and will see if I see ADV7511 problems. I cannot > > fully test HDMI probably, because it seems that this HDMI->DVI chain I > > have does not work. > > It's supposed to be supported, so that might be something we need to fix. More > work for me \o/ :-) :/ Let me know if I can send you debug output. > > Okay, so before any 'modetest' activity. Which kernelconfig? > > shmobile_defconfig? > > .config attached. That one also probes for me... I only disabled DHCP and added my initramfs. I patched the fbdev build error out and changed Lager dts to use i2c-rcar (instead of i2c-sh_mobile). Can you enable CONFIG_I2C_DEBUG_CORE in the config, apply this patch, and send me the trace output and bootlog? Thanks, Wolfram diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index 1921294afc87ce..cd56f77550cac1 100644 --- a/drivers/i2c/busses/i2c-rcar.c +++ b/drivers/i2c/busses/i2c-rcar.c @@ -418,6 +418,7 @@ static irqreturn_t rcar_i2c_irq(int irq, void *ptr) rcar_i2c_write(priv, ICMCR, val & RCAR_BUS_MASK_DATA); msr = rcar_i2c_read(priv, ICMSR); +trace_printk("msr %08x\n", msr); /* Only handle interrupts that are currently enabled */ msr &= rcar_i2c_read(priv, ICMIER); [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-23 9:45 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-09-03 20:20 [PATCH 0/9] i2c: rcar: tackle race conditions in the driver Wolfram Sang 2015-09-03 20:20 ` Wolfram Sang 2015-09-03 20:20 ` [PATCH 1/9] i2c: rcar: rework hw init Wolfram Sang 2015-09-03 20:20 ` Wolfram Sang 2015-09-03 20:20 ` [PATCH 2/9] i2c: rcar: remove unused IOERROR state Wolfram Sang 2015-09-03 20:20 ` Wolfram Sang 2015-09-03 20:20 ` [PATCH 6/9] i2c: rcar: don't issue stop when HW does it automatically Wolfram Sang 2015-09-03 20:20 ` Wolfram Sang [not found] ` <1441311613-2681-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2015-09-03 20:20 ` [PATCH 3/9] i2c: rcar: remove spinlock Wolfram Sang 2015-09-03 20:20 ` Wolfram Sang 2015-09-03 20:20 ` [PATCH 4/9] i2c: rcar: refactor setup of a msg Wolfram Sang 2015-09-03 20:20 ` Wolfram Sang 2015-09-03 20:20 ` [PATCH 5/9] i2c: rcar: init new messages in irq Wolfram Sang 2015-09-03 20:20 ` Wolfram Sang 2015-10-21 23:10 ` Laurent Pinchart 2015-10-21 23:10 ` Laurent Pinchart 2015-10-22 11:05 ` Wolfram Sang 2015-10-22 11:05 ` Wolfram Sang 2015-10-22 11:12 ` Laurent Pinchart 2015-10-22 11:12 ` Laurent Pinchart 2015-10-23 8:06 ` Wolfram Sang 2015-10-23 8:06 ` Wolfram Sang 2015-10-23 8:57 ` Laurent Pinchart 2015-10-23 9:45 ` Wolfram Sang [this message] 2015-10-23 9:45 ` Wolfram Sang 2015-10-23 10:28 ` Laurent Pinchart 2015-10-23 10:28 ` Laurent Pinchart 2015-10-23 12:14 ` Wolfram Sang 2015-10-23 12:14 ` Wolfram Sang 2015-10-23 13:14 ` Laurent Pinchart 2015-10-23 13:14 ` Laurent Pinchart 2015-10-25 15:53 ` Wolfram Sang 2015-10-25 15:53 ` Wolfram Sang 2015-10-29 19:23 ` Wolfram Sang 2015-10-29 19:23 ` Wolfram Sang 2015-10-23 10:04 ` Geert Uytterhoeven 2015-10-23 10:04 ` Geert Uytterhoeven 2015-10-23 10:07 ` Wolfram Sang 2015-10-23 10:07 ` Wolfram Sang 2015-09-03 20:20 ` [PATCH 7/9] i2c: rcar: check master irqs before slave irqs Wolfram Sang 2015-09-03 20:20 ` Wolfram Sang 2015-09-03 20:20 ` [PATCH 8/9] i2c: rcar: revoke START request early Wolfram Sang 2015-09-03 20:20 ` Wolfram Sang 2015-09-03 20:20 ` [PATCH 9/9] i2c: rcar: clean up after refactoring Wolfram Sang 2015-09-03 20:20 ` Wolfram Sang 2015-09-03 20:35 ` [PATCH 0/9] i2c: rcar: tackle race conditions in the driver Laurent Pinchart 2015-09-03 20:35 ` Laurent Pinchart 2015-09-03 20:40 ` Wolfram Sang 2015-09-03 20:40 ` Wolfram Sang 2015-09-03 20:47 ` Laurent Pinchart 2015-09-03 20:47 ` Laurent Pinchart 2015-09-03 20:55 ` Wolfram Sang 2015-09-03 20:55 ` Wolfram Sang 2015-09-04 4:33 ` Magnus Damm 2015-09-04 4:33 ` Magnus Damm 2015-09-05 7:31 ` Wolfram Sang 2015-09-05 7:31 ` Wolfram Sang 2015-09-07 16:04 ` Magnus Damm 2015-09-07 16:04 ` Magnus Damm [not found] ` <CANqRtoRs=f=07B=HSLCVg5G4rnhxj6Heod+spYwxHiKFLZqFWg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-09-08 10:53 ` Wolfram Sang 2015-09-08 10:53 ` Wolfram Sang 2015-09-09 5:08 ` Magnus Damm 2015-09-09 5:08 ` Magnus Damm 2015-09-09 8:54 ` Wolfram Sang 2015-09-09 8:54 ` Wolfram Sang 2015-10-09 21:34 ` Wolfram Sang 2015-10-09 21:34 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20151023094500.GD13380@katana \ --to=wsa@the-dreams.de \ --cc=geert@linux-m68k.org \ --cc=horms@verge.net.au \ --cc=kuninori.morimoto.gx@gmail.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=sergei.shtylyov@cogentembedded.com \ --cc=ykaneko0929@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.