All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas saenz julienne <nsaenz@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>
Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	Mike Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Michael Stapelberg <michael@stapelberg.ch>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/5] clk: bcm-2835: Remove rounding up the dividers
Date: Tue, 28 Sep 2021 18:26:55 +0200	[thread overview]
Message-ID: <1d94747e74061f05395c34a4c441f96823dbf53a.camel@kernel.org> (raw)
In-Reply-To: <20210922125419.4125779-3-maxime@cerno.tech>

On Wed, 2021-09-22 at 14:54 +0200, Maxime Ripard wrote:
> The driver, once it found a divider, tries to round it up by increasing
> the least significant bit of the fractional part by one when the
> round_up argument is set and there's a remainder.
> 
> However, since it increases the divider it will actually reduce the
> clock rate below what we were asking for, leading to issues with
> clk_set_min_rate() that will complain that our rounded clock rate is
> below the minimum of the rate.
> 
> Since the dividers are fairly precise already, let's remove that part so
> that we can have clk_set_min_rate() working.
> 
> This is effectively a revert of 9c95b32ca093 ("clk: bcm2835: add a round
> up ability to the clock divisor").
> 
> Fixes: 9c95b32ca093 ("clk: bcm2835: add a round up ability to the clock divisor")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
Tested-by: Nicolas Saenz Julienne <nsaenz@kernel.org> # boot and basic functionality

Regards,
Nicolas


WARNING: multiple messages have this Message-ID (diff)
From: nicolas saenz julienne <nsaenz@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	 Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>
Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	 linux-rpi-kernel@lists.infradead.org,
	Mike Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Michael Stapelberg <michael@stapelberg.ch>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/5] clk: bcm-2835: Remove rounding up the dividers
Date: Tue, 28 Sep 2021 18:26:55 +0200	[thread overview]
Message-ID: <1d94747e74061f05395c34a4c441f96823dbf53a.camel@kernel.org> (raw)
In-Reply-To: <20210922125419.4125779-3-maxime@cerno.tech>

On Wed, 2021-09-22 at 14:54 +0200, Maxime Ripard wrote:
> The driver, once it found a divider, tries to round it up by increasing
> the least significant bit of the fractional part by one when the
> round_up argument is set and there's a remainder.
> 
> However, since it increases the divider it will actually reduce the
> clock rate below what we were asking for, leading to issues with
> clk_set_min_rate() that will complain that our rounded clock rate is
> below the minimum of the rate.
> 
> Since the dividers are fairly precise already, let's remove that part so
> that we can have clk_set_min_rate() working.
> 
> This is effectively a revert of 9c95b32ca093 ("clk: bcm2835: add a round
> up ability to the clock divisor").
> 
> Fixes: 9c95b32ca093 ("clk: bcm2835: add a round up ability to the clock divisor")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
Tested-by: Nicolas Saenz Julienne <nsaenz@kernel.org> # boot and basic functionality

Regards,
Nicolas


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-28 16:27 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 12:54 [PATCH 0/5] drm/vc4: hdmi: Remove CPU hangs, take 2 Maxime Ripard
2021-09-22 12:54 ` Maxime Ripard
2021-09-22 12:54 ` [PATCH 1/5] clk: bcm-2835: Pick the closest clock rate Maxime Ripard
2021-09-22 12:54   ` Maxime Ripard
2021-09-28 16:26   ` nicolas saenz julienne
2021-09-28 16:26     ` nicolas saenz julienne
2021-09-30 18:08   ` Stephen Boyd
2021-09-30 18:08     ` Stephen Boyd
2021-10-13 12:59   ` (subset) " Maxime Ripard
2021-10-13 12:59     ` Maxime Ripard
2021-09-22 12:54 ` [PATCH 2/5] clk: bcm-2835: Remove rounding up the dividers Maxime Ripard
2021-09-22 12:54   ` Maxime Ripard
2021-09-28 16:26   ` nicolas saenz julienne [this message]
2021-09-28 16:26     ` nicolas saenz julienne
2021-09-29 13:27     ` Maxime Ripard
2021-09-29 13:27       ` Maxime Ripard
2021-09-30 18:09   ` Stephen Boyd
2021-09-30 18:09     ` Stephen Boyd
2021-10-13 12:59   ` (subset) " Maxime Ripard
2021-10-13 12:59     ` Maxime Ripard
2021-09-22 12:54 ` [PATCH 3/5] drm/vc4: hdmi: Set a default HSM rate Maxime Ripard
2021-09-22 12:54   ` Maxime Ripard
2021-09-30 15:51   ` nicolas saenz julienne
2021-09-30 15:51     ` nicolas saenz julienne
2021-10-13 12:59   ` (subset) " Maxime Ripard
2021-10-13 12:59     ` Maxime Ripard
2021-09-22 12:54 ` [PATCH 4/5] drm/vc4: hdmi: Move the HSM clock enable to runtime_pm Maxime Ripard
2021-09-22 12:54   ` Maxime Ripard
2021-09-30 15:54   ` nicolas saenz julienne
2021-09-30 15:54     ` nicolas saenz julienne
2021-10-13 12:59   ` (subset) " Maxime Ripard
2021-10-13 12:59     ` Maxime Ripard
2021-09-22 12:54 ` [PATCH 5/5] drm/vc4: hdmi: Make sure the controller is powered in detect Maxime Ripard
2021-09-22 12:54   ` Maxime Ripard
2021-09-30 15:55   ` nicolas saenz julienne
2021-09-30 15:55     ` nicolas saenz julienne
2021-10-13 12:59   ` (subset) " Maxime Ripard
2021-10-13 12:59     ` Maxime Ripard
     [not found] ` <CANnVG6kFC7q_dDDp4rRZsJz=paHKy2STn9127LE=JJOf2kW2TA@mail.gmail.com>
2021-09-23  7:05   ` [PATCH 0/5] drm/vc4: hdmi: Remove CPU hangs, take 2 Michael Stapelberg
2021-09-23  7:05     ` Michael Stapelberg
2021-09-24  7:40 ` Maxime Ripard
2021-09-24  7:40   ` Maxime Ripard
2021-09-28 13:05   ` Maxime Ripard
2021-09-28 13:05     ` Maxime Ripard
2021-09-30 18:09     ` Stephen Boyd
2021-09-30 18:09       ` Stephen Boyd
2021-09-30 18:39       ` Florian Fainelli
2021-09-30 18:39         ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d94747e74061f05395c34a4c441f96823dbf53a.camel@kernel.org \
    --to=nsaenz@kernel.org \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maxime@cerno.tech \
    --cc=michael@stapelberg.ch \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.