From: Maxime Ripard <maxime@cerno.tech> To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Thomas Zimmermann <tzimmermann@suse.de>, Maxime Ripard <maxime@cerno.tech>, Daniel Vetter <daniel.vetter@intel.com>, David Airlie <airlied@linux.ie> Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Nicolas Saenz Julienne <nsaenz@kernel.org>, Florian Fainelli <f.fainelli@gmail.com>, Michael Stapelberg <michael@stapelberg.ch>, Linus Torvalds <torvalds@linux-foundation.org> Subject: [PATCH 1/5] clk: bcm-2835: Pick the closest clock rate Date: Wed, 22 Sep 2021 14:54:15 +0200 [thread overview] Message-ID: <20210922125419.4125779-2-maxime@cerno.tech> (raw) In-Reply-To: <20210922125419.4125779-1-maxime@cerno.tech> The driver currently tries to pick the closest rate that is lower than the rate being requested. This causes an issue with clk_set_min_rate() since it actively checks for the rounded rate to be above the minimum that was just set. Let's change the logic a bit to pick the closest rate to the requested rate, no matter if it's actually higher or lower. Fixes: 6d18b8adbe67 ("clk: bcm2835: Support for clock parent selection") Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/clk/bcm/clk-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index a254512965eb..bf97b2b2a63f 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/drivers/clk/bcm/clk-bcm2835.c @@ -1216,7 +1216,7 @@ static int bcm2835_clock_determine_rate(struct clk_hw *hw, rate = bcm2835_clock_choose_div_and_prate(hw, i, req->rate, &div, &prate, &avgrate); - if (rate > best_rate && rate <= req->rate) { + if (abs(req->rate - rate) < abs(req->rate - best_rate)) { best_parent = parent; best_prate = prate; best_rate = rate; -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech> To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Thomas Zimmermann <tzimmermann@suse.de>, Maxime Ripard <maxime@cerno.tech>, Daniel Vetter <daniel.vetter@intel.com>, David Airlie <airlied@linux.ie> Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Nicolas Saenz Julienne <nsaenz@kernel.org>, Florian Fainelli <f.fainelli@gmail.com>, Michael Stapelberg <michael@stapelberg.ch>, Linus Torvalds <torvalds@linux-foundation.org> Subject: [PATCH 1/5] clk: bcm-2835: Pick the closest clock rate Date: Wed, 22 Sep 2021 14:54:15 +0200 [thread overview] Message-ID: <20210922125419.4125779-2-maxime@cerno.tech> (raw) In-Reply-To: <20210922125419.4125779-1-maxime@cerno.tech> The driver currently tries to pick the closest rate that is lower than the rate being requested. This causes an issue with clk_set_min_rate() since it actively checks for the rounded rate to be above the minimum that was just set. Let's change the logic a bit to pick the closest rate to the requested rate, no matter if it's actually higher or lower. Fixes: 6d18b8adbe67 ("clk: bcm2835: Support for clock parent selection") Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/clk/bcm/clk-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index a254512965eb..bf97b2b2a63f 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/drivers/clk/bcm/clk-bcm2835.c @@ -1216,7 +1216,7 @@ static int bcm2835_clock_determine_rate(struct clk_hw *hw, rate = bcm2835_clock_choose_div_and_prate(hw, i, req->rate, &div, &prate, &avgrate); - if (rate > best_rate && rate <= req->rate) { + if (abs(req->rate - rate) < abs(req->rate - best_rate)) { best_parent = parent; best_prate = prate; best_rate = rate; -- 2.31.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-22 12:54 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-22 12:54 [PATCH 0/5] drm/vc4: hdmi: Remove CPU hangs, take 2 Maxime Ripard 2021-09-22 12:54 ` Maxime Ripard 2021-09-22 12:54 ` Maxime Ripard [this message] 2021-09-22 12:54 ` [PATCH 1/5] clk: bcm-2835: Pick the closest clock rate Maxime Ripard 2021-09-28 16:26 ` nicolas saenz julienne 2021-09-28 16:26 ` nicolas saenz julienne 2021-09-30 18:08 ` Stephen Boyd 2021-09-30 18:08 ` Stephen Boyd 2021-10-13 12:59 ` (subset) " Maxime Ripard 2021-10-13 12:59 ` Maxime Ripard 2021-09-22 12:54 ` [PATCH 2/5] clk: bcm-2835: Remove rounding up the dividers Maxime Ripard 2021-09-22 12:54 ` Maxime Ripard 2021-09-28 16:26 ` nicolas saenz julienne 2021-09-28 16:26 ` nicolas saenz julienne 2021-09-29 13:27 ` Maxime Ripard 2021-09-29 13:27 ` Maxime Ripard 2021-09-30 18:09 ` Stephen Boyd 2021-09-30 18:09 ` Stephen Boyd 2021-10-13 12:59 ` (subset) " Maxime Ripard 2021-10-13 12:59 ` Maxime Ripard 2021-09-22 12:54 ` [PATCH 3/5] drm/vc4: hdmi: Set a default HSM rate Maxime Ripard 2021-09-22 12:54 ` Maxime Ripard 2021-09-30 15:51 ` nicolas saenz julienne 2021-09-30 15:51 ` nicolas saenz julienne 2021-10-13 12:59 ` (subset) " Maxime Ripard 2021-10-13 12:59 ` Maxime Ripard 2021-09-22 12:54 ` [PATCH 4/5] drm/vc4: hdmi: Move the HSM clock enable to runtime_pm Maxime Ripard 2021-09-22 12:54 ` Maxime Ripard 2021-09-30 15:54 ` nicolas saenz julienne 2021-09-30 15:54 ` nicolas saenz julienne 2021-10-13 12:59 ` (subset) " Maxime Ripard 2021-10-13 12:59 ` Maxime Ripard 2021-09-22 12:54 ` [PATCH 5/5] drm/vc4: hdmi: Make sure the controller is powered in detect Maxime Ripard 2021-09-22 12:54 ` Maxime Ripard 2021-09-30 15:55 ` nicolas saenz julienne 2021-09-30 15:55 ` nicolas saenz julienne 2021-10-13 12:59 ` (subset) " Maxime Ripard 2021-10-13 12:59 ` Maxime Ripard [not found] ` <CANnVG6kFC7q_dDDp4rRZsJz=paHKy2STn9127LE=JJOf2kW2TA@mail.gmail.com> 2021-09-23 7:05 ` [PATCH 0/5] drm/vc4: hdmi: Remove CPU hangs, take 2 Michael Stapelberg 2021-09-23 7:05 ` Michael Stapelberg 2021-09-24 7:40 ` Maxime Ripard 2021-09-24 7:40 ` Maxime Ripard 2021-09-28 13:05 ` Maxime Ripard 2021-09-28 13:05 ` Maxime Ripard 2021-09-30 18:09 ` Stephen Boyd 2021-09-30 18:09 ` Stephen Boyd 2021-09-30 18:39 ` Florian Fainelli 2021-09-30 18:39 ` Florian Fainelli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210922125419.4125779-2-maxime@cerno.tech \ --to=maxime@cerno.tech \ --cc=airlied@linux.ie \ --cc=daniel.vetter@intel.com \ --cc=f.fainelli@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=michael@stapelberg.ch \ --cc=mturquette@baylibre.com \ --cc=nsaenz@kernel.org \ --cc=sboyd@kernel.org \ --cc=torvalds@linux-foundation.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.