All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas saenz julienne <nsaenz@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>
Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	Mike Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Michael Stapelberg <michael@stapelberg.ch>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH 4/5] drm/vc4: hdmi: Move the HSM clock enable to runtime_pm
Date: Thu, 30 Sep 2021 17:54:43 +0200	[thread overview]
Message-ID: <25e5880dc5c2c00bc2c261bd12246289a2adb8b5.camel@kernel.org> (raw)
In-Reply-To: <20210922125419.4125779-5-maxime@cerno.tech>

On Wed, 2021-09-22 at 14:54 +0200, Maxime Ripard wrote:
> In order to access the HDMI controller, we need to make sure the HSM
> clock is enabled. If we were to access it with the clock disabled, the
> CPU would completely hang, resulting in an hard crash.
> 
> Since we have different code path that would require it, let's move that
> clock enable / disable to runtime_pm that will take care of the
> reference counting for us.
> 
> Since we also want to change the HSM clock rate and it's only valid
> while the clock is disabled, we need to move the clk_set_min_rate() call
> on the HSM clock above pm_runtime_get_and_sync().
> 
> Fixes: 4f6e3d66ac52 ("drm/vc4: Add runtime PM support to the HDMI encoder driver")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
Tested-by: Nicolas Saenz Julienne <nsaenz@kernel.org>

Regards,
Nicolas


WARNING: multiple messages have this Message-ID (diff)
From: nicolas saenz julienne <nsaenz@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	 Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>
Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	 linux-rpi-kernel@lists.infradead.org,
	Mike Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Michael Stapelberg <michael@stapelberg.ch>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	 Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH 4/5] drm/vc4: hdmi: Move the HSM clock enable to runtime_pm
Date: Thu, 30 Sep 2021 17:54:43 +0200	[thread overview]
Message-ID: <25e5880dc5c2c00bc2c261bd12246289a2adb8b5.camel@kernel.org> (raw)
In-Reply-To: <20210922125419.4125779-5-maxime@cerno.tech>

On Wed, 2021-09-22 at 14:54 +0200, Maxime Ripard wrote:
> In order to access the HDMI controller, we need to make sure the HSM
> clock is enabled. If we were to access it with the clock disabled, the
> CPU would completely hang, resulting in an hard crash.
> 
> Since we have different code path that would require it, let's move that
> clock enable / disable to runtime_pm that will take care of the
> reference counting for us.
> 
> Since we also want to change the HSM clock rate and it's only valid
> while the clock is disabled, we need to move the clk_set_min_rate() call
> on the HSM clock above pm_runtime_get_and_sync().
> 
> Fixes: 4f6e3d66ac52 ("drm/vc4: Add runtime PM support to the HDMI encoder driver")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
Tested-by: Nicolas Saenz Julienne <nsaenz@kernel.org>

Regards,
Nicolas


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-30 15:54 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 12:54 [PATCH 0/5] drm/vc4: hdmi: Remove CPU hangs, take 2 Maxime Ripard
2021-09-22 12:54 ` Maxime Ripard
2021-09-22 12:54 ` [PATCH 1/5] clk: bcm-2835: Pick the closest clock rate Maxime Ripard
2021-09-22 12:54   ` Maxime Ripard
2021-09-28 16:26   ` nicolas saenz julienne
2021-09-28 16:26     ` nicolas saenz julienne
2021-09-30 18:08   ` Stephen Boyd
2021-09-30 18:08     ` Stephen Boyd
2021-10-13 12:59   ` (subset) " Maxime Ripard
2021-10-13 12:59     ` Maxime Ripard
2021-09-22 12:54 ` [PATCH 2/5] clk: bcm-2835: Remove rounding up the dividers Maxime Ripard
2021-09-22 12:54   ` Maxime Ripard
2021-09-28 16:26   ` nicolas saenz julienne
2021-09-28 16:26     ` nicolas saenz julienne
2021-09-29 13:27     ` Maxime Ripard
2021-09-29 13:27       ` Maxime Ripard
2021-09-30 18:09   ` Stephen Boyd
2021-09-30 18:09     ` Stephen Boyd
2021-10-13 12:59   ` (subset) " Maxime Ripard
2021-10-13 12:59     ` Maxime Ripard
2021-09-22 12:54 ` [PATCH 3/5] drm/vc4: hdmi: Set a default HSM rate Maxime Ripard
2021-09-22 12:54   ` Maxime Ripard
2021-09-30 15:51   ` nicolas saenz julienne
2021-09-30 15:51     ` nicolas saenz julienne
2021-10-13 12:59   ` (subset) " Maxime Ripard
2021-10-13 12:59     ` Maxime Ripard
2021-09-22 12:54 ` [PATCH 4/5] drm/vc4: hdmi: Move the HSM clock enable to runtime_pm Maxime Ripard
2021-09-22 12:54   ` Maxime Ripard
2021-09-30 15:54   ` nicolas saenz julienne [this message]
2021-09-30 15:54     ` nicolas saenz julienne
2021-10-13 12:59   ` (subset) " Maxime Ripard
2021-10-13 12:59     ` Maxime Ripard
2021-09-22 12:54 ` [PATCH 5/5] drm/vc4: hdmi: Make sure the controller is powered in detect Maxime Ripard
2021-09-22 12:54   ` Maxime Ripard
2021-09-30 15:55   ` nicolas saenz julienne
2021-09-30 15:55     ` nicolas saenz julienne
2021-10-13 12:59   ` (subset) " Maxime Ripard
2021-10-13 12:59     ` Maxime Ripard
     [not found] ` <CANnVG6kFC7q_dDDp4rRZsJz=paHKy2STn9127LE=JJOf2kW2TA@mail.gmail.com>
2021-09-23  7:05   ` [PATCH 0/5] drm/vc4: hdmi: Remove CPU hangs, take 2 Michael Stapelberg
2021-09-23  7:05     ` Michael Stapelberg
2021-09-24  7:40 ` Maxime Ripard
2021-09-24  7:40   ` Maxime Ripard
2021-09-28 13:05   ` Maxime Ripard
2021-09-28 13:05     ` Maxime Ripard
2021-09-30 18:09     ` Stephen Boyd
2021-09-30 18:09       ` Stephen Boyd
2021-09-30 18:39       ` Florian Fainelli
2021-09-30 18:39         ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25e5880dc5c2c00bc2c261bd12246289a2adb8b5.camel@kernel.org \
    --to=nsaenz@kernel.org \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maxime@cerno.tech \
    --cc=michael@stapelberg.ch \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.