From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and thermal on Odroid XU board
Date: Tue, 31 May 2016 15:36:04 -0400 [thread overview]
Message-ID: <1ec0f7fc-f6e0-e4d6-e424-43289bf31b16@osg.samsung.com> (raw)
In-Reply-To: <1464719945-3417-5-git-send-email-krzk@kernel.org>
Hello Krzysztof,
On 05/31/2016 02:39 PM, Krzysztof Kozlowski wrote:
> Extend the DTS for Exynos5410-based Odroid XU board with:
> 1. Proper PWM outputs,
> 2. usb3503 USB HUB (with integrated LAN9730 ethernet adapter (smsc95xx)),
> 3. Maxim 77802 PMIC (regulators, 32 kHz clocks, RTC),
> 4. CPU thermal (trip points are the same as in Odroid XU3/XU4 but
> cooling maps are different as there is no CPU freq and only one
> cluster available for now),
> 5. Regulator supplies for USB 3.0.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
[snip]
> +
> + ldo10_reg: LDO10 {
> + regulator-name = "vdd18_mipi";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> +
[snip]
> +
> + ldo12_reg: LDO12 {
> + regulator-name = "vdd33_usb3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
[snip]
> +
> + ldo15_reg: LDO15 {
> + regulator-name = "vdd10_usb3";
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
> + regulator-always-on;
> + };
> +
I see that LDO 10, 12 and 15 are used by still marked as always-on. Did
you try not marking as always-on those or that also causes issues like
in the other regulators were you added comments about being always-on?
Besides that, patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
WARNING: multiple messages have this Message-ID (diff)
From: javier@osg.samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and thermal on Odroid XU board
Date: Tue, 31 May 2016 15:36:04 -0400 [thread overview]
Message-ID: <1ec0f7fc-f6e0-e4d6-e424-43289bf31b16@osg.samsung.com> (raw)
In-Reply-To: <1464719945-3417-5-git-send-email-krzk@kernel.org>
Hello Krzysztof,
On 05/31/2016 02:39 PM, Krzysztof Kozlowski wrote:
> Extend the DTS for Exynos5410-based Odroid XU board with:
> 1. Proper PWM outputs,
> 2. usb3503 USB HUB (with integrated LAN9730 ethernet adapter (smsc95xx)),
> 3. Maxim 77802 PMIC (regulators, 32 kHz clocks, RTC),
> 4. CPU thermal (trip points are the same as in Odroid XU3/XU4 but
> cooling maps are different as there is no CPU freq and only one
> cluster available for now),
> 5. Regulator supplies for USB 3.0.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
[snip]
> +
> + ldo10_reg: LDO10 {
> + regulator-name = "vdd18_mipi";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> +
[snip]
> +
> + ldo12_reg: LDO12 {
> + regulator-name = "vdd33_usb3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
[snip]
> +
> + ldo15_reg: LDO15 {
> + regulator-name = "vdd10_usb3";
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
> + regulator-always-on;
> + };
> +
I see that LDO 10, 12 and 15 are used by still marked as always-on. Did
you try not marking as always-on those or that also causes issues like
in the other regulators were you added comments about being always-on?
Besides that, patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-05-31 19:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 18:39 [PATCH 1/6] dt-bindings: clock: Add TMU clock ID to Exynos5410 Krzysztof Kozlowski
2016-05-31 18:39 ` Krzysztof Kozlowski
2016-05-31 18:39 ` [PATCH 2/6] clk: samsung: exynos5410: Add TMU clock Krzysztof Kozlowski
2016-05-31 18:39 ` Krzysztof Kozlowski
2016-05-31 18:56 ` Javier Martinez Canillas
2016-05-31 18:56 ` Javier Martinez Canillas
2016-06-01 9:59 ` Sylwester Nawrocki
2016-06-01 9:59 ` Sylwester Nawrocki
2016-05-31 18:39 ` [PATCH 3/6] ARM: dts: exynos: Interrupt for USB DWC3-1 differs between Exynos5420 and 5410 Krzysztof Kozlowski
2016-05-31 18:39 ` Krzysztof Kozlowski
2016-05-31 19:01 ` Javier Martinez Canillas
2016-05-31 19:01 ` Javier Martinez Canillas
2016-05-31 19:26 ` Krzysztof Kozlowski
2016-05-31 19:26 ` Krzysztof Kozlowski
2016-05-31 18:39 ` [PATCH 4/6] ARM: dts: exynos: Add Thermal Management Unit to Exynos5410 Krzysztof Kozlowski
2016-05-31 18:39 ` Krzysztof Kozlowski
2016-05-31 19:21 ` Javier Martinez Canillas
2016-05-31 19:21 ` Javier Martinez Canillas
2016-05-31 19:28 ` Krzysztof Kozlowski
2016-05-31 19:28 ` Krzysztof Kozlowski
2016-05-31 18:39 ` [PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and thermal on Odroid XU board Krzysztof Kozlowski
2016-05-31 18:39 ` Krzysztof Kozlowski
2016-05-31 19:36 ` Javier Martinez Canillas [this message]
2016-05-31 19:36 ` Javier Martinez Canillas
2016-05-31 20:05 ` Krzysztof Kozlowski
2016-05-31 20:05 ` Krzysztof Kozlowski
2016-05-31 20:10 ` Javier Martinez Canillas
2016-05-31 20:10 ` Javier Martinez Canillas
2016-05-31 18:39 ` [PATCH 6/6] ARM: dts: exynos: No need to enable TMU nodes on Odroid XU3 family Krzysztof Kozlowski
2016-05-31 18:39 ` Krzysztof Kozlowski
2016-05-31 19:37 ` Javier Martinez Canillas
2016-05-31 19:37 ` Javier Martinez Canillas
2016-05-31 18:53 ` [PATCH 1/6] dt-bindings: clock: Add TMU clock ID to Exynos5410 Javier Martinez Canillas
2016-05-31 18:53 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ec0f7fc-f6e0-e4d6-e424-43289bf31b16@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.