From: Krzysztof Kozlowski <krzk@kernel.org> To: Javier Martinez Canillas <javier@osg.samsung.com> Cc: Kukjin Kim <kgene@kernel.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 4/6] ARM: dts: exynos: Add Thermal Management Unit to Exynos5410 Date: Tue, 31 May 2016 21:28:18 +0200 [thread overview] Message-ID: <CAJKOXPeDw4BQm8HU0Pe1f1=5C8kHa_ZXGbYZR=o7Ah0mZX1H=Q@mail.gmail.com> (raw) In-Reply-To: <25549eaa-a286-7579-8407-411f0c1834ae@osg.samsung.com> On Tue, May 31, 2016 at 9:21 PM, Javier Martinez Canillas <javier@osg.samsung.com> wrote: > Hello Krzysztof, > > On 05/31/2016 02:39 PM, Krzysztof Kozlowski wrote: >> Add nodes for Thermal Management Unit to exynos5410.dtsi. Use the same >> compatible as for Exynos5420 however without second base for TRIMINFO >> register. >> >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> >> --- >> arch/arm/boot/dts/exynos5410.dtsi | 55 +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 55 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi >> index 994d16a44fe4..f1effd3f03c4 100644 >> --- a/arch/arm/boot/dts/exynos5410.dtsi >> +++ b/arch/arm/boot/dts/exynos5410.dtsi >> @@ -81,6 +81,42 @@ >> #clock-cells = <1>; >> }; >> >> + tmu_cpu0: tmu@10060000 { >> + compatible = "samsung,exynos5420-tmu"; >> + reg = <0x10060000 0x100>; >> + interrupts = <0 65 0>; > > Please use GIC_SPI instead of 0 on these. ok > >> + clocks = <&clock CLK_TMU>; >> + clock-names = "tmu_apbif"; >> + #include "exynos4412-tmu-sensor-conf.dtsi" >> + }; >> + >> + tmu_cpu1: tmu@10064000 { >> + compatible = "samsung,exynos5420-tmu"; >> + reg = <0x10064000 0x100>; >> + interrupts = <0 183 0>; >> + clocks = <&clock CLK_TMU>; >> + clock-names = "tmu_apbif"; >> + #include "exynos4412-tmu-sensor-conf.dtsi" >> + }; >> + >> + tmu_cpu2: tmu@10068000 { >> + compatible = "samsung,exynos5420-tmu"; >> + reg = <0x10068000 0x100>; >> + interrupts = <0 184 0>; >> + clocks = <&clock CLK_TMU>; >> + clock-names = "tmu_apbif"; >> + #include "exynos4412-tmu-sensor-conf.dtsi" >> + }; >> + >> + tmu_cpu3: tmu@1006c000 { >> + compatible = "samsung,exynos5420-tmu"; >> + reg = <0x1006c000 0x100>; >> + interrupts = <0 185 0>; >> + clocks = <&clock CLK_TMU>; >> + clock-names = "tmu_apbif"; >> + #include "exynos4412-tmu-sensor-conf.dtsi" >> + }; >> + > > Exynos5420 has 5 TMU channels and you are adding only 4 so I guess this > is another difference with Exynos5410 besides the TRIMINFO register not > being misplaced? Probably is worth to mention it in the commit message. Yes, indeed there is no GPU thermal zone. I'll mention it. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: krzk@kernel.org (Krzysztof Kozlowski) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/6] ARM: dts: exynos: Add Thermal Management Unit to Exynos5410 Date: Tue, 31 May 2016 21:28:18 +0200 [thread overview] Message-ID: <CAJKOXPeDw4BQm8HU0Pe1f1=5C8kHa_ZXGbYZR=o7Ah0mZX1H=Q@mail.gmail.com> (raw) In-Reply-To: <25549eaa-a286-7579-8407-411f0c1834ae@osg.samsung.com> On Tue, May 31, 2016 at 9:21 PM, Javier Martinez Canillas <javier@osg.samsung.com> wrote: > Hello Krzysztof, > > On 05/31/2016 02:39 PM, Krzysztof Kozlowski wrote: >> Add nodes for Thermal Management Unit to exynos5410.dtsi. Use the same >> compatible as for Exynos5420 however without second base for TRIMINFO >> register. >> >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> >> --- >> arch/arm/boot/dts/exynos5410.dtsi | 55 +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 55 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi >> index 994d16a44fe4..f1effd3f03c4 100644 >> --- a/arch/arm/boot/dts/exynos5410.dtsi >> +++ b/arch/arm/boot/dts/exynos5410.dtsi >> @@ -81,6 +81,42 @@ >> #clock-cells = <1>; >> }; >> >> + tmu_cpu0: tmu at 10060000 { >> + compatible = "samsung,exynos5420-tmu"; >> + reg = <0x10060000 0x100>; >> + interrupts = <0 65 0>; > > Please use GIC_SPI instead of 0 on these. ok > >> + clocks = <&clock CLK_TMU>; >> + clock-names = "tmu_apbif"; >> + #include "exynos4412-tmu-sensor-conf.dtsi" >> + }; >> + >> + tmu_cpu1: tmu at 10064000 { >> + compatible = "samsung,exynos5420-tmu"; >> + reg = <0x10064000 0x100>; >> + interrupts = <0 183 0>; >> + clocks = <&clock CLK_TMU>; >> + clock-names = "tmu_apbif"; >> + #include "exynos4412-tmu-sensor-conf.dtsi" >> + }; >> + >> + tmu_cpu2: tmu at 10068000 { >> + compatible = "samsung,exynos5420-tmu"; >> + reg = <0x10068000 0x100>; >> + interrupts = <0 184 0>; >> + clocks = <&clock CLK_TMU>; >> + clock-names = "tmu_apbif"; >> + #include "exynos4412-tmu-sensor-conf.dtsi" >> + }; >> + >> + tmu_cpu3: tmu at 1006c000 { >> + compatible = "samsung,exynos5420-tmu"; >> + reg = <0x1006c000 0x100>; >> + interrupts = <0 185 0>; >> + clocks = <&clock CLK_TMU>; >> + clock-names = "tmu_apbif"; >> + #include "exynos4412-tmu-sensor-conf.dtsi" >> + }; >> + > > Exynos5420 has 5 TMU channels and you are adding only 4 so I guess this > is another difference with Exynos5410 besides the TRIMINFO register not > being misplaced? Probably is worth to mention it in the commit message. Yes, indeed there is no GPU thermal zone. I'll mention it. Best regards, Krzysztof
next prev parent reply other threads:[~2016-05-31 19:28 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-31 18:39 [PATCH 1/6] dt-bindings: clock: Add TMU clock ID to Exynos5410 Krzysztof Kozlowski 2016-05-31 18:39 ` Krzysztof Kozlowski 2016-05-31 18:39 ` [PATCH 2/6] clk: samsung: exynos5410: Add TMU clock Krzysztof Kozlowski 2016-05-31 18:39 ` Krzysztof Kozlowski 2016-05-31 18:56 ` Javier Martinez Canillas 2016-05-31 18:56 ` Javier Martinez Canillas 2016-06-01 9:59 ` Sylwester Nawrocki 2016-06-01 9:59 ` Sylwester Nawrocki 2016-05-31 18:39 ` [PATCH 3/6] ARM: dts: exynos: Interrupt for USB DWC3-1 differs between Exynos5420 and 5410 Krzysztof Kozlowski 2016-05-31 18:39 ` Krzysztof Kozlowski 2016-05-31 19:01 ` Javier Martinez Canillas 2016-05-31 19:01 ` Javier Martinez Canillas 2016-05-31 19:26 ` Krzysztof Kozlowski 2016-05-31 19:26 ` Krzysztof Kozlowski 2016-05-31 18:39 ` [PATCH 4/6] ARM: dts: exynos: Add Thermal Management Unit to Exynos5410 Krzysztof Kozlowski 2016-05-31 18:39 ` Krzysztof Kozlowski 2016-05-31 19:21 ` Javier Martinez Canillas 2016-05-31 19:21 ` Javier Martinez Canillas 2016-05-31 19:28 ` Krzysztof Kozlowski [this message] 2016-05-31 19:28 ` Krzysztof Kozlowski 2016-05-31 18:39 ` [PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and thermal on Odroid XU board Krzysztof Kozlowski 2016-05-31 18:39 ` Krzysztof Kozlowski 2016-05-31 19:36 ` Javier Martinez Canillas 2016-05-31 19:36 ` Javier Martinez Canillas 2016-05-31 20:05 ` Krzysztof Kozlowski 2016-05-31 20:05 ` Krzysztof Kozlowski 2016-05-31 20:10 ` Javier Martinez Canillas 2016-05-31 20:10 ` Javier Martinez Canillas 2016-05-31 18:39 ` [PATCH 6/6] ARM: dts: exynos: No need to enable TMU nodes on Odroid XU3 family Krzysztof Kozlowski 2016-05-31 18:39 ` Krzysztof Kozlowski 2016-05-31 19:37 ` Javier Martinez Canillas 2016-05-31 19:37 ` Javier Martinez Canillas 2016-05-31 18:53 ` [PATCH 1/6] dt-bindings: clock: Add TMU clock ID to Exynos5410 Javier Martinez Canillas 2016-05-31 18:53 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJKOXPeDw4BQm8HU0Pe1f1=5C8kHa_ZXGbYZR=o7Ah0mZX1H=Q@mail.gmail.com' \ --to=krzk@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=javier@osg.samsung.com \ --cc=kgene@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=s.nawrocki@samsung.com \ --cc=sboyd@codeaurora.org \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.