From: Auger Eric <eric.auger@redhat.com> To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>, Jacob Pan <jacob.jun.pan@linux.intel.com>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>, David Woodhouse <dwmw2@infradead.org>, Alex Williamson <alex.williamson@redhat.com> Cc: "Tian, Kevin" <kevin.tian@intel.com>, Raj Ashok <ashok.raj@intel.com>, Andriy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: Re: [PATCH v3 02/16] iommu: Introduce cache_invalidate API Date: Tue, 14 May 2019 09:46:35 +0200 [thread overview] Message-ID: <1edd45e6-4da3-e393-36b2-9e63cd5f7607@redhat.com> (raw) In-Reply-To: <1a5a5fad-ed21-5c79-9a9e-ff21fadfb95f@arm.com> Hi Jean, On 5/13/19 7:09 PM, Jean-Philippe Brucker wrote: > On 13/05/2019 17:50, Auger Eric wrote: >>> struct iommu_inv_pasid_info { >>> #define IOMMU_INV_PASID_FLAGS_PASID (1 << 0) >>> #define IOMMU_INV_PASID_FLAGS_ARCHID (1 << 1) >>> __u32 flags; >>> __u32 archid; >>> __u64 pasid; >>> }; >> I agree it does the job now. However it looks a bit strange to do a >> PASID based invalidation in my case - SMMUv3 nested stage - where I >> don't have any PASID involved. >> >> Couldn't we call it context based invalidation then? A context can be >> tagged by a PASID or/and an ARCHID. > > I think calling it "context" would be confusing as well (I shouldn't > have used it earlier), since VT-d uses that name for device table > entries (=STE on Arm SMMU). Maybe "addr_space"? yes you're right. Well we already pasid table table terminology so we can use it here as well - as long as we understand what purpose it serves ;-) - So OK for iommu_inv_pasid_info. I think Jean understood we would keep pasid standalone field in iommu_cache_invalidate_info's union. I understand the struct iommu_inv_pasid_info now would replace it, correct? Thanks Eric > > Thanks, > Jean > >> >> Domain invalidation would invalidate all the contexts belonging to that >> domain. >> >> Thanks >> >> Eric
WARNING: multiple messages have this Message-ID (diff)
From: Auger Eric <eric.auger@redhat.com> To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>, Jacob Pan <jacob.jun.pan@linux.intel.com>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>, David Woodhouse <dwmw2@infradead.org>, Alex Williamson <alex.williamson@redhat.com> Cc: "Tian, Kevin" <kevin.tian@intel.com>, Andriy Shevchenko <andriy.shevchenko@linux.intel.com>, Raj Ashok <ashok.raj@intel.com> Subject: Re: [PATCH v3 02/16] iommu: Introduce cache_invalidate API Date: Tue, 14 May 2019 09:46:35 +0200 [thread overview] Message-ID: <1edd45e6-4da3-e393-36b2-9e63cd5f7607@redhat.com> (raw) In-Reply-To: <1a5a5fad-ed21-5c79-9a9e-ff21fadfb95f@arm.com> Hi Jean, On 5/13/19 7:09 PM, Jean-Philippe Brucker wrote: > On 13/05/2019 17:50, Auger Eric wrote: >>> struct iommu_inv_pasid_info { >>> #define IOMMU_INV_PASID_FLAGS_PASID (1 << 0) >>> #define IOMMU_INV_PASID_FLAGS_ARCHID (1 << 1) >>> __u32 flags; >>> __u32 archid; >>> __u64 pasid; >>> }; >> I agree it does the job now. However it looks a bit strange to do a >> PASID based invalidation in my case - SMMUv3 nested stage - where I >> don't have any PASID involved. >> >> Couldn't we call it context based invalidation then? A context can be >> tagged by a PASID or/and an ARCHID. > > I think calling it "context" would be confusing as well (I shouldn't > have used it earlier), since VT-d uses that name for device table > entries (=STE on Arm SMMU). Maybe "addr_space"? yes you're right. Well we already pasid table table terminology so we can use it here as well - as long as we understand what purpose it serves ;-) - So OK for iommu_inv_pasid_info. I think Jean understood we would keep pasid standalone field in iommu_cache_invalidate_info's union. I understand the struct iommu_inv_pasid_info now would replace it, correct? Thanks Eric > > Thanks, > Jean > >> >> Domain invalidation would invalidate all the contexts belonging to that >> domain. >> >> Thanks >> >> Eric _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-05-14 7:46 UTC|newest] Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-03 22:32 [PATCH v3 00/16] Shared virtual address IOMMU and VT-d support Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 01/16] iommu: Introduce attach/detach_pasid_table API Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 02/16] iommu: Introduce cache_invalidate API Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-13 9:14 ` Auger Eric 2019-05-13 9:14 ` Auger Eric 2019-05-13 11:20 ` Jean-Philippe Brucker 2019-05-13 11:20 ` Jean-Philippe Brucker 2019-05-13 16:50 ` Auger Eric 2019-05-13 16:50 ` Auger Eric 2019-05-13 17:09 ` Jean-Philippe Brucker 2019-05-13 17:09 ` Jean-Philippe Brucker 2019-05-13 22:16 ` Jacob Pan 2019-05-13 22:16 ` Jacob Pan 2019-05-14 7:36 ` Auger Eric 2019-05-14 7:36 ` Auger Eric 2019-05-14 10:41 ` Jean-Philippe Brucker 2019-05-14 10:41 ` Jean-Philippe Brucker 2019-05-14 17:44 ` Jacob Pan 2019-05-14 17:44 ` Jacob Pan 2019-05-14 17:57 ` Jacob Pan 2019-05-14 17:57 ` Jacob Pan 2019-05-15 11:03 ` Jean-Philippe Brucker 2019-05-15 11:03 ` Jean-Philippe Brucker 2019-05-15 14:47 ` Tian, Kevin 2019-05-15 14:47 ` Tian, Kevin 2019-05-15 15:25 ` Jean-Philippe Brucker 2019-05-15 15:25 ` Jean-Philippe Brucker 2019-05-14 7:46 ` Auger Eric [this message] 2019-05-14 7:46 ` Auger Eric 2019-05-14 10:42 ` Jean-Philippe Brucker 2019-05-14 10:42 ` Jean-Philippe Brucker 2019-05-14 11:02 ` Auger Eric 2019-05-14 11:02 ` Auger Eric 2019-05-14 17:55 ` Jacob Pan 2019-05-14 17:55 ` Jacob Pan 2019-05-15 15:52 ` Jean-Philippe Brucker 2019-05-15 15:52 ` Jean-Philippe Brucker 2019-05-15 16:25 ` Jacob Pan 2019-05-15 16:25 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 03/16] iommu: Add I/O ASID allocator Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-21 8:21 ` Auger Eric 2019-05-21 8:21 ` Auger Eric 2019-05-21 17:03 ` Jacob Pan 2019-05-21 17:03 ` Jacob Pan 2019-05-22 12:19 ` Jean-Philippe Brucker 2019-05-22 12:19 ` Jean-Philippe Brucker 2019-05-21 9:41 ` Auger Eric 2019-05-21 9:41 ` Auger Eric 2019-05-21 17:05 ` Jacob Pan 2019-05-21 17:05 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 04/16] ioasid: Add custom IOASID allocator Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-21 9:55 ` Auger Eric 2019-05-21 9:55 ` Auger Eric 2019-05-22 19:42 ` Jacob Pan 2019-05-22 19:42 ` Jacob Pan 2019-05-23 7:14 ` Auger Eric 2019-05-23 7:14 ` Auger Eric 2019-05-23 15:40 ` Jacob Pan 2019-05-23 15:40 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 05/16] iommu/vt-d: Enlightened PASID allocation Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 06/16] iommu/vt-d: Add custom allocator for IOASID Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 07/16] iommu/vtd: Optimize tlb invalidation for vIOMMU Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 08/16] iommu/vt-d: Replace Intel specific PASID allocator with IOASID Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 09/16] iommu: Introduce guest PASID bind function Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-16 14:14 ` Jean-Philippe Brucker 2019-05-16 14:14 ` Jean-Philippe Brucker 2019-05-16 16:14 ` Jacob Pan 2019-05-16 16:14 ` Jacob Pan 2019-05-20 19:22 ` Jacob Pan 2019-05-20 19:22 ` Jacob Pan 2019-05-21 16:09 ` Jean-Philippe Brucker 2019-05-21 16:09 ` Jean-Philippe Brucker 2019-05-21 22:50 ` Jacob Pan 2019-05-21 22:50 ` Jacob Pan 2019-05-22 15:05 ` Jean-Philippe Brucker 2019-05-22 15:05 ` Jean-Philippe Brucker 2019-05-22 17:15 ` Jacob Pan 2019-05-22 17:15 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 10/16] iommu/vt-d: Move domain helper to header Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 11/16] iommu/vt-d: Avoid duplicated code for PASID setup Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 12/16] iommu/vt-d: Add nested translation helper function Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 13/16] iommu/vt-d: Clean up for SVM device list Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 14/16] iommu/vt-d: Add bind guest PASID support Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 15/16] iommu/vt-d: Support flushing more translation cache types Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-03 22:32 ` [PATCH v3 16/16] iommu/vt-d: Add svm/sva invalidate function Jacob Pan 2019-05-03 22:32 ` Jacob Pan 2019-05-15 16:31 ` [PATCH v3 00/16] Shared virtual address IOMMU and VT-d support Jacob Pan 2019-05-15 16:31 ` Jacob Pan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1edd45e6-4da3-e393-36b2-9e63cd5f7607@redhat.com \ --to=eric.auger@redhat.com \ --cc=alex.williamson@redhat.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=ashok.raj@intel.com \ --cc=dwmw2@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@linux.intel.com \ --cc=jean-philippe.brucker@arm.com \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.