All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Phillips <phillips@istop.com>
To: Mark Fasheh <mark.fasheh@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	ocfs2-devel@oss.oracle.com, torvalds@osdl.org, akpm@osdl.org,
	wim.coekaerts@oracle.com, lmb@suse.de
Subject: Re: [RFC] [PATCH] OCFS2
Date: Thu, 19 May 2005 12:23:15 -0400	[thread overview]
Message-ID: <200505191223.16189.phillips@istop.com> (raw)
In-Reply-To: <20050519065405.GI1340@ca-server1.us.oracle.com>

Hi Mark,

On Thursday 19 May 2005 02:54, Mark Fasheh wrote:
> On Thu, May 19, 2005 at 02:30:23AM -0400, Daniel Phillips wrote:
> > Zero terminated strings for lock names is bad taste.  It generates a
> > bunch of useless strlen executions and you force an ascii namespace for
> > no apparent reason.  Add a 9th parameter, namelen, to the lock call
> > maybe?
>
> Or perhaps pass in a qstr? Anyway I have to agree. That shouldn't be
> difficult to fix up.

Qstr would be nice, either that or an explicit string length.  Either way, the 
compiler will catch any missed fixups.

Regards,

Daniel


WARNING: multiple messages have this Message-ID (diff)
From: Daniel Phillips <phillips@istop.com>
To: Mark Fasheh <mark.fasheh@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	ocfs2-devel@oss.oracle.com, torvalds@osdl.org, akpm@osdl.org,
	wim.coekaerts@oracle.com, lmb@suse.de
Subject: [Ocfs2-devel] Re: [RFC] [PATCH] OCFS2
Date: Thu May 19 11:19:12 2005	[thread overview]
Message-ID: <200505191223.16189.phillips@istop.com> (raw)
In-Reply-To: <20050519065405.GI1340@ca-server1.us.oracle.com>

Hi Mark,

On Thursday 19 May 2005 02:54, Mark Fasheh wrote:
> On Thu, May 19, 2005 at 02:30:23AM -0400, Daniel Phillips wrote:
> > Zero terminated strings for lock names is bad taste.  It generates a
> > bunch of useless strlen executions and you force an ascii namespace for
> > no apparent reason.  Add a 9th parameter, namelen, to the lock call
> > maybe?
>
> Or perhaps pass in a qstr? Anyway I have to agree. That shouldn't be
> difficult to fix up.

Qstr would be nice, either that or an explicit string length.  Either way, the 
compiler will catch any missed fixups.

Regards,

Daniel

  reply	other threads:[~2005-05-19 16:19 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-18 17:33 [Ocfs2-devel] [RFC] [PATCH] OCFS2 Mark Fasheh
2005-05-18 22:33 ` Mark Fasheh
2005-05-18 19:56 ` [Ocfs2-devel] " Adrian Bunk
2005-05-18 23:40   ` Adrian Bunk
2005-05-18 20:26   ` [Ocfs2-devel] " Manish Singh
2005-05-19  1:26     ` Manish Singh
2005-05-19  4:59     ` Adrian Bunk
2005-05-19  9:45       ` Adrian Bunk
2005-05-19 10:24       ` 2.4 kernel threads linux
2005-05-19 10:39         ` Arjan van de Ven
2005-05-19 16:19         ` Jesse Barnes
2005-05-18 19:56 ` [Ocfs2-devel] Re: [RFC] [PATCH] OCFS2 Hans Reiser
2005-05-18 23:35   ` Hans Reiser
2005-05-18 23:28 ` [Ocfs2-devel] " Kyle Moffett
2005-05-19  2:30   ` Kyle Moffett
2005-05-18 23:30   ` [Ocfs2-devel] " Mark Fasheh
2005-05-19  4:30     ` Mark Fasheh
2005-05-19  1:52 ` [Ocfs2-devel] " Daniel Phillips
2005-05-19  6:30   ` Daniel Phillips
2005-05-19  1:54   ` [Ocfs2-devel] " Mark Fasheh
2005-05-19  6:54     ` Mark Fasheh
2005-05-19 11:19     ` Daniel Phillips [this message]
2005-05-19 16:23       ` Daniel Phillips
2005-05-19 10:26   ` Jeff Garzik
2005-05-19 15:09     ` [Ocfs2-devel] " Jeff Garzik
2005-05-19 15:09     ` Lee Revell
2005-05-19 15:20       ` Lee Revell
2005-05-19 15:09       ` [Ocfs2-devel] " Jeff Garzik
2005-05-19 15:25         ` Jeff Garzik
2005-06-23 13:03 ` [Ocfs2-devel] " James Morris
2005-06-23 18:03   ` James Morris
2005-06-23 13:29   ` [Ocfs2-devel] " Mark Fasheh
2005-06-23 18:29     ` Mark Fasheh
2005-06-24  3:05   ` Paul Jackson
2005-06-24 15:34     ` [Ocfs2-devel] " Paul Jackson
2005-06-23 23:00     ` Mark Fasheh
2005-06-24  3:59       ` Mark Fasheh
2005-06-24  4:17       ` Paul Jackson
2005-06-24 15:34         ` [Ocfs2-devel] " Paul Jackson
2005-06-24  3:29     ` Paul Jackson
2005-06-24 15:34       ` [Ocfs2-devel] " Paul Jackson
2005-06-21 21:14 Steve French
2005-06-21 22:03 ` Mark Fasheh
2005-06-21 22:43   ` Steve French
2005-06-22  0:04     ` Mark Fasheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200505191223.16189.phillips@istop.com \
    --to=phillips@istop.com \
    --cc=akpm@osdl.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lmb@suse.de \
    --cc=mark.fasheh@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=torvalds@osdl.org \
    --cc=wim.coekaerts@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.