All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Morris <jmorris@redhat.com>
To: Mark Fasheh <mark.fasheh@oracle.com>
Cc: linux-kernel@vger.kernel.org, <linux-fsdevel@vger.kernel.org>,
	<ocfs2-devel@oss.oracle.com>, <torvalds@osdl.org>,
	<akpm@osdl.org>, <wim.coekaerts@oracle.com>, <lmb@suse.de>
Subject: Re: [RFC] [PATCH] OCFS2
Date: Thu, 23 Jun 2005 14:03:35 -0400 (EDT)	[thread overview]
Message-ID: <Xine.LNX.4.44.0506231358230.14123-100000@thoron.boston.redhat.com> (raw)
In-Reply-To: <20050518223303.GE1340@ca-server1.us.oracle.com>

On Wed, 18 May 2005, Mark Fasheh wrote:

> This is OCFS2, a shared disk cluster file system which we hope will be
> included in the kernel.

The masklog code looks potentially useful outside of ocfs2, as a general 
kernel facility.  Any chance of splitting it out?


Quibbles:

- A lot of the macros should probably be replaced with static inlines, 
like OCFS2_IS_VALID_DINODE.

- Approx. 80 typedefs.  ouch.



-- 
James Morris
<jmorris@redhat.com>



WARNING: multiple messages have this Message-ID (diff)
From: James Morris <jmorris@redhat.com>
To: Mark Fasheh <mark.fasheh@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	ocfs2-devel@oss.oracle.com, torvalds@osdl.org, akpm@osdl.org,
	wim.coekaerts@oracle.com, lmb@suse.de
Subject: [Ocfs2-devel] Re: [RFC] [PATCH] OCFS2
Date: Thu Jun 23 13:03:40 2005	[thread overview]
Message-ID: <Xine.LNX.4.44.0506231358230.14123-100000@thoron.boston.redhat.com> (raw)
In-Reply-To: <20050518223303.GE1340@ca-server1.us.oracle.com>

On Wed, 18 May 2005, Mark Fasheh wrote:

> This is OCFS2, a shared disk cluster file system which we hope will be
> included in the kernel.

The masklog code looks potentially useful outside of ocfs2, as a general 
kernel facility.  Any chance of splitting it out?


Quibbles:

- A lot of the macros should probably be replaced with static inlines, 
like OCFS2_IS_VALID_DINODE.

- Approx. 80 typedefs.  ouch.



-- 
James Morris
<jmorris@redhat.com>

  parent reply	other threads:[~2005-06-23 18:03 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-18 17:33 [Ocfs2-devel] [RFC] [PATCH] OCFS2 Mark Fasheh
2005-05-18 22:33 ` Mark Fasheh
2005-05-18 19:56 ` [Ocfs2-devel] " Adrian Bunk
2005-05-18 23:40   ` Adrian Bunk
2005-05-18 20:26   ` [Ocfs2-devel] " Manish Singh
2005-05-19  1:26     ` Manish Singh
2005-05-19  4:59     ` Adrian Bunk
2005-05-19  9:45       ` Adrian Bunk
2005-05-19 10:24       ` 2.4 kernel threads linux
2005-05-19 10:39         ` Arjan van de Ven
2005-05-19 16:19         ` Jesse Barnes
2005-05-18 19:56 ` [Ocfs2-devel] Re: [RFC] [PATCH] OCFS2 Hans Reiser
2005-05-18 23:35   ` Hans Reiser
2005-05-18 23:28 ` [Ocfs2-devel] " Kyle Moffett
2005-05-19  2:30   ` Kyle Moffett
2005-05-18 23:30   ` [Ocfs2-devel] " Mark Fasheh
2005-05-19  4:30     ` Mark Fasheh
2005-05-19  1:52 ` [Ocfs2-devel] " Daniel Phillips
2005-05-19  6:30   ` Daniel Phillips
2005-05-19  1:54   ` [Ocfs2-devel] " Mark Fasheh
2005-05-19  6:54     ` Mark Fasheh
2005-05-19 11:19     ` [Ocfs2-devel] " Daniel Phillips
2005-05-19 16:23       ` Daniel Phillips
2005-05-19 10:26   ` Jeff Garzik
2005-05-19 15:09     ` [Ocfs2-devel] " Jeff Garzik
2005-05-19 15:09     ` Lee Revell
2005-05-19 15:20       ` Lee Revell
2005-05-19 15:09       ` [Ocfs2-devel] " Jeff Garzik
2005-05-19 15:25         ` Jeff Garzik
2005-06-23 13:03 ` James Morris [this message]
2005-06-23 18:03   ` James Morris
2005-06-23 13:29   ` [Ocfs2-devel] " Mark Fasheh
2005-06-23 18:29     ` Mark Fasheh
2005-06-24  3:05   ` Paul Jackson
2005-06-24 15:34     ` [Ocfs2-devel] " Paul Jackson
2005-06-23 23:00     ` Mark Fasheh
2005-06-24  3:59       ` Mark Fasheh
2005-06-24  4:17       ` Paul Jackson
2005-06-24 15:34         ` [Ocfs2-devel] " Paul Jackson
2005-06-24  3:29     ` Paul Jackson
2005-06-24 15:34       ` [Ocfs2-devel] " Paul Jackson
2005-06-21 21:14 Steve French
2005-06-21 22:03 ` Mark Fasheh
2005-06-21 22:43   ` Steve French
2005-06-22  0:04     ` Mark Fasheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Xine.LNX.4.44.0506231358230.14123-100000@thoron.boston.redhat.com \
    --to=jmorris@redhat.com \
    --cc=akpm@osdl.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lmb@suse.de \
    --cc=mark.fasheh@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=torvalds@osdl.org \
    --cc=wim.coekaerts@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.