Re: [RFC] [PATCH] OCFS2

From: Mark Fasheh <mark.fasheh@oracle.com>
To: James Morris <jmorris@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	ocfs2-devel@oss.oracle.com, torvalds@osdl.org, akpm@osdl.org,
	wim.coekaerts@oracle.com, lmb@suse.de
Subject: Re: [RFC] [PATCH] OCFS2
Date: Thu, 23 Jun 2005 11:29:01 -0700	[thread overview]
Message-ID: <20050623182901.GB8215@ca-server1.us.oracle.com> (raw)
In-Reply-To: <Xine.LNX.4.44.0506231358230.14123-100000@thoron.boston.redhat.com>

Hi James,

Thanks for looking over this.

On Thu, Jun 23, 2005 at 02:03:35PM -0400, James Morris wrote:
> The masklog code looks potentially useful outside of ocfs2, as a general 
> kernel facility.  Any chance of splitting it out?
Absolutely. We've found that stuff invaluable in debugging issues for a
while now, and as far as I recall, Zach wrote it with the idea that it could
be useful to other folks too. I think the only issue to resolve there would
be how other subsystems reserve a debugging bit...

> Quibbles:
> 
> - A lot of the macros should probably be replaced with static inlines, 
> like OCFS2_IS_VALID_DINODE.
> 
> - Approx. 80 typedefs.  ouch.
Heh, we're slowly removing those :)
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com