[U-Boot] [PATCH 9/9] at91rm9200ek: add dcc support with at91rm9200ek_dcc_config

From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 9/9] at91rm9200ek: add dcc support with at91rm9200ek_dcc_config
Date: Mon, 09 Mar 2009 00:28:55 +0100	[thread overview]
Message-ID: <20090308232855.F0539832E8B8@gemini.denx.de> (raw)
In-Reply-To: <1236089265-24598-9-git-send-email-plagnioj@jcrosoft.com>

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1236089265-24598-9-git-send-email-plagnioj@jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  Makefile                       |   14 +++++++++++++-
>  include/configs/at91rm9200ek.h |    4 +++-
>  2 files changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 50ce78e..c24115d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2605,8 +2605,20 @@ shannon_config	:	unconfig
>  at91rm9200dk_config	:	unconfig
>  	@$(MKCONFIG) $(@:_config=) arm arm920t at91rm9200dk atmel at91rm9200
>  
> +at91rm9200ek_dcc_multi_config	\
> +at91rm9200ek_dcc_config		\
>  at91rm9200ek_config	:	unconfig
> -	@$(MKCONFIG) $(@:_config=) arm arm920t at91rm9200ek atmel at91rm9200
> +	@mkdir -p $(obj)include
> +	@if [ "$(findstring _dcc_mutli, $@)" ] ; then \

It seems you never even tested this, or you should have noticed the
type ("mutli" != "multi").

> +		echo "#define CONFIG_ARM_DCC" >> $(obj)include/config.h ; \
> +		echo "#define CONFIG_ARM_DCC_MUTLI" >> $(obj)include/config.h ; \
> +		echo "#define CONFIG_CONSOLE_MUX" >> $(obj)include/config.h ; \
> +		$(XECHO) "... configured with dcc as multi serial"; \
> +	elif [ "$(findstring _dcc_, $@)" ] ; then \
> +		echo "#define CONFIG_ARM_DCC"	>>$(obj)include/config.h ; \
> +		$(XECHO) "... with dcc as serial" ; \
> +	fi;
> +	@$(MKCONFIG) -a at91rm9200ek arm arm920t at91rm9200ek atmel at91rm9200

CONFIG_ options shall not be added in the Makefile. these are user
changable settings that go into the board config file.

Also, please do not pollute the main Makefile with lots of such
things.

NAK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Never put off until tomorrow what you can put off indefinitely.