From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/9] at91rm9200: fix DCC support
Date: Mon, 9 Mar 2009 18:12:56 +0100 [thread overview]
Message-ID: <20090309171256.GB20714@game.jcrosoft.org> (raw)
In-Reply-To: <20090309155049.9398B832E8B8@gemini.denx.de>
On 16:50 Mon 09 Mar , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
>
> In message <20090309120954.GK24237@game.jcrosoft.org> you wrote:
> >
> > > > > The #ifdef above does not seem to depend on DCC at all?
> > >
> > > You did not answer this question.
> > >
> > > > > And what does it hurt if we always shut down the console? To me that
> > > > > looks clearer than an additional #ifdef.
> > the UART code is not active or compile so you can't do it.
>
> This statement makes no sense to me. If the #ifdef has any effect,
> then this code is actually compiled. What would happen if the
> statement would be executed?
>
> Actually this is a question I repeat in all my replies to your
> posting - what exactly is the problem with the current code? Does it
> cause crashes or so? Or is it just that you think it is not necessary
> because UARTs are not active?
It does not build because the serial driver of the rm9200 is not compiled
this code must be use only if this driver is compile not everytime
Best Regards,
J.
next prev parent reply other threads:[~2009-03-09 17:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 14:07 [U-Boot] [PATCH 1/9] at91sam9/cap9: use define instead hardcoded value for the USB_OHCI_REGS_BASE Jean-Christophe PLAGNIOL-VILLARD
2009-03-03 14:07 ` [U-Boot] [PATCH 2/9] AT91RM9200EK: fix broken boot from NOR flash Jean-Christophe PLAGNIOL-VILLARD
2009-03-03 14:07 ` [U-Boot] [PATCH 3/9] at91: rename DATAFLASH_MMC_SELECT to CONFIG_SYS_DATAFLASH_MMC_PIO Jean-Christophe PLAGNIOL-VILLARD
2009-03-03 14:07 ` [U-Boot] [PATCH 4/9] at91rm9200dk: Move conditional compilation to Makefile Jean-Christophe PLAGNIOL-VILLARD
2009-03-03 14:07 ` [U-Boot] [PATCH 5/9] Add support for the AT91RM9200EK Board Jean-Christophe PLAGNIOL-VILLARD
2009-03-03 14:07 ` [U-Boot] [PATCH 6/9] at91rm9200: move serial driver to drivers/serial Jean-Christophe PLAGNIOL-VILLARD
2009-03-03 14:07 ` [U-Boot] [PATCH 7/9] at91rm9200: fix DCC support Jean-Christophe PLAGNIOL-VILLARD
2009-03-03 14:07 ` [U-Boot] [PATCH 8/9] at91sam9263ek add dcc support with at91sam9263ek_dcc_config Jean-Christophe PLAGNIOL-VILLARD
2009-03-03 14:07 ` [U-Boot] [PATCH 9/9] at91rm9200ek: add dcc support with at91rm9200ek_dcc_config Jean-Christophe PLAGNIOL-VILLARD
2009-03-08 23:28 ` Wolfgang Denk
2009-03-08 23:33 ` [U-Boot] [PATCH 8/9] at91sam9263ek add dcc support with at91sam9263ek_dcc_config Wolfgang Denk
2009-03-09 8:35 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-09 11:19 ` Wolfgang Denk
2009-03-08 23:31 ` [U-Boot] [PATCH 7/9] at91rm9200: fix DCC support Wolfgang Denk
2009-03-09 8:36 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-09 11:19 ` Wolfgang Denk
2009-03-09 11:18 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-09 11:37 ` Wolfgang Denk
2009-03-09 12:09 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-09 15:50 ` Wolfgang Denk
2009-03-09 17:12 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-03-09 19:45 ` Wolfgang Denk
2009-03-08 23:26 ` [U-Boot] [PATCH 5/9] Add support for the AT91RM9200EK Board Wolfgang Denk
2009-03-09 8:37 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-09 11:19 ` Wolfgang Denk
2009-03-08 23:21 ` [U-Boot] [PATCH 1/9] at91sam9/cap9: use define instead hardcoded value for the USB_OHCI_REGS_BASE Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090309171256.GB20714@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.