[U-Boot] [PATCH 7/9] at91rm9200: fix DCC support

From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/9] at91rm9200: fix DCC support
Date: Mon, 09 Mar 2009 20:45:18 +0100	[thread overview]
Message-ID: <20090309194518.2591A832E8B8@gemini.denx.de> (raw)
In-Reply-To: <20090309171256.GB20714@game.jcrosoft.org>

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090309171256.GB20714@game.jcrosoft.org> you wrote:
>
> > Actually this is a question I  repeat  in  all  my  replies  to  your
> > posting  - what exactly is the problem with the current code? Does it
> > cause crashes or so? Or is it just that you think it is not necessary
> > because UARTs are not active?
> It does not build because the serial driver of the rm9200 is not compiled
> 
> this code must be use only if this driver is compile not everytime

We're discussing this part of your patch:

> +#if defined(CONFIG_DBGU) || defined(CONFIG_USART0) || defined(CONFIG_USART1)
>  	/*shutdown the console to avoid strange chars during reset */
>  	us->US_CR = (AT91C_US_RSTRX | AT91C_US_RSTTX);
> +#endif

I cannot see any reference to the serial driver in that. Do you really
want to tell me that this specific statement causes build problems?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Until you walk a mile in another man's moccasins, you  can't  imagine
the smell.