[PATCH] kfree(napi->skb) => kfree_skb

[PATCH] kfree(napi->skb) => kfree_skb

[Roel Kluin]

struct sk_buff pointers should be freed with kfree_skb.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
@@ -2669,11 +2669,11 @@ EXPORT_SYMBOL(netif_napi_add);
 void netif_napi_del(struct napi_struct *napi)
 {
 	struct sk_buff *skb, *next;
 
 	list_del_init(&napi->dev_list);
-	kfree(napi->skb);
+	kfree_skb(napi->skb);
 
 	for (skb = napi->gro_list; skb; skb = next) {
 		next = skb->next;
 		skb->next = NULL;
 		kfree_skb(skb);

Re: [PATCH] kfree(napi->skb) => kfree_skb

[David Miller]

From: Roel Kluin <roel.kluin@gmail.com>
Date: Tue, 17 Mar 2009 11:38:25 +0100

> struct sk_buff pointers should be freed with kfree_skb.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> @@ -2669,11 +2669,11 @@ EXPORT_SYMBOL(netif_napi_add);
>  void netif_napi_del(struct napi_struct *napi)
>  {

Roel, what did you use to generate this patch? :-/

If you hand-edited the patch, please check your work before sending it
out.

Re: [PATCH] kfree(napi->skb) => kfree_skb

[David Miller]

From: David Miller <davem@davemloft.net>
Date: Wed, 18 Mar 2009 23:10:43 -0700 (PDT)

> From: Roel Kluin <roel.kluin@gmail.com>
> Date: Tue, 17 Mar 2009 11:38:25 +0100
> 
> > struct sk_buff pointers should be freed with kfree_skb.
> > 
> > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> > ---
> > @@ -2669,11 +2669,11 @@ EXPORT_SYMBOL(netif_napi_add);
> >  void netif_napi_del(struct napi_struct *napi)
> >  {
> 
> Roel, what did you use to generate this patch? :-/
> 
> If you hand-edited the patch, please check your work before sending it
> out.

Don't bother resending Roel, I took care of it by hand.

Nobody is doing anything reasonably today, so I am just going
to start doing everything myself like I always seem to end
up doing :-/

Today sucks... so... much...