From: David Miller <davem@davemloft.net>
To: hpa@zytor.com
Cc: rdreier@cisco.com, h.mitake@gmail.com, mingo@elte.hu,
tglx@linutronix.de, rpjday@crashcourse.ca,
linux-kernel@vger.kernel.org
Subject: Re: arch/x86/Kconfig selects invalid HAVE_READQ, HAVE_WRITEQ vars
Date: Tue, 21 Apr 2009 17:27:54 -0700 (PDT) [thread overview]
Message-ID: <20090421.172754.210369267.davem@davemloft.net> (raw)
In-Reply-To: <49EE19E0.8040405@zytor.com>
From: "H. Peter Anvin" <hpa@zytor.com>
Date: Tue, 21 Apr 2009 12:09:20 -0700
> Do you really expect driver authors to type writeq_nonatomic() for
> every register reference?
They'll write local driver macros, as every driver does
to save typing. It also allows to get rid of the
redundant "foop->regs" in every register access too.
Look at what all of these drivers do:
#define nr64(reg) readq(np->regs + (reg))
#define nw64(reg, val) writeq((val), np->regs + (reg))
So nobody actually types readq() for every register access,
just as they don't type foop->regs for every register access
either :-)
next prev parent reply other threads:[~2009-04-22 0:28 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 19:45 arch/x86/Kconfig selects invalid HAVE_READQ, HAVE_WRITEQ vars Robert P. J. Day
2009-04-19 21:12 ` Roland Dreier
2009-04-19 21:46 ` Ingo Molnar
2009-04-19 22:02 ` H. Peter Anvin
2009-04-19 22:35 ` Ingo Molnar
2009-04-20 0:56 ` Roland Dreier
2009-04-20 2:08 ` Robert Hancock
2009-04-20 0:53 ` Roland Dreier
2009-04-20 1:20 ` H. Peter Anvin
2009-04-20 10:53 ` Ingo Molnar
2009-04-20 14:47 ` Hitoshi Mitake
2009-04-20 16:03 ` Ingo Molnar
2009-04-21 8:33 ` Hitoshi Mitake
2009-04-21 8:45 ` Ingo Molnar
2009-04-21 8:57 ` Hitoshi Mitake
2009-04-21 15:44 ` H. Peter Anvin
2009-04-21 17:07 ` Roland Dreier
2009-04-21 17:19 ` H. Peter Anvin
2009-04-21 17:23 ` Roland Dreier
2009-04-21 19:09 ` H. Peter Anvin
2009-04-21 21:11 ` Roland Dreier
2009-04-21 21:16 ` H. Peter Anvin
2009-04-22 0:31 ` David Miller
2009-04-28 19:05 ` [PATCH] x86: Remove readq()/writeq() on 32-bit Roland Dreier
2009-04-29 5:12 ` David Miller
2009-04-29 11:56 ` Ingo Molnar
2009-04-29 12:10 ` Jeff Garzik
2009-04-29 17:25 ` Roland Dreier
2009-04-29 19:59 ` Jeff Garzik
2009-05-13 5:32 ` Hitoshi Mitake
2009-05-13 20:19 ` H. Peter Anvin
2009-05-13 22:39 ` Jeff Garzik
2009-05-13 23:39 ` H. Peter Anvin
2009-05-14 0:49 ` Jeff Garzik
2009-05-14 7:19 ` Hitoshi Mitake
2009-05-15 23:44 ` Jeff Garzik
2009-05-17 7:12 ` Hitoshi Mitake
2009-05-17 8:06 ` Jeff Garzik
2009-05-21 11:35 ` Hitoshi Mitake
2009-05-21 11:49 ` Hitoshi Mitake
2009-05-13 20:42 ` Jeff Garzik
2009-05-13 21:05 ` H. Peter Anvin
2009-05-13 21:30 ` Jeff Garzik
2009-05-13 21:31 ` Jeff Garzik
2009-05-13 21:54 ` H. Peter Anvin
2009-05-13 22:06 ` Roland Dreier
2009-05-13 22:29 ` Jeff Garzik
2009-04-29 17:21 ` Roland Dreier
2009-04-22 0:27 ` David Miller [this message]
2009-04-22 0:25 ` arch/x86/Kconfig selects invalid HAVE_READQ, HAVE_WRITEQ vars David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090421.172754.210369267.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=h.mitake@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdreier@cisco.com \
--cc=rpjday@crashcourse.ca \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.