Re: [PATCH V4 1/5] The macro spin_event_timeout() takes a condition and timeout value

From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
	alsa-devel@alsa-project.org, Timur Tabi <timur@freescale.com>,
	broonie@sirena.org.uk
Subject: Re: [PATCH V4 1/5] The macro spin_event_timeout() takes a condition and timeout value
Date: Tue, 26 May 2009 13:49:48 +0100	[thread overview]
Message-ID: <200905261349.49832.arnd@arndb.de> (raw)
In-Reply-To: <alpine.LRH.2.00.0905261348160.4897@vixen.sonytel.be>

On Tuesday 26 May 2009, Geert Uytterhoeven wrote:
> However, you can still improve useability by making the macro return the rc,
> instead of letting the caller pass it, cfr. wait_event_timeout() and friends.

Either that, or it should at least use the do { ... } while (0) construct
to make the macro a statement. All multi-line macros need to either
use ({ ... }) or do { ... } while (0) to make sure they behave well.

	Arnd <><