All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: grant.likely@secretlab.ca, linuxppc-dev@ozlabs.org,
	alsa-devel@alsa-project.org, timur@freescale.com
Subject: Re: [PATCH V4 0/5] AC97 driver for mpc5200
Date: Tue, 26 May 2009 12:04:43 +0100	[thread overview]
Message-ID: <20090526110443.GB8969@sirena.org.uk> (raw)
In-Reply-To: <20090525221406.21370.30326.stgit@terra>

On Mon, May 25, 2009 at 06:15:05PM -0400, Jon Smirl wrote:

> reset retries. Removing the retries makes the driver fail to load about 5% of the time. An oscilliscope is 

Please also send a patch sorting this out in the STAC9766 driver as
requested.  Other than that and the udelay() thing it looks like we can
merge this now - there's the reset issue and probably other things to
clean up but it'd be better to do those as incremental patches.

> needed to figure out what is going on with failed resets. Both pcm030 and Efika ocasionally fail to reset 
> and they use different codec chips.

Like I say, it may be worth checking into the startup of the master
clock for the CODECs, especially if it's an output from the SoC on both
boards.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org,
	timur@freescale.com
Subject: Re: [alsa-devel] [PATCH V4 0/5] AC97 driver for mpc5200
Date: Tue, 26 May 2009 12:04:43 +0100	[thread overview]
Message-ID: <20090526110443.GB8969@sirena.org.uk> (raw)
In-Reply-To: <20090525221406.21370.30326.stgit@terra>

On Mon, May 25, 2009 at 06:15:05PM -0400, Jon Smirl wrote:

> reset retries. Removing the retries makes the driver fail to load about 5% of the time. An oscilliscope is 

Please also send a patch sorting this out in the STAC9766 driver as
requested.  Other than that and the udelay() thing it looks like we can
merge this now - there's the reset issue and probably other things to
clean up but it'd be better to do those as incremental patches.

> needed to figure out what is going on with failed resets. Both pcm030 and Efika ocasionally fail to reset 
> and they use different codec chips.

Like I say, it may be worth checking into the startup of the master
clock for the CODECs, especially if it's an output from the SoC on both
boards.

  parent reply	other threads:[~2009-05-26 11:04 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-25 22:15 [PATCH V4 0/5] AC97 driver for mpc5200 Jon Smirl
2009-05-25 22:15 ` [PATCH V4 1/5] The macro spin_event_timeout() takes a condition and timeout value Jon Smirl
2009-05-25 22:15   ` Jon Smirl
2009-05-26  7:29   ` Geert Uytterhoeven
2009-05-26 11:32     ` Timur Tabi
2009-05-26 11:32       ` Timur Tabi
2009-05-26 11:51       ` Geert Uytterhoeven
2009-05-26 12:49         ` Arnd Bergmann
2009-05-26 14:20           ` Timur Tabi
2009-05-26 14:20             ` Timur Tabi
2009-05-25 22:15 ` [PATCH V4 2/5] Main rewite of the mpc5200 audio DMA code Jon Smirl
2009-05-26 11:01   ` [alsa-devel] " Mark Brown
2009-05-26 16:51     ` Grant Likely
2009-05-26 16:53       ` Jon Smirl
2009-05-26 16:53         ` [alsa-devel] " Jon Smirl
2009-05-26 16:56         ` Grant Likely
2009-05-26 16:56           ` [alsa-devel] " Grant Likely
2009-05-26 17:08         ` Timur Tabi
2009-05-26 17:08           ` [alsa-devel] " Timur Tabi
2009-05-26 20:21           ` Mark Brown
2009-05-25 22:15 ` [PATCH V4 3/5] AC97 driver for mpc5200 Jon Smirl
2009-05-26  3:41   ` Timur Tabi
2009-05-26  3:41     ` [alsa-devel] " Timur Tabi
2009-05-26  3:47     ` Grant Likely
2009-05-26  3:47       ` [alsa-devel] " Grant Likely
2009-05-25 22:15 ` [PATCH V4 4/5] Support for AC97 on Phytec pmc030 base board Jon Smirl
2009-05-25 22:15 ` [PATCH V4 5/5] Fabric bindings for STAC9766 on the Efika Jon Smirl
2009-05-26  3:44 ` [alsa-devel] [PATCH V4 0/5] AC97 driver for mpc5200 Timur Tabi
2009-05-26  3:44   ` Timur Tabi
2009-05-26  9:21   ` Mark Brown
2009-05-26  9:21     ` [alsa-devel] " Mark Brown
2009-05-26 11:08   ` Jon Smirl
2009-05-26 11:08     ` Jon Smirl
2009-05-26 11:39     ` Timur Tabi
2009-05-26 11:39       ` [alsa-devel] " Timur Tabi
2009-05-26 11:43     ` Mark Brown
2009-05-26 11:43       ` [alsa-devel] " Mark Brown
2009-05-26 11:04 ` Mark Brown [this message]
2009-05-26 11:04   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090526110443.GB8969@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jonsmirl@gmail.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.