From: Grant Likely <grant.likely@secretlab.ca>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org,
broonie@sirena.org.uk
Subject: Re: [PATCH V4 3/5] AC97 driver for mpc5200
Date: Mon, 25 May 2009 21:47:24 -0600 [thread overview]
Message-ID: <fa686aa40905252047g6c88efa9t2b9b864f2d2023f9@mail.gmail.com> (raw)
In-Reply-To: <ed82fe3e0905252041u367cac2fk80c9316c0236e340@mail.gmail.com>
On Mon, May 25, 2009 at 9:41 PM, Timur Tabi <timur@freescale.com> wrote:
> On Mon, May 25, 2009 at 5:15 PM, Jon Smirl <jonsmirl@gmail.com> wrote:
>
>> + spin_event_timeout(1, 3, 0, rc);
>
> Ugh, don't do this. Just use udelay!
heh; indeed. My objection to udelay is that it burns cycles it the
test loop that could be used to decide whether or not the loop is
complete. Not an issue when the explicit goal is to burn a fixed
number of cycles.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org,
broonie@sirena.org.uk
Subject: Re: [alsa-devel] [PATCH V4 3/5] AC97 driver for mpc5200
Date: Mon, 25 May 2009 21:47:24 -0600 [thread overview]
Message-ID: <fa686aa40905252047g6c88efa9t2b9b864f2d2023f9@mail.gmail.com> (raw)
In-Reply-To: <ed82fe3e0905252041u367cac2fk80c9316c0236e340@mail.gmail.com>
On Mon, May 25, 2009 at 9:41 PM, Timur Tabi <timur@freescale.com> wrote:
> On Mon, May 25, 2009 at 5:15 PM, Jon Smirl <jonsmirl@gmail.com> wrote:
>
>> + =A0 =A0 =A0 spin_event_timeout(1, 3, 0, rc);
>
> Ugh, don't do this. =A0Just use udelay!
heh; indeed. My objection to udelay is that it burns cycles it the
test loop that could be used to decide whether or not the loop is
complete. Not an issue when the explicit goal is to burn a fixed
number of cycles.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-05-26 3:47 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 22:15 [PATCH V4 0/5] AC97 driver for mpc5200 Jon Smirl
2009-05-25 22:15 ` [PATCH V4 1/5] The macro spin_event_timeout() takes a condition and timeout value Jon Smirl
2009-05-25 22:15 ` Jon Smirl
2009-05-26 7:29 ` Geert Uytterhoeven
2009-05-26 11:32 ` Timur Tabi
2009-05-26 11:32 ` Timur Tabi
2009-05-26 11:51 ` Geert Uytterhoeven
2009-05-26 12:49 ` Arnd Bergmann
2009-05-26 14:20 ` Timur Tabi
2009-05-26 14:20 ` Timur Tabi
2009-05-25 22:15 ` [PATCH V4 2/5] Main rewite of the mpc5200 audio DMA code Jon Smirl
2009-05-26 11:01 ` [alsa-devel] " Mark Brown
2009-05-26 16:51 ` Grant Likely
2009-05-26 16:53 ` Jon Smirl
2009-05-26 16:53 ` [alsa-devel] " Jon Smirl
2009-05-26 16:56 ` Grant Likely
2009-05-26 16:56 ` [alsa-devel] " Grant Likely
2009-05-26 17:08 ` Timur Tabi
2009-05-26 17:08 ` [alsa-devel] " Timur Tabi
2009-05-26 20:21 ` Mark Brown
2009-05-25 22:15 ` [PATCH V4 3/5] AC97 driver for mpc5200 Jon Smirl
2009-05-26 3:41 ` Timur Tabi
2009-05-26 3:41 ` [alsa-devel] " Timur Tabi
2009-05-26 3:47 ` Grant Likely [this message]
2009-05-26 3:47 ` Grant Likely
2009-05-25 22:15 ` [PATCH V4 4/5] Support for AC97 on Phytec pmc030 base board Jon Smirl
2009-05-25 22:15 ` [PATCH V4 5/5] Fabric bindings for STAC9766 on the Efika Jon Smirl
2009-05-26 3:44 ` [alsa-devel] [PATCH V4 0/5] AC97 driver for mpc5200 Timur Tabi
2009-05-26 3:44 ` Timur Tabi
2009-05-26 9:21 ` Mark Brown
2009-05-26 9:21 ` [alsa-devel] " Mark Brown
2009-05-26 11:08 ` Jon Smirl
2009-05-26 11:08 ` Jon Smirl
2009-05-26 11:39 ` Timur Tabi
2009-05-26 11:39 ` [alsa-devel] " Timur Tabi
2009-05-26 11:43 ` Mark Brown
2009-05-26 11:43 ` [alsa-devel] " Mark Brown
2009-05-26 11:04 ` Mark Brown
2009-05-26 11:04 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40905252047g6c88efa9t2b9b864f2d2023f9@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.