From: Jon Smirl <jonsmirl@gmail.com> To: Grant Likely <grant.likely@secretlab.ca> Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org, Mark Brown <broonie@opensource.wolfsonmicro.com>, timur@freescale.com Subject: Re: [PATCH V4 2/5] Main rewite of the mpc5200 audio DMA code Date: Tue, 26 May 2009 12:53:07 -0400 [thread overview] Message-ID: <9e4733910905260953i6337f8a9xc3cd1ff490cd3540@mail.gmail.com> (raw) In-Reply-To: <fa686aa40905260951g5115007fo3ef5eb1fb90998f3@mail.gmail.com> On Tue, May 26, 2009 at 12:51 PM, Grant Likely <grant.likely@secretlab.ca> wrote: > On Tue, May 26, 2009 at 5:01 AM, Mark Brown > <broonie@opensource.wolfsonmicro.com> wrote: >> On Mon, May 25, 2009 at 06:15:09PM -0400, Jon Smirl wrote: >>> Rewrite the mpc5200 audio DMA code to support both I2S and AC97. >>> >>> Signed-off-by: Jon Smirl <jonsmirl@gmail.com> >> >> Grant, I'm OK with that if you are? > > Acked-by: Grant Likely <grant.likely@secretlab.ca> Put in the V5 version this one has this in the h file: -int psc_dma_trigger(struct snd_pcm_substream *substream, int cmd, - struct snd_soc_dai *dai); +/* whack this after Timur's patch is merged in to arch/powerpc/include/asm/delay.h */ +#define spin_event_timeout(condition, timeout, delay, rc) \ +{ \ + unsigned long __loops = tb_ticks_per_usec * timeout; \ + unsigned long __start = get_tbl(); \ + while ((rc = (condition)) && (tb_ticks_since(__start) <= __loops)) \ + if (delay) \ + udelay(delay); \ + else \ + cpu_relax(); \ +} +/* whack this after Timur's patch is merged in to arch/powerpc/include/asm/delay.h */ > > > > > -- > Grant Likely, B.Sc., P.Eng. > Secret Lab Technologies Ltd. > -- Jon Smirl jonsmirl@gmail.com
WARNING: multiple messages have this Message-ID (diff)
From: Jon Smirl <jonsmirl@gmail.com> To: Grant Likely <grant.likely@secretlab.ca> Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org, Mark Brown <broonie@opensource.wolfsonmicro.com>, timur@freescale.com Subject: Re: [alsa-devel] [PATCH V4 2/5] Main rewite of the mpc5200 audio DMA code Date: Tue, 26 May 2009 12:53:07 -0400 [thread overview] Message-ID: <9e4733910905260953i6337f8a9xc3cd1ff490cd3540@mail.gmail.com> (raw) In-Reply-To: <fa686aa40905260951g5115007fo3ef5eb1fb90998f3@mail.gmail.com> On Tue, May 26, 2009 at 12:51 PM, Grant Likely <grant.likely@secretlab.ca> wrote: > On Tue, May 26, 2009 at 5:01 AM, Mark Brown > <broonie@opensource.wolfsonmicro.com> wrote: >> On Mon, May 25, 2009 at 06:15:09PM -0400, Jon Smirl wrote: >>> Rewrite the mpc5200 audio DMA code to support both I2S and AC97. >>> >>> Signed-off-by: Jon Smirl <jonsmirl@gmail.com> >> >> Grant, I'm OK with that if you are? > > Acked-by: Grant Likely <grant.likely@secretlab.ca> Put in the V5 version this one has this in the h file: -int psc_dma_trigger(struct snd_pcm_substream *substream, int cmd, - struct snd_soc_dai *dai); +/* whack this after Timur's patch is merged in to arch/powerpc/include/asm/delay.h */ +#define spin_event_timeout(condition, timeout, delay, rc) \ +{ \ + unsigned long __loops = tb_ticks_per_usec * timeout; \ + unsigned long __start = get_tbl(); \ + while ((rc = (condition)) && (tb_ticks_since(__start) <= __loops)) \ + if (delay) \ + udelay(delay); \ + else \ + cpu_relax(); \ +} +/* whack this after Timur's patch is merged in to arch/powerpc/include/asm/delay.h */ > > > > > -- > Grant Likely, B.Sc., P.Eng. > Secret Lab Technologies Ltd. > -- Jon Smirl jonsmirl@gmail.com
next prev parent reply other threads:[~2009-05-26 16:53 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-05-25 22:15 [PATCH V4 0/5] AC97 driver for mpc5200 Jon Smirl 2009-05-25 22:15 ` [PATCH V4 1/5] The macro spin_event_timeout() takes a condition and timeout value Jon Smirl 2009-05-25 22:15 ` Jon Smirl 2009-05-26 7:29 ` Geert Uytterhoeven 2009-05-26 11:32 ` Timur Tabi 2009-05-26 11:32 ` Timur Tabi 2009-05-26 11:51 ` Geert Uytterhoeven 2009-05-26 12:49 ` Arnd Bergmann 2009-05-26 14:20 ` Timur Tabi 2009-05-26 14:20 ` Timur Tabi 2009-05-25 22:15 ` [PATCH V4 2/5] Main rewite of the mpc5200 audio DMA code Jon Smirl 2009-05-26 11:01 ` [alsa-devel] " Mark Brown 2009-05-26 16:51 ` Grant Likely 2009-05-26 16:53 ` Jon Smirl [this message] 2009-05-26 16:53 ` Jon Smirl 2009-05-26 16:56 ` Grant Likely 2009-05-26 16:56 ` [alsa-devel] " Grant Likely 2009-05-26 17:08 ` Timur Tabi 2009-05-26 17:08 ` [alsa-devel] " Timur Tabi 2009-05-26 20:21 ` Mark Brown 2009-05-25 22:15 ` [PATCH V4 3/5] AC97 driver for mpc5200 Jon Smirl 2009-05-26 3:41 ` Timur Tabi 2009-05-26 3:41 ` [alsa-devel] " Timur Tabi 2009-05-26 3:47 ` Grant Likely 2009-05-26 3:47 ` [alsa-devel] " Grant Likely 2009-05-25 22:15 ` [PATCH V4 4/5] Support for AC97 on Phytec pmc030 base board Jon Smirl 2009-05-25 22:15 ` [PATCH V4 5/5] Fabric bindings for STAC9766 on the Efika Jon Smirl 2009-05-26 3:44 ` [alsa-devel] [PATCH V4 0/5] AC97 driver for mpc5200 Timur Tabi 2009-05-26 3:44 ` Timur Tabi 2009-05-26 9:21 ` Mark Brown 2009-05-26 9:21 ` [alsa-devel] " Mark Brown 2009-05-26 11:08 ` Jon Smirl 2009-05-26 11:08 ` Jon Smirl 2009-05-26 11:39 ` Timur Tabi 2009-05-26 11:39 ` [alsa-devel] " Timur Tabi 2009-05-26 11:43 ` Mark Brown 2009-05-26 11:43 ` [alsa-devel] " Mark Brown 2009-05-26 11:04 ` Mark Brown 2009-05-26 11:04 ` [alsa-devel] " Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9e4733910905260953i6337f8a9xc3cd1ff490cd3540@mail.gmail.com \ --to=jonsmirl@gmail.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@opensource.wolfsonmicro.com \ --cc=grant.likely@secretlab.ca \ --cc=linuxppc-dev@ozlabs.org \ --cc=timur@freescale.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.