All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
Cc: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>,
	Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>,
	Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
	Anton Blanchard <anton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
	general-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	Jeff Squyres <jsquyres-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Subject: Re: [ofa-general] Re: [GIT PULL] please pull ummunotify
Date: Tue, 13 Oct 2009 10:27:25 -0600	[thread overview]
Message-ID: <20091013162725.GL18578@obsidianresearch.com> (raw)
In-Reply-To: <20091013064006.GC9470-X9Un+BFzKDI@public.gmane.org>

On Tue, Oct 13, 2009 at 08:40:06AM +0200, Ingo Molnar wrote:
> 
> * Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote:
> 
> > On Mon, Oct 12, 2009 at 10:20:46PM +0200, Ingo Molnar wrote:
> > > It might be more acceptable because the flag-hint mechanism can at most 
> > > cause over-flushing - while with perf events we might miss to invalidate 
> > > a range altogether.
> > 
> > Right. Overflushing is not important, but missing an event entirely is 
> > not recoverable (at least within the current kernel APIs).
> 
> So if we detect event loss in the perf event case (should not happen 
> with sufficient buffering but it is a possibility the code should be 
> prepared for) then we can just flush the [0,-1ULL] range, right?

No, the reason overflushing within a registration is OK is because of
how the MPI APIs are defined and typically used. The map and
registration window will typically be 1:1 ie you malloc something and
then register it. It is an error to register beyond your malloced
space. So, in truth, the hint stuff isn't really essential for MPI.

flushing all ranges would result in data loss since ranges may be in
use at the time, and 'flush' is actually unregister/reregister - the
hardware cannot do in place atomic modify.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Pavel Machek <pavel@ucw.cz>, Roland Dreier <rdreier@cisco.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	Paul Mackerras <paulus@samba.org>,
	Anton Blanchard <anton@samba.org>,
	general@lists.openfabrics.org, akpm@linux-foundation.org,
	torvalds@linux-foundation.org, Jeff Squyres <jsquyres@cisco.com>
Subject: Re: [ofa-general] Re: [GIT PULL] please pull ummunotify
Date: Tue, 13 Oct 2009 10:27:25 -0600	[thread overview]
Message-ID: <20091013162725.GL18578@obsidianresearch.com> (raw)
In-Reply-To: <20091013064006.GC9470@elte.hu>

On Tue, Oct 13, 2009 at 08:40:06AM +0200, Ingo Molnar wrote:
> 
> * Jason Gunthorpe <jgunthorpe@obsidianresearch.com> wrote:
> 
> > On Mon, Oct 12, 2009 at 10:20:46PM +0200, Ingo Molnar wrote:
> > > It might be more acceptable because the flag-hint mechanism can at most 
> > > cause over-flushing - while with perf events we might miss to invalidate 
> > > a range altogether.
> > 
> > Right. Overflushing is not important, but missing an event entirely is 
> > not recoverable (at least within the current kernel APIs).
> 
> So if we detect event loss in the perf event case (should not happen 
> with sufficient buffering but it is a possibility the code should be 
> prepared for) then we can just flush the [0,-1ULL] range, right?

No, the reason overflushing within a registration is OK is because of
how the MPI APIs are defined and typically used. The map and
registration window will typically be 1:1 ie you malloc something and
then register it. It is an error to register beyond your malloced
space. So, in truth, the hint stuff isn't really essential for MPI.

flushing all ranges would result in data loss since ranges may be in
use at the time, and 'flush' is actually unregister/reregister - the
hardware cannot do in place atomic modify.

Jason

  parent reply	other threads:[~2009-10-13 16:27 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-11  4:38 [GIT PULL] please pull ummunotify Roland Dreier
2009-09-11  4:38 ` Roland Dreier
2009-09-15 11:34 ` Pavel Machek
     [not found]   ` <20090915113434.GF1328-+ZI9xUNit7I@public.gmane.org>
2009-09-15 14:57     ` [ofa-general] " Roland Dreier
2009-09-15 14:57       ` Roland Dreier
     [not found]       ` <ada7hw0gsqz.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-09-28 20:49         ` Pavel Machek
2009-09-28 20:49           ` Pavel Machek
     [not found]           ` <20090928204923.GA1960-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2009-09-28 21:40             ` Jason Gunthorpe
2009-09-28 21:40               ` Jason Gunthorpe
     [not found] ` <aday6omhz9d.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-09-11  5:56   ` KOSAKI Motohiro
2009-09-11  5:56     ` KOSAKI Motohiro
2009-09-11  6:03     ` [ofa-general] " Roland Dreier
2009-09-11  6:03       ` Roland Dreier
     [not found]       ` <adatyzahvbm.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-09-11  6:11         ` KOSAKI Motohiro
2009-09-11  6:11           ` KOSAKI Motohiro
     [not found]           ` <20090911150552.DB68.A69D9226-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-09-11 16:42             ` Gleb Natapov
2009-09-11 16:42               ` Gleb Natapov
2009-09-11  6:15       ` Brice Goglin
     [not found]         ` <4AA9EAF7.5010401-MZpvjPyXg2s@public.gmane.org>
2009-09-11  6:21           ` KOSAKI Motohiro
2009-09-11  6:21             ` KOSAKI Motohiro
2009-09-11  6:22           ` Roland Dreier
2009-09-11  6:22             ` Roland Dreier
2009-09-11  6:40             ` [ofa-general] " Jason Gunthorpe
2009-09-11  6:40               ` Jason Gunthorpe
     [not found]               ` <20090911064019.GZ4973-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2009-09-11 16:58                 ` Roland Dreier
2009-09-11 16:58                   ` Roland Dreier
     [not found]                   ` <adaljklifkt.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-09-15  7:03                     ` KOSAKI Motohiro
2009-09-15  7:03                       ` KOSAKI Motohiro
2009-09-15  8:27                       ` Roland Dreier
2009-09-15  8:27                         ` Roland Dreier
2009-09-15 12:38                       ` Jeff Squyres
2009-09-15 12:38                         ` Jeff Squyres
2009-09-16 16:30   ` Roland Dreier
2009-09-16 16:30     ` Roland Dreier
2009-09-16 16:40     ` [ofa-general] " Linus Torvalds
2009-09-16 16:40       ` Linus Torvalds
2009-09-17 11:30   ` Peter Zijlstra
2009-09-17 11:30     ` Peter Zijlstra
2009-09-17 14:24     ` [ofa-general] " Roland Dreier
     [not found]       ` <adafxalejiq.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-09-17 14:32         ` Roland Dreier
2009-09-17 14:32           ` Roland Dreier
     [not found]           ` <adaab0tej5c.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-09-17 14:49             ` Peter Zijlstra
2009-09-17 14:49               ` Peter Zijlstra
2009-09-17 15:03               ` Roland Dreier
2009-09-17 15:03                 ` Roland Dreier
     [not found]                 ` <adazl8td35u.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-09-17 15:22                   ` Peter Zijlstra
2009-09-17 15:22                     ` Peter Zijlstra
2009-09-17 15:45                   ` Roland Dreier
2009-09-17 15:45                     ` Roland Dreier
     [not found]                     ` <adatyz1d17q.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-09-18 11:50                       ` Ingo Molnar
2009-09-18 11:50                         ` Ingo Molnar
2009-09-29 17:13                       ` Pavel Machek
2009-09-29 17:13                         ` Pavel Machek
     [not found]                         ` <20090929171332.GD14405-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2009-09-30  9:44                           ` Ingo Molnar
2009-09-30  9:44                             ` Ingo Molnar
     [not found]                             ` <20090930094456.GD24621-X9Un+BFzKDI@public.gmane.org>
2009-09-30 16:02                               ` Jason Gunthorpe
2009-09-30 16:02                                 ` Jason Gunthorpe
     [not found]                                 ` <20090930160232.GZ22310-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2009-10-12 18:19                                   ` Ingo Molnar
2009-10-12 18:19                                     ` Ingo Molnar
     [not found]                                     ` <20091012181944.GF17138-X9Un+BFzKDI@public.gmane.org>
2009-10-12 19:30                                       ` Jason Gunthorpe
2009-10-12 19:30                                         ` Jason Gunthorpe
2009-10-12 20:20                                         ` Ingo Molnar
     [not found]                                           ` <20091012202046.GA7648-X9Un+BFzKDI@public.gmane.org>
2009-10-13  4:05                                             ` Jason Gunthorpe
2009-10-13  4:05                                               ` Jason Gunthorpe
2009-10-13  6:40                                               ` Ingo Molnar
     [not found]                                                 ` <20091013064006.GC9470-X9Un+BFzKDI@public.gmane.org>
2009-10-13 16:27                                                   ` Jason Gunthorpe [this message]
2009-10-13 16:27                                                     ` Jason Gunthorpe
2009-10-13  5:43                                           ` Brice Goglin
     [not found]                                             ` <4AD41373.8010108-MZpvjPyXg2s@public.gmane.org>
2009-10-13  6:38                                               ` Ingo Molnar
2009-10-13  6:38                                                 ` Ingo Molnar
2009-09-30 17:06                               ` Roland Dreier
2009-09-30 17:06                                 ` Roland Dreier
2009-10-02 16:32                               ` Roland Dreier
2009-10-02 16:32                                 ` Roland Dreier
     [not found]                                 ` <ada3a61rc3j.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-10-02 20:45                                   ` Pavel Machek
2009-10-02 20:45                                     ` Pavel Machek
2009-10-07 22:34                                   ` Roland Dreier
2009-10-07 22:34                                     ` Roland Dreier
     [not found]                                     ` <ada3a5uq1dk.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-10-12 17:33                                       ` Peter Zijlstra
2009-10-12 17:33                                         ` Peter Zijlstra
2009-09-17 14:43         ` Peter Zijlstra
2009-09-17 14:43           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091013162725.GL18578@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=anton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
    --cc=general-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org \
    --cc=jsquyres-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mingo-X9Un+BFzKDI@public.gmane.org \
    --cc=paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
    --cc=pavel-+ZI9xUNit7I@public.gmane.org \
    --cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
    --cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.