From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com> To: "Bruno Prémont" <bonbons@linux-vserver.org> Cc: Andrew Morton <akpm@linux-foundation.org>, Greg Kroah-Hartman <gregkh@suse.de>, Daniel Oliveira Nascimento <don@syst.com.br>, Len Brown <len.brown@intel.com>, Anisse Astier <anisse@astier.eu>, Thomas Renninger <trenn@suse.de>, Matt Chen <machen@novell.com>, Harald Welte <laforge@gnumonks.org>, Martin Lucina <mato@kotelna.sk>, Bjorn Helgaas <bjorn.helgaas@hp.com>, pancho horrillo <pancho@pancho.name>, Mike Frysinger <vapier@gentoo.org>, Vivek Kutal <vivek.kutal@azingo.com>, Michael Hennerich <michael.hennerich@analog.com>, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 3/3] backlight: fix missing/incomplete registration failure handling Date: Sun, 21 Feb 2010 10:35:29 -0300 [thread overview] Message-ID: <20100221133528.GB1840@holoscopio.com> (raw) In-Reply-To: <20100221002831.689bace8@neptune.home> [-- Attachment #1: Type: text/plain, Size: 4893 bytes --] On Sun, Feb 21, 2010 at 12:28:31AM +0100, Bruno Prémont wrote: > Check newly registered backlight_device for error and properly > return error to parent > > Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org> > --- > drivers/platform/x86/classmate-laptop.c | 2 ++ > drivers/platform/x86/msi-wmi.c | 4 +++- > drivers/platform/x86/panasonic-laptop.c | 4 +++- > drivers/usb/misc/appledisplay.c | 1 + > drivers/video/bf54x-lq043fb.c | 8 ++++++++ > drivers/video/bfin-t350mcqb-fb.c | 8 ++++++++ > 6 files changed, 25 insertions(+), 2 deletions(-) > I think you should split the patch for every driver. Then, every mantainer may ack only its particular section of the patch. > diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c > index bfae789..66f6aad 100644 > --- a/drivers/platform/x86/classmate-laptop.c > +++ b/drivers/platform/x86/classmate-laptop.c > @@ -463,6 +463,8 @@ static int cmpc_bl_add(struct acpi_device *acpi) > > bd = backlight_device_register("cmpc_bl", &acpi->dev, > acpi->handle, &cmpc_bl_ops); > + if (IS_ERR(bd)) > + return PTR_ERR(bd); > bd->props.max_brightness = 7; > dev_set_drvdata(&acpi->dev, bd); > return 0; > diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c > index 5f7cff1..2ffbfcf 100644 > --- a/drivers/platform/x86/msi-wmi.c > +++ b/drivers/platform/x86/msi-wmi.c > @@ -251,8 +251,10 @@ static int __init msi_wmi_init(void) > if (!acpi_video_backlight_support()) { > backlight = backlight_device_register(DRV_NAME, > NULL, NULL, &msi_backlight_ops); > - if (IS_ERR(backlight)) > + if (IS_ERR(backlight)) { > + err = PTR_ERR(backlight); > goto err_free_input; > + } > > backlight->props.max_brightness = ARRAY_SIZE(backlight_map) - 1; > err = bl_get(NULL); > diff --git a/drivers/platform/x86/panasonic-laptop.c b/drivers/platform/x86/panasonic-laptop.c > index 9012d8d..9b17343 100644 > --- a/drivers/platform/x86/panasonic-laptop.c > +++ b/drivers/platform/x86/panasonic-laptop.c > @@ -644,8 +644,10 @@ static int acpi_pcc_hotkey_add(struct acpi_device *device) > /* initialize backlight */ > pcc->backlight = backlight_device_register("panasonic", NULL, pcc, > &pcc_backlight_ops); > - if (IS_ERR(pcc->backlight)) > + if (IS_ERR(pcc->backlight)) { > + result = PTR_ERR(pcc->backlight); > goto out_input; > + } > > if (!acpi_pcc_retrieve_biosdata(pcc, pcc->sinf)) { > ACPI_DEBUG_PRINT((ACPI_DB_ERROR, > diff --git a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c > index ef79ca2..413f154 100644 > --- a/drivers/usb/misc/appledisplay.c > +++ b/drivers/usb/misc/appledisplay.c > @@ -283,6 +283,7 @@ static int appledisplay_probe(struct usb_interface *iface, > &appledisplay_bl_data); > if (IS_ERR(pdata->bd)) { > dev_err(&iface->dev, "Backlight registration failed\n"); > + retval = PTR_ERR(pdata->bd); > goto error; > } > > diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c > index db4e6f7..a589216 100644 > --- a/drivers/video/bf54x-lq043fb.c > +++ b/drivers/video/bf54x-lq043fb.c > @@ -678,6 +678,12 @@ static int __devinit bfin_bf54x_probe(struct platform_device *pdev) > bl_dev = > backlight_device_register("bf54x-bl", NULL, NULL, > &bfin_lq043fb_bl_ops); > + if (IS_ERR(bl_dev)) { > + printk(KERN_ERR DRIVER_NAME > + ": unable to register backlight.\n"); > + ret = -EINVAL; > + goto out9; > + } > bl_dev->props.max_brightness = 255; > > lcd_dev = lcd_device_register(DRIVER_NAME, &pdev->dev, NULL, &bfin_lcd_ops); > @@ -686,6 +692,8 @@ static int __devinit bfin_bf54x_probe(struct platform_device *pdev) > > return 0; > > +out9: > + unregister_framebuffer(fbinfo); > out8: > free_irq(info->irq, info); > out7: > diff --git a/drivers/video/bfin-t350mcqb-fb.c b/drivers/video/bfin-t350mcqb-fb.c > index bc204c6..fe1492b 100644 > --- a/drivers/video/bfin-t350mcqb-fb.c > +++ b/drivers/video/bfin-t350mcqb-fb.c > @@ -572,6 +572,12 @@ static int __devinit bfin_t350mcqb_probe(struct platform_device *pdev) > bl_dev = > backlight_device_register("bf52x-bl", NULL, NULL, > &bfin_lq043fb_bl_ops); > + if (IS_ERR(bl_dev)) { > + printk(KERN_ERR DRIVER_NAME > + ": unable to register backlight.\n"); > + ret = -EINVAL; > + goto out9; > + } > bl_dev->props.max_brightness = 255; > > lcd_dev = lcd_device_register(DRIVER_NAME, NULL, &bfin_lcd_ops); > @@ -580,6 +586,8 @@ static int __devinit bfin_t350mcqb_probe(struct platform_device *pdev) > > return 0; > > +out9: > + unregister_framebuffer(fbinfo); > out8: > free_irq(info->irq, info); > out7: > -- > 1.6.4.4 > [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com> To: "Bruno Prémont" <bonbons@linux-vserver.org> Cc: Andrew Morton <akpm@linux-foundation.org>, Greg Kroah-Hartman <gregkh@suse.de>, Daniel Oliveira Nascimento <don@syst.com.br>, Len Brown <len.brown@intel.com>, Anisse Astier <anisse@astier.eu>, Thomas Renninger <trenn@suse.de>, Matt Chen <machen@novell.com>, Harald Welte <laforge@gnumonks.org>, Martin Lucina <mato@kotelna.sk>, Bjorn Helgaas <bjorn.helgaas@hp.com>, pancho horrillo <pancho@pancho.name>, Mike Frysinger <vapier@gentoo.org>, Vivek Kutal <vivek.kutal@azingo.com>, Michael Hennerich <michael.hennerich@analog.com>, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 3/3] backlight: fix missing/incomplete registration Date: Sun, 21 Feb 2010 13:35:29 +0000 [thread overview] Message-ID: <20100221133528.GB1840@holoscopio.com> (raw) In-Reply-To: <20100221002831.689bace8@neptune.home> [-- Attachment #1: Type: text/plain, Size: 4893 bytes --] On Sun, Feb 21, 2010 at 12:28:31AM +0100, Bruno Prémont wrote: > Check newly registered backlight_device for error and properly > return error to parent > > Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org> > --- > drivers/platform/x86/classmate-laptop.c | 2 ++ > drivers/platform/x86/msi-wmi.c | 4 +++- > drivers/platform/x86/panasonic-laptop.c | 4 +++- > drivers/usb/misc/appledisplay.c | 1 + > drivers/video/bf54x-lq043fb.c | 8 ++++++++ > drivers/video/bfin-t350mcqb-fb.c | 8 ++++++++ > 6 files changed, 25 insertions(+), 2 deletions(-) > I think you should split the patch for every driver. Then, every mantainer may ack only its particular section of the patch. > diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c > index bfae789..66f6aad 100644 > --- a/drivers/platform/x86/classmate-laptop.c > +++ b/drivers/platform/x86/classmate-laptop.c > @@ -463,6 +463,8 @@ static int cmpc_bl_add(struct acpi_device *acpi) > > bd = backlight_device_register("cmpc_bl", &acpi->dev, > acpi->handle, &cmpc_bl_ops); > + if (IS_ERR(bd)) > + return PTR_ERR(bd); > bd->props.max_brightness = 7; > dev_set_drvdata(&acpi->dev, bd); > return 0; > diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c > index 5f7cff1..2ffbfcf 100644 > --- a/drivers/platform/x86/msi-wmi.c > +++ b/drivers/platform/x86/msi-wmi.c > @@ -251,8 +251,10 @@ static int __init msi_wmi_init(void) > if (!acpi_video_backlight_support()) { > backlight = backlight_device_register(DRV_NAME, > NULL, NULL, &msi_backlight_ops); > - if (IS_ERR(backlight)) > + if (IS_ERR(backlight)) { > + err = PTR_ERR(backlight); > goto err_free_input; > + } > > backlight->props.max_brightness = ARRAY_SIZE(backlight_map) - 1; > err = bl_get(NULL); > diff --git a/drivers/platform/x86/panasonic-laptop.c b/drivers/platform/x86/panasonic-laptop.c > index 9012d8d..9b17343 100644 > --- a/drivers/platform/x86/panasonic-laptop.c > +++ b/drivers/platform/x86/panasonic-laptop.c > @@ -644,8 +644,10 @@ static int acpi_pcc_hotkey_add(struct acpi_device *device) > /* initialize backlight */ > pcc->backlight = backlight_device_register("panasonic", NULL, pcc, > &pcc_backlight_ops); > - if (IS_ERR(pcc->backlight)) > + if (IS_ERR(pcc->backlight)) { > + result = PTR_ERR(pcc->backlight); > goto out_input; > + } > > if (!acpi_pcc_retrieve_biosdata(pcc, pcc->sinf)) { > ACPI_DEBUG_PRINT((ACPI_DB_ERROR, > diff --git a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c > index ef79ca2..413f154 100644 > --- a/drivers/usb/misc/appledisplay.c > +++ b/drivers/usb/misc/appledisplay.c > @@ -283,6 +283,7 @@ static int appledisplay_probe(struct usb_interface *iface, > &appledisplay_bl_data); > if (IS_ERR(pdata->bd)) { > dev_err(&iface->dev, "Backlight registration failed\n"); > + retval = PTR_ERR(pdata->bd); > goto error; > } > > diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c > index db4e6f7..a589216 100644 > --- a/drivers/video/bf54x-lq043fb.c > +++ b/drivers/video/bf54x-lq043fb.c > @@ -678,6 +678,12 @@ static int __devinit bfin_bf54x_probe(struct platform_device *pdev) > bl_dev = > backlight_device_register("bf54x-bl", NULL, NULL, > &bfin_lq043fb_bl_ops); > + if (IS_ERR(bl_dev)) { > + printk(KERN_ERR DRIVER_NAME > + ": unable to register backlight.\n"); > + ret = -EINVAL; > + goto out9; > + } > bl_dev->props.max_brightness = 255; > > lcd_dev = lcd_device_register(DRIVER_NAME, &pdev->dev, NULL, &bfin_lcd_ops); > @@ -686,6 +692,8 @@ static int __devinit bfin_bf54x_probe(struct platform_device *pdev) > > return 0; > > +out9: > + unregister_framebuffer(fbinfo); > out8: > free_irq(info->irq, info); > out7: > diff --git a/drivers/video/bfin-t350mcqb-fb.c b/drivers/video/bfin-t350mcqb-fb.c > index bc204c6..fe1492b 100644 > --- a/drivers/video/bfin-t350mcqb-fb.c > +++ b/drivers/video/bfin-t350mcqb-fb.c > @@ -572,6 +572,12 @@ static int __devinit bfin_t350mcqb_probe(struct platform_device *pdev) > bl_dev = > backlight_device_register("bf52x-bl", NULL, NULL, > &bfin_lq043fb_bl_ops); > + if (IS_ERR(bl_dev)) { > + printk(KERN_ERR DRIVER_NAME > + ": unable to register backlight.\n"); > + ret = -EINVAL; > + goto out9; > + } > bl_dev->props.max_brightness = 255; > > lcd_dev = lcd_device_register(DRIVER_NAME, NULL, &bfin_lcd_ops); > @@ -580,6 +586,8 @@ static int __devinit bfin_t350mcqb_probe(struct platform_device *pdev) > > return 0; > > +out9: > + unregister_framebuffer(fbinfo); > out8: > free_irq(info->irq, info); > out7: > -- > 1.6.4.4 > [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-02-21 13:41 UTC|newest] Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-02-20 23:10 [Patch 0/3] backlight Bruno Prémont 2010-02-20 23:10 ` Bruno Prémont 2010-02-20 23:18 ` [PATCH 2/3] backlight: mark struct backlight_ops const Bruno Prémont 2010-02-20 23:18 ` Bruno Prémont 2010-02-20 23:18 ` Bruno Prémont 2010-02-20 23:18 ` Bruno Prémont [not found] ` <20100221001851.673db863-hY15tx4IgV39zxVx7UNMDg@public.gmane.org> 2010-02-22 19:35 ` Mike Frysinger 2010-02-22 19:35 ` Mike Frysinger 2010-02-22 19:35 ` Mike Frysinger 2010-02-22 19:35 ` Mike Frysinger 2010-02-26 11:56 ` [PATCH] " Bruno Prémont 2010-02-26 11:56 ` Bruno Prémont 2010-02-20 23:20 ` [PATCH 1/3] backlight: Add backlight_device parameter to check_fb Bruno Prémont 2010-02-20 23:20 ` Bruno Prémont 2010-02-24 16:00 ` [PATCH 1/3] picolcd: driver for PicoLCD HID device Bruno Prémont 2010-02-24 16:00 ` Bruno Prémont 2010-02-24 16:00 ` Bruno Prémont 2010-02-24 16:01 ` [PATCH 2/3] hid: add suspend/resume hooks for hid drivers Bruno Prémont 2010-02-25 4:19 ` Oliver Neukum 2010-02-25 10:12 ` Bruno Prémont 2010-02-24 16:01 ` [PATCH 3/3] hid-picolcd: make use of new suspend/resume hooks Bruno Prémont 2010-02-24 16:01 ` Bruno Prémont 2010-02-24 18:27 ` [PATCH 1/3] picolcd: driver for PicoLCD HID device Oliver Neukum 2010-02-24 18:27 ` Oliver Neukum 2010-02-24 18:27 ` Oliver Neukum 2010-02-24 21:44 ` Rick L. Vinyard, Jr. 2010-02-24 21:44 ` Rick L. Vinyard, Jr. 2010-02-24 21:44 ` Rick L. Vinyard, Jr. 2010-02-25 4:11 ` Oliver Neukum 2010-02-25 4:11 ` Oliver Neukum 2010-02-25 11:00 ` Jiri Kosina 2010-02-25 11:00 ` Jiri Kosina 2010-02-25 15:34 ` Rick L. Vinyard, Jr. 2010-02-25 15:34 ` Rick L. Vinyard, Jr. 2010-02-26 8:12 ` Dmitry Torokhov 2010-02-26 8:12 ` Dmitry Torokhov 2010-02-25 11:07 ` Jiri Kosina 2010-02-25 11:07 ` Jiri Kosina 2010-02-25 11:07 ` Jiri Kosina 2010-02-25 11:32 ` Bruno Prémont 2010-02-25 11:32 ` Bruno Prémont 2010-02-25 11:32 ` Bruno Prémont 2010-02-25 15:18 ` Jiri Kosina 2010-02-25 15:18 ` Jiri Kosina 2010-02-25 15:18 ` Jiri Kosina 2010-02-25 15:29 ` Bruno Prémont 2010-02-25 15:29 ` Bruno Prémont 2010-03-13 19:39 ` Bruno Prémont 2010-03-13 19:39 ` Bruno Prémont 2010-03-13 21:35 ` Alan Stern 2010-03-13 21:35 ` Alan Stern 2010-03-13 22:13 ` [PATCH] hid: Register debugfs entries before adding device Bruno Prémont 2010-03-13 22:13 ` Bruno Prémont 2010-03-15 13:48 ` Jiri Kosina 2010-02-25 17:52 ` [PATCH 1/3] picolcd: driver for PicoLCD HID device Rick L. Vinyard, Jr. 2010-02-25 17:52 ` Rick L. Vinyard, Jr. 2010-02-25 17:52 ` Rick L. Vinyard, Jr. 2010-02-26 8:15 ` Dmitry Torokhov 2010-02-26 8:15 ` Dmitry Torokhov 2010-02-26 8:15 ` Dmitry Torokhov 2010-03-03 6:04 ` Pavel Machek 2010-03-03 6:04 ` Pavel Machek 2010-02-26 11:53 ` [PATCH] backlight: Add backlight_device parameter to check_fb Bruno Prémont 2010-02-26 11:53 ` Bruno Prémont 2010-02-20 23:28 ` [PATCH 3/3] backlight: fix missing/incomplete registration failure handling Bruno Prémont 2010-02-20 23:28 ` [PATCH 3/3] backlight: fix missing/incomplete registration failure Bruno Prémont 2010-02-21 8:04 ` [PATCH 3/3] backlight: fix missing/incomplete registration failure handling Harald Welte 2010-02-21 13:35 ` Thadeu Lima de Souza Cascardo [this message] 2010-02-21 13:35 ` [PATCH 3/3] backlight: fix missing/incomplete registration Thadeu Lima de Souza Cascardo 2010-02-24 15:33 ` [PATCH 3/3] backlight: fix missing/incomplete registration failure handling Anisse Astier 2010-02-24 15:33 ` [PATCH 3/3] backlight: fix missing/incomplete registration Anisse Astier 2010-02-26 11:59 ` [PATCH] backlight, classmate-laptop: fix missing registration failure handling Bruno Prémont 2010-02-26 16:20 ` Thadeu Lima de Souza Cascardo 2010-02-26 16:32 ` Matthew Garrett 2010-02-26 16:45 ` Richard Purdie 2010-02-26 22:25 ` Bruno Prémont 2010-02-26 12:02 ` [PATCH] backlight, appledisplay: fix incomplete " Bruno Prémont 2010-02-26 12:04 ` [PATCH] backlight, blackfin: fix missing " Bruno Prémont 2010-02-26 12:04 ` [PATCH] backlight, blackfin: fix missing registration failure Bruno Prémont 2010-02-26 12:17 ` [PATCH] backlight, msi-laptop, msi-wmi: fix incomplete registration failure handling Bruno Prémont 2010-02-26 12:20 ` [PATCH] backlight, panasonic-laptop: " Bruno Prémont
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100221133528.GB1840@holoscopio.com \ --to=cascardo@holoscopio.com \ --cc=akpm@linux-foundation.org \ --cc=anisse@astier.eu \ --cc=bjorn.helgaas@hp.com \ --cc=bonbons@linux-vserver.org \ --cc=don@syst.com.br \ --cc=gregkh@suse.de \ --cc=laforge@gnumonks.org \ --cc=len.brown@intel.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=machen@novell.com \ --cc=mato@kotelna.sk \ --cc=michael.hennerich@analog.com \ --cc=pancho@pancho.name \ --cc=trenn@suse.de \ --cc=vapier@gentoo.org \ --cc=vivek.kutal@azingo.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.