From: "Bruno Prémont" <bonbons@linux-vserver.org> To: Richard Purdie <rpurdie@linux.intel.com>, Andrew Morton <akpm@linux-foundation.org> Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] backlight: Add backlight_device parameter to check_fb Date: Fri, 26 Feb 2010 12:53:58 +0100 [thread overview] Message-ID: <20100226125358.08cb3277@neptune.home> (raw) In-Reply-To: 20100221002001.0a7e05a7@neptune.home check_fb from backlight_ops lacks a reference to the backlight_device that's being referred to. Add this parameter so a backlight_device can be mapped to a single framebuffer, especially if the same driver handles multiple devices on a single system. Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org> --- drivers/video/backlight/adx_bl.c | 2 +- drivers/video/backlight/backlight.c | 2 +- include/linux/backlight.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/backlight/adx_bl.c b/drivers/video/backlight/adx_bl.c index d769b0b..a683dd1 100644 --- a/drivers/video/backlight/adx_bl.c +++ b/drivers/video/backlight/adx_bl.c @@ -56,7 +56,7 @@ static int adx_backlight_get_brightness(struct backlight_device *bldev) return brightness & 0xff; } -static int adx_backlight_check_fb(struct fb_info *fb) +static int adx_backlight_check_fb(struct backlight_device *bldev, struct fb_info *fb) { return 1; } diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c index 18829cf..b800cd4 100644 --- a/drivers/video/backlight/backlight.c +++ b/drivers/video/backlight/backlight.c @@ -38,7 +38,7 @@ static int fb_notifier_callback(struct notifier_block *self, mutex_lock(&bd->ops_lock); if (bd->ops) if (!bd->ops->check_fb || - bd->ops->check_fb(evdata->info)) { + bd->ops->check_fb(bd, evdata->info)) { bd->props.fb_blank = *(int *)evdata->data; if (bd->props.fb_blank == FB_BLANK_UNBLANK) bd->props.state &= ~BL_CORE_FBBLANK; diff --git a/include/linux/backlight.h b/include/linux/backlight.h index 8c4f884..15413ce 100644 --- a/include/linux/backlight.h +++ b/include/linux/backlight.h @@ -47,7 +47,7 @@ struct backlight_ops { int (* const get_brightness)(struct backlight_device *); /* Check if given framebuffer device is the one bound to this backlight; return 0 if not, !=0 if it is. If NULL, backlight always matches the fb. */ - int (* const check_fb)(struct fb_info *); + int (* const check_fb)(struct backlight_device *, struct fb_info *); }; /* This structure defines all the properties of a backlight */ -- 1.6.4.4
WARNING: multiple messages have this Message-ID (diff)
From: "Bruno Prémont" <bonbons@linux-vserver.org> To: Richard Purdie <rpurdie@linux.intel.com>, Andrew Morton <akpm@linux-foundation.org> Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] backlight: Add backlight_device parameter to check_fb Date: Fri, 26 Feb 2010 11:53:58 +0000 [thread overview] Message-ID: <20100226125358.08cb3277@neptune.home> (raw) In-Reply-To: 20100221002001.0a7e05a7@neptune.home check_fb from backlight_ops lacks a reference to the backlight_device that's being referred to. Add this parameter so a backlight_device can be mapped to a single framebuffer, especially if the same driver handles multiple devices on a single system. Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org> --- drivers/video/backlight/adx_bl.c | 2 +- drivers/video/backlight/backlight.c | 2 +- include/linux/backlight.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/backlight/adx_bl.c b/drivers/video/backlight/adx_bl.c index d769b0b..a683dd1 100644 --- a/drivers/video/backlight/adx_bl.c +++ b/drivers/video/backlight/adx_bl.c @@ -56,7 +56,7 @@ static int adx_backlight_get_brightness(struct backlight_device *bldev) return brightness & 0xff; } -static int adx_backlight_check_fb(struct fb_info *fb) +static int adx_backlight_check_fb(struct backlight_device *bldev, struct fb_info *fb) { return 1; } diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c index 18829cf..b800cd4 100644 --- a/drivers/video/backlight/backlight.c +++ b/drivers/video/backlight/backlight.c @@ -38,7 +38,7 @@ static int fb_notifier_callback(struct notifier_block *self, mutex_lock(&bd->ops_lock); if (bd->ops) if (!bd->ops->check_fb || - bd->ops->check_fb(evdata->info)) { + bd->ops->check_fb(bd, evdata->info)) { bd->props.fb_blank = *(int *)evdata->data; if (bd->props.fb_blank = FB_BLANK_UNBLANK) bd->props.state &= ~BL_CORE_FBBLANK; diff --git a/include/linux/backlight.h b/include/linux/backlight.h index 8c4f884..15413ce 100644 --- a/include/linux/backlight.h +++ b/include/linux/backlight.h @@ -47,7 +47,7 @@ struct backlight_ops { int (* const get_brightness)(struct backlight_device *); /* Check if given framebuffer device is the one bound to this backlight; return 0 if not, !=0 if it is. If NULL, backlight always matches the fb. */ - int (* const check_fb)(struct fb_info *); + int (* const check_fb)(struct backlight_device *, struct fb_info *); }; /* This structure defines all the properties of a backlight */ -- 1.6.4.4
next prev parent reply other threads:[~2010-02-26 12:21 UTC|newest] Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-02-20 23:10 [Patch 0/3] backlight Bruno Prémont 2010-02-20 23:10 ` Bruno Prémont 2010-02-20 23:18 ` [PATCH 2/3] backlight: mark struct backlight_ops const Bruno Prémont 2010-02-20 23:18 ` Bruno Prémont 2010-02-20 23:18 ` Bruno Prémont 2010-02-20 23:18 ` Bruno Prémont [not found] ` <20100221001851.673db863-hY15tx4IgV39zxVx7UNMDg@public.gmane.org> 2010-02-22 19:35 ` Mike Frysinger 2010-02-22 19:35 ` Mike Frysinger 2010-02-22 19:35 ` Mike Frysinger 2010-02-22 19:35 ` Mike Frysinger 2010-02-26 11:56 ` [PATCH] " Bruno Prémont 2010-02-26 11:56 ` Bruno Prémont 2010-02-20 23:20 ` [PATCH 1/3] backlight: Add backlight_device parameter to check_fb Bruno Prémont 2010-02-20 23:20 ` Bruno Prémont 2010-02-24 16:00 ` [PATCH 1/3] picolcd: driver for PicoLCD HID device Bruno Prémont 2010-02-24 16:00 ` Bruno Prémont 2010-02-24 16:00 ` Bruno Prémont 2010-02-24 16:01 ` [PATCH 2/3] hid: add suspend/resume hooks for hid drivers Bruno Prémont 2010-02-25 4:19 ` Oliver Neukum 2010-02-25 10:12 ` Bruno Prémont 2010-02-24 16:01 ` [PATCH 3/3] hid-picolcd: make use of new suspend/resume hooks Bruno Prémont 2010-02-24 16:01 ` Bruno Prémont 2010-02-24 18:27 ` [PATCH 1/3] picolcd: driver for PicoLCD HID device Oliver Neukum 2010-02-24 18:27 ` Oliver Neukum 2010-02-24 18:27 ` Oliver Neukum 2010-02-24 21:44 ` Rick L. Vinyard, Jr. 2010-02-24 21:44 ` Rick L. Vinyard, Jr. 2010-02-24 21:44 ` Rick L. Vinyard, Jr. 2010-02-25 4:11 ` Oliver Neukum 2010-02-25 4:11 ` Oliver Neukum 2010-02-25 11:00 ` Jiri Kosina 2010-02-25 11:00 ` Jiri Kosina 2010-02-25 15:34 ` Rick L. Vinyard, Jr. 2010-02-25 15:34 ` Rick L. Vinyard, Jr. 2010-02-26 8:12 ` Dmitry Torokhov 2010-02-26 8:12 ` Dmitry Torokhov 2010-02-25 11:07 ` Jiri Kosina 2010-02-25 11:07 ` Jiri Kosina 2010-02-25 11:07 ` Jiri Kosina 2010-02-25 11:32 ` Bruno Prémont 2010-02-25 11:32 ` Bruno Prémont 2010-02-25 11:32 ` Bruno Prémont 2010-02-25 15:18 ` Jiri Kosina 2010-02-25 15:18 ` Jiri Kosina 2010-02-25 15:18 ` Jiri Kosina 2010-02-25 15:29 ` Bruno Prémont 2010-02-25 15:29 ` Bruno Prémont 2010-03-13 19:39 ` Bruno Prémont 2010-03-13 19:39 ` Bruno Prémont 2010-03-13 21:35 ` Alan Stern 2010-03-13 21:35 ` Alan Stern 2010-03-13 22:13 ` [PATCH] hid: Register debugfs entries before adding device Bruno Prémont 2010-03-13 22:13 ` Bruno Prémont 2010-03-15 13:48 ` Jiri Kosina 2010-02-25 17:52 ` [PATCH 1/3] picolcd: driver for PicoLCD HID device Rick L. Vinyard, Jr. 2010-02-25 17:52 ` Rick L. Vinyard, Jr. 2010-02-25 17:52 ` Rick L. Vinyard, Jr. 2010-02-26 8:15 ` Dmitry Torokhov 2010-02-26 8:15 ` Dmitry Torokhov 2010-02-26 8:15 ` Dmitry Torokhov 2010-03-03 6:04 ` Pavel Machek 2010-03-03 6:04 ` Pavel Machek 2010-02-26 11:53 ` Bruno Prémont [this message] 2010-02-26 11:53 ` [PATCH] backlight: Add backlight_device parameter to check_fb Bruno Prémont 2010-02-20 23:28 ` [PATCH 3/3] backlight: fix missing/incomplete registration failure handling Bruno Prémont 2010-02-20 23:28 ` [PATCH 3/3] backlight: fix missing/incomplete registration failure Bruno Prémont 2010-02-21 8:04 ` [PATCH 3/3] backlight: fix missing/incomplete registration failure handling Harald Welte 2010-02-21 13:35 ` Thadeu Lima de Souza Cascardo 2010-02-21 13:35 ` [PATCH 3/3] backlight: fix missing/incomplete registration Thadeu Lima de Souza Cascardo 2010-02-24 15:33 ` [PATCH 3/3] backlight: fix missing/incomplete registration failure handling Anisse Astier 2010-02-24 15:33 ` [PATCH 3/3] backlight: fix missing/incomplete registration Anisse Astier 2010-02-26 11:59 ` [PATCH] backlight, classmate-laptop: fix missing registration failure handling Bruno Prémont 2010-02-26 16:20 ` Thadeu Lima de Souza Cascardo 2010-02-26 16:32 ` Matthew Garrett 2010-02-26 16:45 ` Richard Purdie 2010-02-26 22:25 ` Bruno Prémont 2010-02-26 12:02 ` [PATCH] backlight, appledisplay: fix incomplete " Bruno Prémont 2010-02-26 12:04 ` [PATCH] backlight, blackfin: fix missing " Bruno Prémont 2010-02-26 12:04 ` [PATCH] backlight, blackfin: fix missing registration failure Bruno Prémont 2010-02-26 12:17 ` [PATCH] backlight, msi-laptop, msi-wmi: fix incomplete registration failure handling Bruno Prémont 2010-02-26 12:20 ` [PATCH] backlight, panasonic-laptop: " Bruno Prémont
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100226125358.08cb3277@neptune.home \ --to=bonbons@linux-vserver.org \ --cc=akpm@linux-foundation.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rpurdie@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.