All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Holt <holt@sgi.com>
To: Anton Starikov <ant.starikov@gmail.com>
Cc: Robin Holt <holt@sgi.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	bugzilla-daemon@bugzilla.kernel.org,
	bugme-daemon@bugzilla.kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [Bugme-new] [Bug 15618] New: 2.6.18->2.6.32->2.6.33 huge regression in performance
Date: Tue, 23 Mar 2010 14:57:28 -0500	[thread overview]
Message-ID: <20100323195728.GC6169@sgi.com> (raw)
In-Reply-To: <20100323194959.GB6169@sgi.com>

On Tue, Mar 23, 2010 at 02:49:59PM -0500, Robin Holt wrote:
> On Tue, Mar 23, 2010 at 08:30:19PM +0100, Anton Starikov wrote:
> > 
> > On Mar 23, 2010, at 8:22 PM, Robin Holt wrote:
> > 
> > > On Tue, Mar 23, 2010 at 07:25:43PM +0100, Anton Starikov wrote:
> > >> On Mar 23, 2010, at 7:21 PM, Andrew Morton wrote:
> > >>>> I will apply this commits to 2.6.32, I afraid current OFED (which I need also) will not work on 2.6.33+.
> > >>>> 
> > >>> 
> > >>> You should be able to simply set CONFIG_RWSEM_GENERIC_SPINLOCK=n,
> > >>> CONFIG_RWSEM_XCHGADD_ALGORITHM=y by hand, as I mentioned earlier?
> > >> 
> > >> Hm. I tried, but when I do "make oldconfig", then it gets rewritten, so I assume that it conflicts with some other setting from default fedora kernel config. trying to figure out which one exactly.
> > > 
> > > Have you tracked this down yet?  I just got the patches applied against
> > > an older kernel and am running into the same issue.
> > 
> > I decided to not track down this issue and just applied patches. I understood that with this patches there is no need to change this config options. Am I wrong?
> 
> We might need to also apply:
> bafaecd11df15ad5b1e598adc7736afcd38ee13d

For the record, these are the patches I have applied to a 2.6.32 kernel from a vendor:

59c33fa7791e9948ba467c2b83e307a0d087ab49
5d0b7235d83eefdafda300656e97d368afcafc9a
1838ef1d782f7527e6defe87e180598622d2d071
0d1622d7f526311d87d7da2ee7dd14b73e45d3fc
bafaecd11df15ad5b1e598adc7736afcd38ee13d

A quick look at the disassembly makes it look like we are using the
rwsem_64, et al.

Robin

WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt@sgi.com>
To: Anton Starikov <ant.starikov@gmail.com>
Cc: Robin Holt <holt@sgi.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	bugzilla-daemon@bugzilla.kernel.org,
	bugme-daemon@bugzilla.kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [Bugme-new] [Bug 15618] New: 2.6.18->2.6.32->2.6.33 huge regression in performance
Date: Tue, 23 Mar 2010 14:57:28 -0500	[thread overview]
Message-ID: <20100323195728.GC6169@sgi.com> (raw)
In-Reply-To: <20100323194959.GB6169@sgi.com>

On Tue, Mar 23, 2010 at 02:49:59PM -0500, Robin Holt wrote:
> On Tue, Mar 23, 2010 at 08:30:19PM +0100, Anton Starikov wrote:
> > 
> > On Mar 23, 2010, at 8:22 PM, Robin Holt wrote:
> > 
> > > On Tue, Mar 23, 2010 at 07:25:43PM +0100, Anton Starikov wrote:
> > >> On Mar 23, 2010, at 7:21 PM, Andrew Morton wrote:
> > >>>> I will apply this commits to 2.6.32, I afraid current OFED (which I need also) will not work on 2.6.33+.
> > >>>> 
> > >>> 
> > >>> You should be able to simply set CONFIG_RWSEM_GENERIC_SPINLOCK=n,
> > >>> CONFIG_RWSEM_XCHGADD_ALGORITHM=y by hand, as I mentioned earlier?
> > >> 
> > >> Hm. I tried, but when I do "make oldconfig", then it gets rewritten, so I assume that it conflicts with some other setting from default fedora kernel config. trying to figure out which one exactly.
> > > 
> > > Have you tracked this down yet?  I just got the patches applied against
> > > an older kernel and am running into the same issue.
> > 
> > I decided to not track down this issue and just applied patches. I understood that with this patches there is no need to change this config options. Am I wrong?
> 
> We might need to also apply:
> bafaecd11df15ad5b1e598adc7736afcd38ee13d

For the record, these are the patches I have applied to a 2.6.32 kernel from a vendor:

59c33fa7791e9948ba467c2b83e307a0d087ab49
5d0b7235d83eefdafda300656e97d368afcafc9a
1838ef1d782f7527e6defe87e180598622d2d071
0d1622d7f526311d87d7da2ee7dd14b73e45d3fc
bafaecd11df15ad5b1e598adc7736afcd38ee13d

A quick look at the disassembly makes it look like we are using the
rwsem_64, et al.

Robin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-03-23 19:57 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-15618-10286@https.bugzilla.kernel.org/>
2010-03-23 14:22 ` [Bugme-new] [Bug 15618] New: 2.6.18->2.6.32->2.6.33 huge regression in performance Andrew Morton
2010-03-23 14:22   ` Andrew Morton
2010-03-23 17:34   ` Ingo Molnar
2010-03-23 17:34     ` Ingo Molnar
2010-03-23 17:45     ` Linus Torvalds
2010-03-23 17:45       ` Linus Torvalds
2010-03-23 17:57       ` Anton Starikov
2010-03-23 17:57         ` Anton Starikov
2010-03-23 18:00       ` Ingo Molnar
2010-03-23 18:00         ` Ingo Molnar
2010-03-23 18:03         ` Anton Starikov
2010-03-23 18:03           ` Anton Starikov
2010-03-23 18:21           ` Andrew Morton
2010-03-23 18:21             ` Andrew Morton
2010-03-23 18:25             ` Anton Starikov
2010-03-23 18:25               ` Anton Starikov
2010-03-23 19:22               ` Robin Holt
2010-03-23 19:22                 ` Robin Holt
2010-03-23 19:30                 ` Anton Starikov
2010-03-23 19:30                   ` Anton Starikov
2010-03-23 19:49                   ` Robin Holt
2010-03-23 19:49                     ` Robin Holt
2010-03-23 19:57                     ` Robin Holt [this message]
2010-03-23 19:57                       ` Robin Holt
2010-03-23 19:50                 ` Anton Starikov
2010-03-23 19:50                   ` Anton Starikov
2010-03-23 19:52             ` Linus Torvalds
2010-03-23 19:52               ` Linus Torvalds
2010-03-24 16:40           ` Roland Dreier
2010-03-24 16:40             ` Roland Dreier
2010-03-26  3:24             ` Anton Starikov
2010-03-26  3:24               ` Anton Starikov
2010-03-23 19:14       ` Anton Starikov
2010-03-23 19:14         ` Anton Starikov
2010-03-23 19:17         ` Peter Zijlstra
2010-03-23 19:17           ` Peter Zijlstra
2010-03-23 19:42           ` Anton Starikov
2010-03-23 19:54         ` Linus Torvalds
2010-03-23 19:54           ` Linus Torvalds
2010-03-23 20:43           ` Anton Starikov
2010-03-23 20:43             ` Anton Starikov
2010-03-23 23:04             ` Linus Torvalds
2010-03-23 23:04               ` Linus Torvalds
2010-03-23 23:19               ` Anton Starikov
2010-03-23 23:19                 ` Anton Starikov
2010-03-23 23:36               ` Ingo Molnar
2010-03-23 23:36                 ` Ingo Molnar
2010-03-23 23:55                 ` Linus Torvalds
2010-03-23 23:55                   ` Linus Torvalds
2010-03-24  0:03                   ` Anton Starikov
2010-03-24  0:03                     ` Anton Starikov
2010-03-24  2:15                   ` Andi Kleen
2010-03-24  2:15                     ` Andi Kleen
2010-03-24  3:00                     ` Linus Torvalds
2010-03-24  3:00                       ` Linus Torvalds
2010-04-19 18:19                       ` Greg KH
2010-04-19 18:19                         ` Greg KH
2010-03-23 18:13     ` Andrew Morton
2010-03-23 18:13       ` Andrew Morton
2010-03-23 18:19       ` Anton Starikov
2010-03-23 18:19         ` Anton Starikov
2010-03-23 18:27       ` Ingo Molnar
2010-03-23 18:27         ` Ingo Molnar
2010-03-23 21:19       ` Anton Starikov
2010-03-23 21:19         ` Anton Starikov
2010-04-02 18:57   ` Lee Schermerhorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100323195728.GC6169@sgi.com \
    --to=holt@sgi.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=ant.starikov@gmail.com \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.