From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> To: Oleg Nesterov <oleg@redhat.com> Cc: kosaki.motohiro@jp.fujitsu.com, LKML <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>, David Rientjes <rientjes@google.com>, Andrew Morton <akpm@linux-foundation.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Nick Piggin <npiggin@suse.de> Subject: [PATCH] oom: Make coredump interruptible Date: Wed, 2 Jun 2010 22:54:02 +0900 (JST) [thread overview] Message-ID: <20100602221805.F524.A69D9226@jp.fujitsu.com> (raw) In-Reply-To: <20100601201843.GA20732@redhat.com> > Otoh, if we make do_coredump() interruptible (and we should do this > in any case), then perhaps the TIF_MEMDIE+PF_COREDUMP is not really > needed? Afaics we always send SIGKILL along with TIF_MEMDIE. How is to make per-process oom flag + interruptible coredump? this per-process oom flag can be used vmscan shortcut exiting too. (IOW, It can help DavidR mmap_sem issue) =========================================================== Subject: [PATCH] oom: Make coredump interruptible If oom victim process is under core dumping, sending SIGKILL cause no-op. Unfortunately, coredump need relatively much memory. It mean OOM vs coredump can makes deadlock. Then, coredump logic should check the task has received SIGKILL from OOM. Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> --- fs/binfmt_elf.c | 5 +++++ include/linux/sched.h | 3 +++ mm/oom_kill.c | 1 + 3 files changed, 9 insertions(+), 0 deletions(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 535e763..aa47979 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -2038,6 +2038,11 @@ static int elf_core_dump(struct coredump_params *cprm) page_cache_release(page); } else stop = !dump_seek(cprm->file, PAGE_SIZE); + + /* Now, The process received OOM. Exit soon! */ + if (current->signal->oom_victim) + stop = 1; + if (stop) goto end_coredump; } diff --git a/include/linux/sched.h b/include/linux/sched.h index 8485aa2..1c4fa86 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -544,6 +544,9 @@ struct signal_struct { int notify_count; struct task_struct *group_exit_task; + /* true mean the process is OOM-killer victim. */ + bool oom_victim; + /* thread group stop support, overloads group_exit_code too */ int group_stop_count; unsigned int flags; /* see SIGNAL_* flags below */ diff --git a/mm/oom_kill.c b/mm/oom_kill.c index f33a1b8..39e31bf 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -400,6 +400,7 @@ static int __oom_kill_process(struct task_struct *p, struct mem_cgroup *mem, */ p->rt.time_slice = HZ; set_tsk_thread_flag(p, TIF_MEMDIE); + p->signal->oom_victim = true; force_sig(SIGKILL, p); -- 1.6.5.2
WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> To: Oleg Nesterov <oleg@redhat.com> Cc: kosaki.motohiro@jp.fujitsu.com, LKML <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>, David Rientjes <rientjes@google.com>, Andrew Morton <akpm@linux-foundation.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Nick Piggin <npiggin@suse.de> Subject: [PATCH] oom: Make coredump interruptible Date: Wed, 2 Jun 2010 22:54:02 +0900 (JST) [thread overview] Message-ID: <20100602221805.F524.A69D9226@jp.fujitsu.com> (raw) In-Reply-To: <20100601201843.GA20732@redhat.com> > Otoh, if we make do_coredump() interruptible (and we should do this > in any case), then perhaps the TIF_MEMDIE+PF_COREDUMP is not really > needed? Afaics we always send SIGKILL along with TIF_MEMDIE. How is to make per-process oom flag + interruptible coredump? this per-process oom flag can be used vmscan shortcut exiting too. (IOW, It can help DavidR mmap_sem issue) =========================================================== Subject: [PATCH] oom: Make coredump interruptible If oom victim process is under core dumping, sending SIGKILL cause no-op. Unfortunately, coredump need relatively much memory. It mean OOM vs coredump can makes deadlock. Then, coredump logic should check the task has received SIGKILL from OOM. Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> --- fs/binfmt_elf.c | 5 +++++ include/linux/sched.h | 3 +++ mm/oom_kill.c | 1 + 3 files changed, 9 insertions(+), 0 deletions(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 535e763..aa47979 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -2038,6 +2038,11 @@ static int elf_core_dump(struct coredump_params *cprm) page_cache_release(page); } else stop = !dump_seek(cprm->file, PAGE_SIZE); + + /* Now, The process received OOM. Exit soon! */ + if (current->signal->oom_victim) + stop = 1; + if (stop) goto end_coredump; } diff --git a/include/linux/sched.h b/include/linux/sched.h index 8485aa2..1c4fa86 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -544,6 +544,9 @@ struct signal_struct { int notify_count; struct task_struct *group_exit_task; + /* true mean the process is OOM-killer victim. */ + bool oom_victim; + /* thread group stop support, overloads group_exit_code too */ int group_stop_count; unsigned int flags; /* see SIGNAL_* flags below */ diff --git a/mm/oom_kill.c b/mm/oom_kill.c index f33a1b8..39e31bf 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -400,6 +400,7 @@ static int __oom_kill_process(struct task_struct *p, struct mem_cgroup *mem, */ p->rt.time_slice = HZ; set_tsk_thread_flag(p, TIF_MEMDIE); + p->signal->oom_victim = true; force_sig(SIGKILL, p); -- 1.6.5.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-06-02 13:54 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-05-31 9:33 [PATCH 1/5] oom: select_bad_process: check PF_KTHREAD instead of !mm to skip kthreads KOSAKI Motohiro 2010-05-31 9:33 ` KOSAKI Motohiro 2010-05-31 9:35 ` [PATCH 2/5] oom: select_bad_process: PF_EXITING check should take ->mm into account KOSAKI Motohiro 2010-05-31 9:35 ` KOSAKI Motohiro 2010-05-31 16:43 ` Oleg Nesterov 2010-05-31 16:43 ` Oleg Nesterov 2010-06-01 1:10 ` KOSAKI Motohiro 2010-06-01 1:10 ` KOSAKI Motohiro 2010-06-01 20:18 ` Oleg Nesterov 2010-06-01 20:18 ` Oleg Nesterov 2010-06-02 13:54 ` [PATCH] oom: remove PF_EXITING check completely KOSAKI Motohiro 2010-06-02 13:54 ` KOSAKI Motohiro 2010-06-02 15:54 ` Oleg Nesterov 2010-06-02 15:54 ` Oleg Nesterov 2010-06-02 21:02 ` David Rientjes 2010-06-02 21:02 ` David Rientjes 2010-06-03 4:48 ` KOSAKI Motohiro 2010-06-03 4:48 ` KOSAKI Motohiro 2010-06-03 6:29 ` David Rientjes 2010-06-03 6:29 ` David Rientjes 2010-06-02 13:54 ` KOSAKI Motohiro [this message] 2010-06-02 13:54 ` [PATCH] oom: Make coredump interruptible KOSAKI Motohiro 2010-06-02 15:42 ` Oleg Nesterov 2010-06-02 15:42 ` Oleg Nesterov 2010-06-02 17:29 ` Roland McGrath 2010-06-02 17:29 ` Roland McGrath 2010-06-02 17:53 ` Oleg Nesterov 2010-06-02 17:53 ` Oleg Nesterov 2010-06-02 18:58 ` Roland McGrath 2010-06-02 18:58 ` Roland McGrath 2010-06-02 20:38 ` Oleg Nesterov 2010-06-02 20:38 ` Oleg Nesterov 2010-06-03 14:03 ` Oleg Nesterov 2010-06-03 14:03 ` Oleg Nesterov 2010-06-04 10:54 ` KOSAKI Motohiro 2010-06-04 10:54 ` KOSAKI Motohiro 2010-06-04 11:27 ` Oleg Nesterov 2010-06-04 11:27 ` Oleg Nesterov 2010-06-04 11:34 ` Oleg Nesterov 2010-06-04 11:34 ` Oleg Nesterov 2010-06-09 19:53 ` Oleg Nesterov 2010-06-09 19:53 ` Oleg Nesterov 2010-06-09 20:41 ` David Rientjes 2010-06-09 20:41 ` David Rientjes 2010-06-09 21:03 ` Oleg Nesterov 2010-06-09 21:03 ` Oleg Nesterov 2010-06-13 11:24 ` KOSAKI Motohiro 2010-06-13 11:24 ` KOSAKI Motohiro 2010-06-13 15:53 ` Oleg Nesterov 2010-06-13 15:53 ` Oleg Nesterov 2010-06-13 17:13 ` uninterruptible CLONE_VFORK (Was: oom: Make coredump interruptible) Oleg Nesterov 2010-06-13 17:13 ` Oleg Nesterov 2010-06-14 0:56 ` Roland McGrath 2010-06-14 0:56 ` Roland McGrath 2010-06-14 16:33 ` Oleg Nesterov 2010-06-14 16:33 ` Oleg Nesterov 2010-06-14 19:17 ` Roland McGrath 2010-06-14 19:17 ` Roland McGrath 2010-06-28 17:33 ` Oleg Nesterov 2010-06-28 17:33 ` Oleg Nesterov 2010-06-28 18:04 ` Roland McGrath 2010-06-28 18:04 ` Roland McGrath 2010-06-14 0:36 ` [PATCH] oom: Make coredump interruptible Roland McGrath 2010-06-14 0:36 ` Roland McGrath 2010-06-14 0:26 ` Roland McGrath 2010-06-14 0:26 ` Roland McGrath 2010-06-01 20:39 ` [PATCH 2/5] oom: select_bad_process: PF_EXITING check should take ->mm into account David Rientjes 2010-06-01 20:39 ` David Rientjes 2010-05-31 9:36 ` [PATCH 3/5] oom: introduce find_lock_task_mm() to fix !mm false positives KOSAKI Motohiro 2010-05-31 9:36 ` KOSAKI Motohiro 2010-06-01 0:57 ` KAMEZAWA Hiroyuki 2010-06-01 0:57 ` KAMEZAWA Hiroyuki 2010-06-01 20:42 ` David Rientjes 2010-06-01 20:42 ` David Rientjes 2010-06-02 16:05 ` Minchan Kim 2010-06-02 16:05 ` Minchan Kim 2010-05-31 9:37 ` [PATCH 4/5] oom: the points calculation of child processes must use find_lock_task_mm() too KOSAKI Motohiro 2010-05-31 9:37 ` KOSAKI Motohiro 2010-05-31 16:56 ` Oleg Nesterov 2010-05-31 16:56 ` Oleg Nesterov 2010-05-31 23:48 ` KOSAKI Motohiro 2010-05-31 23:48 ` KOSAKI Motohiro 2010-05-31 9:38 ` [PATCH 5/5] oom: __oom_kill_task() " KOSAKI Motohiro 2010-05-31 9:38 ` KOSAKI Motohiro 2010-06-01 1:02 ` KAMEZAWA Hiroyuki 2010-06-01 1:02 ` KAMEZAWA Hiroyuki 2010-06-01 20:44 ` David Rientjes 2010-06-01 20:44 ` David Rientjes 2010-06-01 0:54 ` [PATCH 1/5] oom: select_bad_process: check PF_KTHREAD instead of !mm to skip kthreads KAMEZAWA Hiroyuki 2010-06-01 0:54 ` KAMEZAWA Hiroyuki 2010-06-01 20:36 ` David Rientjes 2010-06-01 20:36 ` David Rientjes 2010-06-01 21:20 ` Oleg Nesterov 2010-06-01 21:20 ` Oleg Nesterov 2010-06-01 21:26 ` David Rientjes 2010-06-01 21:26 ` David Rientjes 2010-06-02 13:54 ` KOSAKI Motohiro 2010-06-02 13:54 ` KOSAKI Motohiro 2010-06-02 21:09 ` David Rientjes 2010-06-02 21:09 ` David Rientjes 2010-06-02 21:33 ` Oleg Nesterov 2010-06-02 21:33 ` Oleg Nesterov 2010-06-02 21:46 ` David Rientjes 2010-06-02 21:46 ` David Rientjes 2010-06-03 14:27 ` Oleg Nesterov 2010-06-03 14:27 ` Oleg Nesterov 2010-06-03 20:11 ` David Rientjes 2010-06-03 20:11 ` David Rientjes 2010-06-02 15:32 ` Minchan Kim 2010-06-02 15:32 ` Minchan Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100602221805.F524.A69D9226@jp.fujitsu.com \ --to=kosaki.motohiro@jp.fujitsu.com \ --cc=akpm@linux-foundation.org \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=npiggin@suse.de \ --cc=oleg@redhat.com \ --cc=rientjes@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.