From: Grant Likely <grant.likely@secretlab.ca>
To: John Bonesio <bones@secretlab.ca>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
jdl@jdl.com, glikely@secretlab.ca,
devicetree-discuss@lists.ozlabs.org, david@gibson.dropbear.id.au
Subject: Re: [PATCH 3/5] powerpc/5200: dts: remove unused properties
Date: Tue, 16 Nov 2010 22:05:14 -0700 [thread overview]
Message-ID: <20101117050514.GC12084@angua.secretlab.ca> (raw)
In-Reply-To: <20101116205010.12146.37154.stgit@riker>
On Tue, Nov 16, 2010 at 12:50:10PM -0800, John Bonesio wrote:
> This patch remove unused properties in dts files in preparation of refactoring
> the dts files for MPC5200b based boards.
>
> Signed-off-by: John Bonesio <bones@secretlab.ca>
> ---
>
> arch/powerpc/boot/dts/cm5200.dts | 2 --
> arch/powerpc/boot/dts/lite5200b.dts | 3 ---
> arch/powerpc/boot/dts/media5200.dts | 2 --
> arch/powerpc/boot/dts/motionpro.dts | 2 --
> arch/powerpc/boot/dts/pcm030.dts | 2 --
> arch/powerpc/boot/dts/pcm032.dts | 2 --
> 6 files changed, 0 insertions(+), 13 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/cm5200.dts b/arch/powerpc/boot/dts/cm5200.dts
> index 9369dcd..d549897 100644
> --- a/arch/powerpc/boot/dts/cm5200.dts
> +++ b/arch/powerpc/boot/dts/cm5200.dts
> @@ -230,8 +230,6 @@
> reg = <0 0 0x2000000>;
> bank-width = <2>;
> device-width = <2>;
> - #size-cells = <1>;
> - #address-cells = <1>;
> };
> };
> };
> diff --git a/arch/powerpc/boot/dts/lite5200b.dts b/arch/powerpc/boot/dts/lite5200b.dts
> index a74b790..c0a4e45 100644
> --- a/arch/powerpc/boot/dts/lite5200b.dts
> +++ b/arch/powerpc/boot/dts/lite5200b.dts
> @@ -174,7 +174,6 @@
>
> psc@2000 { // PSC1
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <0>;
> reg = <0x2000 0x100>;
> interrupts = <2 1 0>;
> };
> @@ -198,7 +197,6 @@
> // PSC4 in uart mode example
> //serial@2600 { // PSC4
> // compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - // cell-index = <3>;
> // reg = <0x2600 0x100>;
> // interrupts = <2 11 0>;
> //};
> @@ -206,7 +204,6 @@
> // PSC5 in uart mode example
> //serial@2800 { // PSC5
> // compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - // cell-index = <4>;
> // reg = <0x2800 0x100>;
> // interrupts = <2 12 0>;
> //};
How about deleting the commented out nodes entirely since they can now
be captured in the mpc5200.dtsi file.
> diff --git a/arch/powerpc/boot/dts/media5200.dts b/arch/powerpc/boot/dts/media5200.dts
> index a70ef68..e027f45 100644
> --- a/arch/powerpc/boot/dts/media5200.dts
> +++ b/arch/powerpc/boot/dts/media5200.dts
> @@ -185,8 +185,6 @@
> // PSC6 in uart mode
> console: psc@2c00 { // PSC6
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <5>;
> - port-number = <0>; // Logical port assignment
> reg = <0x2c00 0x100>;
> interrupts = <2 4 0>;
> };
> diff --git a/arch/powerpc/boot/dts/motionpro.dts b/arch/powerpc/boot/dts/motionpro.dts
> index f6261ea..3ab4666 100644
> --- a/arch/powerpc/boot/dts/motionpro.dts
> +++ b/arch/powerpc/boot/dts/motionpro.dts
> @@ -277,8 +277,6 @@
> reg = <0 0 0x01000000>;
> bank-width = <2>;
> device-width = <2>;
> - #size-cells = <1>;
> - #address-cells = <1>;
> };
> };
> };
> diff --git a/arch/powerpc/boot/dts/pcm030.dts b/arch/powerpc/boot/dts/pcm030.dts
> index 3a4f554..f3e30bb 100644
> --- a/arch/powerpc/boot/dts/pcm030.dts
> +++ b/arch/powerpc/boot/dts/pcm030.dts
> @@ -196,7 +196,6 @@
>
> psc@2400 { /* PSC3 in UART mode */
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <2>;
> reg = <0x2400 0x100>;
> interrupts = <2 3 0>;
> };
> @@ -207,7 +206,6 @@
>
> psc@2c00 { /* PSC6 in UART mode */
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <5>;
> reg = <0x2c00 0x100>;
> interrupts = <2 4 0>;
> };
> diff --git a/arch/powerpc/boot/dts/pcm032.dts b/arch/powerpc/boot/dts/pcm032.dts
> index 17596c7..e0f2702 100644
> --- a/arch/powerpc/boot/dts/pcm032.dts
> +++ b/arch/powerpc/boot/dts/pcm032.dts
> @@ -196,7 +196,6 @@
>
> psc@2400 { /* PSC3 in UART mode */
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <2>;
> reg = <0x2400 0x100>;
> interrupts = <2 3 0>;
> };
> @@ -207,7 +206,6 @@
>
> psc@2c00 { /* PSC6 in UART mode */
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <5>;
> reg = <0x2c00 0x100>;
> interrupts = <2 4 0>;
> };
>
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: John Bonesio <bones-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: glikely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH 3/5] powerpc/5200: dts: remove unused properties
Date: Tue, 16 Nov 2010 22:05:14 -0700 [thread overview]
Message-ID: <20101117050514.GC12084@angua.secretlab.ca> (raw)
In-Reply-To: <20101116205010.12146.37154.stgit@riker>
On Tue, Nov 16, 2010 at 12:50:10PM -0800, John Bonesio wrote:
> This patch remove unused properties in dts files in preparation of refactoring
> the dts files for MPC5200b based boards.
>
> Signed-off-by: John Bonesio <bones-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> ---
>
> arch/powerpc/boot/dts/cm5200.dts | 2 --
> arch/powerpc/boot/dts/lite5200b.dts | 3 ---
> arch/powerpc/boot/dts/media5200.dts | 2 --
> arch/powerpc/boot/dts/motionpro.dts | 2 --
> arch/powerpc/boot/dts/pcm030.dts | 2 --
> arch/powerpc/boot/dts/pcm032.dts | 2 --
> 6 files changed, 0 insertions(+), 13 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/cm5200.dts b/arch/powerpc/boot/dts/cm5200.dts
> index 9369dcd..d549897 100644
> --- a/arch/powerpc/boot/dts/cm5200.dts
> +++ b/arch/powerpc/boot/dts/cm5200.dts
> @@ -230,8 +230,6 @@
> reg = <0 0 0x2000000>;
> bank-width = <2>;
> device-width = <2>;
> - #size-cells = <1>;
> - #address-cells = <1>;
> };
> };
> };
> diff --git a/arch/powerpc/boot/dts/lite5200b.dts b/arch/powerpc/boot/dts/lite5200b.dts
> index a74b790..c0a4e45 100644
> --- a/arch/powerpc/boot/dts/lite5200b.dts
> +++ b/arch/powerpc/boot/dts/lite5200b.dts
> @@ -174,7 +174,6 @@
>
> psc@2000 { // PSC1
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <0>;
> reg = <0x2000 0x100>;
> interrupts = <2 1 0>;
> };
> @@ -198,7 +197,6 @@
> // PSC4 in uart mode example
> //serial@2600 { // PSC4
> // compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - // cell-index = <3>;
> // reg = <0x2600 0x100>;
> // interrupts = <2 11 0>;
> //};
> @@ -206,7 +204,6 @@
> // PSC5 in uart mode example
> //serial@2800 { // PSC5
> // compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - // cell-index = <4>;
> // reg = <0x2800 0x100>;
> // interrupts = <2 12 0>;
> //};
How about deleting the commented out nodes entirely since they can now
be captured in the mpc5200.dtsi file.
> diff --git a/arch/powerpc/boot/dts/media5200.dts b/arch/powerpc/boot/dts/media5200.dts
> index a70ef68..e027f45 100644
> --- a/arch/powerpc/boot/dts/media5200.dts
> +++ b/arch/powerpc/boot/dts/media5200.dts
> @@ -185,8 +185,6 @@
> // PSC6 in uart mode
> console: psc@2c00 { // PSC6
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <5>;
> - port-number = <0>; // Logical port assignment
> reg = <0x2c00 0x100>;
> interrupts = <2 4 0>;
> };
> diff --git a/arch/powerpc/boot/dts/motionpro.dts b/arch/powerpc/boot/dts/motionpro.dts
> index f6261ea..3ab4666 100644
> --- a/arch/powerpc/boot/dts/motionpro.dts
> +++ b/arch/powerpc/boot/dts/motionpro.dts
> @@ -277,8 +277,6 @@
> reg = <0 0 0x01000000>;
> bank-width = <2>;
> device-width = <2>;
> - #size-cells = <1>;
> - #address-cells = <1>;
> };
> };
> };
> diff --git a/arch/powerpc/boot/dts/pcm030.dts b/arch/powerpc/boot/dts/pcm030.dts
> index 3a4f554..f3e30bb 100644
> --- a/arch/powerpc/boot/dts/pcm030.dts
> +++ b/arch/powerpc/boot/dts/pcm030.dts
> @@ -196,7 +196,6 @@
>
> psc@2400 { /* PSC3 in UART mode */
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <2>;
> reg = <0x2400 0x100>;
> interrupts = <2 3 0>;
> };
> @@ -207,7 +206,6 @@
>
> psc@2c00 { /* PSC6 in UART mode */
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <5>;
> reg = <0x2c00 0x100>;
> interrupts = <2 4 0>;
> };
> diff --git a/arch/powerpc/boot/dts/pcm032.dts b/arch/powerpc/boot/dts/pcm032.dts
> index 17596c7..e0f2702 100644
> --- a/arch/powerpc/boot/dts/pcm032.dts
> +++ b/arch/powerpc/boot/dts/pcm032.dts
> @@ -196,7 +196,6 @@
>
> psc@2400 { /* PSC3 in UART mode */
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <2>;
> reg = <0x2400 0x100>;
> interrupts = <2 3 0>;
> };
> @@ -207,7 +206,6 @@
>
> psc@2c00 { /* PSC6 in UART mode */
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <5>;
> reg = <0x2c00 0x100>;
> interrupts = <2 4 0>;
> };
>
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: John Bonesio <bones@secretlab.ca>
Cc: jdl@jdl.com, glikely@secretlab.ca,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
david@gibson.dropbear.id.au
Subject: Re: [PATCH 3/5] powerpc/5200: dts: remove unused properties
Date: Tue, 16 Nov 2010 22:05:14 -0700 [thread overview]
Message-ID: <20101117050514.GC12084@angua.secretlab.ca> (raw)
In-Reply-To: <20101116205010.12146.37154.stgit@riker>
On Tue, Nov 16, 2010 at 12:50:10PM -0800, John Bonesio wrote:
> This patch remove unused properties in dts files in preparation of refactoring
> the dts files for MPC5200b based boards.
>
> Signed-off-by: John Bonesio <bones@secretlab.ca>
> ---
>
> arch/powerpc/boot/dts/cm5200.dts | 2 --
> arch/powerpc/boot/dts/lite5200b.dts | 3 ---
> arch/powerpc/boot/dts/media5200.dts | 2 --
> arch/powerpc/boot/dts/motionpro.dts | 2 --
> arch/powerpc/boot/dts/pcm030.dts | 2 --
> arch/powerpc/boot/dts/pcm032.dts | 2 --
> 6 files changed, 0 insertions(+), 13 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/cm5200.dts b/arch/powerpc/boot/dts/cm5200.dts
> index 9369dcd..d549897 100644
> --- a/arch/powerpc/boot/dts/cm5200.dts
> +++ b/arch/powerpc/boot/dts/cm5200.dts
> @@ -230,8 +230,6 @@
> reg = <0 0 0x2000000>;
> bank-width = <2>;
> device-width = <2>;
> - #size-cells = <1>;
> - #address-cells = <1>;
> };
> };
> };
> diff --git a/arch/powerpc/boot/dts/lite5200b.dts b/arch/powerpc/boot/dts/lite5200b.dts
> index a74b790..c0a4e45 100644
> --- a/arch/powerpc/boot/dts/lite5200b.dts
> +++ b/arch/powerpc/boot/dts/lite5200b.dts
> @@ -174,7 +174,6 @@
>
> psc@2000 { // PSC1
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <0>;
> reg = <0x2000 0x100>;
> interrupts = <2 1 0>;
> };
> @@ -198,7 +197,6 @@
> // PSC4 in uart mode example
> //serial@2600 { // PSC4
> // compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - // cell-index = <3>;
> // reg = <0x2600 0x100>;
> // interrupts = <2 11 0>;
> //};
> @@ -206,7 +204,6 @@
> // PSC5 in uart mode example
> //serial@2800 { // PSC5
> // compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - // cell-index = <4>;
> // reg = <0x2800 0x100>;
> // interrupts = <2 12 0>;
> //};
How about deleting the commented out nodes entirely since they can now
be captured in the mpc5200.dtsi file.
> diff --git a/arch/powerpc/boot/dts/media5200.dts b/arch/powerpc/boot/dts/media5200.dts
> index a70ef68..e027f45 100644
> --- a/arch/powerpc/boot/dts/media5200.dts
> +++ b/arch/powerpc/boot/dts/media5200.dts
> @@ -185,8 +185,6 @@
> // PSC6 in uart mode
> console: psc@2c00 { // PSC6
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <5>;
> - port-number = <0>; // Logical port assignment
> reg = <0x2c00 0x100>;
> interrupts = <2 4 0>;
> };
> diff --git a/arch/powerpc/boot/dts/motionpro.dts b/arch/powerpc/boot/dts/motionpro.dts
> index f6261ea..3ab4666 100644
> --- a/arch/powerpc/boot/dts/motionpro.dts
> +++ b/arch/powerpc/boot/dts/motionpro.dts
> @@ -277,8 +277,6 @@
> reg = <0 0 0x01000000>;
> bank-width = <2>;
> device-width = <2>;
> - #size-cells = <1>;
> - #address-cells = <1>;
> };
> };
> };
> diff --git a/arch/powerpc/boot/dts/pcm030.dts b/arch/powerpc/boot/dts/pcm030.dts
> index 3a4f554..f3e30bb 100644
> --- a/arch/powerpc/boot/dts/pcm030.dts
> +++ b/arch/powerpc/boot/dts/pcm030.dts
> @@ -196,7 +196,6 @@
>
> psc@2400 { /* PSC3 in UART mode */
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <2>;
> reg = <0x2400 0x100>;
> interrupts = <2 3 0>;
> };
> @@ -207,7 +206,6 @@
>
> psc@2c00 { /* PSC6 in UART mode */
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <5>;
> reg = <0x2c00 0x100>;
> interrupts = <2 4 0>;
> };
> diff --git a/arch/powerpc/boot/dts/pcm032.dts b/arch/powerpc/boot/dts/pcm032.dts
> index 17596c7..e0f2702 100644
> --- a/arch/powerpc/boot/dts/pcm032.dts
> +++ b/arch/powerpc/boot/dts/pcm032.dts
> @@ -196,7 +196,6 @@
>
> psc@2400 { /* PSC3 in UART mode */
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <2>;
> reg = <0x2400 0x100>;
> interrupts = <2 3 0>;
> };
> @@ -207,7 +206,6 @@
>
> psc@2c00 { /* PSC6 in UART mode */
> compatible = "fsl,mpc5200b-psc-uart","fsl,mpc5200-psc-uart";
> - cell-index = <5>;
> reg = <0x2c00 0x100>;
> interrupts = <2 4 0>;
> };
>
next prev parent reply other threads:[~2010-11-17 5:05 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 20:49 [PATCH 0/5] Series short description John Bonesio
2010-11-16 20:49 ` John Bonesio
2010-11-16 20:49 ` John Bonesio
2010-11-16 20:49 ` [PATCH 1/5] scripts: dtc: Merge in changes from the dtc repository John Bonesio
2010-11-16 20:49 ` John Bonesio
2010-11-17 4:59 ` Grant Likely
2010-11-17 4:59 ` Grant Likely
2010-11-17 15:47 ` Jon Loeliger
2010-11-17 15:47 ` Jon Loeliger
2010-11-17 15:47 ` Jon Loeliger
2010-11-18 3:41 ` David Gibson
2010-11-18 3:41 ` David Gibson
2010-11-18 3:41 ` David Gibson
2010-11-17 5:56 ` Kyle Moffett
2010-11-17 5:56 ` Kyle Moffett
2010-11-17 5:56 ` Kyle Moffett
2010-11-17 5:59 ` Grant Likely
2010-11-17 5:59 ` Grant Likely
2010-11-17 5:59 ` Grant Likely
2010-11-17 15:51 ` Jon Loeliger
2010-11-17 15:51 ` Jon Loeliger
2010-11-17 15:51 ` Jon Loeliger
2010-11-17 6:11 ` Grant Likely
2010-11-17 6:11 ` Grant Likely
2010-11-17 6:11 ` Grant Likely
2010-11-17 6:29 ` John Bonesio
2010-11-17 6:29 ` John Bonesio
2010-11-17 6:29 ` John Bonesio
2010-11-16 20:50 ` [PATCH 2/5] powerpc/5200: dts: rename nodes to prepare for refactoring dts files John Bonesio
2010-11-16 20:50 ` John Bonesio
2010-11-17 5:03 ` Grant Likely
2010-11-17 5:03 ` Grant Likely
2010-11-17 5:03 ` Grant Likely
2010-11-16 20:50 ` [PATCH 3/5] powerpc/5200: dts: remove unused properties John Bonesio
2010-11-16 20:50 ` John Bonesio
2010-11-17 5:05 ` Grant Likely [this message]
2010-11-17 5:05 ` Grant Likely
2010-11-17 5:05 ` Grant Likely
2010-11-16 20:50 ` [PATCH 4/5] powerpc/5200: dts: Remove incorrect combatible strings John Bonesio
2010-11-16 20:50 ` John Bonesio
2010-11-17 5:08 ` Grant Likely
2010-11-17 5:08 ` Grant Likely
2010-11-16 20:50 ` [PATCH 5/5] powerpc/5200: dts: refactor dts files John Bonesio
2010-11-16 20:50 ` John Bonesio
2010-11-17 23:28 [PATCH 0/5] refactor dts files for mpc5200b based systems (take 2) John Bonesio
2010-11-17 23:28 ` [PATCH 3/5] powerpc/5200: dts: remove unused properties John Bonesio
2010-11-17 23:28 ` John Bonesio
2011-01-04 1:29 ` Grant Likely
2011-01-04 1:29 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117050514.GC12084@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=bones@secretlab.ca \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=glikely@secretlab.ca \
--cc=jdl@jdl.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.