From: Gleb Natapov <gleb@redhat.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: Avi Kivity <avi@redhat.com>, Anthony Liguori <aliguori@linux.vnet.ibm.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org, blauwirbel@gmail.com, armbru@redhat.com, alex.williamson@redhat.com, kevin@koconnor.net, Anthony Liguori <aliguori@us.ibm.com> Subject: Re: [PATCHv6 00/16] boot order specification Date: Sun, 28 Nov 2010 15:19:00 +0200 [thread overview] Message-ID: <20101128131900.GC2187@redhat.com> (raw) In-Reply-To: <20101128131352.GA12874@redhat.com> On Sun, Nov 28, 2010 at 03:13:52PM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 28, 2010 at 09:54:04AM +0200, Gleb Natapov wrote: > > On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: > > > On 11/23/2010 06:12 PM, Anthony Liguori wrote: > > > >On 11/23/2010 09:31 AM, Gleb Natapov wrote: > > > >>Anthony, Blue > > > >> > > > >>No comments on this patch series for almost a week. Can it be applied? > > > > > > > >Does that mean everyone's happy or have folks not gotten around to > > > >review it? > > > > > > > >IOW, last call if you have objections :-) > > > > > > > > > > I haven't reviewed this - I trust the author and maintainers to get > > > it right. > > > > > > But I notice the there is no documentation - surely some is needed? > > > > > > > The patch creates Openfirmware device path from qdev > > hierarchy. Each element of a device path depends on type of a bus > > the device resides on. You can find various bus bindings here: > > http://playground.sun.com/1275/bindings/ and main spec is here > > sun.com links have a tendency to disappear nowdays :) > Is this the official location? Aren't bindings part of some standard? I think this is official location. > > It also worries me that PCI Express bindings are in a 'proposal' form > from August 2004. The PCI bindings are from 1994. They are likely to miss > some recent technology advancements :) > > > Further, while this last document which is only 28 page in length, is > not readable by itself: one must first digest the openfirmware spec. > However ... > > > http://forthworks.com/standards/of1275.pdf. > > That's 266 pages of a specification. I am guessing that most of it is > irrelevant for the task in question? Can we have a small text document > including just the path format, please? > So basically you are complaining that reading specs is difficult. It is. That's life. -- Gleb.
WARNING: multiple messages have this Message-ID (diff)
From: Gleb Natapov <gleb@redhat.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: Anthony Liguori <aliguori@us.ibm.com>, kvm@vger.kernel.org, armbru@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, Anthony Liguori <aliguori@linux.vnet.ibm.com>, alex.williamson@redhat.com, kevin@koconnor.net, Avi Kivity <avi@redhat.com> Subject: [Qemu-devel] Re: [PATCHv6 00/16] boot order specification Date: Sun, 28 Nov 2010 15:19:00 +0200 [thread overview] Message-ID: <20101128131900.GC2187@redhat.com> (raw) In-Reply-To: <20101128131352.GA12874@redhat.com> On Sun, Nov 28, 2010 at 03:13:52PM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 28, 2010 at 09:54:04AM +0200, Gleb Natapov wrote: > > On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: > > > On 11/23/2010 06:12 PM, Anthony Liguori wrote: > > > >On 11/23/2010 09:31 AM, Gleb Natapov wrote: > > > >>Anthony, Blue > > > >> > > > >>No comments on this patch series for almost a week. Can it be applied? > > > > > > > >Does that mean everyone's happy or have folks not gotten around to > > > >review it? > > > > > > > >IOW, last call if you have objections :-) > > > > > > > > > > I haven't reviewed this - I trust the author and maintainers to get > > > it right. > > > > > > But I notice the there is no documentation - surely some is needed? > > > > > > > The patch creates Openfirmware device path from qdev > > hierarchy. Each element of a device path depends on type of a bus > > the device resides on. You can find various bus bindings here: > > http://playground.sun.com/1275/bindings/ and main spec is here > > sun.com links have a tendency to disappear nowdays :) > Is this the official location? Aren't bindings part of some standard? I think this is official location. > > It also worries me that PCI Express bindings are in a 'proposal' form > from August 2004. The PCI bindings are from 1994. They are likely to miss > some recent technology advancements :) > > > Further, while this last document which is only 28 page in length, is > not readable by itself: one must first digest the openfirmware spec. > However ... > > > http://forthworks.com/standards/of1275.pdf. > > That's 266 pages of a specification. I am guessing that most of it is > irrelevant for the task in question? Can we have a small text document > including just the path format, please? > So basically you are complaining that reading specs is difficult. It is. That's life. -- Gleb.
next prev parent reply other threads:[~2010-11-28 13:19 UTC|newest] Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-11-17 16:43 [PATCHv6 00/16] boot order specification Gleb Natapov 2010-11-17 16:43 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:43 ` [PATCHv6 01/16] Introduce fw_name field to DeviceInfo structure Gleb Natapov 2010-11-17 16:43 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:43 ` [PATCHv6 02/16] Introduce new BusInfo callback get_fw_dev_path Gleb Natapov 2010-11-17 16:43 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:43 ` [PATCHv6 03/16] Keep track of ISA ports ISA device is using in qdev Gleb Natapov 2010-11-17 16:43 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:43 ` [PATCHv6 04/16] Add get_fw_dev_path callback to ISA bus " Gleb Natapov 2010-11-17 16:43 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:43 ` [PATCHv6 05/16] Store IDE bus id in IDEBus structure for easy access Gleb Natapov 2010-11-17 16:43 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:43 ` [PATCHv6 06/16] Add get_fw_dev_path callback to IDE bus Gleb Natapov 2010-11-17 16:43 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:43 ` [PATCHv6 07/16] Add get_dev_path callback for system bus Gleb Natapov 2010-11-17 16:43 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:43 ` [PATCHv6 08/16] Add get_fw_dev_path callback for pci bus Gleb Natapov 2010-11-17 16:43 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:43 ` [PATCHv6 09/16] Record which USBDevice USBPort belongs too Gleb Natapov 2010-11-17 16:43 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:43 ` [PATCHv6 10/16] Add get_dev_path callback for usb bus Gleb Natapov 2010-11-17 16:43 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:43 ` [PATCHv6 11/16] Add get_dev_path callback to scsi bus Gleb Natapov 2010-11-17 16:43 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:43 ` [PATCHv6 12/16] Add bootindex parameter to net/block/fd device Gleb Natapov 2010-11-17 16:43 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:44 ` [PATCHv6 13/16] Change fw_cfg_add_file() to get full file path as a parameter Gleb Natapov 2010-11-17 16:44 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:44 ` [PATCHv6 14/16] Add bootindex for option roms Gleb Natapov 2010-11-17 16:44 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:44 ` [PATCHv6 15/16] Add notifier that will be called when machine is fully created Gleb Natapov 2010-11-17 16:44 ` [Qemu-devel] " Gleb Natapov 2010-11-17 16:44 ` [PATCHv6 16/16] Pass boot device list to firmware Gleb Natapov 2010-11-17 16:44 ` [Qemu-devel] " Gleb Natapov 2010-11-23 15:31 ` [PATCHv6 00/16] boot order specification Gleb Natapov 2010-11-23 15:31 ` [Qemu-devel] " Gleb Natapov 2010-11-23 16:12 ` Anthony Liguori 2010-11-23 16:12 ` [Qemu-devel] " Anthony Liguori 2010-11-23 19:30 ` Blue Swirl 2010-11-23 19:30 ` [Qemu-devel] " Blue Swirl 2010-11-27 20:56 ` Avi Kivity 2010-11-27 20:56 ` [Qemu-devel] " Avi Kivity 2010-11-28 7:54 ` Gleb Natapov 2010-11-28 7:54 ` [Qemu-devel] " Gleb Natapov 2010-11-28 9:38 ` Avi Kivity 2010-11-28 9:38 ` [Qemu-devel] " Avi Kivity 2010-11-28 9:47 ` Gleb Natapov 2010-11-28 9:47 ` [Qemu-devel] " Gleb Natapov 2010-11-28 12:39 ` Blue Swirl 2010-11-28 12:39 ` [Qemu-devel] " Blue Swirl 2010-11-28 13:03 ` Gleb Natapov 2010-11-28 13:03 ` [Qemu-devel] " Gleb Natapov 2010-11-28 13:13 ` Michael S. Tsirkin 2010-11-28 13:13 ` [Qemu-devel] " Michael S. Tsirkin 2010-11-28 13:19 ` Gleb Natapov [this message] 2010-11-28 13:19 ` Gleb Natapov 2010-11-28 13:22 ` Blue Swirl 2010-11-28 13:22 ` [Qemu-devel] " Blue Swirl 2010-11-28 17:02 ` Michael S. Tsirkin 2010-11-28 17:02 ` [Qemu-devel] " Michael S. Tsirkin 2010-11-28 17:23 ` Michael S. Tsirkin 2010-11-28 17:23 ` [Qemu-devel] " Michael S. Tsirkin 2010-11-28 18:54 ` Gleb Natapov 2010-11-28 18:54 ` [Qemu-devel] " Gleb Natapov 2010-11-28 19:09 ` Michael S. Tsirkin 2010-11-28 19:09 ` [Qemu-devel] " Michael S. Tsirkin 2010-11-28 19:20 ` Gleb Natapov 2010-11-28 19:20 ` [Qemu-devel] " Gleb Natapov 2010-11-28 13:25 ` Gleb Natapov 2010-11-28 13:25 ` [Qemu-devel] " Gleb Natapov 2010-11-24 1:19 ` Kevin O'Connor 2010-11-24 1:19 ` [Qemu-devel] " Kevin O'Connor 2010-11-24 10:03 ` Gleb Natapov 2010-11-24 10:03 ` [Qemu-devel] " Gleb Natapov 2010-11-27 15:41 ` Kevin O'Connor 2010-11-27 15:41 ` [Qemu-devel] " Kevin O'Connor 2010-11-27 16:22 ` Gleb Natapov 2010-11-27 16:22 ` [Qemu-devel] " Gleb Natapov 2010-11-27 16:49 ` Kevin O'Connor 2010-11-27 16:49 ` [Qemu-devel] " Kevin O'Connor 2010-11-27 17:06 ` Gleb Natapov 2010-11-27 17:06 ` [Qemu-devel] " Gleb Natapov 2010-11-27 17:47 ` Kevin O'Connor 2010-11-27 17:47 ` [Qemu-devel] " Kevin O'Connor 2010-11-27 18:15 ` Gleb Natapov 2010-11-27 18:15 ` [Qemu-devel] " Gleb Natapov 2010-11-27 18:40 ` Kevin O'Connor 2010-11-27 18:40 ` [Qemu-devel] " Kevin O'Connor 2010-11-27 19:04 ` Gleb Natapov 2010-11-27 19:04 ` [Qemu-devel] " Gleb Natapov 2010-11-27 21:07 ` Kevin O'Connor 2010-11-27 21:07 ` [Qemu-devel] " Kevin O'Connor 2010-11-28 7:45 ` Gleb Natapov 2010-11-28 7:45 ` [Qemu-devel] " Gleb Natapov 2010-11-28 17:15 ` Kevin O'Connor 2010-11-28 17:15 ` [Qemu-devel] " Kevin O'Connor 2010-11-28 18:47 ` Gleb Natapov 2010-11-28 18:47 ` [Qemu-devel] " Gleb Natapov 2010-11-30 1:34 ` Kevin O'Connor 2010-11-30 14:01 ` Gleb Natapov 2010-11-30 14:01 ` [Qemu-devel] " Gleb Natapov 2010-12-01 2:53 ` Kevin O'Connor 2010-12-01 2:53 ` [Qemu-devel] " Kevin O'Connor 2010-12-01 12:27 ` Gleb Natapov 2010-12-01 12:27 ` [Qemu-devel] " Gleb Natapov 2010-12-02 2:25 ` Kevin O'Connor 2010-12-02 2:25 ` [Qemu-devel] " Kevin O'Connor 2010-12-02 12:30 ` Gleb Natapov 2010-12-02 12:30 ` [Qemu-devel] " Gleb Natapov 2010-12-02 15:07 ` [SeaBIOS] " Peter Stuge 2010-12-02 15:07 ` [Qemu-devel] " Peter Stuge 2010-12-02 17:13 ` Gleb Natapov 2010-12-02 17:13 ` [Qemu-devel] " Gleb Natapov 2010-12-02 21:22 ` Sebastian Herbszt 2010-12-02 21:22 ` [Qemu-devel] " Sebastian Herbszt 2010-12-03 2:01 ` Kevin O'Connor 2010-12-03 2:01 ` [Qemu-devel] " Kevin O'Connor 2010-12-03 5:55 ` Gleb Natapov 2010-12-03 5:55 ` [Qemu-devel] " Gleb Natapov 2010-11-29 10:50 ` Gerd Hoffmann 2010-11-29 10:50 ` [Qemu-devel] " Gerd Hoffmann 2010-11-30 1:55 ` Kevin O'Connor 2010-11-30 14:59 ` Gleb Natapov 2010-11-30 14:59 ` [Qemu-devel] " Gleb Natapov 2010-11-28 19:00 ` [SeaBIOS] " Peter Stuge 2010-11-28 19:00 ` [Qemu-devel] " Peter Stuge 2010-11-28 19:11 ` Peter Stuge 2010-11-28 19:11 ` [Qemu-devel] " Peter Stuge 2010-11-28 19:52 ` Gleb Natapov 2010-11-28 19:52 ` [Qemu-devel] " Gleb Natapov 2010-11-28 19:16 ` Gleb Natapov 2010-11-28 19:16 ` [Qemu-devel] " Gleb Natapov 2010-11-29 10:19 ` Gerd Hoffmann 2010-11-29 10:19 ` [Qemu-devel] " Gerd Hoffmann 2010-11-29 12:07 ` Gleb Natapov 2010-11-29 12:07 ` [Qemu-devel] " Gleb Natapov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20101128131900.GC2187@redhat.com \ --to=gleb@redhat.com \ --cc=alex.williamson@redhat.com \ --cc=aliguori@linux.vnet.ibm.com \ --cc=aliguori@us.ibm.com \ --cc=armbru@redhat.com \ --cc=avi@redhat.com \ --cc=blauwirbel@gmail.com \ --cc=kevin@koconnor.net \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.