All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: imx/eukrea_mbimx27: fix compile warnings about unused variables
@ 2011-02-08 20:17 Uwe Kleine-König
  2011-02-09 13:57 ` Sergei Shtylyov
  0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2011-02-08 20:17 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
 arch/arm/mach-imx/eukrea_mbimx27-baseboard.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
index 275c858..9ac5348 100644
--- a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
+++ b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
@@ -249,7 +249,7 @@ static const struct imxuart_platform_data uart_pdata __initconst = {
 
 #define ADS7846_PENDOWN (GPIO_PORTD | 25)
 
-static void ads7846_dev_init(void)
+static void __maybe_unused ads7846_dev_init(void)
 {
 	if (gpio_request(ADS7846_PENDOWN, "ADS7846 pendown") < 0) {
 		printk(KERN_ERR "can't get ads746 pen down GPIO\n");
@@ -268,7 +268,8 @@ static struct ads7846_platform_data ads7846_config __initdata = {
 	.keep_vref_on		= 1,
 };
 
-static struct spi_board_info eukrea_mbimx27_spi_board_info[] __initdata = {
+static struct spi_board_info __maybe_unused
+eukrea_mbimx27_spi_board_info[] __initdata = {
 	[0] = {
 		.modalias	= "ads7846",
 		.bus_num	= 0,
-- 
1.7.2.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] ARM: imx/eukrea_mbimx27: fix compile warnings about unused variables
  2011-02-08 20:17 [PATCH] ARM: imx/eukrea_mbimx27: fix compile warnings about unused variables Uwe Kleine-König
@ 2011-02-09 13:57 ` Sergei Shtylyov
  2011-02-09 19:39   ` Uwe Kleine-König
  0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2011-02-09 13:57 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 08-02-2011 23:17, Uwe Kleine-K?nig wrote:

> Signed-off-by: Uwe Kleine-K?nig<u.kleine-koenig@pengutronix.de>
[...]

> diff --git a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
> index 275c858..9ac5348 100644
> --- a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
> +++ b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
[...]
> @@ -268,7 +268,8 @@ static struct ads7846_platform_data ads7846_config __initdata = {
>   	.keep_vref_on		= 1,
>   };
>
> -static struct spi_board_info eukrea_mbimx27_spi_board_info[] __initdata = {
> +static struct spi_board_info __maybe_unused
> +eukrea_mbimx27_spi_board_info[] __initdata = {

    I think the second line should be somewhat indented.

WBR, Sergei

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: imx/eukrea_mbimx27: fix compile warnings about unused variables
  2011-02-09 13:57 ` Sergei Shtylyov
@ 2011-02-09 19:39   ` Uwe Kleine-König
  2011-02-09 20:13     ` Sergei Shtylyov
  0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2011-02-09 19:39 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Feb 09, 2011 at 04:57:18PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 08-02-2011 23:17, Uwe Kleine-K?nig wrote:
> 
> >Signed-off-by: Uwe Kleine-K?nig<u.kleine-koenig@pengutronix.de>
> [...]
> 
> >diff --git a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
> >index 275c858..9ac5348 100644
> >--- a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
> >+++ b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
> [...]
> >@@ -268,7 +268,8 @@ static struct ads7846_platform_data ads7846_config __initdata = {
> >  	.keep_vref_on		= 1,
> >  };
> >
> >-static struct spi_board_info eukrea_mbimx27_spi_board_info[] __initdata = {
> >+static struct spi_board_info __maybe_unused
> >+eukrea_mbimx27_spi_board_info[] __initdata = {
> 
>    I think the second line should be somewhat indented.
I like it as it is.  There are no rules for that, no?

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: imx/eukrea_mbimx27: fix compile warnings about unused variables
  2011-02-09 19:39   ` Uwe Kleine-König
@ 2011-02-09 20:13     ` Sergei Shtylyov
  2011-02-10 10:07       ` Uwe Kleine-König
  0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2011-02-09 20:13 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

Uwe Kleine-K?nig wrote:

>>> Signed-off-by: Uwe Kleine-K?nig<u.kleine-koenig@pengutronix.de>
>> [...]

>>> diff --git a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
>>> index 275c858..9ac5348 100644
>>> --- a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
>>> +++ b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
>> [...]
>>> @@ -268,7 +268,8 @@ static struct ads7846_platform_data ads7846_config __initdata = {
>>>  	.keep_vref_on		= 1,
>>>  };
>>>
>>> -static struct spi_board_info eukrea_mbimx27_spi_board_info[] __initdata = {
>>> +static struct spi_board_info __maybe_unused
>>> +eukrea_mbimx27_spi_board_info[] __initdata = {

>>    I think the second line should be somewhat indented.

> I like it as it is.  There are no rules for that, no?

    Documentation/CodingStyle, chapter 2.

> Uwe

WBR, Sergei

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: imx/eukrea_mbimx27: fix compile warnings about unused variables
  2011-02-09 20:13     ` Sergei Shtylyov
@ 2011-02-10 10:07       ` Uwe Kleine-König
  0 siblings, 0 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2011-02-10 10:07 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
Hello,

On Wed, Feb 09, 2011 at 11:13:26PM +0300, Sergei Shtylyov wrote:
> >>>-static struct spi_board_info eukrea_mbimx27_spi_board_info[] __initdata = {
> >>>+static struct spi_board_info __maybe_unused
> >>>+eukrea_mbimx27_spi_board_info[] __initdata = {
>
> >>   I think the second line should be somewhat indented.
> 
> >I like it as it is.  There are no rules for that, no?
> 
>    Documentation/CodingStyle, chapter 2.
hmm, this is how vim indents and checkpatch doesn't diagnose a style problem.
Though I prefer it unindented, too, I don't care enough.  So here's a patch
with the 2nd line having 2 tabs.  Up to Sascha which to include ...

Best regards and thanks,
Uwe

 arch/arm/mach-imx/eukrea_mbimx27-baseboard.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
index 275c858..d12815d 100644
--- a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
+++ b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
@@ -249,7 +249,7 @@ static const struct imxuart_platform_data uart_pdata __initconst = {
 
 #define ADS7846_PENDOWN (GPIO_PORTD | 25)
 
-static void ads7846_dev_init(void)
+static void __maybe_unused ads7846_dev_init(void)
 {
 	if (gpio_request(ADS7846_PENDOWN, "ADS7846 pendown") < 0) {
 		printk(KERN_ERR "can't get ads746 pen down GPIO\n");
@@ -268,7 +268,8 @@ static struct ads7846_platform_data ads7846_config __initdata = {
 	.keep_vref_on		= 1,
 };
 
-static struct spi_board_info eukrea_mbimx27_spi_board_info[] __initdata = {
+static struct spi_board_info __maybe_unused
+		eukrea_mbimx27_spi_board_info[] __initdata = {
 	[0] = {
 		.modalias	= "ads7846",
 		.bus_num	= 0,
-- 
1.7.2.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-02-10 10:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-08 20:17 [PATCH] ARM: imx/eukrea_mbimx27: fix compile warnings about unused variables Uwe Kleine-König
2011-02-09 13:57 ` Sergei Shtylyov
2011-02-09 19:39   ` Uwe Kleine-König
2011-02-09 20:13     ` Sergei Shtylyov
2011-02-10 10:07       ` Uwe Kleine-König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.