All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
	Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH v2 02/10] compaction: trivial clean up acct_isolated
Date: Tue, 31 May 2011 14:11:50 +0200	[thread overview]
Message-ID: <20110531121150.GA3190@cmpxchg.org> (raw)
In-Reply-To: <d2a446699fd72bf439b0e538f798e3d600314d92.1306689214.git.minchan.kim@gmail.com>

On Mon, May 30, 2011 at 03:13:41AM +0900, Minchan Kim wrote:
> acct_isolated of compaction uses page_lru_base_type which returns only
> base type of LRU list so it never returns LRU_ACTIVE_ANON or LRU_ACTIVE_FILE.
> In addtion, cc->nr_[anon|file] is used in only acct_isolated so it doesn't have
> fields in conpact_control.
> This patch removes fields from compact_control and makes clear function of
> acct_issolated which counts the number of anon|file pages isolated.
> 
> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Signed-off-by: Minchan Kim <minchan.kim@gmail.com>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
	Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH v2 02/10] compaction: trivial clean up acct_isolated
Date: Tue, 31 May 2011 14:11:50 +0200	[thread overview]
Message-ID: <20110531121150.GA3190@cmpxchg.org> (raw)
In-Reply-To: <d2a446699fd72bf439b0e538f798e3d600314d92.1306689214.git.minchan.kim@gmail.com>

On Mon, May 30, 2011 at 03:13:41AM +0900, Minchan Kim wrote:
> acct_isolated of compaction uses page_lru_base_type which returns only
> base type of LRU list so it never returns LRU_ACTIVE_ANON or LRU_ACTIVE_FILE.
> In addtion, cc->nr_[anon|file] is used in only acct_isolated so it doesn't have
> fields in conpact_control.
> This patch removes fields from compact_control and makes clear function of
> acct_issolated which counts the number of anon|file pages isolated.
> 
> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Signed-off-by: Minchan Kim <minchan.kim@gmail.com>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-05-31 12:12 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-29 18:13 [PATCH v2 00/10] Prevent LRU churning Minchan Kim
2011-05-29 18:13 ` Minchan Kim
2011-05-29 18:13 ` [PATCH v2 01/10] Make clear description of isolate/putback functions Minchan Kim
2011-05-29 18:13   ` Minchan Kim
2011-05-31 20:48   ` Rik van Riel
2011-05-31 20:48     ` Rik van Riel
2011-05-29 18:13 ` [PATCH v2 02/10] compaction: trivial clean up acct_isolated Minchan Kim
2011-05-29 18:13   ` Minchan Kim
2011-05-31 12:11   ` Johannes Weiner [this message]
2011-05-31 12:11     ` Johannes Weiner
2011-06-01 15:31   ` Rik van Riel
2011-06-01 15:31     ` Rik van Riel
2011-05-29 18:13 ` [PATCH v2 03/10] Change isolate mode from int type to enum type Minchan Kim
2011-05-29 18:13   ` Minchan Kim
2011-05-31 13:36   ` Johannes Weiner
2011-05-31 13:36     ` Johannes Weiner
2011-05-31 13:44     ` Minchan Kim
2011-05-31 13:44       ` Minchan Kim
2011-05-29 18:13 ` [PATCH v2 04/10] Add additional isolation mode Minchan Kim
2011-05-29 18:13   ` Minchan Kim
2011-05-31 13:39   ` Johannes Weiner
2011-05-31 13:39     ` Johannes Weiner
2011-06-01 15:55   ` Rik van Riel
2011-06-01 15:55     ` Rik van Riel
2011-05-29 18:13 ` [PATCH v2 05/10] compaction: make isolate_lru_page with filter aware Minchan Kim
2011-05-29 18:13   ` Minchan Kim
2011-06-01 16:03   ` Rik van Riel
2011-06-01 16:03     ` Rik van Riel
2011-05-29 18:13 ` [PATCH v2 06/10] vmscan: " Minchan Kim
2011-05-29 18:13   ` Minchan Kim
2011-05-31 13:46   ` Johannes Weiner
2011-05-31 13:46     ` Johannes Weiner
2011-05-31 13:51     ` Minchan Kim
2011-05-31 13:51       ` Minchan Kim
2011-05-29 18:13 ` [PATCH v2 07/10] In order putback lru core Minchan Kim
2011-05-29 18:13   ` Minchan Kim
2011-06-01 21:08   ` Rik van Riel
2011-06-01 21:08     ` Rik van Riel
2011-05-29 18:13 ` [PATCH v2 08/10] migration: make in-order-putback aware Minchan Kim
2011-05-29 18:13   ` Minchan Kim
2011-05-29 18:13 ` [PATCH v2 09/10] compaction: make compaction use in-order putback Minchan Kim
2011-05-29 18:13   ` Minchan Kim
2011-05-29 18:13 ` [PATCH v2 10/10] add tracepoints Minchan Kim
2011-05-29 18:13   ` Minchan Kim
2011-05-29 18:37 ` [PATCH v2 00/10] Prevent LRU churning Minchan Kim
2011-05-29 18:37   ` Minchan Kim
2011-05-30  1:47 ` KOSAKI Motohiro
2011-05-30  1:47   ` KOSAKI Motohiro
2011-05-30  7:25   ` Minchan Kim
2011-05-30  7:25     ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110531121150.GA3190@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=minchan.kim@gmail.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.