From: Minchan Kim <minchan.kim@gmail.com> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>, Andrea Arcangeli <aarcange@redhat.com>, Johannes Weiner <hannes@cmpxchg.org>, Minchan Kim <minchan.kim@gmail.com> Subject: [PATCH v2 10/10] add tracepoints Date: Mon, 30 May 2011 03:13:49 +0900 [thread overview] Message-ID: <9777d8d136811e8790a4be18af6f6c5628232f09.1306689214.git.minchan.kim@gmail.com> (raw) In-Reply-To: <cover.1306689214.git.minchan.kim@gmail.com> In-Reply-To: <cover.1306689214.git.minchan.kim@gmail.com> This patch adds some tracepints for see the effect this patch series. This tracepoints isn't for merge but just see the effect. Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Cc: Mel Gorman <mgorman@suse.de> Cc: Rik van Riel <riel@redhat.com> Cc: Andrea Arcangeli <aarcange@redhat.com> Signed-off-by: Minchan Kim <minchan.kim@gmail.com> --- include/trace/events/inorder_putback.h | 79 ++++++++++++++++++++++++++++++++ mm/compaction.c | 2 + mm/migrate.c | 7 +++ mm/vmscan.c | 3 +- 4 files changed, 89 insertions(+), 2 deletions(-) create mode 100644 include/trace/events/inorder_putback.h diff --git a/include/trace/events/inorder_putback.h b/include/trace/events/inorder_putback.h new file mode 100644 index 0000000..c615ed8 --- /dev/null +++ b/include/trace/events/inorder_putback.h @@ -0,0 +1,79 @@ +#undef TRACE_SYSTEM +#define TRACE_SYSTEM inorder_putback + +#if !defined(_TRACE_INP_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_INP_H + +#include <linux/types.h> +#include <linux/tracepoint.h> + +TRACE_EVENT(mm_compaction_inorder, + + TP_PROTO(struct page *page, + struct page *newpage), + + TP_ARGS(page, newpage), + + TP_STRUCT__entry( + __field(struct page *, page) + __field(struct page *, newpage) + ), + + TP_fast_assign( + __entry->page = page; + __entry->newpage = newpage; + ), + + TP_printk("pfn=%lu new pfn=%lu", + page_to_pfn(__entry->page), + page_to_pfn(__entry->newpage)) +); + +TRACE_EVENT(mm_compaction_outoforder, + + TP_PROTO(struct page *page, + struct page *newpage), + + TP_ARGS(page, newpage), + + TP_STRUCT__entry( + __field(struct page *, page) + __field(struct page *, newpage) + ), + + TP_fast_assign( + __entry->page = page; + __entry->newpage = newpage; + ), + + TP_printk("pfn=%lu new pfn=%lu", + page_to_pfn(__entry->page), + page_to_pfn(__entry->newpage)) +); + +TRACE_EVENT(mm_compact_isolate, + + TP_PROTO(struct page *prev_page, + struct page *page), + + TP_ARGS(prev_page, page), + + TP_STRUCT__entry( + __field(struct page *, prev_page) + __field(struct page *, page) + ), + + TP_fast_assign( + __entry->prev_page = prev_page; + __entry->page = page; + ), + + TP_printk("pfn=%lu prev_pfn=%lu", + page_to_pfn(__entry->page), + page_to_pfn(__entry->prev_page)) +); + +#endif /* _TRACE_INP_H */ + +/* This part must be outside protection */ +#include <trace/define_trace.h> diff --git a/mm/compaction.c b/mm/compaction.c index 00e710a..92c180d 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -16,6 +16,7 @@ #include <linux/sysfs.h> #include "internal.h" +#include <trace/events/inorder_putback.h> #define CREATE_TRACE_POINTS #include <trace/events/compaction.h> @@ -333,6 +334,7 @@ static unsigned long isolate_migratepages(struct zone *zone, if (__isolate_inorder_lru_page(page, mode, 0, &prev_page) != 0) continue; + trace_mm_compact_isolate(prev_page, page); VM_BUG_ON(PageTransCompound(page)); /* Successfully isolated */ diff --git a/mm/migrate.c b/mm/migrate.c index bc614d3..6ec98c1 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -39,6 +39,9 @@ #include "internal.h" +#define CREATE_TRACE_POINTS +#include <trace/events/inorder_putback.h> + #define lru_to_page(_head) (list_entry((_head)->prev, struct page, lru)) /* @@ -96,10 +99,12 @@ void putback_inorder_lru_pages(struct inorder_lru *l) spin_lock_irq(&zone->lru_lock); prev = page->ilru.prev_page; if (keep_lru_order(page, prev)) { + trace_mm_compaction_inorder(page, page); putback_page_to_lru(page, prev); spin_unlock_irq(&zone->lru_lock); } else { + trace_mm_compaction_outoforder(page, page); spin_unlock_irq(&zone->lru_lock); putback_lru_page(page); } @@ -1060,6 +1065,7 @@ move_newpage: if (keep_lru_order(page, prev_page)) { putback_page_to_lru(newpage, prev_page); spin_unlock_irq(&zone->lru_lock); + trace_mm_compaction_inorder(page, newpage); /* * The newpage will replace LRU position of old page and * old one would be freed. So let's adjust prev_page of pages @@ -1071,6 +1077,7 @@ move_newpage: else { spin_unlock_irq(&zone->lru_lock); + trace_mm_compaction_inorder(page, newpage); putback_lru_page(newpage); } diff --git a/mm/vmscan.c b/mm/vmscan.c index 118ce9f..10e4577 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -49,10 +49,9 @@ #include <linux/swapops.h> #include "internal.h" - +#include <trace/events/inorder_putback.h> #define CREATE_TRACE_POINTS #include <trace/events/vmscan.h> - /* * reclaim_mode determines how the inactive list is shrunk * RECLAIM_MODE_SINGLE: Reclaim only order-0 pages -- 1.7.0.4
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan.kim@gmail.com> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>, Andrea Arcangeli <aarcange@redhat.com>, Johannes Weiner <hannes@cmpxchg.org>, Minchan Kim <minchan.kim@gmail.com> Subject: [PATCH v2 10/10] add tracepoints Date: Mon, 30 May 2011 03:13:49 +0900 [thread overview] Message-ID: <9777d8d136811e8790a4be18af6f6c5628232f09.1306689214.git.minchan.kim@gmail.com> (raw) In-Reply-To: <cover.1306689214.git.minchan.kim@gmail.com> In-Reply-To: <cover.1306689214.git.minchan.kim@gmail.com> This patch adds some tracepints for see the effect this patch series. This tracepoints isn't for merge but just see the effect. Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Cc: Mel Gorman <mgorman@suse.de> Cc: Rik van Riel <riel@redhat.com> Cc: Andrea Arcangeli <aarcange@redhat.com> Signed-off-by: Minchan Kim <minchan.kim@gmail.com> --- include/trace/events/inorder_putback.h | 79 ++++++++++++++++++++++++++++++++ mm/compaction.c | 2 + mm/migrate.c | 7 +++ mm/vmscan.c | 3 +- 4 files changed, 89 insertions(+), 2 deletions(-) create mode 100644 include/trace/events/inorder_putback.h diff --git a/include/trace/events/inorder_putback.h b/include/trace/events/inorder_putback.h new file mode 100644 index 0000000..c615ed8 --- /dev/null +++ b/include/trace/events/inorder_putback.h @@ -0,0 +1,79 @@ +#undef TRACE_SYSTEM +#define TRACE_SYSTEM inorder_putback + +#if !defined(_TRACE_INP_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_INP_H + +#include <linux/types.h> +#include <linux/tracepoint.h> + +TRACE_EVENT(mm_compaction_inorder, + + TP_PROTO(struct page *page, + struct page *newpage), + + TP_ARGS(page, newpage), + + TP_STRUCT__entry( + __field(struct page *, page) + __field(struct page *, newpage) + ), + + TP_fast_assign( + __entry->page = page; + __entry->newpage = newpage; + ), + + TP_printk("pfn=%lu new pfn=%lu", + page_to_pfn(__entry->page), + page_to_pfn(__entry->newpage)) +); + +TRACE_EVENT(mm_compaction_outoforder, + + TP_PROTO(struct page *page, + struct page *newpage), + + TP_ARGS(page, newpage), + + TP_STRUCT__entry( + __field(struct page *, page) + __field(struct page *, newpage) + ), + + TP_fast_assign( + __entry->page = page; + __entry->newpage = newpage; + ), + + TP_printk("pfn=%lu new pfn=%lu", + page_to_pfn(__entry->page), + page_to_pfn(__entry->newpage)) +); + +TRACE_EVENT(mm_compact_isolate, + + TP_PROTO(struct page *prev_page, + struct page *page), + + TP_ARGS(prev_page, page), + + TP_STRUCT__entry( + __field(struct page *, prev_page) + __field(struct page *, page) + ), + + TP_fast_assign( + __entry->prev_page = prev_page; + __entry->page = page; + ), + + TP_printk("pfn=%lu prev_pfn=%lu", + page_to_pfn(__entry->page), + page_to_pfn(__entry->prev_page)) +); + +#endif /* _TRACE_INP_H */ + +/* This part must be outside protection */ +#include <trace/define_trace.h> diff --git a/mm/compaction.c b/mm/compaction.c index 00e710a..92c180d 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -16,6 +16,7 @@ #include <linux/sysfs.h> #include "internal.h" +#include <trace/events/inorder_putback.h> #define CREATE_TRACE_POINTS #include <trace/events/compaction.h> @@ -333,6 +334,7 @@ static unsigned long isolate_migratepages(struct zone *zone, if (__isolate_inorder_lru_page(page, mode, 0, &prev_page) != 0) continue; + trace_mm_compact_isolate(prev_page, page); VM_BUG_ON(PageTransCompound(page)); /* Successfully isolated */ diff --git a/mm/migrate.c b/mm/migrate.c index bc614d3..6ec98c1 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -39,6 +39,9 @@ #include "internal.h" +#define CREATE_TRACE_POINTS +#include <trace/events/inorder_putback.h> + #define lru_to_page(_head) (list_entry((_head)->prev, struct page, lru)) /* @@ -96,10 +99,12 @@ void putback_inorder_lru_pages(struct inorder_lru *l) spin_lock_irq(&zone->lru_lock); prev = page->ilru.prev_page; if (keep_lru_order(page, prev)) { + trace_mm_compaction_inorder(page, page); putback_page_to_lru(page, prev); spin_unlock_irq(&zone->lru_lock); } else { + trace_mm_compaction_outoforder(page, page); spin_unlock_irq(&zone->lru_lock); putback_lru_page(page); } @@ -1060,6 +1065,7 @@ move_newpage: if (keep_lru_order(page, prev_page)) { putback_page_to_lru(newpage, prev_page); spin_unlock_irq(&zone->lru_lock); + trace_mm_compaction_inorder(page, newpage); /* * The newpage will replace LRU position of old page and * old one would be freed. So let's adjust prev_page of pages @@ -1071,6 +1077,7 @@ move_newpage: else { spin_unlock_irq(&zone->lru_lock); + trace_mm_compaction_inorder(page, newpage); putback_lru_page(newpage); } diff --git a/mm/vmscan.c b/mm/vmscan.c index 118ce9f..10e4577 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -49,10 +49,9 @@ #include <linux/swapops.h> #include "internal.h" - +#include <trace/events/inorder_putback.h> #define CREATE_TRACE_POINTS #include <trace/events/vmscan.h> - /* * reclaim_mode determines how the inactive list is shrunk * RECLAIM_MODE_SINGLE: Reclaim only order-0 pages -- 1.7.0.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-29 18:14 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-05-29 18:13 [PATCH v2 00/10] Prevent LRU churning Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-29 18:13 ` [PATCH v2 01/10] Make clear description of isolate/putback functions Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-31 20:48 ` Rik van Riel 2011-05-31 20:48 ` Rik van Riel 2011-05-29 18:13 ` [PATCH v2 02/10] compaction: trivial clean up acct_isolated Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-31 12:11 ` Johannes Weiner 2011-05-31 12:11 ` Johannes Weiner 2011-06-01 15:31 ` Rik van Riel 2011-06-01 15:31 ` Rik van Riel 2011-05-29 18:13 ` [PATCH v2 03/10] Change isolate mode from int type to enum type Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-31 13:36 ` Johannes Weiner 2011-05-31 13:36 ` Johannes Weiner 2011-05-31 13:44 ` Minchan Kim 2011-05-31 13:44 ` Minchan Kim 2011-05-29 18:13 ` [PATCH v2 04/10] Add additional isolation mode Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-31 13:39 ` Johannes Weiner 2011-05-31 13:39 ` Johannes Weiner 2011-06-01 15:55 ` Rik van Riel 2011-06-01 15:55 ` Rik van Riel 2011-05-29 18:13 ` [PATCH v2 05/10] compaction: make isolate_lru_page with filter aware Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-06-01 16:03 ` Rik van Riel 2011-06-01 16:03 ` Rik van Riel 2011-05-29 18:13 ` [PATCH v2 06/10] vmscan: " Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-31 13:46 ` Johannes Weiner 2011-05-31 13:46 ` Johannes Weiner 2011-05-31 13:51 ` Minchan Kim 2011-05-31 13:51 ` Minchan Kim 2011-05-29 18:13 ` [PATCH v2 07/10] In order putback lru core Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-06-01 21:08 ` Rik van Riel 2011-06-01 21:08 ` Rik van Riel 2011-05-29 18:13 ` [PATCH v2 08/10] migration: make in-order-putback aware Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-29 18:13 ` [PATCH v2 09/10] compaction: make compaction use in-order putback Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-29 18:13 ` Minchan Kim [this message] 2011-05-29 18:13 ` [PATCH v2 10/10] add tracepoints Minchan Kim 2011-05-29 18:37 ` [PATCH v2 00/10] Prevent LRU churning Minchan Kim 2011-05-29 18:37 ` Minchan Kim 2011-05-30 1:47 ` KOSAKI Motohiro 2011-05-30 1:47 ` KOSAKI Motohiro 2011-05-30 7:25 ` Minchan Kim 2011-05-30 7:25 ` Minchan Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9777d8d136811e8790a4be18af6f6c5628232f09.1306689214.git.minchan.kim@gmail.com \ --to=minchan.kim@gmail.com \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=hannes@cmpxchg.org \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=kosaki.motohiro@jp.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=riel@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.