From: Minchan Kim <minchan.kim@gmail.com> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>, Andrea Arcangeli <aarcange@redhat.com>, Johannes Weiner <hannes@cmpxchg.org>, Minchan Kim <minchan.kim@gmail.com> Subject: [PATCH v2 05/10] compaction: make isolate_lru_page with filter aware Date: Mon, 30 May 2011 03:13:44 +0900 [thread overview] Message-ID: <4feb21bdac4c00a30f3c0d9361bd3565e6afa72f.1306689214.git.minchan.kim@gmail.com> (raw) In-Reply-To: <cover.1306689214.git.minchan.kim@gmail.com> In-Reply-To: <cover.1306689214.git.minchan.kim@gmail.com> In async mode, compaction doesn't migrate dirty or writeback pages. So, it's meaningless to pick the page and re-add it to lru list. Of course, when we isolate the page in compaction, the page might be dirty or writeback but when we try to migrate the page, the page would be not dirty, writeback. So it could be migrated. But it's very unlikely as isolate and migration cycle is much faster than writeout. So, this patch helps cpu and prevent unnecessary LRU churning. Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Acked-by: Mel Gorman <mgorman@suse.de> Cc: Rik van Riel <riel@redhat.com> Cc: Andrea Arcangeli <aarcange@redhat.com> Signed-off-by: Minchan Kim <minchan.kim@gmail.com> --- mm/compaction.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 61eab88..e218562 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -243,6 +243,7 @@ static unsigned long isolate_migratepages(struct zone *zone, unsigned long last_pageblock_nr = 0, pageblock_nr; unsigned long nr_scanned = 0, nr_isolated = 0; struct list_head *migratelist = &cc->migratepages; + enum ISOLATE_PAGE_MODE mode = ISOLATE_BOTH; /* Do not scan outside zone boundaries */ low_pfn = max(cc->migrate_pfn, zone->zone_start_pfn); @@ -327,7 +328,9 @@ static unsigned long isolate_migratepages(struct zone *zone, } /* Try isolate the page */ - if (__isolate_lru_page(page, ISOLATE_BOTH, 0) != 0) + if (!cc->sync) + mode |= ISOLATE_CLEAN; + if (__isolate_lru_page(page, mode, 0) != 0) continue; VM_BUG_ON(PageTransCompound(page)); -- 1.7.0.4
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan.kim@gmail.com> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>, Andrea Arcangeli <aarcange@redhat.com>, Johannes Weiner <hannes@cmpxchg.org>, Minchan Kim <minchan.kim@gmail.com> Subject: [PATCH v2 05/10] compaction: make isolate_lru_page with filter aware Date: Mon, 30 May 2011 03:13:44 +0900 [thread overview] Message-ID: <4feb21bdac4c00a30f3c0d9361bd3565e6afa72f.1306689214.git.minchan.kim@gmail.com> (raw) In-Reply-To: <cover.1306689214.git.minchan.kim@gmail.com> In-Reply-To: <cover.1306689214.git.minchan.kim@gmail.com> In async mode, compaction doesn't migrate dirty or writeback pages. So, it's meaningless to pick the page and re-add it to lru list. Of course, when we isolate the page in compaction, the page might be dirty or writeback but when we try to migrate the page, the page would be not dirty, writeback. So it could be migrated. But it's very unlikely as isolate and migration cycle is much faster than writeout. So, this patch helps cpu and prevent unnecessary LRU churning. Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Acked-by: Mel Gorman <mgorman@suse.de> Cc: Rik van Riel <riel@redhat.com> Cc: Andrea Arcangeli <aarcange@redhat.com> Signed-off-by: Minchan Kim <minchan.kim@gmail.com> --- mm/compaction.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 61eab88..e218562 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -243,6 +243,7 @@ static unsigned long isolate_migratepages(struct zone *zone, unsigned long last_pageblock_nr = 0, pageblock_nr; unsigned long nr_scanned = 0, nr_isolated = 0; struct list_head *migratelist = &cc->migratepages; + enum ISOLATE_PAGE_MODE mode = ISOLATE_BOTH; /* Do not scan outside zone boundaries */ low_pfn = max(cc->migrate_pfn, zone->zone_start_pfn); @@ -327,7 +328,9 @@ static unsigned long isolate_migratepages(struct zone *zone, } /* Try isolate the page */ - if (__isolate_lru_page(page, ISOLATE_BOTH, 0) != 0) + if (!cc->sync) + mode |= ISOLATE_CLEAN; + if (__isolate_lru_page(page, mode, 0) != 0) continue; VM_BUG_ON(PageTransCompound(page)); -- 1.7.0.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-29 18:14 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-05-29 18:13 [PATCH v2 00/10] Prevent LRU churning Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-29 18:13 ` [PATCH v2 01/10] Make clear description of isolate/putback functions Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-31 20:48 ` Rik van Riel 2011-05-31 20:48 ` Rik van Riel 2011-05-29 18:13 ` [PATCH v2 02/10] compaction: trivial clean up acct_isolated Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-31 12:11 ` Johannes Weiner 2011-05-31 12:11 ` Johannes Weiner 2011-06-01 15:31 ` Rik van Riel 2011-06-01 15:31 ` Rik van Riel 2011-05-29 18:13 ` [PATCH v2 03/10] Change isolate mode from int type to enum type Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-31 13:36 ` Johannes Weiner 2011-05-31 13:36 ` Johannes Weiner 2011-05-31 13:44 ` Minchan Kim 2011-05-31 13:44 ` Minchan Kim 2011-05-29 18:13 ` [PATCH v2 04/10] Add additional isolation mode Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-31 13:39 ` Johannes Weiner 2011-05-31 13:39 ` Johannes Weiner 2011-06-01 15:55 ` Rik van Riel 2011-06-01 15:55 ` Rik van Riel 2011-05-29 18:13 ` Minchan Kim [this message] 2011-05-29 18:13 ` [PATCH v2 05/10] compaction: make isolate_lru_page with filter aware Minchan Kim 2011-06-01 16:03 ` Rik van Riel 2011-06-01 16:03 ` Rik van Riel 2011-05-29 18:13 ` [PATCH v2 06/10] vmscan: " Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-31 13:46 ` Johannes Weiner 2011-05-31 13:46 ` Johannes Weiner 2011-05-31 13:51 ` Minchan Kim 2011-05-31 13:51 ` Minchan Kim 2011-05-29 18:13 ` [PATCH v2 07/10] In order putback lru core Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-06-01 21:08 ` Rik van Riel 2011-06-01 21:08 ` Rik van Riel 2011-05-29 18:13 ` [PATCH v2 08/10] migration: make in-order-putback aware Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-29 18:13 ` [PATCH v2 09/10] compaction: make compaction use in-order putback Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-29 18:13 ` [PATCH v2 10/10] add tracepoints Minchan Kim 2011-05-29 18:13 ` Minchan Kim 2011-05-29 18:37 ` [PATCH v2 00/10] Prevent LRU churning Minchan Kim 2011-05-29 18:37 ` Minchan Kim 2011-05-30 1:47 ` KOSAKI Motohiro 2011-05-30 1:47 ` KOSAKI Motohiro 2011-05-30 7:25 ` Minchan Kim 2011-05-30 7:25 ` Minchan Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4feb21bdac4c00a30f3c0d9361bd3565e6afa72f.1306689214.git.minchan.kim@gmail.com \ --to=minchan.kim@gmail.com \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=hannes@cmpxchg.org \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=kosaki.motohiro@jp.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=riel@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.