From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: romieu@fr.zoreil.com, greearb@candelatech.com,
torvalds@linux-foundation.org, david@unsolicited.net,
tj@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: allow netif_carrier to be called safely from IRQ
Date: Fri, 22 Jul 2011 17:16:42 -0700 (PDT) [thread overview]
Message-ID: <20110722.171642.1498051921735569337.davem@davemloft.net> (raw)
In-Reply-To: <20110722155356.5911225f@nehalam.ftrdhcpuser.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 22 Jul 2011 15:53:56 -0700
> As reported by Ben Greer and Froncois Romieu. The code path in
> the netif_carrier code leads it to try and disable
> a late workqueue to reenable it immediately
> netif_carrier_on
> -> linkwatch_fire_event
> -> linkwatch_schedule_work
> -> cancel_delayed_work
> -> del_timer_sync
>
> If __cancel_delayed_work is used instead then there is no
> problem of waiting for running linkwatch_event.
>
> There is a race between linkwatch_event running re-scheduling
> but it is harmless to schedule an extra scan of the linkwatch queue.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
next prev parent reply other threads:[~2011-07-23 0:17 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 17:06 Major 2.6.38 regression ignored? Luke-Jr
2011-05-20 18:08 ` Ray Lee
2011-05-20 20:24 ` Rafael J. Wysocki
2011-05-20 21:11 ` Ray Lee
2011-05-21 8:41 ` Chris Wilson
2011-05-21 15:23 ` Luke-Jr
2011-05-21 15:40 ` Chris Wilson
2011-05-21 15:40 ` Chris Wilson
2011-05-21 19:33 ` Luke-Jr
2011-05-21 19:33 ` Luke-Jr
2011-05-28 13:19 ` Major 2.6.38 / 2.6.39 " Kirill Smelkov
2011-07-12 17:17 ` [Intel-gfx] " Kirill Smelkov
2011-07-12 18:07 ` Pekka Enberg
2011-07-12 18:07 ` Pekka Enberg
2011-07-22 2:59 ` Linux 3.0 release Linus Torvalds
2011-07-22 11:08 ` Major 2.6.38 / 2.6.39 / 3.0 regression ignored? Kirill Smelkov
2011-07-22 11:08 ` Kirill Smelkov
2011-07-22 14:12 ` Herbert Xu
2011-07-22 14:12 ` Herbert Xu
2011-07-22 18:00 ` Keith Packard
2011-07-22 18:00 ` Keith Packard
2011-07-22 20:23 ` Kirill Smelkov
2011-07-22 20:23 ` Kirill Smelkov
2011-07-22 20:50 ` Keith Packard
2011-07-22 20:50 ` Keith Packard
2011-07-22 21:08 ` Kirill Smelkov
2011-07-22 21:08 ` Kirill Smelkov
2011-07-22 21:31 ` [Intel-gfx] " Kirill Smelkov
2011-07-22 21:31 ` Kirill Smelkov
2011-07-23 15:10 ` [Intel-gfx] " Alex Deucher
2011-07-23 15:10 ` Alex Deucher
2011-07-23 18:19 ` Kirill Smelkov
2011-07-23 18:19 ` Kirill Smelkov
2011-07-23 15:55 ` Pekka Enberg
2011-07-25 4:29 ` Keith Packard
2011-07-26 13:48 ` [Intel-gfx] " Kirill Smelkov
2011-07-26 13:48 ` Kirill Smelkov
2011-08-09 12:08 ` Kirill Smelkov
2011-08-09 12:08 ` Kirill Smelkov
2011-08-09 14:00 ` [Intel-gfx] " Vasily Khoruzhick
2011-08-09 14:00 ` Vasily Khoruzhick
2011-08-09 14:47 ` [Intel-gfx] " Kirill Smelkov
2011-08-09 14:47 ` Kirill Smelkov
2011-08-09 15:09 ` [Intel-gfx] " Vasily Khoruzhick
2011-08-09 15:09 ` Vasily Khoruzhick
2011-08-09 15:34 ` [Intel-gfx] " Kirill Smelkov
2011-08-09 15:34 ` Kirill Smelkov
2011-08-09 16:02 ` [Intel-gfx] " Vasily Khoruzhick
2011-08-09 16:02 ` Vasily Khoruzhick
2011-08-09 16:32 ` [Intel-gfx] " Kirill Smelkov
2011-08-09 16:32 ` Kirill Smelkov
2011-08-09 16:56 ` Ray Lee
2011-08-09 16:56 ` Ray Lee
2011-08-09 17:40 ` Kirill Smelkov
2011-08-09 17:40 ` Kirill Smelkov
2011-08-09 17:43 ` [Intel-gfx] " Ray Lee
2011-08-09 17:43 ` Ray Lee
2011-08-10 8:36 ` Kirill Smelkov
2011-08-10 8:36 ` Kirill Smelkov
2011-08-10 9:41 ` [Intel-gfx] " Alan Cox
2011-08-10 9:41 ` Alan Cox
2011-08-10 11:37 ` Kirill Smelkov
2011-08-10 11:37 ` Kirill Smelkov
2011-07-22 12:52 ` Linux 3.0 release Martin Knoblauch
2011-07-22 19:11 ` David
2011-07-22 19:21 ` Linus Torvalds
2011-07-22 19:44 ` Ben Greear
2011-07-22 20:32 ` Stephen Hemminger
2011-07-22 20:35 ` Linus Torvalds
2011-07-23 2:27 ` Tejun Heo
2011-07-23 2:30 ` Tejun Heo
2011-07-22 21:26 ` Francois Romieu
2011-07-22 22:09 ` Stephen Hemminger
2011-07-22 22:53 ` [PATCH] net: allow netif_carrier to be called safely from IRQ Stephen Hemminger
2011-07-23 0:16 ` David Miller [this message]
2011-07-22 23:21 ` Linux 3.0 release - btrfs possible locking deadlock Ed Tomlinson
2011-07-25 19:49 ` Chris Mason
2011-07-26 0:22 ` Ed Tomlinson
2011-07-24 22:04 ` Linux 3.0 release Arnaud Lacombe
2011-07-25 2:21 ` Yoshinori Sato
2011-07-25 15:50 ` Arnaud Lacombe
2011-07-27 15:22 ` Yoshinori Sato
2011-07-27 17:29 ` Arnaud Lacombe
2011-07-28 2:08 ` Arnaud Lacombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110722.171642.1498051921735569337.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david@unsolicited.net \
--cc=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=shemminger@vyatta.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.