All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/25] SPEAr: Place ethaddr write and read within CONFIG_CMD_NET
Date: Wed, 7 Mar 2012 08:29:53 -0500	[thread overview]
Message-ID: <201203070829.58727.vapier@gentoo.org> (raw)
In-Reply-To: <201203071421.08705.sr@denx.de>

On Wednesday 07 March 2012 08:21:08 Stefan Roese wrote:
> On Wednesday 07 March 2012 13:03:52 Amit Virdi wrote:
> > From: Vipin KUMAR <vipin.kumar@st.com>
> > 
> > ethaddr can be optionally read from i2c memory. So, chip_config command
> > supports reading/writing hw mac id into i2c memory. Placing this code
> > within CONFIG_CMD_NET as this would only be needed when network interface
> > is configured
> > 
> > Signed-off-by: Vipin Kumar <vipin.kumar@st.com>
> > Signed-off-by: Amit Virdi <amit.virdi@st.com>
> 
> I'm not really sure, why you have this special ethaddr handling in I2C prom
> here at all. Isn't it enough to have the MAC address (ethaddr) stored in
> the U-Boot environment (NOR, NAND, etc)? Why do you need this additional
> I2C stuff? Could you please explain this?

if the board is coming from the factory manufactured like this, then it makes 
sense to me to support it.  after all, development boards aren't sold as "only 
runs u-boot".  if i got a dev board and installed u-boot on it myself, i'd 
really prefer it to automatically look up the mac if it's stored locally.

that said, this looks like a debug command, so not sure if i would even bother 
making it depend on CONFIG_CMD_NET if there's no real runtime overhead ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120307/abe02197/attachment.pgp>

  reply	other threads:[~2012-03-07 13:29 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07 12:03 [U-Boot] [PATCH 00/25] SPEAr: Update platform support for SPEAr3xx/6xx Amit Virdi
2012-03-07 12:03 ` [U-Boot] [PATCH 01/25] SPEAr: Fix ARM relocation support Amit Virdi
2012-03-07 13:11   ` Stefan Roese
2012-03-07 12:03 ` [U-Boot] [PATCH 02/25] SPEAr: Eliminate dependency on Xloader table Amit Virdi
2012-03-07 13:16   ` Stefan Roese
2012-03-07 12:03 ` [U-Boot] [PATCH 03/25] SPEAr: Place ethaddr write and read within CONFIG_CMD_NET Amit Virdi
2012-03-07 13:21   ` Stefan Roese
2012-03-07 13:29     ` Mike Frysinger [this message]
2012-03-26 11:23     ` Amit Virdi
2012-03-26 13:15       ` Wolfgang Denk
2012-03-07 12:03 ` [U-Boot] [PATCH 04/25] SPEAr: Configure network support for spear SoCs Amit Virdi
2012-03-07 13:29   ` Stefan Roese
2012-03-26 11:41     ` Amit Virdi
2012-03-26 11:51       ` Stefan Roese
2012-03-07 12:03 ` [U-Boot] [PATCH 05/25] SPEAr: Add macb driver support for spear310 and spear320 Amit Virdi
2012-03-07 12:03 ` [U-Boot] [PATCH 06/25] SPEAr: Add interface information in initialization Amit Virdi
2012-03-07 12:03 ` [U-Boot] [PATCH 07/25] SPEAr: Add basic arch related support for SPEAr SoCs Amit Virdi
2012-03-07 13:49   ` Stefan Roese
2012-03-12 12:30     ` Amit Virdi
2012-03-07 12:03 ` [U-Boot] [PATCH 08/25] SPEAr: Add configuration options for spear3xx and spear6xx boards Amit Virdi
2012-03-07 13:54   ` Stefan Roese
2012-03-26 12:10     ` Amit Virdi
2012-03-26 12:30       ` Stefan Roese
2012-03-27  5:59         ` Amit Virdi
2012-03-07 12:03 ` [U-Boot] [PATCH 09/25] SPEAr: Remove unused flag (CONFIG_SYS_HZ_CLOCK) Amit Virdi
2012-03-07 13:56   ` Stefan Roese
2012-03-07 12:03 ` [U-Boot] [PATCH 10/25] SPEAr: Change the default environment variables Amit Virdi
2012-03-07 14:03   ` Stefan Roese
2012-03-12 12:38     ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 11/25] SPEAr: Initialize SNOR in early_board_init_f Amit Virdi
2012-03-07 14:06   ` Stefan Roese
2012-03-07 12:04 ` [U-Boot] [PATCH 12/25] SPEAr: Enable usb device high speed support Amit Virdi
2012-03-07 14:07   ` Stefan Roese
2012-03-12 12:39     ` Amit Virdi
2012-03-26 12:15       ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 13/25] SPEAr: spear usbtty configuration does not use ethernet device Amit Virdi
2012-03-07 14:14   ` Stefan Roese
2012-03-12 13:12     ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 14/25] SPEAr: Enable udc and usb-console support only for usbtty configuration Amit Virdi
2012-03-07 14:15   ` Stefan Roese
2012-03-07 12:04 ` [U-Boot] [PATCH 15/25] SPEAr: Enable autoneg for ethernet Amit Virdi
2012-03-07 14:18   ` Stefan Roese
2012-03-27  9:02     ` Amit Virdi
2012-03-27  9:20       ` Stefan Roese
2012-03-27  9:24         ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 16/25] SPEAr: Enable dcache for fast file transfer Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 17/25] SPEAr: Enable CONFIG_SYS_FLASH_PROTECTION Amit Virdi
2012-03-07 14:25   ` Stefan Roese
2012-03-27  6:39     ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 18/25] SPEAr: Correct the definition of CONFIG_SYS_MONITOR_BASE Amit Virdi
2012-03-07 14:31   ` Stefan Roese
2012-03-27  6:38     ` Amit Virdi
2012-03-27  7:05       ` Stefan Roese
2012-03-27  7:42         ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 19/25] SPEAr: Enable CONFIG_SYS_FLASH_EMPTY_INFO macro Amit Virdi
2012-03-07 14:32   ` Stefan Roese
2012-03-27  6:11     ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 20/25] SPEAr: Enable ONFI nand flash detection for spear3xx and 6xx and evb Amit Virdi
2012-03-07 14:34   ` Stefan Roese
2012-03-27  6:09     ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 21/25] SPEAr: explicitly select clk src for UART Amit Virdi
2012-03-07 14:36   ` Stefan Roese
2012-03-07 12:04 ` [U-Boot] [PATCH 22/25] SPEAr: Correct SoC ID offset in misc configuration space Amit Virdi
2012-03-07 14:36   ` Stefan Roese
2012-03-07 12:04 ` [U-Boot] [PATCH 23/25] SPEAr: Use separate config flags for 3xx and 6xx board files Amit Virdi
2012-03-07 14:38   ` Stefan Roese
2012-03-12 13:57     ` Amit Virdi
2012-03-12 14:17       ` Stefan Roese
2012-03-07 12:04 ` [U-Boot] [PATCH 24/25] cleanup/SPEAr: Remove unnecessary parenthesis Amit Virdi
2012-03-07 14:41   ` Stefan Roese
2012-03-07 14:46     ` Stefan Roese
2012-03-12 13:52       ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 25/25] cleanup/SPEAr: Define configuration flags more elegantly Amit Virdi
2012-03-07 14:42   ` Stefan Roese
2012-03-07 13:15 ` [U-Boot] [PATCH 00/25] SPEAr: Update platform support for SPEAr3xx/6xx Stefan Roese
2012-03-07 13:56   ` Amit Virdi
2012-03-09  7:29   ` Vipin Kumar
2012-03-09  7:47     ` Stefan Roese
2012-03-09  8:47       ` Vipin Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203070829.58727.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.