Re: [PATCH 00/17] mark const init data with __initconst instead of __initdata - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Anatolij Gustschin <agust@denx.de>,
	Andreas Koensgen <ajk@comnets.uni-bremen.de>,
	Andrew Lunn <andrew@lunn.ch>, Andrew Victor <linux@maxim.org.za>,
	Arnd Bergmann <arnd@arndb.de>, Barry Song <baohua.song@csr.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Bryan Huntsman <bryanh@codeaurora.org>,
	cbe-oss-dev@lists.ozlabs.org,
	Christoph Lameter <cl@linux-foundation.org>,
	Daniel Walker <dwalker@fifo99.com>,
	David Brown <davidb@codeaurora.org>,
	David Howells <dhowells@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	David Woodhouse <dwmw2@infradead.org>,
	davinci-linux-open-source@linux.davincidsp.com,
	Eric Miao <eric.y.miao@gmail.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Grant@igel.home
Subject: Re: [PATCH 00/17] mark const init data with __initconst instead of __initdata
Date: Fri, 30 Mar 2012 20:19:36 +0200	[thread overview]
Message-ID: <20120330181936.GU15647@pengutronix.de> (raw)
In-Reply-To: <m2bone7215.fsf@igel.home>

Hello Andreas,

On Fri, Mar 30, 2012 at 01:37:26PM +0200, Andreas Schwab wrote:
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
> 
> > After a question by Shawn Guo I noticed that my command to do the changes
> > was to lax and changed things that must not be changed (at least not
> > with further care). Affected are lines like:
> >
> > 	static const char *at91_dt_board_compat[] __initconst = {
> >
> > While at91_dt_board_compat[0] is const, at91_dt_board_compat is not.
> 
> Though it looks like at91_dt_board_compat should really be const (it is
> assigned to a const pointer, likewise for all other uses of struct
> machine_desc.dt_compat).
Yeah, still for this series I will revert to static const char
*at91_dt_board_compat[] __initdata to only have a single logical change.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |