All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Cc: kernel@pengutronix.de, Jean Delvare <khali@linux-fr.org>,
	Guenter Roeck <guenter.roeck@ericsson.com>,
	lm-sensors@lm-sensors.org
Subject: [PATCH 06/17] hwmon: mark const init data with __initconst instead of __initdata
Date: Thu, 29 Mar 2012 23:12:23 +0200	[thread overview]
Message-ID: <1333055554-31300-6-git-send-email-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20120329211131.GA31250@pengutronix.de>

As long as there is no other non-const variable marked __initdata in the
same compilation unit it doesn't hurt. If there were one however
compilation would fail with

	error: $variablename causes a section type conflict

because a section containing const variables is marked read only and so
cannot contain non-const variables.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Jean Delvare <khali@linux-fr.org>
Cc: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: lm-sensors@lm-sensors.org
---
 drivers/hwmon/w83627ehf.c |   18 +++++++++---------
 drivers/hwmon/w83627hf.c  |    2 +-
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
index a25350c..54922ed 100644
--- a/drivers/hwmon/w83627ehf.c
+++ b/drivers/hwmon/w83627ehf.c
@@ -2619,15 +2619,15 @@ static struct platform_driver w83627ehf_driver = {
 static int __init w83627ehf_find(int sioaddr, unsigned short *addr,
 				 struct w83627ehf_sio_data *sio_data)
 {
-	static const char __initdata sio_name_W83627EHF[] = "W83627EHF";
-	static const char __initdata sio_name_W83627EHG[] = "W83627EHG";
-	static const char __initdata sio_name_W83627DHG[] = "W83627DHG";
-	static const char __initdata sio_name_W83627DHG_P[] = "W83627DHG-P";
-	static const char __initdata sio_name_W83627UHG[] = "W83627UHG";
-	static const char __initdata sio_name_W83667HG[] = "W83667HG";
-	static const char __initdata sio_name_W83667HG_B[] = "W83667HG-B";
-	static const char __initdata sio_name_NCT6775[] = "NCT6775F";
-	static const char __initdata sio_name_NCT6776[] = "NCT6776F";
+	static const char sio_name_W83627EHF[] __initconst = "W83627EHF";
+	static const char sio_name_W83627EHG[] __initconst = "W83627EHG";
+	static const char sio_name_W83627DHG[] __initconst = "W83627DHG";
+	static const char sio_name_W83627DHG_P[] __initconst = "W83627DHG-P";
+	static const char sio_name_W83627UHG[] __initconst = "W83627UHG";
+	static const char sio_name_W83667HG[] __initconst = "W83667HG";
+	static const char sio_name_W83667HG_B[] __initconst = "W83667HG-B";
+	static const char sio_name_NCT6775[] __initconst = "NCT6775F";
+	static const char sio_name_NCT6776[] __initconst = "NCT6776F";
 
 	u16 val;
 	const char *sio_name;
diff --git a/drivers/hwmon/w83627hf.c b/drivers/hwmon/w83627hf.c
index 5ce54a2..aaf67ff 100644
--- a/drivers/hwmon/w83627hf.c
+++ b/drivers/hwmon/w83627hf.c
@@ -1206,7 +1206,7 @@ static int __init w83627hf_find(int sioaddr, unsigned short *addr,
 	int err = -ENODEV;
 	u16 val;
 
-	static const __initdata char *names[] = {
+	static const char *names[] __initconst = {
 		"W83627HF",
 		"W83627THF",
 		"W83697HF",
-- 
1.7.9.1


WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Cc: kernel@pengutronix.de, Jean Delvare <khali@linux-fr.org>,
	Guenter Roeck <guenter.roeck@ericsson.com>,
	lm-sensors@lm-sensors.org
Subject: [lm-sensors] [PATCH 06/17] hwmon: mark const init data with __initconst instead of __initdata
Date: Thu, 29 Mar 2012 21:12:23 +0000	[thread overview]
Message-ID: <1333055554-31300-6-git-send-email-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20120329211131.GA31250@pengutronix.de>

QXMgbG9uZyBhcyB0aGVyZSBpcyBubyBvdGhlciBub24tY29uc3QgdmFyaWFibGUgbWFya2VkIF9f
aW5pdGRhdGEgaW4gdGhlCnNhbWUgY29tcGlsYXRpb24gdW5pdCBpdCBkb2Vzbid0IGh1cnQuIElm
IHRoZXJlIHdlcmUgb25lIGhvd2V2ZXIKY29tcGlsYXRpb24gd291bGQgZmFpbCB3aXRoCgoJZXJy
b3I6ICR2YXJpYWJsZW5hbWUgY2F1c2VzIGEgc2VjdGlvbiB0eXBlIGNvbmZsaWN0CgpiZWNhdXNl
IGEgc2VjdGlvbiBjb250YWluaW5nIGNvbnN0IHZhcmlhYmxlcyBpcyBtYXJrZWQgcmVhZCBvbmx5
IGFuZCBzbwpjYW5ub3QgY29udGFpbiBub24tY29uc3QgdmFyaWFibGVzLgoKU2lnbmVkLW9mZi1i
eTogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0BwZW5ndXRyb25peC5kZT4KQ2M6
IEplYW4gRGVsdmFyZSA8a2hhbGlAbGludXgtZnIub3JnPgpDYzogR3VlbnRlciBSb2VjayA8Z3Vl
bnRlci5yb2Vja0Blcmljc3Nvbi5jb20+CkNjOiBsbS1zZW5zb3JzQGxtLXNlbnNvcnMub3JnCi0t
LQogZHJpdmVycy9od21vbi93ODM2MjdlaGYuYyB8ICAgMTggKysrKysrKysrLS0tLS0tLS0tCiBk
cml2ZXJzL2h3bW9uL3c4MzYyN2hmLmMgIHwgICAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxMCBp
bnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2h3bW9u
L3c4MzYyN2VoZi5jIGIvZHJpdmVycy9od21vbi93ODM2MjdlaGYuYwppbmRleCBhMjUzNTBjLi41
NDkyMmVkIDEwMDY0NAotLS0gYS9kcml2ZXJzL2h3bW9uL3c4MzYyN2VoZi5jCisrKyBiL2RyaXZl
cnMvaHdtb24vdzgzNjI3ZWhmLmMKQEAgLTI2MTksMTUgKzI2MTksMTUgQEAgc3RhdGljIHN0cnVj
dCBwbGF0Zm9ybV9kcml2ZXIgdzgzNjI3ZWhmX2RyaXZlciA9IHsKIHN0YXRpYyBpbnQgX19pbml0
IHc4MzYyN2VoZl9maW5kKGludCBzaW9hZGRyLCB1bnNpZ25lZCBzaG9ydCAqYWRkciwKIAkJCQkg
c3RydWN0IHc4MzYyN2VoZl9zaW9fZGF0YSAqc2lvX2RhdGEpCiB7Ci0Jc3RhdGljIGNvbnN0IGNo
YXIgX19pbml0ZGF0YSBzaW9fbmFtZV9XODM2MjdFSEZbXSA9ICJXODM2MjdFSEYiOwotCXN0YXRp
YyBjb25zdCBjaGFyIF9faW5pdGRhdGEgc2lvX25hbWVfVzgzNjI3RUhHW10gPSAiVzgzNjI3RUhH
IjsKLQlzdGF0aWMgY29uc3QgY2hhciBfX2luaXRkYXRhIHNpb19uYW1lX1c4MzYyN0RIR1tdID0g
Ilc4MzYyN0RIRyI7Ci0Jc3RhdGljIGNvbnN0IGNoYXIgX19pbml0ZGF0YSBzaW9fbmFtZV9XODM2
MjdESEdfUFtdID0gIlc4MzYyN0RIRy1QIjsKLQlzdGF0aWMgY29uc3QgY2hhciBfX2luaXRkYXRh
IHNpb19uYW1lX1c4MzYyN1VIR1tdID0gIlc4MzYyN1VIRyI7Ci0Jc3RhdGljIGNvbnN0IGNoYXIg
X19pbml0ZGF0YSBzaW9fbmFtZV9XODM2NjdIR1tdID0gIlc4MzY2N0hHIjsKLQlzdGF0aWMgY29u
c3QgY2hhciBfX2luaXRkYXRhIHNpb19uYW1lX1c4MzY2N0hHX0JbXSA9ICJXODM2NjdIRy1CIjsK
LQlzdGF0aWMgY29uc3QgY2hhciBfX2luaXRkYXRhIHNpb19uYW1lX05DVDY3NzVbXSA9ICJOQ1Q2
Nzc1RiI7Ci0Jc3RhdGljIGNvbnN0IGNoYXIgX19pbml0ZGF0YSBzaW9fbmFtZV9OQ1Q2Nzc2W10g
PSAiTkNUNjc3NkYiOworCXN0YXRpYyBjb25zdCBjaGFyIHNpb19uYW1lX1c4MzYyN0VIRltdIF9f
aW5pdGNvbnN0ID0gIlc4MzYyN0VIRiI7CisJc3RhdGljIGNvbnN0IGNoYXIgc2lvX25hbWVfVzgz
NjI3RUhHW10gX19pbml0Y29uc3QgPSAiVzgzNjI3RUhHIjsKKwlzdGF0aWMgY29uc3QgY2hhciBz
aW9fbmFtZV9XODM2MjdESEdbXSBfX2luaXRjb25zdCA9ICJXODM2MjdESEciOworCXN0YXRpYyBj
b25zdCBjaGFyIHNpb19uYW1lX1c4MzYyN0RIR19QW10gX19pbml0Y29uc3QgPSAiVzgzNjI3REhH
LVAiOworCXN0YXRpYyBjb25zdCBjaGFyIHNpb19uYW1lX1c4MzYyN1VIR1tdIF9faW5pdGNvbnN0
ID0gIlc4MzYyN1VIRyI7CisJc3RhdGljIGNvbnN0IGNoYXIgc2lvX25hbWVfVzgzNjY3SEdbXSBf
X2luaXRjb25zdCA9ICJXODM2NjdIRyI7CisJc3RhdGljIGNvbnN0IGNoYXIgc2lvX25hbWVfVzgz
NjY3SEdfQltdIF9faW5pdGNvbnN0ID0gIlc4MzY2N0hHLUIiOworCXN0YXRpYyBjb25zdCBjaGFy
IHNpb19uYW1lX05DVDY3NzVbXSBfX2luaXRjb25zdCA9ICJOQ1Q2Nzc1RiI7CisJc3RhdGljIGNv
bnN0IGNoYXIgc2lvX25hbWVfTkNUNjc3NltdIF9faW5pdGNvbnN0ID0gIk5DVDY3NzZGIjsKIAog
CXUxNiB2YWw7CiAJY29uc3QgY2hhciAqc2lvX25hbWU7CmRpZmYgLS1naXQgYS9kcml2ZXJzL2h3
bW9uL3c4MzYyN2hmLmMgYi9kcml2ZXJzL2h3bW9uL3c4MzYyN2hmLmMKaW5kZXggNWNlNTRhMi4u
YWFmNjdmZiAxMDA2NDQKLS0tIGEvZHJpdmVycy9od21vbi93ODM2MjdoZi5jCisrKyBiL2RyaXZl
cnMvaHdtb24vdzgzNjI3aGYuYwpAQCAtMTIwNiw3ICsxMjA2LDcgQEAgc3RhdGljIGludCBfX2lu
aXQgdzgzNjI3aGZfZmluZChpbnQgc2lvYWRkciwgdW5zaWduZWQgc2hvcnQgKmFkZHIsCiAJaW50
IGVyciA9IC1FTk9ERVY7CiAJdTE2IHZhbDsKIAotCXN0YXRpYyBjb25zdCBfX2luaXRkYXRhIGNo
YXIgKm5hbWVzW10gPSB7CisJc3RhdGljIGNvbnN0IGNoYXIgKm5hbWVzW10gX19pbml0Y29uc3Qg
PSB7CiAJCSJXODM2MjdIRiIsCiAJCSJXODM2MjdUSEYiLAogCQkiVzgzNjk3SEYiLAotLSAKMS43
LjkuMQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxt
LXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xp
c3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGluZm8vbG0tc2Vuc29ycw=

  parent reply	other threads:[~2012-03-29 21:15 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-29 21:11 [PATCH 00/17] mark const init data with __initconst instead of __initdata Uwe Kleine-König
2012-03-29 21:11 ` [lm-sensors] " Uwe Kleine-König
2012-03-29 21:11 ` Uwe Kleine-König
2012-03-29 21:11 ` Uwe Kleine-König
2012-03-29 21:11 ` Uwe Kleine-König
2012-03-29 21:11 ` Uwe Kleine-König
2012-03-29 21:11 ` Uwe Kleine-König
2012-03-29 21:12 ` [PATCH 01/17] percpu: " Uwe Kleine-König
2012-03-29 21:12   ` Uwe Kleine-König
2012-03-29 21:12 ` [PATCH 02/17] pinctrl: " Uwe Kleine-König
2012-04-03 20:28   ` Linus Walleij
2012-03-29 21:12 ` [PATCH 03/17] ARM: " Uwe Kleine-König
2012-03-29 21:12   ` Uwe Kleine-König
2012-03-29 21:12   ` Uwe Kleine-König
2012-03-29 22:31   ` David Brown
2012-03-29 22:31     ` David Brown
2012-03-29 22:31     ` David Brown
2012-03-30  4:34   ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-30  4:34     ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-30  4:34     ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-30  6:11   ` Shawn Guo
2012-03-30  6:11     ` Shawn Guo
2012-03-30  6:11     ` Shawn Guo
2012-03-30  9:50     ` Uwe Kleine-König
2012-03-30  9:50       ` Uwe Kleine-König
2012-03-30  9:50       ` Uwe Kleine-König
2012-03-30 11:25       ` Shawn Guo
2012-03-30 11:25         ` Shawn Guo
2012-03-30 11:25         ` Shawn Guo
2012-03-30 16:11   ` Tony Lindgren
2012-03-30 16:11     ` Tony Lindgren
2012-03-30 16:11     ` Tony Lindgren
2012-03-29 21:12 ` [PATCH 04/17] FRV: " Uwe Kleine-König
2012-03-29 21:12 ` [PATCH 05/17] net: " Uwe Kleine-König
2012-03-29 21:12   ` Uwe Kleine-König
2012-03-29 21:12   ` Uwe Kleine-König
2012-03-29 21:12 ` Uwe Kleine-König [this message]
2012-03-29 21:12   ` [lm-sensors] [PATCH 06/17] hwmon: " Uwe Kleine-König
2012-03-29 21:12 ` [PATCH 07/17] mfd: " Uwe Kleine-König
2012-03-29 21:12 ` [PATCH 08/17] mips: " Uwe Kleine-König
2012-03-29 21:12 ` [PATCH 09/17] h8300: " Uwe Kleine-König
2012-03-29 21:12 ` [PATCH 10/17] ia64: " Uwe Kleine-König
2012-03-29 21:12   ` Uwe Kleine-König
2012-03-29 21:12 ` [PATCH 11/17] powerpc: " Uwe Kleine-König
2012-03-29 21:12   ` Uwe Kleine-König
2012-03-29 21:12 ` [PATCH 12/17] gpio/samsung: " Uwe Kleine-König
2012-04-03 20:29   ` Linus Walleij
2012-03-29 21:12 ` [PATCH 13/17] ide: " Uwe Kleine-König
2012-03-29 21:12 ` [PATCH 14/17] media/video/s5p-tv: " Uwe Kleine-König
2012-03-29 21:12   ` Uwe Kleine-König
2012-03-29 21:12 ` [PATCH 15/17] mtd: " Uwe Kleine-König
2012-03-29 21:12   ` Uwe Kleine-König
2012-04-13 15:43   ` Artem Bityutskiy
2012-04-13 15:43     ` Artem Bityutskiy
2012-03-29 21:12 ` [PATCH 16/17] drivers/x86: " Uwe Kleine-König
2012-03-29 21:12 ` [PATCH 17/17] kstrtox: " Uwe Kleine-König
2012-03-30  9:59 ` [PATCH 00/17] " Uwe Kleine-König
2012-03-30  9:59   ` [lm-sensors] " Uwe Kleine-König
2012-03-30  9:59   ` Uwe Kleine-König
2012-03-30  9:59   ` Uwe Kleine-König
2012-03-30  9:59   ` Uwe Kleine-König
2012-03-30  9:59   ` Uwe Kleine-König
2012-03-30  9:59   ` Uwe Kleine-König
2012-03-30 11:37   ` Andreas Schwab
2012-03-30 18:19     ` Uwe Kleine-König
2012-03-30 20:03 ` [PATCH v2 00/15] " Uwe Kleine-König
2012-03-30 20:03   ` [lm-sensors] " Uwe Kleine-König
2012-03-30 20:03   ` Uwe Kleine-König
2012-03-30 20:03   ` Uwe Kleine-König
2012-03-30 20:03   ` Uwe Kleine-König
2012-03-30 20:03   ` Uwe Kleine-König
2012-03-30 20:04   ` [PATCH v2 01/15] pinctrl: " Uwe Kleine-König
2012-04-03 20:47     ` Linus Walleij
2012-03-30 20:04   ` [PATCH v2 02/15] ARM: " Uwe Kleine-König
2012-03-30 20:04     ` Uwe Kleine-König
2012-03-30 20:04     ` Uwe Kleine-König
2012-04-11 11:34     ` Sekhar Nori
2012-04-11 11:34       ` Sekhar Nori
2012-04-11 11:34       ` Sekhar Nori
2012-03-30 20:04   ` [PATCH v2 03/15] FRV: " Uwe Kleine-König
2012-03-30 20:04   ` [PATCH v2 04/15] net: " Uwe Kleine-König
2012-03-30 20:04     ` Uwe Kleine-König
2012-03-30 20:04     ` Uwe Kleine-König
2012-03-30 20:04   ` [PATCH v2 05/15] hwmon: " Uwe Kleine-König
2012-03-30 20:04     ` [lm-sensors] " Uwe Kleine-König
2012-03-31  3:54     ` Guenter Roeck
2012-03-31  3:54       ` [lm-sensors] " Guenter Roeck
2012-03-31 14:09       ` Uwe Kleine-König
2012-03-31 14:09         ` [lm-sensors] " Uwe Kleine-König
2012-03-31 20:14         ` Guenter Roeck
2012-03-31 20:14           ` [lm-sensors] " Guenter Roeck
2012-03-30 20:04   ` [PATCH v2 06/15] mfd: " Uwe Kleine-König
2012-04-16 10:30     ` Samuel Ortiz
2012-03-30 20:04   ` [PATCH v2 07/15] mips: " Uwe Kleine-König
2012-03-30 20:04   ` [PATCH v2 08/15] h8300: " Uwe Kleine-König
2012-03-30 20:04   ` [PATCH v2 09/15] ia64: " Uwe Kleine-König
2012-03-30 20:04     ` Uwe Kleine-König
2012-03-30 20:05   ` [PATCH v2 10/15] powerpc: " Uwe Kleine-König
2012-03-30 20:05     ` Uwe Kleine-König
2012-03-30 20:05   ` [PATCH v2 11/15] gpio/samsung: " Uwe Kleine-König
2012-03-30 20:05   ` [PATCH v2 12/15] ide: " Uwe Kleine-König
2012-03-30 20:05   ` [PATCH v2 13/15] media/video/s5p-tv: " Uwe Kleine-König
2012-03-30 20:05     ` Uwe Kleine-König
2012-03-30 20:05   ` [PATCH v2 14/15] drivers/x86: " Uwe Kleine-König
2012-03-30 20:05   ` [PATCH v2 15/15] kstrtox: " Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333055554-31300-6-git-send-email-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=guenter.roeck@ericsson.com \
    --cc=kernel@pengutronix.de \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.