From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org> Cc: kernel@pengutronix.de, Josh Boyer <jwboyer@gmail.com>, Matt Porter <mporter@kernel.crashing.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Anatolij Gustschin <agust@denx.de>, Kumar Gala <galak@kernel.crashing.org>, Arnd Bergmann <arnd@arndb.de>, linuxppc-dev@lists.ozlabs.org, cbe-oss-dev@lists.ozlabs.org Subject: [PATCH v2 10/15] powerpc: mark const init data with __initconst instead of __initdata Date: Fri, 30 Mar 2012 22:05:00 +0200 [thread overview] Message-ID: <1333137905-13809-10-git-send-email-u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <20120330200358.GV15647@pengutronix.de> As long as there is no other non-const variable marked __initdata in the same compilation unit it doesn't hurt. If there were one however compilation would fail with error: $variablename causes a section type conflict because a section containing const variables is marked read only and so cannot contain non-const variables. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: Josh Boyer <jwboyer@gmail.com> Cc: Matt Porter <mporter@kernel.crashing.org> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Anatolij Gustschin <agust@denx.de> Cc: Kumar Gala <galak@kernel.crashing.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: linuxppc-dev@lists.ozlabs.org Cc: cbe-oss-dev@lists.ozlabs.org --- changes since (implicit) v1: - drop wrong changes to several files: - arch/powerpc/platforms/40x/ppc40x_simple.c - arch/powerpc/platforms/512x/mpc5121_generic.c - arch/powerpc/platforms/52xx/lite5200.c - arch/powerpc/platforms/52xx/media5200.c - arch/powerpc/platforms/52xx/mpc5200_simple.c - arch/powerpc/platforms/83xx/mpc830x_rdb.c - arch/powerpc/platforms/83xx/mpc831x_rdb.c - arch/powerpc/platforms/83xx/mpc837x_rdb.c - arch/powerpc/platforms/85xx/tqm85xx.c arch/powerpc/platforms/52xx/mpc52xx_pci.c | 2 +- arch/powerpc/platforms/cell/qpace_setup.c | 2 +- arch/powerpc/platforms/cell/setup.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/52xx/mpc52xx_pci.c b/arch/powerpc/platforms/52xx/mpc52xx_pci.c index bfb11e0..e2d401a 100644 --- a/arch/powerpc/platforms/52xx/mpc52xx_pci.c +++ b/arch/powerpc/platforms/52xx/mpc52xx_pci.c @@ -93,7 +93,7 @@ struct mpc52xx_pci { }; /* MPC5200 device tree match tables */ -const struct of_device_id mpc52xx_pci_ids[] __initdata = { +const struct of_device_id mpc52xx_pci_ids[] __initconst = { { .type = "pci", .compatible = "fsl,mpc5200-pci", }, { .type = "pci", .compatible = "mpc5200-pci", }, {} diff --git a/arch/powerpc/platforms/cell/qpace_setup.c b/arch/powerpc/platforms/cell/qpace_setup.c index 7f9b674..6e3409d 100644 --- a/arch/powerpc/platforms/cell/qpace_setup.c +++ b/arch/powerpc/platforms/cell/qpace_setup.c @@ -61,7 +61,7 @@ static void qpace_progress(char *s, unsigned short hex) printk("*** %04x : %s\n", hex, s ? s : ""); } -static const struct of_device_id qpace_bus_ids[] __initdata = { +static const struct of_device_id qpace_bus_ids[] __initconst = { { .type = "soc", }, { .compatible = "soc", }, { .type = "spider", }, diff --git a/arch/powerpc/platforms/cell/setup.c b/arch/powerpc/platforms/cell/setup.c index fa3e294..4ab0876 100644 --- a/arch/powerpc/platforms/cell/setup.c +++ b/arch/powerpc/platforms/cell/setup.c @@ -140,7 +140,7 @@ static int __devinit cell_setup_phb(struct pci_controller *phb) return 0; } -static const struct of_device_id cell_bus_ids[] __initdata = { +static const struct of_device_id cell_bus_ids[] __initconst = { { .type = "soc", }, { .compatible = "soc", }, { .type = "spider", }, -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org> Cc: cbe-oss-dev@lists.ozlabs.org, Arnd Bergmann <arnd@arndb.de>, Paul Mackerras <paulus@samba.org>, kernel@pengutronix.de, Anatolij Gustschin <agust@denx.de>, linuxppc-dev@lists.ozlabs.org Subject: [PATCH v2 10/15] powerpc: mark const init data with __initconst instead of __initdata Date: Fri, 30 Mar 2012 22:05:00 +0200 [thread overview] Message-ID: <1333137905-13809-10-git-send-email-u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <20120330200358.GV15647@pengutronix.de> As long as there is no other non-const variable marked __initdata in the same compilation unit it doesn't hurt. If there were one however compilation would fail with error: $variablename causes a section type conflict because a section containing const variables is marked read only and so cannot contain non-const variables. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: Josh Boyer <jwboyer@gmail.com> Cc: Matt Porter <mporter@kernel.crashing.org> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Anatolij Gustschin <agust@denx.de> Cc: Kumar Gala <galak@kernel.crashing.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: linuxppc-dev@lists.ozlabs.org Cc: cbe-oss-dev@lists.ozlabs.org --- changes since (implicit) v1: - drop wrong changes to several files: - arch/powerpc/platforms/40x/ppc40x_simple.c - arch/powerpc/platforms/512x/mpc5121_generic.c - arch/powerpc/platforms/52xx/lite5200.c - arch/powerpc/platforms/52xx/media5200.c - arch/powerpc/platforms/52xx/mpc5200_simple.c - arch/powerpc/platforms/83xx/mpc830x_rdb.c - arch/powerpc/platforms/83xx/mpc831x_rdb.c - arch/powerpc/platforms/83xx/mpc837x_rdb.c - arch/powerpc/platforms/85xx/tqm85xx.c arch/powerpc/platforms/52xx/mpc52xx_pci.c | 2 +- arch/powerpc/platforms/cell/qpace_setup.c | 2 +- arch/powerpc/platforms/cell/setup.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/52xx/mpc52xx_pci.c b/arch/powerpc/platforms/52xx/mpc52xx_pci.c index bfb11e0..e2d401a 100644 --- a/arch/powerpc/platforms/52xx/mpc52xx_pci.c +++ b/arch/powerpc/platforms/52xx/mpc52xx_pci.c @@ -93,7 +93,7 @@ struct mpc52xx_pci { }; /* MPC5200 device tree match tables */ -const struct of_device_id mpc52xx_pci_ids[] __initdata = { +const struct of_device_id mpc52xx_pci_ids[] __initconst = { { .type = "pci", .compatible = "fsl,mpc5200-pci", }, { .type = "pci", .compatible = "mpc5200-pci", }, {} diff --git a/arch/powerpc/platforms/cell/qpace_setup.c b/arch/powerpc/platforms/cell/qpace_setup.c index 7f9b674..6e3409d 100644 --- a/arch/powerpc/platforms/cell/qpace_setup.c +++ b/arch/powerpc/platforms/cell/qpace_setup.c @@ -61,7 +61,7 @@ static void qpace_progress(char *s, unsigned short hex) printk("*** %04x : %s\n", hex, s ? s : ""); } -static const struct of_device_id qpace_bus_ids[] __initdata = { +static const struct of_device_id qpace_bus_ids[] __initconst = { { .type = "soc", }, { .compatible = "soc", }, { .type = "spider", }, diff --git a/arch/powerpc/platforms/cell/setup.c b/arch/powerpc/platforms/cell/setup.c index fa3e294..4ab0876 100644 --- a/arch/powerpc/platforms/cell/setup.c +++ b/arch/powerpc/platforms/cell/setup.c @@ -140,7 +140,7 @@ static int __devinit cell_setup_phb(struct pci_controller *phb) return 0; } -static const struct of_device_id cell_bus_ids[] __initdata = { +static const struct of_device_id cell_bus_ids[] __initconst = { { .type = "soc", }, { .compatible = "soc", }, { .type = "spider", }, -- 1.7.9.5
next prev parent reply other threads:[~2012-03-30 20:05 UTC|newest] Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-03-29 21:11 [PATCH 00/17] mark const init data with __initconst instead of __initdata Uwe Kleine-König 2012-03-29 21:11 ` [lm-sensors] " Uwe Kleine-König 2012-03-29 21:11 ` Uwe Kleine-König 2012-03-29 21:11 ` Uwe Kleine-König 2012-03-29 21:11 ` Uwe Kleine-König 2012-03-29 21:11 ` Uwe Kleine-König 2012-03-29 21:11 ` Uwe Kleine-König 2012-03-29 21:12 ` [PATCH 01/17] percpu: " Uwe Kleine-König 2012-03-29 21:12 ` Uwe Kleine-König 2012-03-29 21:12 ` [PATCH 02/17] pinctrl: " Uwe Kleine-König 2012-04-03 20:28 ` Linus Walleij 2012-03-29 21:12 ` [PATCH 03/17] ARM: " Uwe Kleine-König 2012-03-29 21:12 ` Uwe Kleine-König 2012-03-29 21:12 ` Uwe Kleine-König 2012-03-29 22:31 ` David Brown 2012-03-29 22:31 ` David Brown 2012-03-29 22:31 ` David Brown 2012-03-30 4:34 ` Jean-Christophe PLAGNIOL-VILLARD 2012-03-30 4:34 ` Jean-Christophe PLAGNIOL-VILLARD 2012-03-30 4:34 ` Jean-Christophe PLAGNIOL-VILLARD 2012-03-30 6:11 ` Shawn Guo 2012-03-30 6:11 ` Shawn Guo 2012-03-30 6:11 ` Shawn Guo 2012-03-30 9:50 ` Uwe Kleine-König 2012-03-30 9:50 ` Uwe Kleine-König 2012-03-30 9:50 ` Uwe Kleine-König 2012-03-30 11:25 ` Shawn Guo 2012-03-30 11:25 ` Shawn Guo 2012-03-30 11:25 ` Shawn Guo 2012-03-30 16:11 ` Tony Lindgren 2012-03-30 16:11 ` Tony Lindgren 2012-03-30 16:11 ` Tony Lindgren 2012-03-29 21:12 ` [PATCH 04/17] FRV: " Uwe Kleine-König 2012-03-29 21:12 ` [PATCH 05/17] net: " Uwe Kleine-König 2012-03-29 21:12 ` Uwe Kleine-König 2012-03-29 21:12 ` Uwe Kleine-König 2012-03-29 21:12 ` [PATCH 06/17] hwmon: " Uwe Kleine-König 2012-03-29 21:12 ` [lm-sensors] " Uwe Kleine-König 2012-03-29 21:12 ` [PATCH 07/17] mfd: " Uwe Kleine-König 2012-03-29 21:12 ` [PATCH 08/17] mips: " Uwe Kleine-König 2012-03-29 21:12 ` [PATCH 09/17] h8300: " Uwe Kleine-König 2012-03-29 21:12 ` [PATCH 10/17] ia64: " Uwe Kleine-König 2012-03-29 21:12 ` Uwe Kleine-König 2012-03-29 21:12 ` [PATCH 11/17] powerpc: " Uwe Kleine-König 2012-03-29 21:12 ` Uwe Kleine-König 2012-03-29 21:12 ` [PATCH 12/17] gpio/samsung: " Uwe Kleine-König 2012-04-03 20:29 ` Linus Walleij 2012-03-29 21:12 ` [PATCH 13/17] ide: " Uwe Kleine-König 2012-03-29 21:12 ` [PATCH 14/17] media/video/s5p-tv: " Uwe Kleine-König 2012-03-29 21:12 ` Uwe Kleine-König 2012-03-29 21:12 ` [PATCH 15/17] mtd: " Uwe Kleine-König 2012-03-29 21:12 ` Uwe Kleine-König 2012-04-13 15:43 ` Artem Bityutskiy 2012-04-13 15:43 ` Artem Bityutskiy 2012-03-29 21:12 ` [PATCH 16/17] drivers/x86: " Uwe Kleine-König 2012-03-29 21:12 ` [PATCH 17/17] kstrtox: " Uwe Kleine-König 2012-03-30 9:59 ` [PATCH 00/17] " Uwe Kleine-König 2012-03-30 9:59 ` [lm-sensors] " Uwe Kleine-König 2012-03-30 9:59 ` Uwe Kleine-König 2012-03-30 9:59 ` Uwe Kleine-König 2012-03-30 9:59 ` Uwe Kleine-König 2012-03-30 9:59 ` Uwe Kleine-König 2012-03-30 9:59 ` Uwe Kleine-König 2012-03-30 11:37 ` Andreas Schwab 2012-03-30 18:19 ` Uwe Kleine-König 2012-03-30 20:03 ` [PATCH v2 00/15] " Uwe Kleine-König 2012-03-30 20:03 ` [lm-sensors] " Uwe Kleine-König 2012-03-30 20:03 ` Uwe Kleine-König 2012-03-30 20:03 ` Uwe Kleine-König 2012-03-30 20:03 ` Uwe Kleine-König 2012-03-30 20:03 ` Uwe Kleine-König 2012-03-30 20:04 ` [PATCH v2 01/15] pinctrl: " Uwe Kleine-König 2012-04-03 20:47 ` Linus Walleij 2012-03-30 20:04 ` [PATCH v2 02/15] ARM: " Uwe Kleine-König 2012-03-30 20:04 ` Uwe Kleine-König 2012-03-30 20:04 ` Uwe Kleine-König 2012-04-11 11:34 ` Sekhar Nori 2012-04-11 11:34 ` Sekhar Nori 2012-04-11 11:34 ` Sekhar Nori 2012-03-30 20:04 ` [PATCH v2 03/15] FRV: " Uwe Kleine-König 2012-03-30 20:04 ` [PATCH v2 04/15] net: " Uwe Kleine-König 2012-03-30 20:04 ` Uwe Kleine-König 2012-03-30 20:04 ` Uwe Kleine-König 2012-03-30 20:04 ` [PATCH v2 05/15] hwmon: " Uwe Kleine-König 2012-03-30 20:04 ` [lm-sensors] " Uwe Kleine-König 2012-03-31 3:54 ` Guenter Roeck 2012-03-31 3:54 ` [lm-sensors] " Guenter Roeck 2012-03-31 14:09 ` Uwe Kleine-König 2012-03-31 14:09 ` [lm-sensors] " Uwe Kleine-König 2012-03-31 20:14 ` Guenter Roeck 2012-03-31 20:14 ` [lm-sensors] " Guenter Roeck 2012-03-30 20:04 ` [PATCH v2 06/15] mfd: " Uwe Kleine-König 2012-04-16 10:30 ` Samuel Ortiz 2012-03-30 20:04 ` [PATCH v2 07/15] mips: " Uwe Kleine-König 2012-03-30 20:04 ` [PATCH v2 08/15] h8300: " Uwe Kleine-König 2012-03-30 20:04 ` [PATCH v2 09/15] ia64: " Uwe Kleine-König 2012-03-30 20:04 ` Uwe Kleine-König 2012-03-30 20:05 ` Uwe Kleine-König [this message] 2012-03-30 20:05 ` [PATCH v2 10/15] powerpc: " Uwe Kleine-König 2012-03-30 20:05 ` [PATCH v2 11/15] gpio/samsung: " Uwe Kleine-König 2012-03-30 20:05 ` [PATCH v2 12/15] ide: " Uwe Kleine-König 2012-03-30 20:05 ` [PATCH v2 13/15] media/video/s5p-tv: " Uwe Kleine-König 2012-03-30 20:05 ` Uwe Kleine-König 2012-03-30 20:05 ` [PATCH v2 14/15] drivers/x86: " Uwe Kleine-König 2012-03-30 20:05 ` [PATCH v2 15/15] kstrtox: " Uwe Kleine-König
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1333137905-13809-10-git-send-email-u.kleine-koenig@pengutronix.de \ --to=u.kleine-koenig@pengutronix.de \ --cc=agust@denx.de \ --cc=akpm@linux-foundation.org \ --cc=arnd@arndb.de \ --cc=benh@kernel.crashing.org \ --cc=cbe-oss-dev@lists.ozlabs.org \ --cc=galak@kernel.crashing.org \ --cc=jwboyer@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mporter@kernel.crashing.org \ --cc=paulus@samba.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.