All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Saravana Kannan <skannan@codeaurora.org>,
	Mike Turquette <mturquette@linaro.org>,
	Arnd Bergman <arnd.bergmann@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	Andrew Lunn <andrew@lunn.ch>, Paul Walmsley <paul@pwsan.com>,
	Linus Walleij <linus.walleij@stericsson.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-arm-msm@vger.kernel.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-kernel@vger.kernel.org,
	Rob Herring <rob.herring@calxeda.com>,
	Richard Zhao <richard.zhao@linaro.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	Deepak Saxena <dsaxena@linaro.org>,
	Amit Kucheria <amit.kucheria@linaro.org>,
	Jamie Iles <jamie@jamieiles.com>,
	Jeremy Kerr <jeremy.kerr@canonical.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Shawn Guo <shawn.guo@freescale.com>
Subject: Re: [PATCH] clk: Use a separate struct for holding init data.
Date: Wed, 2 May 2012 12:11:32 +0200	[thread overview]
Message-ID: <20120502101132.GW4141@pengutronix.de> (raw)
In-Reply-To: <20120502100225.GB24211@n2100.arm.linux.org.uk>

On Wed, May 02, 2012 at 11:02:25AM +0100, Russell King - ARM Linux wrote:
> > 
> > There is a mux->hw.init = &init missing here.
> 
> What happens to mux->hw.init long term?  Because once this function
> returns, that pointer will no longer be valid.

It's not used after clk_register, so everything should be fine.

> It would be a good
> idea to NULL it out in clk_register() once its done with, to ensure
> that no one comes up with the idea of using it later.

Enforcing this is a good idea.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: Use a separate struct for holding init data.
Date: Wed, 2 May 2012 12:11:32 +0200	[thread overview]
Message-ID: <20120502101132.GW4141@pengutronix.de> (raw)
In-Reply-To: <20120502100225.GB24211@n2100.arm.linux.org.uk>

On Wed, May 02, 2012 at 11:02:25AM +0100, Russell King - ARM Linux wrote:
> > 
> > There is a mux->hw.init = &init missing here.
> 
> What happens to mux->hw.init long term?  Because once this function
> returns, that pointer will no longer be valid.

It's not used after clk_register, so everything should be fine.

> It would be a good
> idea to NULL it out in clk_register() once its done with, to ensure
> that no one comes up with the idea of using it later.

Enforcing this is a good idea.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2012-05-02 10:11 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-26  5:58 [PATCH] clk: Use a separate struct for holding init data Saravana Kannan
2012-04-26  5:58 ` Saravana Kannan
2012-04-26  6:28 ` Saravana Kannan
2012-04-26  6:28   ` Saravana Kannan
2012-04-26  8:42   ` Sascha Hauer
2012-04-26  8:42     ` Sascha Hauer
2012-04-26  9:36     ` Saravana Kannan
2012-04-26  9:36       ` Saravana Kannan
2012-04-26  9:36       ` Saravana Kannan
2012-04-26  9:51       ` Sascha Hauer
2012-04-26  9:51         ` Sascha Hauer
2012-04-30 19:30         ` Saravana Kannan
2012-04-30 19:30           ` Saravana Kannan
2012-04-30 22:19           ` Turquette, Mike
2012-04-30 22:19             ` Turquette, Mike
2012-04-30 22:46             ` Saravana Kannan
2012-04-30 22:46               ` Saravana Kannan
2012-05-01  8:11               ` Shawn Guo
2012-05-01  8:11                 ` Shawn Guo
2012-05-01  9:13                 ` Andrew Lunn
2012-05-01  9:13                   ` Andrew Lunn
2012-05-01  9:13                   ` Andrew Lunn
2012-05-01 17:00                   ` Mark Brown
2012-05-01 17:00                     ` Mark Brown
2012-05-01 17:00                     ` Mark Brown
2012-05-01 18:03                     ` Saravana Kannan
2012-05-01 18:03                       ` Saravana Kannan
2012-05-01 18:19                       ` Mark Brown
2012-05-01 18:19                         ` Mark Brown
2012-05-02  1:56                         ` Mike Turquette
2012-05-02  1:56                           ` Mike Turquette
2012-05-02  2:14                           ` Shawn Guo
2012-05-02  2:14                             ` Shawn Guo
2012-05-02  5:16                           ` Andrew Lunn
2012-05-02  5:16                             ` Andrew Lunn
2012-05-02  5:16                             ` Andrew Lunn
2012-05-02 19:19                             ` Mike Turquette
2012-05-02 19:19                               ` Mike Turquette
2012-05-02 19:19                               ` Mike Turquette
2012-05-02 13:32                           ` Arnd Bergmann
2012-05-02 13:32                             ` Arnd Bergmann
2012-05-02 15:28                           ` Mark Brown
2012-05-02 15:28                             ` Mark Brown
2012-05-01 18:04                     ` Andrew Lunn
2012-05-01 18:04                       ` Andrew Lunn
2012-05-01 18:04                       ` Andrew Lunn
2012-04-26  8:39 ` Sascha Hauer
2012-04-26  8:39   ` Sascha Hauer
2012-04-26  9:15   ` Saravana Kannan
2012-04-26  9:15     ` Saravana Kannan
2012-04-26  9:15     ` Saravana Kannan
2012-04-26  9:49   ` Mark Brown
2012-04-26  9:49     ` Mark Brown
2012-05-02  2:04 ` Mike Turquette
2012-05-02  2:04   ` Mike Turquette
2012-05-02  4:42   ` Saravana Kannan
2012-05-02  4:42     ` Saravana Kannan
2012-05-02 19:07     ` Mike Turquette
2012-05-02 19:07       ` Mike Turquette
2012-05-02  9:58 ` Sascha Hauer
2012-05-02  9:58   ` Sascha Hauer
2012-05-02 10:02   ` Russell King - ARM Linux
2012-05-02 10:02     ` Russell King - ARM Linux
2012-05-02 10:11     ` Sascha Hauer [this message]
2012-05-02 10:11       ` Sascha Hauer
2012-05-03 23:03 ` Domenico Andreoli
2012-05-03 23:03   ` Domenico Andreoli
2012-05-04  1:11   ` Saravana Kannan
2012-05-04  1:11     ` Saravana Kannan
2012-05-04  6:50     ` Domenico Andreoli
2012-05-04  6:50       ` Domenico Andreoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120502101132.GW4141@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=amit.kucheria@linaro.org \
    --cc=andrew@lunn.ch \
    --cc=arnd.bergmann@linaro.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dsaxena@linaro.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jamie@jamieiles.com \
    --cc=jeremy.kerr@canonical.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=mturquette@linaro.org \
    --cc=paul@pwsan.com \
    --cc=richard.zhao@linaro.org \
    --cc=rob.herring@calxeda.com \
    --cc=sboyd@codeaurora.org \
    --cc=shawn.guo@freescale.com \
    --cc=skannan@codeaurora.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.